Commit Graph

41707 Commits

Author SHA1 Message Date
Jeff Sharkey
9173362f4e DO NOT MERGE. ActivityPicker shouldn't grant permissions. am: 8441943bfa -s ours
am: 70387afef9

Change-Id: Id60f3d902a5a2710310613ea0d12796ea46af931
2017-10-11 20:27:42 +00:00
Jeff Sharkey
556688abdb DO NOT MERGE. ActivityPicker shouldn't grant permissions.
am: 019f31b499

Change-Id: I755c046ad6392a7582d5afc32bd1e4693bcae33e
2017-10-11 20:26:40 +00:00
Jeff Sharkey
7c41707eaf DO NOT MERGE. ActivityPicker shouldn't grant permissions.
am: f32a4fad5d

Change-Id: I54e65289ff205196bd4fba9f0d40dc1f9f116e2b
2017-10-11 20:25:11 +00:00
Jeff Sharkey
e38a7f42ab DO NOT MERGE. ActivityPicker shouldn't grant permissions.
am: 94e678c188

Change-Id: Iffc23a1e80389d1afe9b10a7e992d9d19a33fe11
2017-10-11 20:24:31 +00:00
Jeff Sharkey
0bcee25346 DO NOT MERGE. ActivityPicker shouldn't grant permissions.
am: 1cdc675d7d

Change-Id: I117d8a1f9ab46f375277511da8f59df2db771cb7
2017-10-11 20:24:16 +00:00
Jeff Sharkey
70387afef9 DO NOT MERGE. ActivityPicker shouldn't grant permissions.
am: 8441943bfa  -s ours

Change-Id: I5c1980e7fb722d4d00194f3c953c91304137eea3
2017-10-11 20:24:05 +00:00
Jeffrey Huang
379ba7ffff Merge "Introduce SimulateColorSpacePreferenceController" 2017-10-11 20:05:00 +00:00
Jeffrey Huang
c856ff87e2 Merge "Introduce AnimatorDurationScalePreferenceCtrl" 2017-10-11 20:04:43 +00:00
Jeffrey Huang
0cbc7f6ccc Merge "Introduce BluetoothAudioSampleRatePreferenceCtrl" 2017-10-11 20:04:28 +00:00
Jeffrey Huang
82102a2875 Merge "Introduce LogPersistPreferenceControllerV2" 2017-10-11 20:02:22 +00:00
Fan Zhang
df94389492 Move SettingsRobolectricTestRunner to testutils.
Change-Id: Ia0017983b844cabafc10478adf4839f5755f514c
Merged-In: I6612b1f26404587301c534c8ba60e39d59d6c840
Fixes: 67688380
Test: robotests
2017-10-11 12:27:12 -07:00
Bill Yi
5fdc38e696 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import

Bug: 64712476
Change-Id: I3b96a50ff43d0d3611d3a59d12c265ca3fff5712
2017-10-11 11:28:21 -07:00
Bill Yi
9673578d9f Import translations. DO NOT MERGE
Change-Id: Ia75e445137d69499ce2094190772ee2bf1365afe
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
2017-10-11 11:14:56 -07:00
Jeffrey Huang
2b2653da43 Merge "Introduce DebugGpuOverdrawPreferenceController" 2017-10-11 17:36:56 +00:00
Jeffrey Huang
dd9946ccb4 Merge "Introduce WindowAnimationScalePreferenceController" 2017-10-11 17:36:20 +00:00
TreeHugger Robot
311c981cb0 Merge "Update suggestion (with button) card's title textAppearance" 2017-10-11 02:59:31 +00:00
Ajay Nadathur
24a5a24616 Hero suggestion is announced as disabled by talkback am: e7f5107303
am: 8f273000f0  -s ours

Change-Id: Ida910fb1ee511a1c5455dd22b57a4d5876860211
2017-10-11 01:23:16 +00:00
Fan Zhang
da2fadf607 Update suggestion (with button) card's title textAppearance
Bug: 65065268
Test: visual
Change-Id: I41c7494b935b6465fc99a5fe5dec3d501364f017
2017-10-10 18:17:28 -07:00
jeffreyhuang
d229c25136 Introduce BluetoothAudioSampleRatePreferenceCtrl
- Create new BluetoothAudioSampleRatePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I1cb1f431a94a8665c8b0f11f3d981e58bf733851
2017-10-10 18:10:34 -07:00
TreeHugger Robot
d61d1a4993 Merge "Refactor status page to DashboardFragment" 2017-10-11 01:00:50 +00:00
jeffreyhuang
60023506e9 Introduce AnimatorDurationScalePreferenceCtrl
- Create new AnimatorDurationScalePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I38820337184916f5d174814721ff61fd14ae9055
2017-10-10 17:46:50 -07:00
jeffreyhuang
5b189de9df Introduce SimulateColorSpacePreferenceController
- Create new SimulateColorSpacePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I89044404b19c47a6e3ce4e9d86dd6806aadbd0b5
2017-10-10 17:42:12 -07:00
Ajay Nadathur
8f273000f0 Hero suggestion is announced as disabled by talkback
am: e7f5107303

Change-Id: Idba7b963c3a158335eb59fecdf036f444d3808b8
2017-10-11 00:06:05 +00:00
TreeHugger Robot
921db1f98c Merge "Remove DevelopmentTileConfigActivity and clean up fragment." 2017-10-10 23:38:36 +00:00
Ajay Nadathur
e7f5107303 Hero suggestion is announced as disabled by talkback
- Removed calls to disable view. No ripple effect seen even after that
bug: 65851388
NOTE: cherry picked from master.
Merged-In: I876696a3e7351d586e6d045c8b2d07676f96ea9d
Test: manually tested

Change-Id: Iae377e763ed62b9448221843ed77b4605ad81379
2017-10-10 16:36:35 -07:00
TreeHugger Robot
98311126dc Merge "Hero suggestion is announced as disabled by talkback" 2017-10-10 23:25:26 +00:00
TreeHugger Robot
78f2668ecc Merge "Delete usage of WifiTracker#getCurrentAccessPoints" 2017-10-10 23:22:00 +00:00
TreeHugger Robot
39a9f7494d Merge "Hide "Lanauage" in search to avoid dupe results." 2017-10-10 23:18:59 +00:00
jeffreyhuang
60ab063ea3 Introduce LogPersistPreferenceControllerV2
- Create new LogPersistPreferenceControllerV2
 - Deprecate LogPersistPreferenceController
 - Add DisableLogPersistWarningDialog
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I8ff49ec4ece15cad2d0c60bd21488e3f5d55ee98
2017-10-10 16:05:32 -07:00
Fan Zhang
f63ad8f5f8 Refactor status page to DashboardFragment
Change-Id: I7ebf1e39de5b5ac852e375873d6445c4ef9c8c0a
Fixes: 65492237
Test: robotests
2017-10-10 15:51:35 -07:00
jeffreyhuang
f6cbc875e5 Introduce DebugGpuOverdrawPreferenceController
- Create new DebugGpuOverdrawPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ibaa2faa79716a0cc769d15f6fe3b868719c0f8a6
2017-10-10 15:47:59 -07:00
Jeffrey Huang
07ed55e9d0 Merge "Introduce BluetoothAvrcpVersionPreferenceCtrl" 2017-10-10 22:45:16 +00:00
Eric Schwarzenbach
389daf02ff Show updated Speed Label on Wifi detail page.
Fixes a bug where the detail page sometimes doesn't show a speed label
even when WifiSettings shows it. WifiSettings stores its connected
AccessPoint in a bundle on page load and connect. If that AccessPoint's
score cache doesn't have a score yet, it won't (can't) store it in the
bundle. If the score cache is then updated, it will display a score in
WifiSettings, but since the bundle has already been saved, the
AccessPoint that WifiNetworkDetailPage receives will not have a score.

This change modifies the preference to store the bundle only once the
user clicks the preference, so the detail page will be in sync with
WifiSettings.

Bug: 67607122
Test: manual
Change-Id: I6b33129b5a03b0e3e6d6e48ea48726e8dbe840b9
2017-10-10 15:22:56 -07:00
TreeHugger Robot
be1220071b Merge "Add content description to suggesiton footer" 2017-10-10 22:17:01 +00:00
Tony Mantler
4e43cca7fd Delete usage of WifiTracker#getCurrentAccessPoints
Bug: 67640649
Test: RunSettingsRoboTests, manually search for saved AP
Change-Id: I5a243ccc49abf78551710011cabf0c7473270cc4
2017-10-10 15:12:02 -07:00
jeffreyhuang
9c4a8c104f Introduce WindowAnimationScalePreferenceController
- Create new WindowAnimationScalePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I71c17f4ea7ca9a0273a84cb75e506e9668817473
2017-10-10 14:51:55 -07:00
Ajay Nadathur
8057f3b6aa Hero suggestion is announced as disabled by talkback
- Removed calls to disable view. No ripple effect seen even after
  the change

bug: 65851388
Test: Manually tested and verified
Change-Id: I876696a3e7351d586e6d045c8b2d07676f96ea9d
2017-10-10 21:37:57 +00:00
TreeHugger Robot
0f3bb0447f Merge "Convert more of StatusFragment to PreferenceControllers" 2017-10-10 21:04:21 +00:00
jeffreyhuang
ff1e0e1041 Introduce BluetoothAvrcpVersionPreferenceCtrl
- Create new BluetoothAvrcpVersionPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I752a5d1d777b216e102a5e074f55fa73e63ff6ca
2017-10-10 14:02:01 -07:00
Fan Zhang
231986ae9c Hide "Lanauage" in search to avoid dupe results.
Change-Id: I607ac2150912bfa6ca05e6f977daab7fd90a9637
Fixes: 67515153
Test: robotests
2017-10-10 13:54:05 -07:00
Jeffrey Huang
f12d7270de Merge "Introduce LogdSizePreferenceControllerV2" 2017-10-10 20:43:24 +00:00
TreeHugger Robot
9249707fc9 Merge "Fix Settings crash when activity is null" 2017-10-10 20:35:48 +00:00
Glen Kuhne
ddf705903e Allow 64 char HEX string PSKs in WifiSettingsUi
A check for valid PSKs in the settings UI didnt capture the 64 character
HEX string case. Added a check for it.

Test: tests/app/src/com/android/settings/wifi/WifiSettingsUiTest.java
Test: manual verification
Bug: 67492639
Change-Id: Ide738c4a67f23b613883b4a69f8264a0ffb8a0bc
2017-10-10 13:12:21 -07:00
Fan Zhang
e84911dcf9 Add content description to suggesiton footer
Change-Id: I90402301f9a294326619d8e353e14c1db9962b86
Fixes: 67633955
Test: manual
2017-10-10 12:59:08 -07:00
Fan Zhang
8333260aa5 Remove DevelopmentTileConfigActivity and clean up fragment.
- The tile activity is internal to Settings and nobody should launch it
  externally, thus it doesn't need to have its own activity. Preference
  framework can launch the fragment as a SubSetting

Fixes: 67603649
Test: robotests
Change-Id: I9ba2fc55eb7f571f816ec045567f2dd2714c44e8
2017-10-10 12:12:19 -07:00
TreeHugger Robot
d2b2d2ae0f Merge "Alphabetically sort special access setting menus." 2017-10-10 18:48:48 +00:00
songkailun
c96eeb279e Fix Settings crash when activity is null
in ManageApplications, if getActivity is null, it will cause crash
because in HelpUtils#prepareHelpMenuItem it will call activity's
getString method.

Test: manual
Change-Id: I4c9cf985e94192a936d195ea4279ec1d0f22eb10
Signed-off-by: songkailun <songkailun@xiaomi.com>
2017-10-10 11:33:14 -07:00
TreeHugger Robot
747215614b Merge "Adds a Util.setSafeIcon() function used to avoid crashes." 2017-10-10 17:39:31 +00:00
Felipe Leme
bd88450183 Adds a Util.setSafeIcon() function used to avoid crashes.
There are many places on Settings that loads an icon provided by an application,
and if the icon is too big it crashes Settings.

This CL creates a helper method used to set an icon in a safe way, and
uses it in a few places (but most likely not all of them).

Bug: 65739885
Test: manual verification with an app providing a 2MB png

Change-Id: Iae2becb6d0ec8893328d9ef1de618f9bd12fa4a0
2017-10-10 08:56:56 -07:00
Li YanJia
b699603f68 Fix PrivateVolumeSettings be launched repeatedly
Symptom:
After manually pull out the removable sd card or usb storage in
StorageSettings screen, it automatically moves to
PrivateVolumeSettings screen. This time, launching
PrivateVolumeSettings Activity is triggered six times and end-user
has to press back key six times to exit PrivateVolumeSettings
screen.

Root cause:
When sd card is pulled out, StorageSettings got three state change
event (UNMOUNTED, BAD_REMOVAL and onDiskDestroyed) through
StorageEventListener that triggers launching PrivateVolumeSettings
screen. In addition StorageSettings register the listener two
times, then StorageSettings receives six event in total.
Therefore, PrivateVolumeSettings screen is launched six times.

Solution:
Skip launching PrivateVolumeSettings if it's already triggered.
And removed the duplicated listener registration.

Bug: 67612903

Change-Id: Iabef51677a393977b7be29fc54aa050434213500
2017-10-10 12:49:32 +09:00