Commit Graph

3095 Commits

Author SHA1 Message Date
TreeHugger Robot
de08e6e901 Merge "Fix janky in App info screen" 2019-02-19 03:48:53 +00:00
tmfang
7fb266f30b Fix janky in App info screen
If a Recycle view inside in a NestedScrollView,
The times of calling recyclerView#onCreateViewHolder()
is requal to its data set.

When there are large set of apps need to be shown,
RecyclerView will need to take many time to call
onCreateViewHolder for each item.

So, it causes the screen is janky or freeze UI when page
is loading large data set.

For now, we get rid of NestedScrollView, just use RecycleView
and AppBarLayout to have same bahavior for spinner.

Fixes: 124384314
Fixes: 123036231
Fixes: 122964660
Fixes: 123088178

Test: 1. Select show system in App info screen. Observe whether there
is any janky.
2. Select show system in App info screen, and then change device
orientation. Observer whether there is any janky.
3. Go to Settings > Apps & notifications> Advanced > Special app access >
Select "battery optimization", and then Tap drop down and select "all
apps". Observe whether ther is any janky.

Change-Id: Icd65e91eec3b32476d80cc12e9c4baa71151306a
2019-02-18 17:52:03 +08:00
TreeHugger Robot
56d2dd2515 Merge "Fix [RTL] Wifi QR Scanner option overlaps wifi Password text" 2019-02-18 04:13:39 +00:00
Arc Wang
07ced72e67 Fix [RTL] Wifi QR Scanner option overlaps wifi Password text
Use android:layout_alignParentStart & android:layout_alignParentEnd
to fix the RTL issue. And refine code of the scanner button.

Bug: 123923904
Test: manual test
Change-Id: I85491b99d22ec303e370422a81a43fc203b695fa
2019-02-15 16:30:17 +08:00
jackqdyulei
e642ae67b9 Adjust layout padding for SlicePreference
To make sure text align to other preferences. This CL also
update related style name.

Bug: 124234686
Test: Manual
Change-Id: I9df8ba15630fce5509a8c8a1cbc17f103fcc6481
2019-02-14 14:29:48 -08:00
Jason Chiu
862bcc7787 Apply new slice attributes to customize layout
Fixes: 114807643
Test: robotest
Change-Id: I6c3975f08268cb831627f63c241428ae4574af1f
2019-02-14 18:16:25 +08:00
TreeHugger Robot
0c4d976b82 Merge "Remove weird background color on stroage donut in dark mode" 2019-02-13 23:47:33 +00:00
Fan Zhang
bcefbf288c Remove weird background color on stroage donut in dark mode
Bug: 124313940
Test: visual
Change-Id: Ie95c98c23bb67570418e49a1c6677d4b6809b5d2
2019-02-13 14:17:47 -08:00
TreeHugger Robot
cd15971f14 Merge "Move horizontal progress bar into SettingsLib." 2019-02-13 13:53:56 +00:00
TreeHugger Robot
d611df7c48 Merge "Misc ui tweaks." 2019-02-13 02:15:54 +00:00
Fan Zhang
07207c0113 Misc ui tweaks.
- Update conditional card layout
  - move action button from right side to bottom.
  - Get rid of the forking between small/big screens.

- Update a few icons

Fixes: 121189136
Fixes: 124315564
Fixes: 124316920

Test: visual
Change-Id: I205d9995a2d7ed06ad9d32f3cea74f2840a28aed
2019-02-12 16:14:21 -08:00
jackqdyulei
8360e0181a Update spec for CardPreference
Make icon and title align to other preference

Bug: 119618813
Test: Manual
Change-Id: I2b088fcfe0b005cde1d79db01806e1919cb131cc
2019-02-11 13:42:41 -08:00
Joel Galenson
ad0e49bd6e Move horizontal progress bar into SettingsLib.
Remove the horizontal progress bar as it is being moved into
SettingsLib.

Bug: 123538370
Test: See progress bar in wifi settings screen.
Change-Id: I8fc94b1f3a7a52559cfcf89f3e4a604784ec9995
2019-02-07 08:21:01 -08:00
Edward Savage-Jones
5042c9b41b Add master audio balance setting
This adds an audio balance slider to accessibility allowing the end
user to adjust the audio balance between left and right channels.

Test: Change Balance through Settings, play audio
Bug: 28390736
Change-Id: I70f22d222ea310fd33ebe4f3fb054f44f69d2548
2019-02-05 14:26:28 -08:00
TreeHugger Robot
09c932b2b9 Merge "Add dialog for changing display name for mobile network" 2019-02-01 04:58:45 +00:00
Antony Sargent
e13d04c762 Add dialog for changing display name for mobile network
This CL adds a pencil/edit icon at the top of the mobile network details
page. When clicked, it brings up a dialog that allows the user to set
the display name used for that mobile network - this is most useful in
multi-SIM situations. This dialog also displays the mobile network
operator name and phone number which can help the user keep straight
which one they are renaming.

Bug: 122670283
Test: make RunSettingsRoboTests
Change-Id: Ifd63cfb66ce743bd5ba8a06b52229f06ed56b7bd
2019-01-31 12:54:43 -08:00
Pengquan Meng
7f602c7f67 Add enable/disable DSDS setting switch
This add a switch settings in the Phone Information screen to allow the
user enable/disable the DSDS mode.

Bug: 123088078
Test: build & manual test
Change-Id: Ia3722fb26ce8825820ee96550a1d523da35c7a71
2019-01-30 16:42:02 -08:00
TreeHugger Robot
f660e72009 Merge "Remove empty space in Usage access" 2019-01-30 07:04:25 +00:00
TreeHugger Robot
af6d7b53b4 Merge "Remove cardview wrapper on condition collapse button." 2019-01-30 03:37:42 +00:00
Arc Wang
3dc845a181 Merge "Set Wi-Fi DPP fragment icons." 2019-01-30 02:29:35 +00:00
Fan Zhang
1c15a27c1d Remove cardview wrapper on condition collapse button.
The cardview is adding a strange background color in dark mode

Change-Id: Id205fbd5209e15597157d86d225f8c6c97a2ec5a
Fixes: 123411225
Test: visual
2019-01-29 16:33:53 -08:00
TreeHugger Robot
3a7cbacdcd Merge "Fix padding problem between search bar and homepage cards" 2019-01-29 23:00:18 +00:00
TreeHugger Robot
a0690b3d2e Merge "Add a plus button to the mobile pref on Network & internet page" 2019-01-29 22:08:33 +00:00
Antony Sargent
59adc31773 Add a plus button to the mobile pref on Network & internet page
On the Network & internet page, we have a "Mobile network" pref that in
single-SIM mode leads to a detail page for the current SIM. In multi-SIM
mode it has more complicated behavior (leading either to details about
the current subscription if there is only one, or a list of
subscriptions if more than one).

One of the things we wanted to add was a shortcut to add another eSIM
subscription. So this CL adds a plus button control on the right of the
preference which leads to a flow to add another mobile subscription via
the eSIM manager.

Bug: 116349402
Test: make RunSettingsRoboTests
Change-Id: I38e0031e3bd603e93c45dcb4557750e7bc1b8b5a
2019-01-29 12:27:46 -08:00
tmfang
465ffcd48d Remove empty space in Usage access
When there is no need to show filter component,
we don't need to set an extra padding top.

Test: robotest, visual
Change-Id: Ieaa65ed9785a06f0737aefaf102d0c857002bbdd
Fixes: 123037802
2019-01-29 20:02:49 +08:00
Arc Wang
4ab826ac5b Set Wi-Fi DPP fragment icons.
1. set fragment icon for WifiDppChooseSavedWifiNetworkFragment
2. set fragment icon of success for WifiDppAddDeviceFragment

All Wi-Fi DPP fragment icons are VectorDrawable of instinct size
24dp draw on a 48dp canvas. Except for ic_devices_check_circle_green,
it's a LayerDrawable of different size. I dynamically change ImageView
layout width & height between these 2 different kind of drawable.

Bug: 122982132
Test: manual test
Change-Id: Idab8cd8b0798363e447da00dc6bc68a86498b8be
2019-01-29 17:02:14 +08:00
Yanting Yang
9a87eab259 Merge "Improve UX of Deferred Setup" 2019-01-29 07:51:33 +00:00
Yanting Yang
2784da75a2 Improve UX of Deferred Setup
Change-Id: I3d0735ef1196b04abaef454529664a8daea53967
Bug: 120485678
Test: visual, robotests
2019-01-29 07:43:46 +00:00
Sunny Shao
4ddecb00ef Fix padding problem between search bar and homepage cards
Get the statusbar height dynamically to fix this problem in notch mode.

Change-Id: I4ca0427fc2556f1fb5f868118c5207fdfa035c59
Fixes: 123215804
Test: robotest
2019-01-29 13:56:40 +08:00
Lei Yu
cda45e5d66 Merge changes Ifb5507cb,Ide044cf9
* changes:
  Update BT header using BT metadata
  Add layout for advanced BT detail header
2019-01-29 01:29:23 +00:00
Amin Shaikh
9391361438 Move SettingsLib icons to android.
Bug: 122263617
Test: make
Change-Id: Ia2ab06561824656951fbd0019e9c921442c714e1
2019-01-28 13:46:54 -05:00
jackqdyulei
1fc7629dda Add layout for advanced BT detail header
If device supports metadata, then we display advanced UI in Bluetooth
details header. This CL adds layout for this header.

In advanced layout, it will show:
1. Device name
2. Left, right and case icon
3. Left, right and case battery level

Once API is ready, following CL will get metadata from it and set it
to UI.
Bug: 122460277
Test: RunSettingsRoboTests
Change-Id: Ide044cf9705f350b431b2cb3a9ad82cc4425a17e
2019-01-28 14:12:49 +08:00
TreeHugger Robot
9be72da6f8 Merge "Adjust contextual card dismissal view" 2019-01-25 12:58:27 +00:00
Cosmo Hsieh
846cacbd0b Merge "[Network Connection] Implement dialog title for new design" 2019-01-25 01:44:28 +00:00
Doris Ling
397f6b4c86 Merge "Add module version in About settings." 2019-01-24 20:20:54 +00:00
Kevin Chyn
8565334148 Merge "Streamline accessibility flow" 2019-01-24 09:04:25 +00:00
cosmohsieh
6897c55396 [Network Connection] Implement dialog title for new design
Change title to contain app name from intent.

Bug: 123158944
Test: atest NetworkRequestDialogFragmentTest
Change-Id: If3acea5adec8a5e2bbf712735fda9e6975e71984
2019-01-24 09:35:38 +08:00
Pasty Chang
1fe41d44fe Merge "Migrating to new footer button for ChooseLockPassword page" 2019-01-23 07:37:23 +00:00
Cosmo Hsieh
b05f76369e Merge "[Network Connection] Correct title padding" 2019-01-23 02:16:36 +00:00
Naina Nalluri
257f85e424 Merge "Add switch to enable/disable cbrs" 2019-01-23 00:04:47 +00:00
Kevin Chyn
05668ce78c Streamline accessibility flow
Bug: 111548033

Test: Builds
Change-Id: I5df5ca230732c8ab4ff105b93ee16865b3f4d999
2019-01-22 10:59:51 -08:00
cosmohsieh
107e16ef28 [Network Connection] Correct title padding
Padding of dialog title needs to align design doc.

Bug: 123161302
Test: manual
Change-Id: I4b8a3d12dd309b0c1812694c42c7e0d283c619f2
2019-01-22 17:21:17 +08:00
pastychang
76ad11c179 Migrating to new footer button for ChooseLockPassword page
Bug: 120805516
Test: RunSettingsRoboTests
Change-Id: I1fb4588d0c2cf04bca88ec470d59945c2fcab01c
2019-01-22 15:10:36 +08:00
TreeHugger Robot
32d561653c Merge "Add a picture for Wi-Fi DPP add device fragment." 2019-01-21 04:58:35 +00:00
Pasty Chang
5cddabf808 Merge "Migrating to new footer button for ChooseLockPattern page" 2019-01-21 03:35:23 +00:00
Yi-Ling Chuang
2ef995b712 Adjust contextual card dismissal view
- Increase the height of button clicking area
- Decrease top margin and some other corresponding adjustments.

Bug: 113783548
Test: visual
Change-Id: Iba1cea6c82036ebb9fe2e08d32eb663e0ad026ac
2019-01-19 11:43:25 +08:00
pastychang
c3c5a5c57e Migrating to new footer button for ChooseLockPattern page
Bug: 120805516
Test: RunSettingsRoboTests
Change-Id: Ifeaf402548146fca9f5fd5dfe0d976d38246b7e9
2019-01-18 14:42:35 +08:00
Sunny Shao
3f735ff345 Use the accent color for search icon in homepage
Add the ic_homepage_search.xml and use the accent color

Bug: 122924929
Test: manual view
Change-Id: I0ed9d2261da776f7c04bd576fd1af612c47d85db
2019-01-18 08:19:00 +08:00
Arc Wang
e05fae643c Add a picture for Wi-Fi DPP add device fragment.
Bug: 122429170
Test: manual
Change-Id: I8a2e9feab238aa2636be25959988145ac8633c24
2019-01-17 23:04:37 +00:00
Doris Ling
380e92c54c Add module version in About settings.
Change-Id: I2474d05ee96e3dd29fe012fe77450c91775fdf1d
Fixes: 122615240
Test: make RunSettingsRoboTests
2019-01-17 10:11:28 -08:00