Commit Graph

86 Commits

Author SHA1 Message Date
Irfan Sheriff
233577cc25 Restart soft Ap on a running config change
Bug: 5079339
Change-Id: I083548ef5ab3ce177e7fa3e7375a68b52bb576d7
2011-07-27 14:05:37 -07:00
Mike Lockwood
69a0957717 Fix USB tethering
The previous approach no longer works with the new USB drivers, since the usb0
interface is no longer enabled by default.
This introduced a chicken & egg problem - usb0 will not be enabled until the
user tries to start tethering, but Settings will not enable the checkbox unless
usb0 is enabled.
To fix this we add an explicit call to start USB tethering in the connectivity manager.
This will enable RNDIS if necessary and then bring up tethering once usb0 is enabled.

Change-Id: If3972c89e05377af00b7a71cc2588e44bd4cfaed
Signed-off-by: Mike Lockwood <lockwood@android.com>
2011-07-19 13:30:03 -07:00
Jake Hamby
c777ee29c8 Improve Bluetooth tethering UI usability.
- Updated hint text for BT tethering checkbox to
  "[Sharing|not sharing] this [tablet|phone]'s mobile data connection".
- Show correct hint text when user enters tethering screen.
- Show correct status after user enables tethering when Bluetooth is off.
  When BluetoothPan.setBluetoothTethering(true) is called with BT off,
  BluetoothPanProfileHandler will add a broadcast receiver to enable
  tethering after BT turns on. This happens too late to show the correct
  status when TetherSettings gets the adapter state changed event, so set
  a flag (mBluetoothEnableForTether) instead, and call setBluetoothTethering
  ourselves after the state changes to ON. Also, clear the flag if the
  adapter state changes to OFF or ERROR.
- Show correct status when user enables tethering, then disables Bluetooth,
  then returns to the tethering screen. Previously it would show
  Bluetooth tethering enabled, even though adapter state was OFF.
- Show the number of connected devices in tethering preference screen.
- Distinguish between PANU and NAP in device profiles screen, and show
  appropriate text to clarify the direction of tethering.
- Remove profiles from device profiles list when the device removes the UUID
  (e.g. Mac OS X turning NAP on/off) and after a NAP disconnection when the
  remote device only supports PANU.

Bug: 3414575
Change-Id: I2c0830876d5b9bddb293e57c4d3ca74f105911b8
2011-03-09 14:56:56 -08:00
Amith Yamasani
84a042c6e9 Move up wifi tethering settings one level.
Bug: 3249998

Remove an extra level of menu by moving the Configure Wi-Fi hotspot preference to the Tethering settings page.

Change-Id: I20b67ae1ddd7e9967c99ff6a8039799be792382f
2011-03-02 16:31:38 -08:00
Jake Hamby
436b29e68e Refactor Bluetooth settings for readability and performance.
Major refactoring of Bluetooth settings classes.
- Moved all functionality from LocalBluetoothManager into new
  LocalBluetoothAdapter and LocalBluetoothPreferences, and into
  existing classes.
- Refactored functionality from BluetoothEventRedirector into new
  BluetoothEventManager class, deleting the original version. New
  version uses a HashMap from action Strings to implementers of the
  BluetoothEventManager.Handler interface.
- Created new BluetoothDiscoveryReceiver to update shared preferences
  timestamp for Bluetooth discovery start/finish. This is the only event
  handling we need to do when the settings app is not visible, so it has
  its own receiver entry in AndroidManifest.xml. Edits are written using
  QueuedWork.singleThreadExecutor(), which BroadcastReceiver knows about
  and will wait for completion, eliminating the need for PendingResult.
- Miscellaneous cleanups to code style and logic for readability.
- Pulled some large switch statement code blocks into new methods.
- Changed all Bluetooth state references to the new BluetoothProfile
  constants.
- Changed use of deprecated Notification constructor in
  BluetoothPairingRequest to use Notification.Builder.
- Moved Utf8ByteLengthFilter helper function from BluetoothNamePreference
  into its own class, and moved test cases into the same package.
- Moved all LocalBluetoothProfileManager functionality related to
  specific profiles into new top-level classes (A2dpProfile, etc.), all
  implementing the LocalBluetoothProfile interface.
- Moved all UI-related methods from CachedBluetoothDevice into the class
  that uses the method, or into the static Utils class for shared methods.

Change-Id: I6d49b7f4ae0c7d7dcf62551ee40b51ecb5fe4f47
2011-03-01 18:44:36 -08:00
Jaikumar Ganesh
9ad703cdb9 Make BluetoothPan implement BluetoothProfile.
This makes it consistent across all other profiles.

Change-Id: I4c0694d042d7ed1b78c92ca3be38c8d543886769
2011-02-23 13:30:08 -08:00
Amith Yamasani
e419bc1bed Fix for crash in TetherSettings when monkey is running.
Bug: 3407666

onCreateView can get called on returning from another fragment. Moved the
relevant code to onCreate().

Change-Id: Icf08c18a3981051cce4eca2d07334d0a9f3c0116
2011-02-14 14:19:08 -08:00
Amith Yamasani
476d795667 NPE check in VpnSettings.
Bug: 3368545

Also fix a couple of bugs in TetherSettings:

Bug: 3090156 - view was being reused without removing from old dialog
Bug: 3368493 - preference being removed a second time

Change-Id: I8fe513d41e1f3af6994783be5ead69b6bd205711
2011-01-21 11:27:29 -08:00
Jake Hamby
3f0f998aa7 Remove Bluetooth tethering settings screen.
Remove obsolete Bluetooth tethering settings screen. BT tethering can
be turned on and off, but the connection must be initiated by the
remote device. For reverse tethering, there will be a checkbox for
that profile in the regular Bluetooth device settings screen.

Bug: 3283928
Change-Id: Ic25139f8862b305feb0381e61c24b7783fad2366
2010-12-14 13:40:10 -08:00
Amith Yamasani
72aa19d1a5 Keep the settings title as "Settings" even if launching a shortcut.
Handle clicks on Settings icon in top-left.
Also fix a bug where Tethering settings was changing the title.
2010-12-09 06:07:50 -08:00
Amith Yamasani
02cf71a591 Use PreferenceActivity and FragmentBreadCrumbs as they offer the same capabilities now.
Also fix: 2997438 and a similar bug in Tether Settings
Show + menu item for User Dictionary
2010-09-21 15:48:52 -07:00
Daisuke Miyakawa
6ebf8619d7 Fragmentize BluetoothSettings.
Add UserLeaveHintListener.java, so that the settings won't use
its implementation around Activity#onUserLeaveHint().

Also fragmentize bluetooth tethering screen.

Change-Id: Id06ae3161fbdb5854ddb7a257f464fb16ea9b089
2010-09-13 16:18:05 -07:00
Daisuke Miyakawa
9c602c4789 Fragmentize TetherSettings and WifiApSettings.
PreferenceScreen for BT tethering isn't fragmentized yet.
We'll need to do so in the near future.

Change-Id: I5a84fecaf84d55b59b6efa8151f2549ad37ca5db
2010-09-10 12:07:58 -07:00
Jaikumar Ganesh
d2bed6935f Decouple enabling of tethering with SDP record.
Change-Id: I50781bab52b28d7b3fe750fb055ffaeac5baf360
2010-09-02 12:11:06 -07:00
Danica Chang
32711b6752 bluetooth tethering
Change-Id: I8dfb1c85bb8b963d2937b8bc4a4c9f0cf641785d
2010-08-17 19:07:07 -07:00
Ben Clark
f2687380dc am 8d62eb4a: am 0008d219: Refactor to remove multiple in-loop Object[]->String[] castings
Merge commit '8d62eb4a51141f4464ba0b4c510cf0ec4198a56a'

* commit '8d62eb4a51141f4464ba0b4c510cf0ec4198a56a':
  Refactor to remove multiple in-loop Object[]->String[] castings
2010-08-17 07:51:35 -07:00
Ben Clark
0008d219a2 Refactor to remove multiple in-loop Object[]->String[] castings
(This replaces Iaa0f3b25eaadb094a4c3fb4cecbd09e0322aae33)

This change removes the need to convert Object[]->String[] for each iteration
of each of available,tethered,errored states in updateStatus()
by converting these as soon as possible.

This fix (and the code before) is strange because each of available,tethered,
errored are defined as type ArrayList<String> but
intent.getStringArrayListExtra() returns type Object[] dispite its name.
Because other calls to updateState() use String[] it seems best to do the
conversion outside this method in the Object[] case and thus avoid the
per-iteration casting in the Object[] case and the downright wasteful
per-iteration String[]->Object[]->String[] casting in the String[] input cases.

I've also removed some unused imports and an unused variable.

Change-Id: I805ef19aa9ceff7e4fc491623cdcb413ce170798
2010-07-29 20:51:31 +01:00
Robert Greenwalt
ad40f5e917 Don't enable USB Tethering UI for monkeys.
If the monkeys turn on USB tethering they kill their usb connection
and we lose the results of the run. Fix it by not showing that UI
during monkey runs.

bug:2679627
Change-Id: I7bb476a2d60c97dc9d3922d317fdcb586d0c7aec
2010-06-16 16:10:01 -07:00
Robert Greenwalt
e434bfb216 String change - wifi tether = hotspot
bug:2664412
Change-Id: I6ca955e7fcc299ae1d69892c93c9250229610b19
2010-05-08 17:20:26 -07:00
Robert Greenwalt
4c3b2f0cf0 Fix the tethering help page.
It worked with language+country resources but for some resources it's just language.
Added a check to see if we had lanugage+country before deciding which to use.

bug:2605981
Change-Id: Icb667a51f0c376f5188e3a43f264e236cd265468
2010-04-19 12:22:48 -07:00
Irfan Sheriff
0b2669647f Fix window leak on orientation change
Use Activity managed dialogs

Bug: 2571764
Bug: 2571820
Change-Id: Id506988abd4200155774e92b31dd132519e29172
2010-04-07 14:38:42 -07:00
Robert Greenwalt
b6b3d17007 Add Title to the Tether help dialog
bug:2546313
Change-Id: Ib70118b40289abd3cafdecf7fc814ca48bce2960
2010-03-30 13:48:27 -07:00
Robert Greenwalt
38925c0b96 Choose the Tether help file based on device config
Don't show wifi Tethering help on devices that don't support it, etc.

bug:2520021
Change-Id: I905d1b66fc239d5a5f5028715623d8781041f9ca
2010-03-19 10:27:52 -07:00
Irfan Sheriff
b3be4d0c50 Move status update to WifiApEnabler
Bug: 2528202
Change-Id: I093699ac171279af9df5f3b3b4ae359aab79088b
2010-03-19 09:17:59 -07:00
Irfan Sheriff
47ebb78954 softAp UI changes
Remove channel settings
Add subtext error handling
Remove WEP, keep WPA2 only for now

Bug: 2413908
Change-Id: Ie867e84a0705f0d2185eeb3a4c86a8227446a338
2010-03-16 16:03:13 -07:00
Robert Greenwalt
c3c93e5c62 Add Tether Help UI.
Add a "Help" button to the tethering page that loads on-device html.

Change-Id: I816ec552a4433296a6cb57345a37611eb2a92b37
2010-03-15 17:21:16 -07:00
Robert Greenwalt
f0ed2f3f31 Fix Settings handling of UMS broadcasts.
Had to update the filter settings to accomodate the data scheme
sent with the broadcast.

bug:2504908
Change-Id: Idf07d3b6d408489735c55df5f3310551cf6192f5
2010-03-12 11:42:32 -08:00
Robert Greenwalt
a2488762a7 Update Tether Settings for new UMS behavior.
Framework Tethering now will remove USB interfaces from the available iface list
when UMS is started.  Do note when UMS changes though so we can display the correct
strings.

bug:2469818
Change-Id: I5bf1eaea71994cbf9882e10301e88593533651a2
2010-03-10 16:57:08 -08:00
Robert Greenwalt
204e7c1a6e Clean up the tethering settings screen a bit.
Change-Id: Iadd1cf9245a5ccd38537050a6b6c9d9390400b20
2010-03-09 11:19:37 -08:00
Robert Greenwalt
209177aac6 Update Tethering UI
Finalizing some strings and changing the error handling.
2010-03-04 18:24:11 -08:00
Irfan Sheriff
65cff17722 Add AP support for tethering
First phase of the AP support in
UI and framework
Bug: 2421638

Change-Id: I0b6c31be5fe79bd4d33c292464d271b054754e8d
2010-03-04 14:34:52 -08:00
Robert Greenwalt
0affd6a002 Update Tether Settings UI.
Remove the USB notification option.
2010-03-04 12:52:28 -08:00
Robert Greenwalt
d5f121c66a Add support for tethering errors. 2010-03-03 15:22:55 -08:00
Mike Lockwood
26dad3ecef Disable tethering checkbox when USB mass storage is active.
Change-Id: If60fab4c18bbac4da22af6c1799f28344e9870bd
Signed-off-by: Mike Lockwood <lockwood@android.com>
2010-03-03 06:19:55 -05:00
Robert Greenwalt
c4764d2483 Update Settings UI regarding tethering.
If tethering is disabled (build var or a gservices property) for the device,
don't show any of the tethering options.  If Usb Tethering is disabled (config.xml) don't show
Usb Options.  If Wifi Tethering is disabled (config.xml) don't show Wifi Options.
2010-02-16 16:56:43 -08:00
Robert Greenwalt
3901edbdf5 First pass at USB-only tether settings.
bug:2281900
2010-02-04 09:17:41 -08:00