Commit Graph

15677 Commits

Author SHA1 Message Date
Doris Ling
dd5693c6f4 Fix crash in TetherSettings.
In onCreate(), it checkes whether ui is restricted, and try to show an
empty screen by creating a new preference screen. However, when the
preference is not attached, it failed to get the next preference id.
Instead of replacing the current screen with a new one, remove all the
preferences on the screen.

Change-Id: I085bee025cfeabaf4aefacb717d145e668bd85e1
Fix: 36589767
Test: manual
2017-03-24 13:10:09 -07:00
TreeHugger Robot
38931ed7c1 Merge "Hide potentially invisible DO Disclosures by default" 2017-03-24 15:26:46 +00:00
Bartosz Fabianowski
9290184ebf Hide potentially invisible DO Disclosures by default
Hiding/unhiding a pref triggers an animation. DO Disclosures that may
not be visible should be hidden by default so that they fade in if
applicable, not fade out if not applicable.

Also, the network and security logging disclosures should only be shown
if logging is currently on or was on in the past and a network log was
retrieved at least once.

Bug: 32692748
Test: m RunSettingsRoboTests

Change-Id: I8c85f2f66ba295f145e5f5e79febb1b1a9bc6ede
2017-03-24 14:37:01 +01:00
Denis Kuznetsov
0c88ff4ed9 Update List of apps on device string,
remove "XX apps" string.

Bug: 32692748
Test: m RunSettingsRoboTests
Change-Id: I64f833497b5362f95cfc56a1057d97d9539ff029
2017-03-24 13:00:49 +01:00
TreeHugger Robot
6edba87daa Merge "Sort saved networks using case insensitive order." 2017-03-24 02:25:48 +00:00
TreeHugger Robot
a7216fdc14 Merge "Update string for battery optimization dialog" 2017-03-24 01:16:42 +00:00
TreeHugger Robot
775cb1479b Merge "Change "When in VR mode" to full screen radio button picker" 2017-03-24 00:47:37 +00:00
Amin Shaikh
bfe6f21204 Sort saved networks using case insensitive order.
Bug: 36570745
Test: m RunSettingsRoboTests
Change-Id: Ie2b2d6dc012429f3ac57f24db26720e67e0bac13
2017-03-23 17:43:59 -07:00
TreeHugger Robot
4a35585197 Merge "Fix bug: UserPreference's gear icon got accidentally hidden" 2017-03-24 00:10:37 +00:00
TreeHugger Robot
af632ab6b2 Merge "Update string for Connected devices page." 2017-03-23 23:42:15 +00:00
Fan Zhang
be59441258 Update string for battery optimization dialog
Change-Id: Iea95bec173ac6cdabc10c32ae51604f190f6f42f
Fix: 36569198
Test: builds
2017-03-23 15:48:15 -07:00
Fan Zhang
abbe272e6f Fix bug: UserPreference's gear icon got accidentally hidden
Change-Id: I9715c3aff20ca8b7a324bd2f8629755690ddc119
Fix: 36545470
Test: make RunSettingsRoboTests
2017-03-23 15:37:42 -07:00
Daniel Nishi
aaebe26678 Merge "Add icons to the main static storage setting prefs." 2017-03-23 22:16:19 +00:00
TreeHugger Robot
be716e423b Merge "Update text for Users & accounts page." 2017-03-23 21:23:53 +00:00
TreeHugger Robot
bf3ba3d121 Merge "Update the donut view to handle new string." 2017-03-23 21:21:53 +00:00
TreeHugger Robot
bc27c06c5b Merge "Refactor DefaultAppPicker to a general radio button picker" 2017-03-23 21:13:58 +00:00
TreeHugger Robot
7d2b05b26a Merge "Update the system info dialog." 2017-03-23 20:56:49 +00:00
Fan Zhang
a0c2c11bbf Change "When in VR mode" to full screen radio button picker
Change-Id: I619af85f9c4a2c32daca786f49e898fde9b593f8
Fix: 36557316
Test: make RunSettingsRoboTests
2017-03-23 13:44:23 -07:00
Doris Ling
fe768e9e22 Update string for Connected devices page.
- update Bluetooth summary text "Connected to" and "Not connected"
- update USB summary text "Charging" and "Supplying"
- update Printing summary to "... on" or "off

Change-Id: I39a809b560a5c6cc6a0e217315dfabb2c4d1a129
Fix: 36234108
Test: builds
2017-03-23 13:22:52 -07:00
TreeHugger Robot
4433c8ce3d Merge "Add page Settings->Security & lock screen->Lock screen preferences." 2017-03-23 20:05:33 +00:00
Doris Ling
81f22e88f9 Update text for Users & accounts page.
- add back the summary loader for UserSettings
- remove "configure" preference category
- add summary for Auto sync data and update the title

Change-Id: Ia00397f775f86d0e160a54783a8518847fce8de8
Bug: 36540644
Test: builds
2017-03-23 12:56:33 -07:00
Fan Zhang
a278962dbc Refactor DefaultAppPicker to a general radio button picker
Bug: 36557316
Test: make RunSettingsRoboTests
Change-Id: I52985e527e55697cf29f8d97d775d4bbed025beb
2017-03-23 12:41:31 -07:00
TreeHugger Robot
f7e9d46370 Merge "Finalize strings for enterprise privacy" 2017-03-23 19:39:24 +00:00
Doris Ling
93582995da Add page Settings->Security & lock screen->Lock screen preferences.
- add the new preference screen that contains configuration for lock
screen notification, add user when locked, and owner info.
- refactor SecuritySettings to use the new owner info controller.

Fix: 36163515
Test: make RunSettingsRoboTests

Change-Id: I3bada8f652f89ed0af7aebc03f0bf2f637296b4d
2017-03-23 11:35:20 -07:00
Daniel Nishi
49118e7e01 Add icons to the main static storage setting prefs.
The dynamic user icons require more than just XML changes to
successfully fetch the badged user icons and are coming in a future
patch.

Bug: 35801039
Test: Manual -- this is purely XML and comment changes.
Change-Id: Id493c0335037a5c6e4f8b4734700611bfc0da7f1
2017-03-23 10:34:06 -07:00
Daniel Nishi
5959c9279e Update the donut view to handle new string.
Change-Id: Idb5cec6d8169f3d229375faecc4bf96501481112
Fixes: 36224266
Test: Manually verified
2017-03-23 10:29:14 -07:00
Bartosz Fabianowski
193e0bedac Finalize strings for enterprise privacy
A few more final string tweaks for the enterprise privacy page.

Bug: 32692748
Test: m RunSettingsRoboTests

Change-Id: Ib955aa5a6e756748ed7422021099234ad3fefa8b
2017-03-23 18:19:19 +01:00
TreeHugger Robot
b3f13f9f32 Merge "Update print setting summary to show number of services" 2017-03-23 17:16:20 +00:00
TreeHugger Robot
795619dba6 Merge "Move "scanning" from location setting actionbar to pref xml" 2017-03-23 16:02:02 +00:00
TreeHugger Robot
51d6bcca4f Merge "New iteration of the Text-to-Speech settings." 2017-03-23 13:56:00 +00:00
Charles He
b436519129 Merge "VPN settings: gray out always-on checkbox dynamically" 2017-03-23 08:49:47 +00:00
TreeHugger Robot
3fe93767cb Merge "Add double-tap & lift gestures to display settings" 2017-03-23 05:09:50 +00:00
TreeHugger Robot
37fcb9d4e3 Merge "Add default value to Bluetooth AVRCP version property get" 2017-03-23 03:03:49 +00:00
Fan Zhang
01ece62faa Update print setting summary to show number of services
-Also some minor cleanup in print setting fragment (create pref using
correct context)

Change-Id: Ic05027ee53fd318da6ccd38c9ed98ce10ca49ba8
Fix: 36234108
Test: make RunSettingsRoboTests
2017-03-22 18:27:19 -07:00
TreeHugger Robot
b0967c8287 Merge changes from topic 'two_target_preference'
* changes:
  Update string character limit
  Convert BT preference to use TwoTargetPreference
  Refactor the layout for MasterSwitch to a 2 target pref
2017-03-23 01:26:48 +00:00
Andrew Sapperstein
6138f1ab31 Add double-tap & lift gestures to display settings
Now they're in both languages & input and display.

Change-Id: Ib0d9fa1aa39656662307e2fc8fda70443f1ae8ed
Fixes: 36415612
Test: robotests
2017-03-22 18:20:37 -07:00
Ajay Panicker
bb1174de5e Add default value to Bluetooth AVRCP version property get
When the property isn't set a crash can occur since we try to look up an
empty property value.

Bug: 36531010
Test: Open Developer options after a factory reset
Change-Id: I82c0fde00774ab1a4f3e4c44a715c74d4a7804e9
2017-03-23 01:09:55 +00:00
Fan Zhang
2d4d993ef3 Move "scanning" from location setting actionbar to pref xml
This fixes the breadcrumb for scanning settings when you search "scan".

- Also did some minor cleanup in LocationSettings (creating preference
using the correct context)

Change-Id: I8efc62246f2e18b2bd4b5eb411b40f24e36b0f2a
Fix: 36529569
Test: manual
2017-03-22 17:04:50 -07:00
Daniel Nishi
fda5d5a6a8 Update the system info dialog.
The string is updated as well as where the dialog shows up.

Change-Id: If1a3b17dca04fe81f52dbdc2353db34ce7adc49a
Fixes: 34857117
Test: Robotest
2017-03-22 16:12:55 -07:00
Fan Zhang
09c7f15b12 Convert BT preference to use TwoTargetPreference
Change-Id: I0b49af4afb4b782a6057060b2666f6528bc003b2
Fix: 36511169
Test: make RunSettingsRoboTests
2017-03-22 16:03:45 -07:00
Fan Zhang
fe292515d8 Refactor the layout for MasterSwitch to a 2 target pref
And move the layout to settingslib.

The new TwoTargetPreference is a preference object that has a vertical
divider between main panel and widget (if it exists).

Converted master switch, restricted preference, gear preference to use
the new style

Change-Id: Ia3848cebb06b8edc4e60abf9b0caf13cdb29c22c
Fix: 36511169
Test: make RunSettingsRoboTests
2017-03-22 16:03:40 -07:00
TreeHugger Robot
cb92917e1e Merge "Use fragment context in AppHeaderController" 2017-03-22 20:59:24 +00:00
TreeHugger Robot
3e4fd030c7 Merge "AVRCP version interop pereference (2/3)" 2017-03-22 20:37:45 +00:00
Charles He
ad828f1551 VPN settings: gray out always-on checkbox dynamically
In the ConfigDialog for legacy VPNs, many configurations do not support
Always-on VPN. Previously, when a user entered an unsupported set of
settings, the Always-on VPN checkbox could still be ticked, and the
Save or Connect action buttons would be disabled. This was not intuitive
as the user could not easily figure out which part of the settings was
incompatible that grayed out the action buttons.

With this change, we disable the Always-on VPN checkbox immediately as
the user enters any incompatible setting. We also display the reason why
Always-on VPN is disabled. This will make it more straightforward for
the users to understand which setting is conflicting with the Always-on
feature.

This change is also the first step towards refactoring the ConfigDialog
for legacy VPNs with PreferenceFragment.

Test: manual
Bug: 29208008
Bug: 28072644
Change-Id: I1e6d32a1069ca0b936513f4985ffb9a9412b249c
2017-03-22 20:29:46 +00:00
jackqdyulei
abba040727 Use fragment context in AppHeaderController
The application context doesn't have the correct theme, use
fragment context instead

Fix: 36489386
Fix: 36516826
Test: RunSettingsRoboTests & Screenshot
Change-Id: I8285584220796264d85ea570df5b1df6ebeb275f
2017-03-22 12:42:39 -07:00
TreeHugger Robot
ceb46ac8e7 Merge "Fix a monkey crash when it dismisses suggestion." 2017-03-22 18:34:56 +00:00
Ajay Panicker
da2723a5ae AVRCP version interop pereference (2/3)
Add a mechanism to allow the user to select the AVRCP version broadcasted
through SDP in the developer options. This helps solve some interoperability
issues such as with Honda Carkits where broadcasting AVRCP version 1.6 causes
media metadata to fail.

Bug: 35956792
Test: Select AVRCP version through developer option
Change-Id: I7d4b1bd23342d1a96ffdf08bb7d6d3c5e5fedca6
2017-03-22 11:32:15 -07:00
Matthew Fritze
fb8e0dc545 Merge "Rename remaining layouts to original search names" 2017-03-22 17:32:19 +00:00
Doris Ling
422fc4a433 Merge "Update preference text for Network & internet screen." 2017-03-22 17:22:27 +00:00
Fan Zhang
8c8c4077fe Fix a monkey crash when it dismisses suggestion.
Change-Id: I300a49ed75381795b6532388f770847ed39a4c8c
Fix: 36509330
Test: make RunSettingsRoboTests
2017-03-22 10:04:39 -07:00