Commit Graph

3265 Commits

Author SHA1 Message Date
Weng Su
e8c9816d15 Merge "Fix WifiPrivacy for special SSID AP" into main 2024-08-30 09:25:46 +00:00
Weng Su
407f69fec5 Fix WifiPrivacy for special SSID AP
- root cause: specail SSID AP(contain '%', end with '\' or '/' and end with '???'), andriodx Navigation cannot find destination

- changes: use Base64 UrlEncode replace String

Bug: 360304229
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiPrivacyPageProviderTest

Change-Id: Ifb89451477f2ba143f504b94c8d4d9167aee2c2e
2024-08-30 16:24:49 +08:00
Chaohui Wang
c72c540ab6 Merge "Clean up InternetPreferenceController" into main 2024-08-30 03:29:56 +00:00
Weng Su
1d92232b84 Add WIFI_LEVEL_UNREACHABLE logs
- Add WIFI_LEVEL_UNREACHABLE logs in Wi-Fi details settings

Bug: 362269742
Flag: EXEMPT add logs only
Test: Manual testing
Change-Id: I9a2b01df06417bafa85d300f1abe41797ec08143
2024-08-29 17:08:25 +08:00
Chaohui Wang
fc8e8991c9 Clean up InternetPreferenceController
And also the flag.

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - Network & internet
Change-Id: Icb3427f6624db0442c05f5e149dbe522d1497e83
2024-08-29 15:55:44 +08:00
Weng Su
739fa3f4c3 Refine Wi-Fi privacy settings
- When changing two configurations, the configuration must be refreshed before modifying the second configuration to prevent the first configuration from being rolled back by the old configuration.

Fix: 360313149
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiPrivacyPageProviderTest

Change-Id: If0e2c2b6a708fa59929b23409aff1254c6566fef
2024-08-21 15:32:14 +08:00
Weng Su
1a975d6f72 Refine WifiHotspotRepository variable names
- Since the speed of hotspot design was changed to refer to allowed channels rather than usable channels, remove the "Usable" naming to avoid confusion

Fix: 360312024
Flag: EXEMPT refactor
Test: Manual testing
atest -c WifiHotspotRepositoryTest

Change-Id: Ie54a351e0f788e1b6aeec079ccf6671f7f78fb1c
2024-08-16 18:55:36 +08:00
Weng Su
6c2158edef Get available channels allowed by Hotspot
- Use getAllowedChannels API instead of getUsableChannels API to avoid corner cases

Bug: 352267181
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiHotspotRepositoryTest

Change-Id: I5ae4a4d429924ac2b8676bbbb27016a93ccd9a1b
2024-08-14 17:10:05 +08:00
Treehugger Robot
0373a46e81 Merge "Hide new Hotspot preferences if feature is disabled" into main 2024-08-12 04:55:54 +00:00
Weng Su
675b817c49 Hide new Hotspot preferences if feature is disabled
- Hide new "Security" preference

- Hide new "Speed and compatibility" preference

Bug: 356898105
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiTetherSettingsTest

Change-Id: I734959ed511929bfcc9a314770a4acdf9a7e0b99
2024-08-12 05:49:02 +08:00
Weng Su
7b0e5560d1 Fix WifiQrCode scheme inconsistency issue
- New WifiQrCode design has been moved to WiFi Framework module
 - URI scheme changed from string "DPP" to integer 2

Bug: 356971926
Flag: EXEMPT bugfix
Test: manual test by 15-dpp-fail.apk
Change-Id: I00834ccb32f3ced8345213eef55b5aaa77006f7a
2024-08-09 04:36:16 +00:00
Chaohui Wang
c311354d10 Show uncheck toggle when wep not supported
When wep not supported, wep is always not allowed, so we should show
unchecked toggle for "Allow WEP networks"

Bug: 356326814
Flag: EXEMPT bug fix
Test: manual - on Network preferences
Test: atest WepNetworksPreferenceControllerTest
Change-Id: I408434fbbf48e1010710ecf3bf9f7988e521b076
2024-08-02 11:43:20 +08:00
Tom Hsu
d26c804af1 Merge "[Settings]Check the Satellite modem state instead of enabled state only." into main 2024-08-01 05:27:06 +00:00
tomhsu
90553d91f1 [Settings]Check the Satellite modem state instead of enabled state only.
Flag: EXEMPT bugfix
Fix: 354806125
Test: Manual test pass
Change-Id: Iaa8d1c9d3df36e40fafda0117234036d9451a4fa
2024-08-01 03:38:48 +00:00
Priyanka Advani (xWF)
9bf8ce78b2 Merge "Revert "Change API requestIsEnabled to requestIsSessionStarted"" into main 2024-07-30 18:12:18 +00:00
Chaitanya Cheemala (xWF)
413e85fa7a Revert "Change API requestIsEnabled to requestIsSessionStarted"
Revert submission 28533501-NTN_check_modem_state

Reason for revert: Likely culprit for b/356320274  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:28533501-NTN_check_modem_state

Change-Id: I4cdb936eb6a27eeee0aba6a5adfcf9cbdfacd5eb
2024-07-30 09:31:35 +00:00
Chaohui Wang
3a8ce3f970 Merge "Call wifiStatusTracker.fetchInitialState first" into main 2024-07-30 07:09:34 +00:00
Tom Hsu
d5225c236d Merge "Change API requestIsEnabled to requestIsSessionStarted" into main 2024-07-30 06:51:17 +00:00
Chaohui Wang
0be6705da6 Call wifiStatusTracker.fetchInitialState first
Before set listening to true, otherwise could cause race condition.

Fix: 354500692
Flag: EXEMPT bug fix
Test: manual - check wifi summary
Change-Id: I4160f89fae666ac02b816b7d9a69bac581bbd29e
2024-07-30 13:51:52 +08:00
tomhsu
b091995671 Change API requestIsEnabled to requestIsSessionStarted
- Avoid using APM/WIFI/BT in settings app from any transitioning from TN to NTN.

Flag: EXEMPT bugfix
fix: 354806125
Test: Manual test
Change-Id: Id65567971b3d1ea3e177a0cc1e1304446d8fa0e8
2024-07-30 01:27:58 +00:00
Treehugger Robot
dc8b74e343 Merge "Make adb team OWNERS of all Adb settings" into main am: 998787ffa8 am: ee6f5cf1ed
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3195878

Change-Id: Ifa37256b70cc3c1d7c6b22637cba040bce62ca3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-26 18:39:33 +00:00
Treehugger Robot
ee6f5cf1ed Merge "Make adb team OWNERS of all Adb settings" into main am: 998787ffa8
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3195878

Change-Id: Idcd085b62b69bace7ddfda325b1645b6b89440ca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-26 18:25:24 +00:00
Fabien Sanglard
c7adef9634 Make adb team OWNERS of all Adb settings
Test: NA
Bug: 355088188
Flags: NA
Change-Id: I59c037765940a26509f1d312b4c8c2e0105a3580
2024-07-26 10:57:43 -07:00
Yi Shiou (Les) Lee
ff6a1750bc Merge "wifi: fix ADB URI doesn't work" into main 2024-07-26 00:26:26 +00:00
Les Lee
da21128568 wifi: fix ADB URI doesn't work
Using old WifiQrCode parsing for ADB Uri.

Flag: EXEMPT bugfix
Bug: 355088188
Test: Manual test & TH
Change-Id: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
2024-07-25 21:38:15 +00:00
Quang Luong
2f257a1982 Merge "Fix mac randomization value mismatch" into main 2024-07-25 10:45:54 +00:00
Yuchen Sun
01ecf76247 Add content description to QR code image for talkback.
- Rename string name for reuse purpose.

Test: Visual
Flag: EXEMPT bug fix
Bug: 350603175
Change-Id: Id5b1383c9cf1c2509a621bb9b225e0efeb58ca7f
2024-07-25 08:47:32 +00:00
SongFerng Wang
410f699c6f Merge "Settings: Adapt edge-to-edge enforcement" into main am: 9befb6cd8f am: e910d895f1
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3142636

Change-Id: I4a7f739df1b12c2151a6b4a484881360541c113d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-18 10:08:48 +00:00
SongFerng Wang
e910d895f1 Merge "Settings: Adapt edge-to-edge enforcement" into main am: 9befb6cd8f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3142636

Change-Id: Ibfc5f8fb007d93d618c4a0c67e396677329b5728
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-18 09:48:49 +00:00
Quang Anh Luong
47a83c7ed7 Fix mac randomization value mismatch
WifiConfigController2 passes in
WifiConfiguration.MacRandomizationSetting to methods that expect
WifiEntry.Privacy enums, resulting in the wrong values being saved and
displayed for the edit dialog. Fix this by making sure the correct
WifiEntry values are used.

Note that the Network Details Page uses
WifiPrivacyPreferenceController2, which uses the correct values.

Flag: EXEMPT bugfix
Bug: 284230986
Test: atest WifiPrivacyPreferenceController2Test, atest
WifiConfigController2Test, manually verify adding a new network saves
the config with RANDOMIZATION_AUTO by default and changing the value
works correctly.

Change-Id: I84dc7cc50d04360aca611ca80ee400a97b693722
2024-07-18 05:31:11 +00:00
Chaohui Wang
371e7b09e1 Clean up WifiPrimarySwitchPreferenceController
This one is not used any more.

Bug: 167474581
Flag: EXEMPT clean up
Test: m Settings
Change-Id: Ia2439af2b3a6b643f41f6e3fce9e4bf1126c282e
2024-07-17 16:02:40 +08:00
Treehugger Robot
2db5d1618f Merge "Show less secure warning in Network details settings" into main 2024-07-15 08:00:42 +00:00
Weng Su
05b28d24c3 Show less secure warning in Network details settings
- Show warning when device connected to WEP protocol

Bug: 331973632
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WepLessSecureWarningControllerTest

Change-Id: I54a9bafb2c672db44d47259d6acc49c02046cb81
2024-07-15 14:51:25 +08:00
Kai Zhou
9775bd31f9 Wifi Sharing page uses a new enum for telemetry.
* Previous ID was shared by several pages.
* New ID is only used by this page.

Bug: b/349226088
Settings Intake: b/329012096

Test: atest WifiDppQrCodeGeneratorFragmentTest
Flag: com.android.settings.flags.enable_wifi_sharing_runtime_fragment

Change-Id: I22c8f3a216cf348460a645561be48b23a4bf0e7e
2024-07-11 02:30:12 +00:00
Weng Su
a7b13c11cd Disable "Add network" if DISALLOW_ADD_WIFI_CONFIG
- When DISALLOW_ADD_WIFI_CONFIG is not restricted by Admin
  - Disable the preference directly

Bug: 335387874
Flag: EXEMPT bugfix
Test: Manual testing
atest -c AddWifiNetworkPreferenceTest

Change-Id: I0bb08656971107c73d7632a395a820d03723620b
2024-07-05 06:52:36 +08:00
Qiang Chen
9507c61155 Settings: Adapt edge-to-edge enforcement
Android 15 enables edge-to-edge by default. WI-FI info should do the
adaptation, or not some UIs may be obscured by system bars.

Apply window insets for WifiConfigInfo and WifiStatusTest activity
content layout.

Bug: 340713923
Test: Manaul

Change-Id: Iecaadfa1be55544809b240df9c2097e3b4d053f9
2024-06-28 12:44:24 +05:30
Chaohui Wang
562f56bb7a Use wifiCallingReadyFlow in WifiCallingSettingsForSub
Simply and unify the logic, and fixed a crash.

Fix: 348372605
Flag: EXEMPT bug fix
Test: manual on Wi-Fi calling
Change-Id: Idc7dff934323fbebb09137bbd0585575e65a7867
2024-06-21 16:53:38 +08:00
Kai Zhou
a6c54bc98f Merge "Retrieve WifiDppQrGeneratorFragment at runtime." into main 2024-06-19 06:56:42 +00:00
Kai Zhou
5097783e6e Retrieve WifiDppQrGeneratorFragment at runtime.
* Add getWifiDppQrCodeGeneratorFragment() in WifiFeatureProvider
* WifiDppConfiguratorActivity calls from the FeatureFactory to get WifiDppQrCodeGeneratorFragment instance
* Use a flag to guard this behaviour
* Updated a few private variables of WifiDppQrCodeGeneratorFragment to
  protected so I can access them in derived classes.

Bug: b/338891273
Settings Intake: b/329012096

Test: manual test, override the flag locally, and check I can switch to
overriden implementation.
Flag: com.android.settings.flags.enable_wifi_sharing_runtime_fragment

Change-Id: I715bf89bd9be221f06914e87629c76bf7a2f743f
2024-06-18 07:28:10 +00:00
Treehugger Robot
b3aae5aaf1 Merge "Don't show the Wi-Fi icon when Wi-Fi is off" into main 2024-06-14 03:58:01 +00:00
Weng Su
3b161c23b3 Don't show the Wi-Fi icon when Wi-Fi is off
- Show an empty icon when the Wi-Fi level is unreachable

Bug: 339343274
Flag: EXEMPT bugfix
Test: Manual testing
atest -c SettingsRoboTests

Change-Id: I55f3be145150235b19484e256c35e37f885a1dcf
2024-06-13 20:43:40 +08:00
Chaohui Wang
b0acf0daf5 InternetPreferenceController V2 (7/7)
Support alternateSummary for HotspotNetworkEntry.

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - on Internet
Test: unit test
Change-Id: I6a454e86453ea8ed597a032d3f5769b6cf9102ba
2024-06-13 16:47:01 +08:00
Chaohui Wang
52b5aef999 InternetPreferenceController V2 (2/n)
Add ConnectivityRepository, when no validated connection,
show "Airplane mode is on" or "Networks available".

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - on Internet
Test: unit test
Change-Id: I227d896fd52c099fb6d58a7ab60e98983fdab8cf
2024-06-07 15:28:46 +08:00
Chaohui Wang
efa1f0e3ed InternetPreferenceController V2 (1/n)
Refactor the InternetPreferenceController, migrate to repository and
flow, run data loading on background thread.

Only add Wifi summary for now.

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - on Internet
Test: unit test
Change-Id: Ibd8911bc11b24d4a7e2ef320dea4d38b9c3a864f
2024-06-07 12:28:44 +08:00
Quang Luong
e3fdcad6a2 Merge "Gate dhcp hostname setting behind Wifi V API flag" into main 2024-06-06 08:33:00 +00:00
Quang Anh Luong
dda3dd56cb Gate dhcp hostname setting behind Wifi V API flag
DCHP hostname setting should only be shown if the feature flag for Wifi
V API is enabled.

Bug: 341981620
Test: manual
Change-Id: Iee3740db2513c7071c14361513f7e51199245af0
2024-06-04 22:59:23 +00:00
Quang Luong
d65e37e8a8 Change hotspot security to WPA3-Transition when switching from 6GHz
When changing hotspot to 6GHz, we auto-set the security to WPA3-SAE. However, we don't do the reverse when changing out of 6GHz, which may cause legacy devices to be unable to connect. Instead, always revert back to WPA3-Transition when switching out of 6GHz.

Bug: 323764310
Test: manual
Change-Id: I06b1e97f452da86a693812a6620c251ff5d0e932
2024-06-04 07:48:16 +00:00
Weng Su
8d4eb82d95 Refer the SoftApCapability cache if getUsableChannels is unsupported
- Get SAP band capability from SoftApCapability#getSupportedChannelList

Bug: 272450463
Bug: 338503507
Bug: 340789513
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiHotspotRepositoryTest

Change-Id: I7b792c27bc3c41e78417032f797d57b030d6db72
2024-05-28 13:08:45 +08:00
Weng Su
ec4db174a8 Merge "Remove Instant Hotspot from Settings search" into main 2024-05-13 06:54:59 +00:00
Weng Su
3dc7837617 Remove Instant Hotspot from Settings search
- If Instant Hotspot is not enabled then remove it from Settings search

Bug: 339159245
Flag: None
Test: Manual testing
atest -c WifiTetherSettingsTest

Change-Id: I0b1d34c1130b17bfc0f3f0451a10c8aba265733c
2024-05-11 20:00:02 +08:00