Commit Graph

20 Commits

Author SHA1 Message Date
Himanshu Gupta
63da8c35f7 Do not move to ALL_APPS when default Launcher is not system.
Currently we fire ALL_APP intent for System Launchers at the
end of PS setup flow, even when the system launcher (NexusLauncher)
was not the default Launcher.

In such cases, the user is moved to NexusLauncher, but they cannot
unlock PS (only default launcher can do it), leading to crashes.
To fix this, we do not fire the intent in case non system Launcher
has the HOME role.

Bug: 331722929
Test: Manual build and flash
Flag: NA
Change-Id: I77353474cc74028d72508c433c89b6116b4148bd
2024-05-24 08:17:01 +01:00
Joseph Vincent
db315e642b Merge changes I6387c999,I470e5c6e into main
* changes:
  Update illustrations in Private Space setup & settings
  Replace autoadvance screens with waiting screen in PS setup
2024-04-10 09:51:35 +00:00
josephpv
f145d0e9a0 Update illustrations in Private Space setup & settings
This inlcudes the changes to use latest private space icon and update
the illustrations in private space setup and settings.
Change made to update illustrations dynamically between light and dark
theme.

Recordings link:
b/332867167#comment3

Bug: 332867167
Test: Manual
Change-Id: I6387c9991ec9bb419f446431926f99843f92c859
2024-04-09 22:35:04 +00:00
josephpv
d82e3961f4 Remove settings activity from recents at end of PS setup
Recording link:
b/310192654#comment2

Bug: 310192654
Test: Manual
Change-Id: Id71480ddce94aee8d9d5f1aa83bfff4e06df6377
2024-04-09 15:06:20 +00:00
Joseph Vincent
0fee5fa0b0 Revert^2 "Add waiting screen before PS setup completion"
This reverts commit d2c91b587e.

Reason for revert: Landing the original cl as the test passes locally with changes and failed test looks to be flaky and not related to the change.

Failure is not seen in the ABTD test run results with this CL  b/331935387#comment10

Change-Id: I744e11a04b70e265c5dcfe5aa8db7237561f3a08
2024-04-03 16:36:21 +00:00
Priyanka Advani
27d7b192f7 Merge "Revert "Add waiting screen before PS setup completion"" into main 2024-03-29 21:43:30 +00:00
Priyanka Advani
d2c91b587e Revert "Add waiting screen before PS setup completion"
This reverts commit 7b0b26ec92.

Reason for revert: b/331935387. ACA has already verified the revert.

Change-Id: Idf28854f25c4bad3563408dbb7b5c84f0cdbe2f2
2024-03-29 21:30:27 +00:00
Joseph Vincent
ea6500455a Merge "Add waiting screen before PS setup completion" into main 2024-03-29 14:30:07 +00:00
josephpv
7b0b26ec92 Add waiting screen before PS setup completion
At the end of PS setup just before showing the final sucess screen this
change adds a new screen with loading layout which enables profile quiet
mode.
After enabling quiet mode checks if user is stopped before removing the
loading layout screen. Until user is stopped loading screen will be
shown.

Bug: 329042236
Bug: 328393532
Test: Manual verify new delay screen is shown
Change-Id: Iac3fd2f0f5c75a64719fbce32ff4dbfb533322d5
2024-03-28 22:53:46 +00:00
josephpv
4cc915ad64 Change icon for Private Space unlocked and setup success toast
Change is made to show customised icon in Toast message shown by using
Toast.makeCustomToastWithIcon()

Screenshots :
go/ss/AcaRQUJQfh79wDw.png
go/ss/5j4oD8xydwX7HTX.png

Bug: 329391204
Bug: 309575523
Test: Manual
Change-Id: I336d7d0419b1de60024e584e943a725662b446a9
2024-03-25 16:53:46 +00:00
Olivier Nshimiye
0f3799cbad Add an additional flag guard for Private Space implementation
This a layer of flag guarding only for the implementation of Private Space features excluding the APIs. The MVP flag allow_private_profile still guards all the features including the APIs.

Bug: 326060689
Test: Manual - a few verifications that some feeatures are unavailable when this flag is disabled
Test: Run presubmits and verify that nothing breaks
Change-Id: I05f7e2f20c6132b33484bb133ce03a933ece485f
2024-03-04 15:43:24 +00:00
josephpv
e9f3a0925b Add illustration to final screen in PS setup and update existing illustrations.
Screenshots:
- go/ss/9KhqUSezFKHnyys.png

Recording link:
- b/321694009#comment2

Bug: 323156268
Bug: 321694009
Test: Verified manually
Change-Id: Ib8abc080f31cad0a9be3b73a1694be744c108a06
2024-02-13 18:27:17 +00:00
josephpv
6f4dc73c53 Add logging to private space settings
Bug: 317625931
Test: Manual
Change-Id: I01200b54c436d2a60ac07c9facbb5cf35a44d920
2024-01-19 23:11:42 +00:00
josephpv
242ae4fbcc Lock Private space at the end of PS setup.
This change is to call UserManager requestQuietModeEnabled() API at the
end of PS setup to enable quitemode for private space.

Bug: 313652502
Test: atest PrivateSpaceMaintainerTest
Verify Private space is locked state after private space setup completion.

Change-Id: I1d863f6d51ffa4bb58318696603905d35c3109b6
2023-12-11 20:43:59 +00:00
josephpv
992f6b97dd Update private space setup string and loading screen title
This includes below changes based on the updated UX mocks:
- Add one more loading screen in setup flow
- Update feature intro text on Setup page
- To swap order of bullets on the setup intro screen
- Update "Private Space" to "private space" in setup flow screens

go/ss/7pVGBSPqezDek47.png
go/ss/ADLX8aXAAGgYQHD.png
go/ss/tYtrGypBgRuXM9V.png
go/ss/3zZfij6JDpudwYR.png
go/ss/BFtWegFZyTueQoT.png
Recording link - b/313654776#comment5

Bug: 313654776, 313882412, 313655290
Test: Verify title and text is same as UX flow
Change-Id: I6a985c4fd6ecbe8ddd11e36bf76a2a9cc8427ef5
2023-12-07 12:39:56 +00:00
Anna Zhuravleva
b1fdd55707 Log events during PS setup flow.
Log pages and user clicks during private
space setup flow.

Bug: 313170618
Test: statd_testdrive 97, output: https://paste.googleplex.com/4874404496932864
Change-Id: I1f59e9720ee4bdd21670b86a4f1f0f98a91fa0db
2023-11-29 15:39:10 +00:00
Manish Singh
51f1321b1e Put stricter flag checks
Also removed a log which gives away flag.

Bug: 312976400
Test: manual
Change-Id: I4a989de8b6b920666aabf0cc9311e28becc4d862
2023-11-24 18:51:27 +00:00
josephpv
6def09c9eb Start All Apps on successful PrivateSpace setup completion
Bug: 309130594
Test: Verified Launcher App Alls is launched on setup complete
Change-Id: I6842d85617e3862f18b2183e8dda7bd7b575bce8
2023-11-08 10:38:09 +00:00
josephpv
380ac9a48e Adds Google account login during private space setup
This has the following changes:
1. On profile creation starts intent to add google account to the private profile for Pixel only devices.
2. On accout sign in failed show an error screen with message to try again.
3. Moves the lock setup fragment from private to main user which now calls the helper Activity as a private user which helps to setup lock. This activity can now also be called from the planned Secondary Auth settings page to set up private profile lock.
4. On set up complete use SHOW_WORK_APPS intent as a workaroud to start launcher.

Bug: 308397617
Test: Manual setup
Change-Id: I19b95375409f015b2a5d30fdad766c2f6baa634b
2023-11-03 13:50:55 +00:00
josephpv
84944ba6f0 Add auto advancing screens for private space setup
This includes changes for
1. To add auto avancing screens to PS setup
2. Screen to set a different Private profile lock or use existing lock
3. Success screen on setup completion
4. Shows Error screen if profile creation failed for some reason
5. Send intent towards launcher, show a Toast message to access PS from bottom of All apps and exit.

Bug: 299069146
Test: Manual setup
Change-Id: If4e5dd5a42abb11259bc40506189c7c750324139
2023-10-27 12:32:12 +00:00