Commit Graph

12 Commits

Author SHA1 Message Date
josephpv
8298c15f53 Remove animation from private space settings page
Screenshot : go/ss/5HeSbdABvUX3iw8.png

Bug: 337866252
Test: Manual
Change-Id: If54ff5f2e309b9ac4dd83ff3bbf53812031732c6
2024-06-10 05:20:01 +00:00
josephpv
f58acef107 Clear settings task on deleting private space
When private space is deleted from private space settings launched from
the All apps settings cog the settings sub activity is not cleared and
visibile in recents.
With this change it is taken care to remove and clear the sub settings
task hosting the Private space settings page when private space does not
exist and to make sure the activity is removed if it is the last
activity in that stack.

Bug: 333538964
Test: Manual
Change-Id: I22ba8ca8d2947c6604280cf398cd47434038d542
2024-04-23 13:30:15 +00:00
josephpv
f145d0e9a0 Update illustrations in Private Space setup & settings
This inlcudes the changes to use latest private space icon and update
the illustrations in private space setup and settings.
Change made to update illustrations dynamically between light and dark
theme.

Recordings link:
b/332867167#comment3

Bug: 332867167
Test: Manual
Change-Id: I6387c9991ec9bb419f446431926f99843f92c859
2024-04-09 22:35:04 +00:00
josephpv
4cc915ad64 Change icon for Private Space unlocked and setup success toast
Change is made to show customised icon in Toast message shown by using
Toast.makeCustomToastWithIcon()

Screenshots :
go/ss/AcaRQUJQfh79wDw.png
go/ss/5j4oD8xydwX7HTX.png

Bug: 329391204
Bug: 309575523
Test: Manual
Change-Id: I336d7d0419b1de60024e584e943a725662b446a9
2024-03-25 16:53:46 +00:00
Olivier Nshimiye
0f3799cbad Add an additional flag guard for Private Space implementation
This a layer of flag guarding only for the implementation of Private Space features excluding the APIs. The MVP flag allow_private_profile still guards all the features including the APIs.

Bug: 326060689
Test: Manual - a few verifications that some feeatures are unavailable when this flag is disabled
Test: Run presubmits and verify that nothing breaks
Change-Id: I05f7e2f20c6132b33484bb133ce03a933ece485f
2024-03-04 15:43:24 +00:00
josephpv
1e6e14c2c5 Add check to not show PS unlock message when activity is recreated
The condition added with this change makes sure the toast message is
shown only once and to not show duplicate toast  evertime the activity
is recreated on screen rotation.

Recording link : b/324442522#comment2

Bug: 324442522
Test: Manual
Change-Id: I4e17384c1d02deacdd911195f014b0c8f1eb8833
2024-02-09 19:30:07 +00:00
josephpv
4d6e11ce4b Show private space unlocked toast when PS is unlocked from Settings
This contains the change to show private space unlocked toast message
when PS is unlocked from private space settings entry point.
Also has change in the pending intent passed to requestQuietModeEnabled
API to allow BAL of PS settings page as suggested in go/debug-bal

Recording is uploaded to the issue b/317313482

Bug: 317313482
Test: Manually verified Toast is shown on PS unlock from settings

Change-Id: I2f03b7decdad2bb9e1018012ff5986e48305a4e7
2024-01-17 10:26:33 +00:00
Manish Singh
c1cd428e43 Don't show setting if private profile is locked
Bug: 311343261
Test: manual
Change-Id: I16e1f08c7cace0964e666a71e785fee1c18cc577
2023-12-12 08:51:19 +00:00
Manish Singh
51f1321b1e Put stricter flag checks
Also removed a log which gives away flag.

Bug: 312976400
Test: manual
Change-Id: I4a989de8b6b920666aabf0cc9311e28becc4d862
2023-11-24 18:51:27 +00:00
josephpv
499eab137f Remove CreatePrivateSpace entry from Private Space settings
Bug: 309581188
Test: Manually verified the item is not shown in Private Space Settings page
Change-Id: I08dca5a07256855ef629aabc68dde9058c00d333
2023-11-13 14:59:13 +00:00
Manish Singh
5aef6b6264 Remove temp workaround for feature flag
Using the trunk stable feature flagging now.

Bug: 295516544
Test: m
Test: manual adb
Test: atest SafetySourceBroadcastReceiverTest
Test: atest PrivateSpaceSafetySourceTest
Change-Id: I3d2d8c11dfb224ad2b09572493633366b4c4805c
2023-09-13 08:49:56 +01:00
Manish Singh
27c3987860 Add Private Space settings page
This involves:
1. Adding a new page for PS settings under Security & Privacy
2. Integrating the PS safety source with SafetyCenter.

Also, add the capability to create and delete PS from the page.
Creation is temporary to help with prototyping, and will be removed
finally.

Screenshots:
Private Space Entry point in Security & Privacy Settings:
https://screenshot.googleplex.com/4VHxNekjhxZHJwF

Private Space Settings page:
https://screenshot.googleplex.com/3Raw4wuymTHTgtM

Creating Private Space:
https://screenshot.googleplex.com/3dvzAH6V4kQmuYf

Private Space created:
https://screenshot.googleplex.com/Aj7nnF9uuUCa9Q5

Design doc:
https://docs.google.com/document/d/1CdjUjAE84-5ZEPRIfw5KYFjLVHtEZxc_sF0w95su8DA/edit?usp=sharing&resourcekey=0-dAACT9HRexY1IyoxMmkVlw

Bug: 286539356
Bug: 293569406
Test: manual
Test: atest DeletePrivateSpaceControllerTest
Test: atest UseOneLockControllerTest
Test: atest HidePrivateSpaceControllerTest
Change-Id: I9caf8e04e7fb2df36e60f607225e2931988ee692
2023-09-07 18:12:53 +01:00