Commit Graph

60621 Commits

Author SHA1 Message Date
Yi-Ling Chuang
ac59ea8e23 Do not prebind sticky slices.
We have a precheck mechanism to filter out slices that are not eligible
to be displayed on the homepage. Since sticky cards are designed to
be always available, which implies they will never be null, so skip
prechecking on them.

This allows us to prevent from the precheck timeout which usually leads
to the disappearance of cards.

Fixes: 152365480
Test: robotests
Change-Id: Ic9e3df8b55609e9b5d1d3fd3a8d95e4086d3d7a4
2020-05-14 11:38:47 +08:00
TreeHugger Robot
bb7a65a19b Merge "Add null check for intent in AppPermissionPreferenceController" into rvc-dev 2020-05-14 03:16:51 +00:00
tim peng
8d2c8f1f33 Merge "When only one device is selected in dynamic group, the device should be disabled" into rvc-dev 2020-05-14 01:35:44 +00:00
tim peng
4439bcf620 Merge "Refine layout for output switcher panel" into rvc-dev 2020-05-14 01:35:26 +00:00
menghanli
efabdcc7d6 Avoid launching activity-based feature to force stop exist actiivty and
recreate it.

Root cause: FLAG_ACTIVITY_CLEAR_TASK would cause the exist activity are finished and new one items to be started. It causes Live Transcribe main activity goes onStart call of new activity is followed by onStop call of old activity, which cause the mic stopping.

Solution: Remmove the FLAG_ACTIVITY_CLEAR_TASK.

Bug: 156455425
Test: Manual test
Change-Id: I86778577ff37d7f14b28e5eca3087fa9cf5cb2c1
2020-05-14 09:29:04 +08:00
Yanting Yang
a2d5ba3ebe Fix text view padding issue in EmptyTextSettings
Set the left and right padding of text view to 24dp.

Impact pages:
Apps & notifications > Special app access > Premium SMS access
Apps & notifications > Special app access > VR helper services

Fixes: 147901392
Test: visual
Change-Id: I01aa7935462e4d16e56be71a8f1f0cbe9b8275f9
2020-05-14 04:33:57 +08:00
TreeHugger Robot
abeb1a09fa Merge "Remove divider after last items" into rvc-dev 2020-05-13 20:01:52 +00:00
Nate Myren
8c7c22d4b9 Add null check for intent in AppPermissionPreferenceController
Sometimes, the App Info page can be reached without an intent in tests.
Add a null check to catch this

Bug: 154650244
Test: atest AppPermissionPreferenceControllerTest#handlePreferenceTreeClick_shouldStartManagePermissionsActivity

Change-Id: I514acda6b78d9e76b230aa945067bd7d6d9feff9
2020-05-13 13:00:53 -07:00
Julia Reynolds
9a6e7329be Remove divider after last items
Fixes: 155890866
Test: manual
Change-Id: Ie0e3f7ad8c1868bda7623718dd60926c300fa353
2020-05-13 14:03:40 -04:00
Bonian Chen
17ad56b3fc [Settings] Avoid from redraw UI when first time onResume
Registration of subscription change lead to redraw.
However, entire UI is newly created where redraw is not required
when fragment first time created.

Therefore, remove first callback from SubscriptionManager to reduce some
time.

Bug: 141833767
Test: manual
Change-Id: I54a58dd8271bb2cd8cd531cc02ff7d64b3e4328c
2020-05-13 18:47:09 +08:00
TreeHugger Robot
8224a5ad3d Merge "Update icon tint color when the user toggles Dark theme" into rvc-dev 2020-05-13 09:37:37 +00:00
PETER LIANG
31e6002ee8 Merge "Add the settings content observer for shortcut preference." into rvc-dev 2020-05-13 09:00:09 +00:00
TreeHugger Robot
0cc66ea23c Merge "Show the app pinning description after user enables it" into rvc-dev 2020-05-13 08:41:18 +00:00
Tim Peng
9a70887d75 Refine layout for output switcher panel
Bug: 156045699
Test: manual test
Change-Id: Ic889c0e755086e7d48c9a493f4ee5a8e394fdbe5
2020-05-13 15:20:54 +08:00
Tsung-Mao Fang
232cfc4e76 Show the app pinning description after user enables it
By design, we still need to show app pinning description
after user enables feature.

Test: Rebuilt rom, and see description.
Fix: 151332926
Change-Id: Ic9a2d7baec865358471ac0210648642ebd9fd65a
2020-05-13 14:43:23 +08:00
Peter_Liang
b3d5df4989 Add the settings content observer for shortcut preference.
Root cause:
Didn't update the UI when settings value chagned.

Next:
Add the settings content observer.

Bug: 155837154
Test: manual test & Robo test & atest
Change-Id: I7be952a3a8824d00d3903d4a69beb8f992d638a1
2020-05-13 14:43:20 +08:00
TreeHugger Robot
dfb3f561ea Merge "Allows to launch only authenticator owned activities" into rvc-dev 2020-05-13 05:26:25 +00:00
TreeHugger Robot
6d2ad68e1a Merge "Revert "Unable to select twilight scheduling after enabling location"" into rvc-dev 2020-05-13 05:16:51 +00:00
TreeHugger Robot
9ae5b47aee Merge "Revert "Add the settings content observer for shortcut preference."" into rvc-dev 2020-05-13 05:05:08 +00:00
TreeHugger Robot
02b7b16c93 Merge "[Wi-Fi] Quit worker thread of WifiPickerTracker" into rvc-dev 2020-05-13 04:18:18 +00:00
Edgar Wang
782438347b Revert "Unable to select twilight scheduling after enabling location"
This reverts commit 9073b2f968.
Bug: 153115261
Reason for revert: this CL make Settings robolectric test fail at com.android.settings.display.darkmode.DarkModeScheduleSelectorControllerTest

Change-Id: I3f1ba35f55f2905b10ca97149268be6074780eda
2020-05-13 03:58:36 +00:00
Edgar Wang
7e70ef64d4 Revert "Add the settings content observer for shortcut preference."
This reverts commit 785af0c15a.

Bug: 155837154

Reason for revert: robolectric test fail at com.android.settings.accessibility.ToggleFeaturePreferenceFragmentTest

Change-Id: If8e5681b044171ad6941307489526cc3834f66b2
2020-05-13 03:45:39 +00:00
Pasty Chang
e060311358 Merge "Set the text of accessibility description in suw to center" into rvc-dev 2020-05-13 03:03:50 +00:00
Sunny Shao
d6d8f98844 Allows to launch only authenticator owned activities
- 3rd party developers can define himself-authenticator
  and use the accountPreferences attribute to load the
  predefined preference UI.
- If a developer defines an action intent to launch the
  other activity in xml and it would return true due
  to the true exported attribute and no permission.
- To avoid launching arbitrary activity. Here allows
  to launch only authenticator owned activities.

Bug: 150946634
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.accounts
Test: PoC app
Change-Id: I5ce1a0b3838db7b3fbe48c6ea23d5f093d625cdb
2020-05-13 10:55:49 +08:00
Betty Chang
0c821c7be2 Merge "Add setPackage for PendingIntent in SliceHelper" into rvc-dev 2020-05-13 02:53:40 +00:00
Arc Wang
a52782bc06 [Wi-Fi] Quit worker thread of WifiPickerTracker
Should quit worker thread when a fragment is about to
be destroyed.

Bug: 152454787
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksFragmentTest
Change-Id: I809511b7f7c092cf9787e8f6bb7c7513c27c98c8
2020-05-13 10:34:51 +08:00
TreeHugger Robot
cd3cde6169 Merge "Revert "Create QS media player setting"" into rvc-dev 2020-05-13 02:20:05 +00:00
TreeHugger Robot
60920beb86 Merge "Remove the xml for bubble pref in developer options" into rvc-dev 2020-05-12 20:15:49 +00:00
Jason Hsu
394f925729 Merge "Fix the issue that title of Color inversion page is wrong" into rvc-dev 2020-05-12 18:04:49 +00:00
Mady Mellor
0216de39d9 Remove the xml for bubble pref in developer options
Fixes: 154246711
Test: build & install settings, check no bubbles option
      in developer options
Change-Id: I50166c21401b9c196d2ec2d039df2c03a080bb4d
2020-05-12 10:46:37 -07:00
Lucas Dupin
d207f1baee Revert "Create QS media player setting"
This reverts commit 665c36eae2.

Reason for revert: New media experience landed
Fixes: 156369996

Change-Id: Icb997a3508cec1e15f523b8ca5b923deacee66b4
2020-05-12 16:51:06 +00:00
Jay Aliomer
a5e7d180f1 Merge "Unable to select twilight scheduling after enabling location" into rvc-dev 2020-05-12 15:42:49 +00:00
jasonwshsu
112cd4d6d1 Fix the issue that title of Color inversion page is wrong
* Title need to be set from getPreferenceScreenResId(), recover the xml file.

Bug: 156201719
Test: manual test
Change-Id: Ib8b79c320c6a48b1dd679738ddc7022ccaeaed86
2020-05-12 23:35:11 +08:00
Kholoud Mohamed
311ff0c1ea Merge "String changes in the cross profile settings page" into rvc-dev 2020-05-12 15:13:32 +00:00
TreeHugger Robot
defd64c797 Merge "Fix broken test cases" into rvc-dev 2020-05-12 12:28:04 +00:00
pastychang
ca42bd3efc Set the text of accessibility description in suw to center
Bug: 155509097
Test: manual
Change-Id: I774ec3b58b9ff9ac38d8063a72d309af70708c84
2020-05-12 19:50:26 +08:00
Stanley Wang
4c5c80d421 Fix the search result "Free up space" doesn't work.
Can't find the target component if add the class name
and package name to the intent. So remove them.

Fixes: 152682394
Test: manual test the search result
Change-Id: I3b69486f6338b458c795860f7b3de9c119cb09de
2020-05-12 19:45:53 +08:00
PETER LIANG
a85f5dc80b Merge "Add the settings content observer for shortcut preference." into rvc-dev 2020-05-12 11:29:11 +00:00
Jason Chiu
bee14256df Add metrics log for special cases
Support Wifi toggle, Smart storage toggle, Manage storage, Face unlock,
Pixel Imprint

Bug: 137559984
Test: robotest
Change-Id: I3e2e666a8bee1e54d6bd13349b5bedb48fbc42df
2020-05-12 18:06:22 +08:00
changbetty
0383d76a5e Add setPackage for PendingIntent in SliceHelper
Bug: 151645867
Bug: 151646375
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiCallingSliceHelperTest
      make RunSettingsRoboTests ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Change-Id: I33c1333f9b5472cdb962b272f6be52a2d2959376
Merged-In: I33c1333f9b5472cdb962b272f6be52a2d2959376
2020-05-12 17:56:48 +08:00
Jason Chiu
b0230a6106 Merge "Rearrange styles and remove the same attributes as the parent style" into rvc-dev 2020-05-12 09:33:54 +00:00
Tsung-Mao Fang
d6c88649f6 Fix broken test cases
Test: Run robo test
Fix: 127602715
Change-Id: Idec3351b76801de98fac502ea59b2396a60df937
2020-05-12 16:57:05 +08:00
TreeHugger Robot
defa38c7ae Merge "Revise the text limit of volume shortcut key." into rvc-dev 2020-05-12 08:49:40 +00:00
Peter_Liang
beb7d8485d Revise the text limit of volume shortcut key.
Revise the char limits as 100.

Bug: 156268057
Test: manual test
Change-Id: I76b9dd5adf5201d6640c7023c487a8205a56bc9a
2020-05-12 14:20:49 +08:00
Peter_Liang
785af0c15a Add the settings content observer for shortcut preference.
Root cause:
Didn't update the UI when settings value chagned.

Next:
Add the settings content observer.

Bug: 155837154
Test: manual test
Change-Id: Icee0bb50f88987ea6c8a0be59bd936628a32ca1e
2020-05-12 14:15:54 +08:00
Jason Chiu
8ac1e4d49d Update icon tint color when the user toggles Dark theme
- Reload theme in slice provider when Dark theme mode changes for slices
- Reload theme in onCreate of Panel activity for its non-slice header
- Remove applyTheme from individual slices

Test: robotest
Fixes: 153700819
Change-Id: I40a7d2817c4b9100d7b2f2962a69c8a9ce6f7906
2020-05-12 10:58:54 +08:00
Tim Peng
550fd3ef9a When only one device is selected in dynamic group, the device should be disabled
-Check if device id is in selected group rather than comparing client package name
-Add test cases

Bug: 154916764
Test: make -j50 RunSettingsRoboTests
Change-Id: I7364a9e3d807bbfc6b26b8212ab2da67ea329582
2020-05-12 01:44:56 +00:00
Nate Myren
0c6037af5f Merge "Add Auto Revoke log to the App Info page" into rvc-dev 2020-05-11 22:37:04 +00:00
Kholoud Mohamed
bcbd9158d6 String changes in the cross profile settings page
Fixes: 155771527
Test: visually tested the string changes.
Change-Id: Idcde93e2035bb8d3d82213befb652aa29aa12efe
2020-05-11 18:38:05 +01:00
TreeHugger Robot
57150e5930 Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-05-11 17:31:56 +00:00