Commit Graph

407 Commits

Author SHA1 Message Date
Irfan Sheriff
18dc7ea709 Fix crash for tether with quotes in SSID
Multiple quotes cause havoc with netd interaction right now.
The solution is to revert the changes for WifiConfiguration on
Access Point side done in Change I0f1e508b and remove all quotes
in the SSID.

Essentially a low risk one line change on top of the revert.

We dont expose API for WifiConfiguration on AP side. This solution
essentially means we treat SSID in WifiConfiguration on AP side
differently. When we do expose things, we should make things consistent.

Change-Id: I0a7e5074b83ace743fc843ee61c1ff86cde8267f
2010-05-17 13:20:39 -07:00
Chung-yih Wang
de5302577f am 5dcdbb5c: am 8719f0d2: am 8c81257f: Fix the double-quoted SSID issue. 2010-05-17 09:21:28 -07:00
Chung-yih Wang
8719f0d20a am 8c81257f: Fix the double-quoted SSID issue.
Merge commit '8c81257f70fabeaa505e292bd0c2226dd5eefc4c' into froyo-plus-aosp

* commit '8c81257f70fabeaa505e292bd0c2226dd5eefc4c':
  Fix the double-quoted SSID issue.
2010-05-14 23:16:25 -07:00
Chung-yih Wang
8c81257f70 Fix the double-quoted SSID issue.
Bug id http://b/issue?id=2684571

Change-Id: I0f1e508b9a3d0fefcef28235380392368a51e42a
2010-05-15 10:57:23 +08:00
The Android Open Source Project
64a2d0c0fe am 1795d18f: am 2c3265af: merge from open-source master 2010-04-21 10:18:33 -07:00
The Android Open Source Project
2c3265af74 merge from open-source master
Change-Id: I9d308271306bfcbdc0ef461605f800e5d48334a3
2010-04-21 09:46:57 -07:00
Mike Lockwood
68b8069862 Display current IP address in advanced Wifi settings screen
Change-Id: I47c6eece376e712b73add72057462926f7b2349f
Signed-off-by: Mike Lockwood <lockwood@android.com>
2010-04-20 13:52:38 -04:00
Irfan Sheriff
c02e258eaa am e7879010: am ea87b6d7: Merge "Stop scanning after errors" into froyo 2010-04-17 09:44:54 -07:00
Irfan Sheriff
ea87b6d75c Merge "Stop scanning after errors" into froyo 2010-04-17 09:28:21 -07:00
Irfan Sheriff
e81497095b Stop scanning after errors
When scan fails for 3 times, we show a
failure toast and continue to scan.
In one case this caused infinite toasts,
until the user stopped wifi.

Its not clear what can cause this kind of
a state since wifi disable broadcast should
stop the scans. This fix will stop scans
after 3 continuous failures. Any wifi state
change will restart scan.

Bug: 2601937
Change-Id: I68733394cb3c9b76ffb15f7579e7af6c1f54d39c
2010-04-16 14:56:54 -07:00
Irfan Sheriff
24e5193e3f am 39a7379a: am c190c4f5: Merge "Grey out wifi tethering in airplane mode" into froyo 2010-04-15 12:32:49 -07:00
Irfan Sheriff
2d4e135fec Grey out wifi tethering in airplane mode
When airplane mode is enabled, wifi tethering
should be disabled since there is no real
use case for it.

This also addresses the issue
of trying to restore Wifi (with tethering on)
when airplane mode is disabled.

Bug: 2594720
Change-Id: I7379ebed74a58b148ae82ed589d09aa2b9ca767d
2010-04-14 15:15:09 -07:00
Irfan Sheriff
5536c4a052 am a4bbf553: am 3957b3c1: Merge "scan only when wifi is enabled" into froyo 2010-04-10 11:58:12 -07:00
Irfan Sheriff
2215c7f868 scan only when wifi is enabled
Bug: 2570611
Change-Id: Ibb51dee8ec110179ec28f9469526a1fe61e74d00
2010-04-09 17:52:26 -07:00
Irfan Sheriff
7c85ce9242 am 0e10c088: am 0b266964: Fix window leak on orientation change 2010-04-07 15:09:43 -07:00
Irfan Sheriff
0b2669647f Fix window leak on orientation change
Use Activity managed dialogs

Bug: 2571764
Bug: 2571820
Change-Id: Id506988abd4200155774e92b31dd132519e29172
2010-04-07 14:38:42 -07:00
Irfan Sheriff
f5a6e5bfa9 am dbb0a7ed: am 6e74d41b: Fix network disable on connect 2010-04-05 10:19:31 -07:00
Irfan Sheriff
6e74d41bd0 Fix network disable on connect
If we dont have an updated access point list
when we are re-enabling networks after connecting,
we could end up keeping some networks disabled.

This could happen if there is no event that
triggers an access point before enabling networks

Update the current access point list
right before enabling all networks.

Bug: 2567770
Change-Id: Ieb1ac8147d4acb05a6d13c44396653f0af94643d
2010-04-05 09:28:25 -07:00
Freeman Ng
79470d1a66 wifi settings option to only enable Next button once a wifi connection is established
Change-Id: I4b346648bce4b93f4885f1577a1510dcd18d8df5
2010-03-31 11:11:28 -07:00
Irfan Sheriff
9303d97e6a Remember Wifi state prior to tethering
We now remember whether Wifi was enabled
prior to enabling tethering. This will
allow us to restore Wifi when tethering
is disabled.

Bug: 2537983
Change-Id: Ia530563bd5647856d62cd59b67ae5156de6fd5d9
2010-03-25 12:23:18 -07:00
Irfan Sheriff
a6a74e222a Disable tethering to enable Wifi
We need to explicitly disable wifi while enabling
tethering and disable tethering while enabling wifi

Bug: 2539071
Change-Id: I7fda6e4d9d1bb804e81561d52b5f3a982a674b0e
2010-03-25 11:39:11 -07:00
Chung-yih Wang
141fe818f1 Fix the incorrect keystore prefix of private key in the wpa_supplicant.conf.
Change-Id: Ibc77d10f6c945d274037422b2e4e58d1bbd9888d
2010-03-23 12:17:20 +08:00
Irfan Sheriff
9775dc9515 Add password hint and fix settings crash
Bug: 2534348
Bug: 2533980
Change-Id: I2f220ac9c710869d3f93a56557afb33478c3b323
2010-03-22 15:33:44 -07:00
Irfan Sheriff
3e5cfe8f0a Update AP config status
Bug: 2533950
Change-Id: Idac1213b9dc44c073fa5cf8da00b8599161565f2
2010-03-22 14:50:46 -07:00
Irfan Sheriff
b3be4d0c50 Move status update to WifiApEnabler
Bug: 2528202
Change-Id: I093699ac171279af9df5f3b3b4ae359aab79088b
2010-03-19 09:17:59 -07:00
Chia-chi Yeh
05d35416e8 WifiSettings: do not set auth_alg for WPA/WPA2 networks.
Change-Id: Ib41a52d90ca8db3cb52aa1fb87e2433bb76f4de2
2010-03-17 15:52:54 +08:00
Irfan Sheriff
47ebb78954 softAp UI changes
Remove channel settings
Add subtext error handling
Remove WEP, keep WPA2 only for now

Bug: 2413908
Change-Id: Ie867e84a0705f0d2185eeb3a4c86a8227446a338
2010-03-16 16:03:13 -07:00
Dmitry Shmidt
c11618c826 Fix WEP Open/Shared network settings
Change-Id: I2ccf73e19d27ed5c60f3f028a44a241ed6a7bb50
Signed-off-by: Dmitry Shmidt <dimitrysh@google.com>
2010-03-16 12:47:33 -07:00
Adam Powell
cc2ee7fcc6 Fixed NPE in WifiApDialog found by monkey
Change-Id: I4f5e75e21c1e3433712e49a148db4af04215f0a1
2010-03-08 11:35:15 -08:00
Adam Powell
2d70273673 Added null check for monkey behavior 2010-03-05 17:51:40 -08:00
Irfan Sheriff
2ae37e8ce0 Get all strings in for Wifi tethering
Bug: 2413908
Change-Id: I3d28fcfcb4a6e4eaf03e57d69f9d2c92730b12e5
2010-03-04 17:40:43 -08:00
Irfan Sheriff
65cff17722 Add AP support for tethering
First phase of the AP support in
UI and framework
Bug: 2421638

Change-Id: I0b6c31be5fe79bd4d33c292464d271b054754e8d
2010-03-04 14:34:52 -08:00
Chia-chi Yeh
af7b2d8a23 WifiSettings: enable all networks only when connected, disconnected, or failed. 2010-02-05 18:18:51 +08:00
Chia-chi Yeh
7d6bfbfc30 WifiSettings: enable all networks when state is changed. 2010-02-05 16:28:39 +08:00
Chia-chi Yeh
9dee8a96c5 WifiSettings: tweak the order of calls to registerReceiver() to make the UI better. 2010-02-04 16:16:25 +08:00
Chia-chi Yeh
065cd4be64 WifiSettings: rename WifiSettings2 to WifiSettings. 2010-02-03 15:56:55 +08:00
Chia-chi Yeh
df90dd9f55 WifiSettings: remove dead code. 2010-02-03 15:16:54 +08:00
Chia-chi Yeh
48090d4066 WifiSettings: revise and add support for editing EAP networks.
Use arrays.xml to store translations for enumerations;
avoid race conditions happened when pop up menu or dialog;
avoid saving configurations with networks disabled;
use the same layout for all the dialogs;
support editing EAP networks;
only unlock keystore before connecting;
and many bug fixes I cannot remember.

The number of lines in the new code is about 1/3 of the old one,
and it improves the readability a lot!
2010-02-02 18:31:58 +08:00
Irfan Sheriff
0a57284e15 Allow channel count modification on userdebug
Bug: 2378844
Change-Id: I62bca602c3fe1fefdc4a4517573b2c3db9d53a1f
2010-01-28 12:26:37 -08:00
Irfan Sheriff
9e0135fd45 am 8e79fda8: am ad76f17a: Remove regulatory group setting in advanced wifi setting
Merge commit '8e79fda826f78afe063763183d31398cdee5ac84'

* commit '8e79fda826f78afe063763183d31398cdee5ac84':
  Remove regulatory group setting in advanced wifi setting
2010-01-27 15:52:35 -08:00
Irfan Sheriff
ad76f17a1c Remove regulatory group setting in advanced wifi setting
Bug: 2378844
Change-Id: I2eefa73cca238ab04842ffc8f8968dac5f953456
2010-01-21 10:20:43 -08:00
Chia-chi Yeh
feeb756132 WifiEnabler: add support to show supplicant state. 2010-01-16 07:09:20 +08:00
Chia-chi Yeh
b90452f3d2 Settings: revise WifiEnabler and BluetoothEnabler.
This mainly changes the way both enablers react to the airplane mode. Now
enablers show a toast message instead of disabling the check box directly. This
avoids the inconsistent state introduced by WirelessSettings which controls the
check box using layout dependency.

Related bug: 2053751
2010-01-15 06:12:29 +08:00
Irfan Sheriff
94a9f0a4ab Do a null check on setting an AP as configured
This was introduced when trying to fix bug 2296038. A null check is required on AP.

Bug: 2296038
2010-01-06 16:54:21 -08:00
Chia-chi Yeh
4e14211d21 Settings: revise WifiSettings. 2009-12-25 14:48:46 +08:00
Jeff Sharkey
1c4e96864f Allow bluetooth in airplane mode when in "toggleable" list.
Settings.System.AIRPLANE_MODE_TOGGLEABLE_RADIOS is a list of
radios that can be toggled while in airplane mode.  This CL
changes BluetoothEnabler to respect this.

It parallels the logic in WifiEnabler, which enables OEMs
to allow Wifi changes when in airplane mode.

Most existing devices don't include "bluetooth" in the
toggleable list, which means bluetooth will continue to be
disabled when in airplane mode for those devices.

Fixes http://b/2297314
2009-12-22 14:35:44 -08:00
Irfan Sheriff
c9a663abf7 WifiSettings has leaked window
Fix for leaked window
Bug: 2311236
2009-12-18 14:52:14 -08:00
Irfan Sheriff
2ff62e2c7b Wifi diagnostic app to enable debug and provide information
This is the first checkin on the wifi diagnostic app. Right now,
it supports using the WifiManager API, shows the configuration details
and provides status on the supplicant, network and wifi state along with
some additional details.

More to come:
- add more API and status on any additional fields
- provide a way to show some logs

Bug: 2302130
2009-12-10 15:07:05 -08:00
Irfan Sheriff
60e5714311 Missing Forget button after doing Add Network on an AP in the scanned list
Problem:

On the Wifi Settings screen, if instead of clicking on the AP shown on the scanned list, we do an "Add Wi-Fi network" and enter the AP information - the AP information gets stored and the client device connects to the AP. Afterwards, if we click on the AP again the "Forget" button does not appear until we exit the Wifi Settings screen and return.

Root cause and Fix:
mApScanList in WifiLayer tracks the list of APs shown. Upon doing a connect through a direct click, the configured state for the AP in the list updated. However, if we do an Add Network, the configured state on mApScanList remains unupdated. This causes the Settings screen to not show "Forget" for the AP when it is clicked.

The fix is to set the Configured state to true in handleSave() by fetching the AP state stored in WifiLayer.

Bug: 2296038
Change-id: I70c545905a4984a03a0f235f3baf17cd36688710
2009-12-01 16:56:39 -08:00
Robert Greenwalt
0a4ab1eab2 Disable Save of empty-named AP.
Empty SSID names can cause weird problems, so don't allow the user to save them.

bug: 2211656
2009-10-26 13:51:06 -07:00