Commit Graph

1527 Commits

Author SHA1 Message Date
Daniel Nishi
6a256e77d6 Fix a crash when transferring an app.
This crash occurs because the background loader is loading
the storage for an app which is currently being moved off of
the device. In the native code which is calculating the storage,
it throws an InstallerException which is caught and rethrown as an
IllegalStateException.

We handle this in the view by reporting that we could not calculate
the size of the app.

Change-Id: I109b1be60ae60f8ef31b08cb4392b576261fa806
Fixes: 35922033
Test: Robotest
2017-03-07 17:53:12 -08:00
TreeHugger Robot
4a23676590 Merge "Fix test when running with ROBOTEST_FILTER option" 2017-03-07 23:55:21 +00:00
Fan Zhang
dc5a06e7e4 Display a hardware info dialog when click model number.
Change-Id: I28eeb3e5c3ed290d4e03e0f3989adde0b966bede
Fix: 35851000
Test: make RunSettingsRoboTests
2017-03-07 15:42:40 -08:00
TreeHugger Robot
8e12df9d62 Merge "Fix a crash when opening uninstalled app detail page" 2017-03-07 23:13:20 +00:00
Daniel Nishi
41f36cdae8 Merge "Use the screen context when adding preferences." 2017-03-07 22:55:06 +00:00
Fan Zhang
6bb0d00d74 Fix test when running with ROBOTEST_FILTER option
Change-Id: I864af10cecb6ad520c999a41be4f6ba6f6c378bf
Bug: 36024626
Test: make RunSettingsRoboTests
2017-03-07 14:28:21 -08:00
Steven Ng
3183c22238 Merge "Fix phishing attack in ChooseLockGeneric" 2017-03-07 21:49:32 +00:00
Fan Zhang
1f81d10dc5 Fix a crash when opening uninstalled app detail page
Change-Id: I417e7eb6f9c857ace4e8047b226abe03a7c8248d
Fix: 36027848
Fix: 34392538
Test: make RunSettingsRoboTests
2017-03-07 13:24:31 -08:00
TreeHugger Robot
e0b65fce67 Merge "Remove code that check for dashboard feature." 2017-03-07 20:57:28 +00:00
Steven Ng
436256c36d Fix phishing attack in ChooseLockGeneric
Test: 1) make and run SettingsTests. It passes.
      2) Manual test 1
         a) On a device supports fingerprint, set a password but not fingerprint.
         b) adb shell am start -a android.app.action.SET_NEW_PARENT_PROFILE_PASSWORD
         c) Confirm Lock password screen is shown
         d) Select "Skip fingerprint". There isn't a second lock password confirmation screen.
         e) A new password can be set successfully.
      3) Manual test 2
         a) Repeat step 2)a) - 2)c)
         b) Select "Fingerprint + PIN". There isn't a second lock password confirmation screen.
         c) A new password and fingerprint can be enrolled successfully.

Bug: 33059280
Change-Id: I1078c6e303fc41aeeb370e5d6518d1f16b5837f1
2017-03-07 19:48:35 +00:00
Gustav Sennton
3c89d8e2cf Fix disabled WebView packages being shown as enabled in Dev Setting.
WebView packages that cannot be chosen as WebView implementation should
be shown as disabled in the 'WebView Implementation' Dev Setting.
Simplify the logic in DefaultAppInfo a little bit to avoid
special-casing for the WebView Dev setting.
Also add tests to ensure we are correctly disabling WebView packages in
the Dev setting and showing their disabled-reasons.

Bug: 35707106
Test: 'make RunSettingsRoboTests'
Test: Ensure disabled WebView packages show up as being disabled in the
'WebView Implementation' Dev Setting.
Change-Id: Ic2f5265c3451b6396e55b7bc29689c3d889ddb5e
2017-03-07 19:30:10 +00:00
Doris Ling
f2cf2aea37 Remove code that check for dashboard feature.
- remove DashboardFeatureProvider.isEnabled() and all relating code
and tests.

Bug: 35764802
Test: make RunSettingsRoboTests
Change-Id: If7796677abc8904b7436525836d50cdef38e37a4
2017-03-07 11:15:03 -08:00
TreeHugger Robot
2437d3c64a Merge "Add default IME to Privacy Settings page" 2017-03-07 18:36:55 +00:00
Daniel Nishi
c7bf800ebf Merge "Align the profile calculation with other screens." 2017-03-07 17:49:28 +00:00
Daniel Nishi
5e1f6dc241 Merge "Fast track the installed app details storage." 2017-03-07 17:48:54 +00:00
Anton Philippov
66084a5368 Hide "Factory reset" item for secondary users
Bug: 35415714
Test: make RunSettingsRoboTests
Change-Id: I48d6d094476c5fc83dbc17906d84cc848e499624
2017-03-07 16:37:36 +00:00
Tony Mak
ef4c83962d Fix failed to remove account in managed profile
Fix: 35996483

Test: m -j RunSettingsRoboTests
Test: manual test
          1. Remove account in work profile
          2. Remove account in user 0


Change-Id: I3ed9364afbf8ef5cddd0edc0d4e0e5e48d2dd62a
2017-03-07 15:33:20 +00:00
Bartosz Fabianowski
2700cdbdac Add default IME to Privacy Settings page
This CL adds information about default IMEs set by Device Owner and/or
Profile Owners to the Enterprise Privacy Setting page.

Test: make RunSettingsRoboTests
Bug: 32692748

Change-Id: I9f78ab4792a5a1d444808048ff33e3e20a0483dc
2017-03-07 12:43:42 +01:00
TreeHugger Robot
126d9ae6f4 Merge "Create settings page for choosing default Network Scorer." 2017-03-07 02:06:09 +00:00
TreeHugger Robot
5914d143e7 Merge "Update preference logger to log pref change as ACTION" 2017-03-07 02:00:32 +00:00
Lei Yu
0d988208c0 Merge "Add type UNACCOUNTED("miscellaneous") in advanced battery page" 2017-03-07 01:54:21 +00:00
TreeHugger Robot
68ef61a105 Merge "Create whitelist for the most popular settings" 2017-03-06 23:56:33 +00:00
Fan Zhang
c6f4c9c9b5 Update preference logger to log pref change as ACTION
Change-Id: I600cf6ec79cbc876347c3fdb20ea70fffbc04524
Fix: 34775467
Test: make RunSettingsRoboTests
2017-03-06 15:39:22 -08:00
Stephen Chen
9347c95c39 Create settings page for choosing default Network Scorer.
Bug: 35203304
Bug: 35852687
Test: make RunSettingsRoboTests -j40
Change-Id: Iaef671e0a9e8beb560e1d2c9864f44ef46993a6b
2017-03-06 14:08:50 -08:00
Daniel Nishi
522e05f169 Align the profile calculation with other screens.
The profile fragment was accidentally adding all of the app's
code data to the profile, even if it was already attributed to the
primary user.

Change-Id: I47000bbe1fcf98d5e9f252eb74b22fee05b7034d
Fixes: 35919232
Test: Settings Robotest
2017-03-06 13:56:57 -08:00
Daniel Nishi
ad7aa871e7 Fast track the installed app details storage.
Change-Id: Ic96a7b4bea6d92a32669887dacbc1f4e54e25ea9
Fixes: 35805032
Test: Settings robotest
2017-03-06 13:55:00 -08:00
TreeHugger Robot
490e4ea011 Merge "Add code coverage support for robolectric tests" 2017-03-06 20:51:34 +00:00
Matthew Fritze
b759516cbf Create whitelist for the most popular settings
As a temporary solution to getting the most popular
settings to be the top rank, we have created a white list.
If a prioritized setting shows up somewhere in the results
then it will be given an elevated rank to be at the top.

Bug: 35048659
Test: make RunSettingsRoboTests
Change-Id: I92b563a17b42d8f91d980dd1d8e5f8f29ca5aa9c
2017-03-06 12:31:41 -08:00
TreeHugger Robot
bdaf7572d9 Merge "Add tests for NonIndexableKeys in NFC payments" 2017-03-06 18:52:36 +00:00
Anton Philippov
8e667cf2d4 Merge "Fix search results for backup settings." 2017-03-06 10:24:17 +00:00
TreeHugger Robot
98fa7780a9 Merge "Fix ServiceConnectionLeak in network fragment" 2017-03-04 16:25:12 +00:00
Matthew Fritze
5e1ab7f974 Add tests for NonIndexableKeys in NFC payments
Also serves as an example for testing NIKs.

Test: make RunSettingsRoboTests
Fixes: 35931606, 35657617

Change-Id: Ia4de8ec3c508ceaa6573252ecd372b479b5ce815
2017-03-03 18:23:28 -08:00
Fan Zhang
f5f71a9be2 Fix ServiceConnectionLeak in network fragment
Change-Id: I43efe9ae31fc2f58361abdb034b0205a3f3e2b71
Fix: 35957226
Test: make RunSettingsRoboTests
2017-03-03 18:01:19 -08:00
TreeHugger Robot
2f7d8bc086 Merge "Adding "Install Other Apps" in App Info page" 2017-03-04 00:39:22 +00:00
TreeHugger Robot
271dd30704 Merge "Update theme for filter widget." 2017-03-04 00:35:07 +00:00
Fan Zhang
3ca5e45425 Update theme for filter widget.
Bug: 35933748
Test: visual

Change-Id: I0c09c90360c436e25ca4a40993dde31cb2b4287b
2017-03-03 14:53:13 -08:00
Suprabh Shukla
86d52db588 Adding "Install Other Apps" in App Info page
Added a preference link to manage external sources in the app info
screen just like other special access permissions.

Test: Manually checked that the link appears on apps once their app op
is set to allow or deny.
Also, added some basic robolectric unit tests:
make -j32 RunSettingsRoboTests

Bug: 35481942
Change-Id: If687778b7a64fb7d278508b78d06272253a98e3e
2017-03-03 14:46:16 -08:00
Soroosh Mariooryad
606cb64097 Fixing a bug in suggestion logging and adding more tests.
Test: RunSettingsRoboTests
Fixes: b/35802845

Change-Id: I216b3ff344ccdffd038d924649109483e80f5437
2017-03-03 10:18:52 -08:00
Anton Philippov
9a5220e7c3 Fix search results for backup settings.
Make BackupSettingsAcitivity searchable and remove PrivacySettings from
the search index.

Bug: 35720213
Test: make RunSettingsRoboTests -j40
Change-Id: Id2e091c978e4da078dcc6bc57760ec830e439c0c
2017-03-03 12:49:40 +00:00
TreeHugger Robot
ce6e17ddfe Merge "Set config for enabling support UI in Settings" 2017-03-03 04:21:38 +00:00
TreeHugger Robot
a9ee4e8649 Merge "Show uninstall for all users option menu in app info." 2017-03-03 04:19:07 +00:00
TreeHugger Robot
d749dfadcb Merge "Show settings app icon and name in recents" 2017-03-03 03:59:28 +00:00
TreeHugger Robot
6f80166cbb Merge "Share preference controllers between fragment/searchIndexer" 2017-03-03 03:09:56 +00:00
Fan Zhang
801be627fc Share preference controllers between fragment/searchIndexer
Test: make RunSettingsRoboTests
Change-Id: I9042bac87b7c063b89c143d3089ed4d94f77b994
Fix: 35812240
2017-03-02 17:03:03 -08:00
Fan Zhang
2a376723ae Fix a NPE when clicking encryption interstitial header
Pref tree handler cannot assume preference has non-null key.

Change-Id: I790e75f3b4c888e2a48b297bea89cda0b8dbaabd
Fix: 35855587
Test: runtest --path tests/app/src/com/android/settings/EncryptionInterstitialTest.java
2017-03-02 17:02:22 -08:00
Fan Zhang
6ff6add756 Set config for enabling support UI in Settings
Change-Id: I85b7c7a7e465084d534757e083667b67928b8e43
Fix: 35870668
Test: make RunSettingsRoboTests
2017-03-02 17:02:06 -08:00
jackqdyulei
64af489a6a Add type UNACCOUNTED("miscellaneous") in advanced battery page
This type is equal to DrainType.UNACCOUNTED.

Bug: 35926913
Test: RunSettingsRoboTests
Change-Id: I2be73a5220c6d674593508f2578e7c4f6e111ea9
2017-03-02 15:20:37 -08:00
Daniel Nishi
dbc54a1736 Use the screen context when adding preferences.
When the context from the controller itself is used, it is
not the correct context and causes the created preferences to
be styled incorrectly. By using the screen's context directly,
we can ensure that the preferences inherit the correct style.

Change-Id: I02503e5f4fab8f8110e5d29bd3a479f0ce1d6aca
Fixes: 35891968
Test: Robotest
2017-03-02 15:08:29 -08:00
Doris Ling
2508ed56ca Show uninstall for all users option menu in app info.
- when there is only 1 user installed the app, also check if it is
installed by the current user or by other user to determine whether or
not to show the uninstall for all button.

Change-Id: I1eecb13a7748c92159cb0626e2b6fe1ed6987d15
Fix: 34760157
Test: make RunSettingsRoboTests
2017-03-02 13:30:59 -08:00
Lei Yu
64fee1cfe1 Merge "Add metric enums for menu in battery settings page." 2017-03-02 21:05:44 +00:00