Commit Graph

4017 Commits

Author SHA1 Message Date
Sunny Shao
6e21c76111 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the ManageAssist page.

Fixes: 139457944
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.applications
Change-Id: I89b6cac21e924774a1fcfe790863d8eaab8d6da7
2019-08-15 15:56:10 +08:00
Sunny Shao
30cfc2553e Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the some accessibility pages.

Fixes: 139455988
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.accessibility
Change-Id: Ia1568e0a120eede26fadc16764caef2ecfb2411a
2019-08-15 15:11:16 +08:00
TreeHugger Robot
c61b43d043 Merge "Use FooterPreference in xml explicitly" 2019-08-14 19:03:35 +00:00
TreeHugger Robot
78d2c2fc56 Merge "Use FooterPreference in xml explicitly" 2019-08-14 09:39:29 +00:00
TreeHugger Robot
73cb0b104a Merge "Remove PreferenceCategory wrapper" 2019-08-14 09:18:28 +00:00
Sunny Shao
a6c0bd5346 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the TetherSettings page.

Fixes: 139397226
Test: manual test
Change-Id: Ice7f97881df9cc17177ed7fcc1da9f3124c445a9
2019-08-14 14:46:23 +08:00
Sunny Shao
a47e7ddcc3 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the DataSaverSummary page.

Fixes: 139393749
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.datausage
Change-Id: Ie229acd903eb24e369beef8bbf5ff0bdd9ce50d1
2019-08-14 13:52:08 +08:00
TreeHugger Robot
5c4f9b3748 Merge "Use FooterPreference in xml explicitly" 2019-08-14 05:12:33 +00:00
Raff Tsai
896de3b48b Remove PreferenceCategory wrapper
- Avoid similiar issue in b/130396913

Bug: 124129485
Test: manual
Change-Id: I6f4698304210bacba5c76020c375dda49330d2cc
2019-08-14 12:31:06 +08:00
Sunny Shao
1bebe19101 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the ChooseLockGeneric page.

Fixes: 139269907
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.password
Change-Id: I86e294015354c0a6a6311441892a770503382d1f
2019-08-13 20:08:54 +08:00
TreeHugger Robot
e796653f0a Merge "Clean up "Restrict SMS" developer setting" 2019-08-13 01:45:40 +00:00
Sunny Shao
b4214464e5 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the ZenModeBlockedEffectsSettings page.

Fixes: 139258311
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.notification
Change-Id: I0367390ffb27743e394db3108b3992fee1b943a7
2019-08-12 12:09:39 +08:00
Raff Tsai
946441ca27 Learn mode link is not in footer text
Use wrong footerPreference key.

Change-Id: Ic88b4bf9cf336474231329aa2154242d3f95b91a
Fix: 139086150
Test: visual
2019-08-09 17:21:18 +08:00
TreeHugger Robot
fa9e685fff Merge "Use FooterPreference in xml explicitly" 2019-08-09 00:25:22 +00:00
Sunny Shao
660b36e061 Use FooterPreference in xml explicitly
- Removed the FooterPreferenceMixin from the BluetoothDetailsMacAddressController.
 - Added the common api addFooterPreference.

Fixes: 139104386
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.bluetooth
Change-Id: Iab40fa4c5be674290b1dc6d372c84609ccc2ea49
2019-08-08 18:42:26 +08:00
Sunny Shao
fb695782c5 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the BillingCycleSettings page.

Fixes: 139099367
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.datausage
Change-Id: I408e433b3366a617b6c5a6fdb18f4830de4b8287
2019-08-08 16:25:14 +08:00
Eugene Susla
1a52b92dc2 Clean up "Restrict SMS" developer setting
The underlying setting itself was cleaned up in Q,
the toggle does nothing and just turns itself back off when toggled

Test: ensure developer settings no longer have the "Restrict SMS" toggle
Fixes: 138827426
Change-Id: I5d5dda82f8f34330a705ad60d2b7f77d552b76fe
2019-08-07 15:43:21 -07:00
TreeHugger Robot
52493ff4f7 Merge "Use FooterPreference in xml explicitly" 2019-08-07 14:35:36 +00:00
Sunny Shao
b97eda4ff5 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the FeatureFlagsDashboard page.

Fixes: 139046148
Test: manual test
Change-Id: I6363f265a9c8b996141b7d7547c450cb70e2a7cd
2019-08-07 17:48:32 +08:00
Sunny Shao
6b4a22522b Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the ChooseAccountFragment page.

Fixes: 139043643
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.accounts
Change-Id: I2b6ebef7f8ca0684afd75ec9bdd742a78a771bcd
2019-08-07 17:01:25 +08:00
Stanley Wang
c9d8437287 Merge "Fix fail to search by input "4G Calling"" 2019-08-07 02:37:30 +00:00
Sunny Shao
343c39faee Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the AdaptiveSleepSettings page.

Fixes: 138965988
Test: manual test
Change-Id: If6fba673af304d8522f3b01ac6607cd8a7ead747
2019-08-06 20:50:20 +08:00
Stanley Wang
7b489d57a8 Fix fail to search by input "4G Calling"
Fixed step:
1.Update resource xml file in SearchIndexProvider.
2.Add keywords for preference title array.
3.Initizlize data member.
When getAvailabilityStatus called by updateNonIndexableKeys,
the data member should be initialized,
otherwise it always returns CONDITIONALLY_UNAVAILABLE

Fixes: 137155154
Test: manual
Change-Id: Id06d78bffdeba247741dcfe81e9ed7e179141397
2019-08-06 19:49:34 +08:00
Sunny Shao
c83bb787c5 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the AutoBrightness page.

Fixes: 138916403
Test: manual test

Change-Id: I131d5cede156e2dae890342d5b456f347b025e27
2019-08-05 18:29:01 +08:00
TreeHugger Robot
87ecb5deed Merge "Import RadioButtonPreference from SettingsLib" 2019-08-03 02:52:36 +00:00
Edgar Wang
677b943ae1 Merge "Add skip lock screen in Notification & security lock screen settings" into qt-r1-dev am: 8e3b202070 am: 3448917d8e
am: fc0aec7f1a

Change-Id: Icb23c10cf6f6b4bf4c8fcb81d23d1c2b8d7ddd33
2019-08-01 23:13:14 -07:00
Edgar Wang
fc0aec7f1a Merge "Add skip lock screen in Notification & security lock screen settings" into qt-r1-dev am: 8e3b202070
am: 3448917d8e

Change-Id: Ib451284c689f984e8064af58ef538b34e8ec6784
2019-08-01 23:00:21 -07:00
Edgar Wang
063cc34713 Merge "Add skip lock screen in Notification & security lock screen settings" into qt-r1-dev
am: 8e3b202070

Change-Id: Ib1cf35ee24f88a9eae71714349fe40cb982214b0
2019-08-01 22:49:22 -07:00
Edgar Wang
8e3b202070 Merge "Add skip lock screen in Notification & security lock screen settings" into qt-r1-dev 2019-08-02 05:38:23 +00:00
Raff Tsai
71a37d138b Import RadioButtonPreference from SettingsLib
Bug: 138620011
Test: manual, robolectric
Change-Id: I3b8a2be021a1b4a07aae61483f2329b7a5bd4655
2019-08-01 07:16:55 +00:00
Edgar Wang
58a5be4401 Add skip lock screen in Notification & security lock screen settings
Users may have trouble finding this setting in face auth.
Heard this from dogfood/executive feedback and customer support discussion.
So add Skip Lock Screen preference in
Display > Lock screen display > What to show >
and
App & Notifications > Notifications > Lock Screen >

Bug: 138458558
Test: robotest & manual

Change-Id: I10e420821423821743d65b00c8b7e6d4d1224e00
2019-08-01 11:17:05 +08:00
Antony Sargent
fa99ea7dc6 Merge "Protect entry points to add an eSIM when admin restricted" into qt-r1-dev am: 4685c785b9 am: ad2f49f851
am: bf2c5ce274

Change-Id: Ia0d2a348088ac2dc72e5b5218718aa80105d3e16
2019-07-31 16:35:58 -07:00
Antony Sargent
ad2f49f851 Merge "Protect entry points to add an eSIM when admin restricted" into qt-r1-dev
am: 4685c785b9

Change-Id: I5792ff5333005e2e0c66fd24d594b79bf67d140c
2019-07-31 15:56:00 -07:00
Antony Sargent
482415d37e Protect entry points to add an eSIM when admin restricted
If the DISALLOW_CONFIG_MOBILE_NETWORKS admin policy is set, we were
accidentally still allowing access to the flow where you add an eSIM
subscription via the "plus" button on the Network & internet page. While
fixing this, I also noticed that the mobile networks list page (which
only becomes available if you have multiple subscriptions) has a link at
the bottom to start the flow as well, and that wasn't being protected.

The fix for the plus button on the Network & internet page was just to
make sure not to call setEnabled(true) if the preference was already
disabled by admin policy, since that has the effect of overriding the
admin-disabling.

The fix for the mobile networks list page just needed to add the
relevant tags in the layout XML, and then we get it for free.

Fixes: 137627845
Test: make RunSettingsRoboTests
Change-Id: I896ac248f50aaeecc157791938a0a0a98265aa07
2019-07-31 12:53:39 -07:00
Kevin Chang
3cb76abd05 Merge "Add gesture navigation setting into a11y settings" 2019-07-30 01:04:13 +00:00
TreeHugger Robot
2d035ddfa2 Merge "Move channel listing into a pref controller" into qt-qpr1-dev 2019-07-29 18:42:25 +00:00
Jason Chiu
3973e79dd4 Merge "Fix DISALLOW_AMBIENT_DISPLAY blocks access to all lock screen display settings" into qt-r1-dev am: 04ad8c905a am: f7423fd7ac
am: 409e4bc475

Change-Id: I7e5552ded8fc30a7e129d339fb8b9eca6deac0a4
2019-07-26 19:08:16 -07:00
Julia Reynolds
c400ce3c80 Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.

Also delete some unused code that no longer complied after
this refactor.

Fixes: 133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
(cherry picked from commit a295d71c94)
2019-07-26 19:24:43 +00:00
Kevin Chang
9f834959d3 Add gesture navigation setting into a11y settings
Add new entry for gesture navigation setting in accessibility settings

Bug: 130362168
Test: Visual
Change-Id: I704ccb40ef913535948b83b439df9f708a89ca46
2019-07-26 19:00:19 +08:00
Jason Chiu
32930dbe4e Fix DISALLOW_AMBIENT_DISPLAY blocks access to all lock screen display settings
"Ambient display" was merged into "Lock screen display", and the entry
was also moved from security page to display page and leveraged the
original user restriction of "Ambient display".

The user restriction should just work on the switch of Ambient display
instead of the "Lock screen display" entry.

Bug: 138177691
Test: robotest, visual
Change-Id: I5db0eb68c3aa6f4f7d8ecd42db2cdc72255b12f7
2019-07-25 16:23:12 +08:00
Kevin Chang
5fc6db2cf7 Merge "Add footer preference into caption preferences" into qt-r1-dev 2019-07-18 06:59:47 +00:00
Kevin Chang
5277da96c2 Add footer preference into caption preferences
Add footer preference into caption preferences to tell users
that the setting doesn't support all apps.

Reference link of screenshot:
https://drive.google.com/file/d/1VzpWa4M-4HjlfjDNNqrEIKwo3v0y_f51/view?usp=sharing

Bug: 135888603
Test: Visual
Change-Id: I95e0aa301eba7343fbc798cc406c0242f4f4eb7e
Merged-In: I95e0aa301eba7343fbc798cc406c0242f4f4eb7e
(cherry picked from commit 8f4b8b9a74)
2019-07-17 11:28:01 +00:00
Kevin Chang
ef9cd2ac95 UI change in caption preferences in Settings
Move the switch after the caption preview and change the oreder of the
settings inside in caption preferences in Accessibility settings.

Reference link for screenshot:
https://drive.google.com/file/d/1EQLpfQFnJTwU1F8vLAOSHPYqSXKWL_ap/view?usp=sharing

Bug: 130755332
Test: Visual
Change-Id: Icb4dabdef71be165a21d1bde474872ee0bb35bfa
Merged-In: Icb4dabdef71be165a21d1bde474872ee0bb35bfa
(cherry picked from commit fd1f1c0f82)
2019-07-17 11:27:06 +00:00
Raff Tsai
55459042ae Merge "Add wifi calling slice to settings search and AGSA" 2019-07-13 04:14:55 +00:00
Raff Tsai
85e1218b31 Add wifi calling slice to settings search and AGSA
Fixes: 121041498
Test: test if wifi calling slice is appeared in Settings Search
Change-Id: I4892da6e7d396f28bb232f8e520a8c946f35570d
2019-07-12 23:40:27 +08:00
Raff Tsai
97b083b268 Make more preference copyable
Fixes: 137255130
Test: manual
Change-Id: I76317efd22ef9cccd094a06943eadde8204427b2
2019-07-12 11:47:41 +08:00
Mill Chen
10829a2164 Merge "Clean up in-code preference controllers from accessibility" 2019-07-10 09:21:22 +00:00
Kevin Chang
4d609c0198 Merge "Add footer preference into caption preferences" 2019-07-10 01:05:31 +00:00
Mill Chen
6f3b222ca5 Clean up in-code preference controllers from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: I0c1358657d3f57ddae2b8f2b12ee610e7363f41f
2019-07-09 17:35:32 +08:00
Mill Chen
d2d1801e3b Separate long press timeout preference controller form accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: If49e4336b3461ec2a9568b8652c5aab0ff64ecfe
2019-07-03 21:27:34 +08:00