Commit Graph

43454 Commits

Author SHA1 Message Date
Behnam Heydarshahi
d9c3cf855f Muting ring volume slider disables notification
With volume_separate_notification flag enbaled, muting ring volume
slice will cause notification volume slice to gray out.

There used to be a bug in which notification slice would not get
updated in response to a change in ring volume mute/unmute broadcast.
The resulting erroneous behavior was notification slider would get to
zero but not get grayed out. To fix that bug, VolumeSliceHelper listens
to ring stream mute/unmute broadcasts and forwards them to notification
slice.

Bug: b/266072907
Test: make DEBUG_ROBOLECTRIC=1 ROBOTEST_FILTER="NotificationVolumePreferenceControllerTest|VolumeSliceHelperTest" RunSettingsRoboTests -j40

Change-Id: I2ab51f1272bf99a0c3d9ca285354052d00910c90
2023-02-15 15:43:08 +00:00
Behnam Heydarshahi
d89de47399 Merge "Propagate mute event to both ring volume slices" into tm-qpr-dev 2023-02-15 14:28:15 +00:00
menghanli
991b70c720 Add a done button to vision setting pages in setup flow
Root cause: User feels confused because the particular screen doesn't have a back button but at that moment of the setup flow the regular UI gestures didn't even work.
Solution: Add a done button to the vision settings pages for clearer navigation. This change combines parts of commit 5e931b2c23 and commit dd2ec775c8.

Bug: 262995569
Test: make RunSettingsRoboTests ROBOTEST_FILTER=FragmentForSetupWizardTest
Change-Id: Id3a0d78389e0e6c11b5b5cf016b37673fde7f286
Merged-In: Id3a0d78389e0e6c11b5b5cf016b37673fde7f286
(cherry picked from commit dd2ec775c8)
2023-02-15 06:32:57 +08:00
Behnam Heydarshahi
236bbcb8bc Propagate mute event to both ring volume slices
Fix a bug where introduction of a separate_ring_volume slice meant that
the original ring_volume slice would not get notified of ring stream
muting event.

Bug: b/266855922

Test: make DEBUG_ROBOLECTRIC=1 ROBOTEST_FILTER=VolumeSliceHelperTest RunSettingsRoboTests -j40
Change-Id: Ifb5ebe4e7d9bde3d14336891cce3fbee167a5911
2023-02-13 14:50:27 +00:00
Candice Lo
b0087167e0 Merge "Move font size related resources to SettingsLib (1/2)" into tm-qpr-dev 2023-02-10 09:12:05 +00:00
Candice Lo
3fb6e69f88 Move font size related resources to SettingsLib (1/2)
Since creating the seekbar for changing font size in SystemUI requires
the size of the value entry array and the values in the array.
Therefore, we move the related resource to SettingsLib to share the usage.

Bug: 242326166
Test: make RunSettingsRoboTests ROBOTEST_FILTER=FontSizeDataTest
Test: Maually test the availability of changing font size through
Settings page

Change-Id: Ia2621e3b4c71f900e6591644d0e3f93bedbe4ee8
Merged-In: If630bd9c9c27823c210410b53342b921a11bbfb9
2023-02-10 06:36:50 +00:00
SongFerngWang
e85bb5058d Add a config to hide the 3G option at preferred network mode UI
Add a config config_display_network_mode_3g_option to hide the 3G
option at preferred network mode UI

Bug: 261615630
Test: build pass. local test pass.
atest EnabledNetworkModePreferenceControllerTest

Change-Id: I4f94971add1d1eddc9f7c7458b8fc8fdcec3935e
(cherry picked from commit f7685dd715)
Merged-In: I4f94971add1d1eddc9f7c7458b8fc8fdcec3935e
2023-02-08 07:41:13 +00:00
TreeHugger Robot
a48f8944f9 Merge "Add animation for progress bar and lottie in fingerprint enrollment" into tm-qpr-dev 2023-02-07 23:53:42 +00:00
Diya Bera
7eb40da9c4 Add animation for progress bar and lottie in fingerprint enrollment
Test: Manual - While enrolling a fingerprint, onHelp will cause the
lottie and progress bar to shake
Bug: 266838595

Change-Id: I547d86182a87846aca7d025b35a008675f449e2e
Merged-in: I547d86182a87846aca7d025b35a008675f449e2e
2023-02-07 22:48:55 +00:00
Zoey Chen
ba7418ecd7 [Settings] Add the CarrierNetworkChange case
Bug: 262927206
Test: atest SubscriptionsPreferenceControllerTest
Change-Id: If7eeb185224179d59ab841af0062ec5b98b956e9
Merged-In: If7eeb185224179d59ab841af0062ec5b98b956e9
2023-02-07 10:48:30 +00:00
Diya Bera
135041eab5 Merge "Remove background tint during SUW" into tm-qpr-dev 2023-02-06 17:57:55 +00:00
Diya Bera
87567ceb5e Remove background tint during SUW
Test: Manual - navigate to the activity mentioned in the bug and observe
the background
Bug: 264993674

Change-Id: I21c8143099e4c76ed5744cff12f31f578320a871
2023-02-03 23:29:06 +00:00
Lucas Silva
ca65b6e5ba Add content description to screensaver customization button
This will let users know which screensaver they are customizing.

Fixes: 267582102
Test: flashed device and enabled talkback, opened screensaver settings,
and verified talkback correctly says the name of the screensaver

Change-Id: I9d0d9422f06b7a78efca0e6953b73fe612f79e2a
2023-02-03 15:27:26 -05:00
Jack Yu
c4a0475681 Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0 am: 3ccadd2c97 am: 9d643d3042 am: 4745a591c5 am: 34ce0e2c3a am: 1befdab699
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: Iafe87e53b9337f84dcd44494e509aa8398b0298c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 14:42:19 +00:00
Jack Yu
1befdab699 Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0 am: 3ccadd2c97 am: 9d643d3042 am: 4745a591c5 am: 34ce0e2c3a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: I0df6b9e868058e014644742f2cfa4841d83ad838
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 13:49:58 +00:00
Jack Yu
34ce0e2c3a Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0 am: 3ccadd2c97 am: 9d643d3042 am: 4745a591c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: Ia0803da9acf81da41d5ffd289b705eb3e7128547
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 13:16:57 +00:00
Jack Yu
4745a591c5 Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0 am: 3ccadd2c97 am: 9d643d3042
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: I3099c3e158aaf0a99a8fa3d894b0c5dc1713e2b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 12:22:41 +00:00
Jack Yu
9d643d3042 Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0 am: 3ccadd2c97
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: I763baefc5b94776c0583273fe9ab47ae99e6a57c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 11:27:23 +00:00
Jack Yu
3ccadd2c97 Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: I5690485d1cacd39b5b74316f561691bc68d48787
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 10:10:20 +00:00
Jack Yu
c098bdcad0 Only primary user is allowed to control secure nfc am: 0e57ff90cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: I35c94f779d47e27c170ec3b4becafc563f077a68
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 09:21:04 +00:00
Josh Hou
406abc4d62 Fix the security vulnerability issue in AppLocalePickerActivity am: 33ef83795e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21152842

Change-Id: Ic0ff8ade7897052d04c118dc0a8f67312f5d0ebf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 00:50:59 +00:00
Josh Hou
1739114d44 Merge "Fix the security vulnerability issue in AppLocalePickerActivity" into tm-qpr-dev 2023-02-02 00:15:12 +00:00
Diya Bera
31406c042d Merge "Tests for SUW in work mode" into tm-qpr-dev 2023-02-01 23:29:35 +00:00
Diya Bera
1021b58ae5 Tests for SUW in work mode
Bug: 247049655
Test: m RunSettingsRoboTests -j30 ROBOTEST_FILTER=MultiBiometricEnrollHelperTest
Change-Id: Ifabb96a90c340bc9306cc0f033ba103c614f32a9
2023-02-01 22:05:09 +00:00
Edgar Wang
b5215abde7 Merge "Update lottie illustration for tablet" into tm-qpr-dev 2023-02-01 10:22:46 +00:00
Josh Hou
33ef83795e Fix the security vulnerability issue in AppLocalePickerActivity
Examine whether the packages is allowed to display app locales list when creating the AppLocalePickerActivity, and examine whether the target user is the same as the calling user.

Bug: 257954050
Test: Follows the test step listed in b/257954050#comment14
Change-Id: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
Merged-In: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
2023-02-01 15:49:20 +08:00
Josh Hou
5d7d1665fe Fix the security vulnerability issue in AppLocalePickerActivity
Examine whether the packages is allowed to display app locales list when creating the AppLocalePickerActivity, and examine whether the target user is the same as the calling user.

Bug: 257954050
Test: Follows the test step listed in b/257954050#comment14
Change-Id: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
Merged-In: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
2023-02-01 15:42:22 +08:00
Edgar Wang
2f5f6d4ee6 Update lottie illustration for tablet
Bug: 243889662
Bug: 243889643
Test: visual
Change-Id: Icac10e4401da3d704350aef6ef2723ff92ca34f8
2023-02-01 07:27:18 +00:00
Yong Zhang
6cb1a7ce5a Merge "Adjust AlwaysExpand List so that face detail settings will show in side panel while posture guidance will show full-screen" into tm-qpr-dev 2023-01-31 23:33:24 +00:00
Jack Yu
0e57ff90cd Only primary user is allowed to control secure nfc
Bug: 238298970
Test: manual
Merged-In: I945490ef1e62af479a732c9a260ed94bdd8bc313
Change-Id: I945490ef1e62af479a732c9a260ed94bdd8bc313
2023-01-31 07:41:49 +00:00
Chengfei Tao
b5e5100f92 Adjust AlwaysExpand List so that face detail settings will show in side panel
while posture guidance will show full-screen

Test: Manual testing with power cycle
Bug: 263068723
Change-Id: I6d632d08dcb3597cd8470f8d3d34258e4280dc14
2023-01-30 10:17:04 +08:00
Stefan Andonian
d0e6bddbc5 Merge "Move ViewCapture On/Off controls to QuickSettings Tile." into tm-qpr-dev 2023-01-27 04:38:04 +00:00
Diya Bera
9f1e35fe1a Merge "Added string to encourage user to enroll more fingerprints" into tm-qpr-dev 2023-01-25 22:16:34 +00:00
Diya Bera
711f16ddd8 Added string to encourage user to enroll more fingerprints
Test: Manual - Finish enrolling a fingerprint and check the message
displayed
Bug: 265023475

Change-Id: I77a6bd08a5bfb58971539bf4d366d0425ae0c9a0
Merged-in: I77a6bd08a5bfb58971539bf4d366d0425ae0c9a0
2023-01-25 18:32:13 +00:00
Daniel Norman
f6e3be8352 Merge "RESTRICT AUTOMERGE Updates Accessibilty Settings resources for sw600dp." into tm-qpr-dev 2023-01-25 17:44:40 +00:00
Valentin Iftime
99b8b4cd60 Enforce INTERACT_ACROSS_USERS_FULL permission for NotificationAccessDetails
When using EXTRA_USER_HANDLE, check for INTERACT_ACROSS_USERS_FULL permission on calling package.

Bug: 259385017
Test:
 1. Build a test app that creates and starts an intent to NOTIFICATION_LISTENER_DETAIL_SETTINGS while setting the intent extra  "android.intent.extra.user_handle" to UserHandle(secondaryUserId).
 2. Create and switch to a secondary user
Settings > System > Multiple users > Allow multiple users > Add user > Switch to New user
 3. Open Settings > Notifications > Device & app notifications and choose an app from the list (uses android.permission.BIND_NOTIFICATION_LISTENER_SERVICE). Enable Device & app notifications for selected app and disable all attributed permissions.
 4. Switch back to the Owner user.
 5. Get the userId of the secondary user: adb shell pm list users.
 6. Open the test app and enter the userId for the secondary user and the component name that uses android.permission.BIND_NOTIFICATION_LISTENER_SERVICE.
 8. In the settings window that open, enable all 4 sub-options.
 9. Switch to the secondary user and note that the all sub-options for the app are disabled.

Change-Id: I875b9f2fc32c252acdcf8374a14067836e0f1ac6
2023-01-23 16:57:21 +00:00
Daniel Norman
383c10fe93 RESTRICT AUTOMERGE Updates Accessibilty Settings resources for sw600dp.
Includes some .java updates to automatically convert colors for lottie
animation files.

Fix: 261547883
Fix: 243905003
Fix: 243889447
Fix: 261544574
Test: launch cf_x86_64_tablet, open Settings > Accessibility
Test: Open "Color & motion" > "Color inversion"
Test: Open "Timing controls" > "Time to take action"
Test: Open "Caption preferences"
Test: Open "Magnification" > "Magnification shortcut"
Test: Open "Accessibility shortcuts" >
      "Accessibility button and gesture", change options
Test: Perform the above with both light and dark mode.
Change-Id: I46b75b53feb8870d3154744e058eb898e6011725
2023-01-20 23:32:20 +00:00
Steve Elliott
c8a6db40ac Merge "Setting to control seen notification filtering" into tm-qpr-dev 2023-01-20 23:22:56 +00:00
Piotr Wilczyński
0066afbe15 Merge "Set display size to all displays" into tm-qpr-dev 2023-01-20 09:39:50 +00:00
Steve Elliott
f127bc13b0 Setting to control seen notification filtering
Test: manual
  1. adb shell settings put secure \
     lock_screen_show_only_unseen_notifications <0|1>
  2. Settings > Notifications > General > Show only new notifications on
     lock screen
  3. Toggle setting
  Observe: if setting is enabled, seen notifications are filtered from
           the lockscreen, and vice versa
Bug: 254647461
Change-Id: I4f6e35a1d918095cea25a97f72ddd08869ad9b31
2023-01-19 22:22:30 +00:00
Bonian Chen
147669c893 Merge "[Settings] Reduce CDMA API access when not required" into tm-qpr-dev 2023-01-19 03:21:27 +00:00
Grace Cheng
5c10188254 Merge "Prevents retrying fingerprint after lockout reset if user exits FingerprintSettings" into tm-qpr-dev 2023-01-19 02:54:26 +00:00
Grace Cheng
83fce8a0aa Prevents retrying fingerprint after lockout reset if user exits FingerprintSettings
Fingerprint auth is active on the enrolled fingerprints page to indicate
to users which fingers are enrolled. Tapping 5x with unenrolled finger
on this page sends FINGERPRINT_ERROR_LOCKOUT, which posts a
mFingerprintLockoutReset runnable to retry fingerprint auth after
LOCKOUT_DURATION. If a user turns off their device and unlocks via
pin/pattern/password, this resets lockout, triggering the runnable and
causing fingerprint auth to be retried upon device entry. This change
prevents this by removing the runnable callback in
FingerprintSettingsFragment#onPause.

Test: Navigate to enrolled fingerprints page (Settings > Security > Face & Fingerprint Unlock > Fingerprint Unlock). Tap 5x with unenrolled finger, then turn off screen and unlock via pin/pattern/password. Ensure indicator does not appear upon device entry.
Fixes: 261366312
Change-Id: I4190669286461e9ce884685a9929313da953476d
2023-01-19 01:00:16 +00:00
Joshua Mccloskey
ead95a4205 Merge "Set default value for performant auth." into tm-qpr-dev 2023-01-18 03:09:58 +00:00
Joshua Mccloskey
0dd635f28f Merge "Fixed additional lottie flicker in fp settings." into tm-qpr-dev 2023-01-17 19:35:31 +00:00
Piotr Wilczyński
2858620d25 Set display size to all displays
Bug: 197730930

Test: Open Settings, go to Display -> Display size and text -> Display size, change the value, fold/unfold the device, see that the value persists.
Test: DisplaySizeDataTest
Test: atest ScreenResolutionFragmentTest
Test: ScreenZoomSettingsTest
Change-Id: I3d6858a9b20798c2ad3b12a66db3484491682691
Merged-In: I3d6858a9b20798c2ad3b12a66db3484491682691
2023-01-17 17:30:12 +00:00
Joshua McCloskey
470c6b11b4 Set default value for performant auth.
Test: Manually verified its default to enabled.
Bug: 265264294
Change-Id: Ibbad0165f4ef396be70d3a566ca77597c2bcbb8e
Merged-In: Ibbad0165f4ef396be70d3a566ca77597c2bcbb8e
2023-01-17 17:07:54 +00:00
Behnam Heydarshahi
673e191e98 Merge "Always index RingerModeAffected slices" into tm-qpr-dev 2023-01-17 14:30:49 +00:00
TreeHugger Robot
66e23eb89c Merge "5/ Refine SetupChooseLockPattern layout by design" into tm-qpr-dev 2023-01-17 03:56:35 +00:00
SongFerng Wang
f71b548285 Merge "Revert "[MEP] psim->esim, don't skip carrierConfigChanged with subId -1"" into tm-qpr-dev 2023-01-16 07:44:37 +00:00