Commit Graph

40705 Commits

Author SHA1 Message Date
changbetty
0adb8dc55a To get Display name by active subscription info
Bug: 206601918
Test: manual test and test team verified pass
Change-Id: Id156b3c5c65ff3af25f74721db27f46c08f3543e
2021-12-06 06:40:52 +00:00
Bonian Chen
5de864ae93 [Settings] Refactor Wifi Calling description text
Refactor the display of description text when no wifi calling options available.
Enhancement:
1. These text need to align the style with the summary part of the wifi
calling options.
2. These text need to be scrollable in order to see full description.
3. The link within text need to be clickable.

Bug: 204844012
Test: local
Change-Id: I60f339bf4adf50236d80176669a557c77f0d97ca
(cherry picked from commit 8a892271da)
Merged-In: I60f339bf4adf50236d80176669a557c77f0d97ca
Merged-In: I8bbe6c653c51b8ca43d936e50166f0f8bfb1acdc
2021-12-06 04:00:50 +00:00
Bonian Chen
ace21a81da [Settings] Refactor Wifi Calling description text
Refactor the display of description text when no wifi calling options available.
Enhancement:
1. These text need to align the style with the summary part of the wifi
calling options.
2. These text need to be scrollable in order to see full description.
3. The link within text need to be clickable.

Bug: 204844012
Test: local
Change-Id: I60f339bf4adf50236d80176669a557c77f0d97ca
(cherry picked from commit 8a892271da)
Merged-In: I60f339bf4adf50236d80176669a557c77f0d97ca
Merged-In: I8bbe6c653c51b8ca43d936e50166f0f8bfb1acdc
2021-12-05 15:05:53 +00:00
Ryan Lin
94c98af51c Merge "Fix incorrect UI after triple-tap is disabled" into sc-v2-dev am: 2007a57560 am: 7f704f6c95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16379103

Change-Id: Ic1ed1eb6e8b74f80bbcc205be3cc45997f2b2ec2
2021-12-03 10:30:05 +00:00
Ryan Lin
7f704f6c95 Merge "Fix incorrect UI after triple-tap is disabled" into sc-v2-dev am: 2007a57560
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16379103

Change-Id: Icce7853960e621266a8817f22cf88a52fae7a7d5
2021-12-03 10:14:30 +00:00
Ryan Lin
2007a57560 Merge "Fix incorrect UI after triple-tap is disabled" into sc-v2-dev 2021-12-03 09:52:13 +00:00
Jason Chiu
d2e506fd20 Merge "Revise homepage highlight mechanism" into sc-v2-dev am: 7bfe3e869a am: 3b9ad4de7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16366004

Change-Id: Ib86f125d24836fb955d5dd31ec26f250460d3161
2021-12-03 09:46:31 +00:00
Jason Chiu
3b9ad4de7f Merge "Revise homepage highlight mechanism" into sc-v2-dev am: 7bfe3e869a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16366004

Change-Id: I0737a0463b51399a9410b238c23094715168f5ae
2021-12-03 09:27:13 +00:00
Jason Chiu
627fd3928c Improve the cold start performance
The performance regressed since the previous change that hide the
homepage view from using View.GONE to View.INVISIBLE

This change only initializes the list views in the invisible homepage
view to prevent a scroll flicker when scrolling is needed.

Test: manual
Bug: 206555277
Bug: 205823792
Change-Id: I8f173b135cfa1d27a1362d5fa8e3f338e2428ad2
2021-12-03 17:12:08 +08:00
Jason Chiu
7bfe3e869a Merge "Revise homepage highlight mechanism" into sc-v2-dev 2021-12-03 08:23:24 +00:00
Wilson Wu
fd9287b7da Merge "Make on-screen keyboard settings support tab layout" 2021-12-03 04:05:18 +00:00
Jason Chiu
a305c23f5e Revise homepage highlight mechanism
- Create TopLevelHighlightMixin to handle highlight actions and simplify
  TopLevelSettings
- Fix the error highlight and the flicker after screen rotation
- Postpone creating the fragment until it's needed to accelerate the
  initialization and to fix the search highlight function breakage after
  toggling light/dark mode
- Register activity embedding rules only once for injection and
  wallpaper
- Do not highlight Tips & support since it's full screen
- Refactor ActivityEmbeddingRulesController

Bug: 207316936
Test: manual, robotest build pass
Change-Id: If322ec180b03ee123987c70779a25c6a570d9faf
2021-12-03 12:04:48 +08:00
ryanlwlin
a992b611bf Fix incorrect UI after triple-tap is disabled
The preference summary is not changed after
users disable the triple tap shortcut by the confirm
dialog. It is due to the fact that the fragment doesn't
observe the settings value change.

To fix it, we add the settings key to observe the change.

Bug: 208755360
Test: manual test
Change-Id: Ie5b7fc5e67c5491b53485af0d3d68d1789aeace4
2021-12-03 01:58:25 +00:00
Alex Johnston
a0ddbe36d6 Merge "Add non system overlay flag to InstallCaCertificateWarning" into sc-v2-dev am: 86cee74361 am: 62ab8f5847
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16358378

Change-Id: I73b5e496f4a2d8f206f23e775816a70ff20fc0a7
2021-12-02 16:05:03 +00:00
Alex Johnston
62ab8f5847 Merge "Add non system overlay flag to InstallCaCertificateWarning" into sc-v2-dev am: 86cee74361
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16358378

Change-Id: If2ceb7cc90fd16ea20e22fde771bb8ccc63842a6
2021-12-02 15:50:18 +00:00
Alex Johnston
86cee74361 Merge "Add non system overlay flag to InstallCaCertificateWarning" into sc-v2-dev 2021-12-02 15:34:01 +00:00
Jason Hsu
4c450d6b4c Merge "Align the "Open activity" UI style with usual accessibility service "Use service"" into sc-v2-dev am: 5c90a9c225 am: 8216c769a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16321718

Change-Id: I7fdcacbe0cc5939d84e08c5e220ef85956cf2ba8
2021-12-02 11:42:11 +00:00
Jason Hsu
8216c769a9 Merge "Align the "Open activity" UI style with usual accessibility service "Use service"" into sc-v2-dev am: 5c90a9c225
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16321718

Change-Id: I56bfde017611f42e38d16488a5fa02f18d2db253
2021-12-02 11:27:03 +00:00
Bonian Chen
6c3320eabb Merge "[Settings] Refactor Wifi Calling description text" 2021-12-02 11:05:28 +00:00
Jason Hsu
5c90a9c225 Merge "Align the "Open activity" UI style with usual accessibility service "Use service"" into sc-v2-dev 2021-12-02 11:01:49 +00:00
TreeHugger Robot
3d8edf8e43 Merge "Fix the background color of CollapsingToolbarLayout" into sc-v2-dev am: d355d7f123
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16284152

Change-Id: I2203f0844c527bf1ac7934b1d711117397ed120c
2021-12-02 07:54:01 +00:00
TreeHugger Robot
d355d7f123 Merge "Fix the background color of CollapsingToolbarLayout" into sc-v2-dev 2021-12-02 07:19:45 +00:00
Mill Chen
3825bff021 Fix the background color of CollapsingToolbarLayout
The wrong background color of CollapsingToolbarLayout appears in some
pages like "All apps" page or "Password and accounts" page. This symptom
can be observed in these pages when the work profile is enabled and the
line count of title is 1.

This issue is caused by updating the title of the page many times. In
these pages that have the tab view, the structure of the page differs
from a general setting page. The title of the page is coming from
BaseActivity, ProfileSelectFragment, PersonalFragment and WorkFragment,
in which the page that has the issue has an empty string from
ProfileSelectFragment. That is causing the CollapsingTollbarLayout has
the different line count during the process of setting the title.

Since the pages that have the tab view are different from the general
pages in Settings, the title should be set separately for those pages.
Adding a method to get the title resource ID so the page extending from
ProfileSelectFragment can set its title.

Bug: 192914660
Test: visual test and manual test
1) Enable work profile
2) Navigate to All apps page
3) The page should have the correct background color in the
CollapsingToolbarLayout

Change-Id: I52ef9729f3cad56161ea3d87ba25429dfcdb26ef
Merged-In: I52ef9729f3cad56161ea3d87ba25429dfcdb26ef
2021-12-02 13:40:45 +08:00
TreeHugger Robot
9e978441af Merge "Fix the background color of CollapsingToolbarLayout" 2021-12-02 05:26:01 +00:00
TreeHugger Robot
fff560a4bd Merge "Set property based on gesture option changed." 2021-12-02 05:14:31 +00:00
Super Liu
65d46d6ee4 Set property based on gesture option changed.
System software could do the runtime configuration based on
this added property.

Bug: 193467627
Test: manual test.
Signed-off-by: Super Liu <supercjliu@google.com>
Change-Id: I1897320e1c5d5d446727899328363e6a714983f8
2021-12-02 09:47:02 +08:00
Joshua Mccloskey
cc179be29f Merge "Fixed face enroll intro button issue" into sc-v2-dev am: 506c6b804f am: 78ab60db84
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16365598

Change-Id: Ic324c6829d8dfa180ca7e0aaf5d8841c0e76dd88
2021-12-01 23:43:01 +00:00
Joshua Mccloskey
78ab60db84 Merge "Fixed face enroll intro button issue" into sc-v2-dev am: 506c6b804f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16365598

Change-Id: I2236768c62d8a8b48a4b4348b5e02bb7beb3c31f
2021-12-01 23:25:22 +00:00
Joshua Mccloskey
506c6b804f Merge "Fixed face enroll intro button issue" into sc-v2-dev 2021-12-01 23:08:49 +00:00
Jan Tomljanovic
6fd0716f58 Add SafetyCenter entry to Settings.
Test: atest SettingsUnitTests
Bug: 204978295
Change-Id: I9bedb58ad740b4ee76620e04675a0aefa659566a
2021-12-01 18:40:57 +00:00
Joshua Mccloskey
3d5c9011f0 Merge "Disable setting if sensor is convenience." into sc-v2-dev am: 1ca42ffc79 am: e372b2a22b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16233490

Change-Id: I32ecd37e6f3937a845ee2637b9774455a8bac81b
2021-12-01 18:08:55 +00:00
Joshua Mccloskey
e372b2a22b Merge "Disable setting if sensor is convenience." into sc-v2-dev am: 1ca42ffc79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16233490

Change-Id: I9a4e565b311d7a65091aca5294879366b9399265
2021-12-01 17:19:04 +00:00
Joshua Mccloskey
1ca42ffc79 Merge "Disable setting if sensor is convenience." into sc-v2-dev 2021-12-01 17:09:50 +00:00
Mill Chen
28bc1c04b9 Fix the background color of CollapsingToolbarLayout
The wrong background color of CollapsingToolbarLayout appears in some
pages like "All apps" page or "Password and accounts" page. This symptom
can be observed in these pages when the work profile is enabled and the
line count of title is 1.

This issue is caused by updating the title of the page many times. In
these pages that have the tab view, the structure of the page differs
from a general setting page. The title of the page is coming from
BaseActivity, ProfileSelectFragment, PersonalFragment and WorkFragment,
in which the page that has the issue has an empty string from
ProfileSelectFragment. That is causing the CollapsingTollbarLayout has
the different line count during the process of setting the title.

Since the pages that have the tab view are different from the general
pages in Settings, the title should be set separately for those pages.
Adding a method to get the title resource ID so the page extending from
ProfileSelectFragment can set its title.

Bug: 192914660
Test: visual test and manual test
1) Enable work profile
2) Navigate to All apps page
3) The page should have the correct background color in the
CollapsingToolbarLayout

Change-Id: I52ef9729f3cad56161ea3d87ba25429dfcdb26ef
2021-12-01 18:44:42 +08:00
Tsung-Mao Fang
737288ff75 Update background color for two-pane mode am: 395ea90b83 am: e6a79f0670
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16282524

Change-Id: Ifad1cd990154bc3e367921e94ea5c9d1d7b73ca5
2021-12-01 10:32:46 +00:00
Tsung-Mao Fang
e6a79f0670 Update background color for two-pane mode am: 395ea90b83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16282524

Change-Id: I2b4fffda97aaec53945c4de4cf6248fb81163e64
2021-12-01 10:22:01 +00:00
Tsung-Mao Fang
395ea90b83 Update background color for two-pane mode
Update background color for status bar and
homepage background programically.
Also, we update the backgroud color for highlight items.

Test: Rebuilt apk and see the screen.
Bug: 195293058
Change-Id: Id100f8c9c7fc02c43420afcca07a703a14ec2312
2021-12-01 16:39:09 +08:00
Joshua Mccloskey
756fa20e1c Fixed face enroll intro button issue
Fixed an issue where sometimes after completing face authentication the
more & agree buttons would display instead of the done button.

1. Enter SUW
2. Complete face authentication flow
3. Go to next step (finishing the Biometric flow)
4. Press the back button
5. Observe that the text now says "Done"

Fixes: 205203673
Test: Verified button text is changed as expected during SUW.
Change-Id: I5cfad265f9b27669dcad64e5872750695b1b5bdc
2021-11-30 09:29:13 -08:00
Alex Johnston
2f193c8157 Add non system overlay flag to InstallCaCertificateWarning
Bug: 196969991
Test: Manual testing with Settings
Change-Id: Ia9dc251c853526b2ce66c9f8ff595d496b7f1bc4
2021-11-30 16:28:31 +00:00
Pavel Grafov
e8d755061d Merge "Check user validity before retrying authentication" 2021-11-30 14:48:00 +00:00
Pavel Grafov
3a48226af1 Merge "Launch ForgotPasswordActivity in a new task." 2021-11-30 14:47:22 +00:00
Bonian Chen
010306644b [Settings] Refactor Wifi Calling description text
Refactor the display of description text when no wifi calling options available.
Enhancement:
1. These text need to align the style with the summary part of the wifi
calling options.
2. These text need to be scrollable in order to see full description.
3. The link within text need to be clickable.

Bug: 204844012
Test: local
Change-Id: Ie89a5b65e75cdd61fab68c6e1bf7c40bfcc68b6b
2021-11-30 13:57:56 +00:00
Bonian Chen
8a892271da [Settings] Refactor Wifi Calling description text
Refactor the display of description text when no wifi calling options available.
Enhancement:
1. These text need to align the style with the summary part of the wifi
calling options.
2. These text need to be scrollable in order to see full description.
3. The link within text need to be clickable.

Bug: 204844012
Test: local
Change-Id: I60f339bf4adf50236d80176669a557c77f0d97ca
2021-11-30 13:55:55 +00:00
Bonian Chen
3dfad58897 [Settings] support of getPhoneNumber API
Access to new API for retrieving phone number.

Bug: 208321353
Test: local build pass
Change-Id: I8484f94934670f24c80c95df89e8752420c1f439
2021-11-30 11:04:38 +00:00
Zoey Chen
3581f65d85 Merge "[Settings] Should show carrier network if airplane mode is on" into sc-v2-dev am: 1df187a439 am: 4aef8765dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16332786

Change-Id: Ic4648dad4fd7950510fea2382fa990efe900baf8
2021-11-30 09:05:10 +00:00
Zoey Chen
4aef8765dc Merge "[Settings] Should show carrier network if airplane mode is on" into sc-v2-dev am: 1df187a439
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16332786

Change-Id: I1a63b9d82fd530af87c2c70ab21e24e599a967e2
2021-11-30 08:46:59 +00:00
Zoey Chen
1df187a439 Merge "[Settings] Should show carrier network if airplane mode is on" into sc-v2-dev 2021-11-30 08:33:50 +00:00
Joshua Mccloskey
b73201c6be Added sensorPrivacyDialog to face settings
Test: Verify flow presents dialog if the privacy setting is enabled.
Bug: 201045056
Change-Id: I96f14db457311d13f07c770ff0993581576c5dba
2021-11-29 23:09:16 -08:00
Zoey Chen
8b1ecea060 [Settings] Should show carrier network if airplane mode is on
https://hsv.googleplex.com/6007361661566976

Test: atest SubscriptionsPreferenceControllerTest
Bug: 206990845
Change-Id: Id39b662f33b201a8e4ce53c34c3007eca9a40edf
2021-11-30 12:10:28 +08:00
Joe Bolinger
54b4689e5a Merge "Remove face auth from setup wizard when configured as a convenience." into sc-v2-dev am: 076dc5ee1b am: 77556bcc51
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16325466

Change-Id: I9c84fbac19a764c012168110db04832a4bf58e92
2021-11-29 23:46:30 +00:00