Commit Graph

1790 Commits

Author SHA1 Message Date
Yuhan Yang
a8eecd48d9 Add observer to autoclick main switch controller
Add an observer in ToggleAutoclickMainSwitchPreferenceController
so when the autoclick is toggled on/off at somewhere else such as
autoclick shortcut, the main switch will change accordingly.

screen cast:
go/screencast-njawnjqynzi2ode1mzm0nhxmztqwmddjzc03oa

Bug: 391416057
Test: verified manually
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: I6e2a3af55cbd3f03b4feeb268b84510fc55518bf
2025-03-12 19:13:05 +00:00
Candice Lo
c8d9ab2c55 Merge "Add content descriptions for Display size and text previews" into main 2025-03-11 19:25:23 -07:00
Yuhan Yang
3fbdd379bf Merge "Initial commit to add autoclick main toggle" into main 2025-03-11 18:55:09 -07:00
Yuhan Yang
a572f89f43 Initial commit to add autoclick main toggle
screen cast: go/screencast-ntc4mdgxndq2mdyxnjcwnhw2yjbhymvlnc0wna

Bug: 391416057
Test: atest ToggleAutoclickMainSwitchPreferenceControllerTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: I6bfa346016d0ab08a61e4813b2c9e16b76281799
2025-03-11 15:49:20 +00:00
Menghan Li
173dceca7c Merge "refactor(A11yFeedback): Simply feedback logic into menu controller" into main 2025-03-11 00:49:19 -07:00
Menghan Li
a389ff59ab refactor(A11yFeedback): Simply feedback logic into menu controller
Bug: 393980229
Test: atest FeedbackMenuControllerTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: I03af00957c2bcca1d1cc81970eccad6dd69bb4ac
2025-03-11 02:43:32 +00:00
Jacky Wang
84f84ca8c0 [Catalyst] Use KeyValueStoreDelegate
NO_IFTTT=Catalyst only

Bug: 388167106
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: I3d04e1bf2620fe7f910fe63f22c17da290e9172d
2025-03-11 09:39:28 +08:00
Jacky Wang
6f684c73e0 [MainSwitchPreference] Remove SettingsMainSwitchPreferenceController
NO_IFTTT=Update base class

Bug: 401406987
Flag: EXEMPT refactor
Test: manual
Change-Id: I68093366f63fa5b4184aa7b3dde8bc2609f17dfb
2025-03-11 00:35:01 +08:00
Candice
7270567527 Add content descriptions for Display size and text previews
Bug: 395882764
Test: manually
Test: atest TextReadingPreviewControllerTest
Test: atest TextReadingPreviewPreferenceTest
Flag: EXEMPT bugfix
Change-Id: Ia8702c3d0bdbbfdd554c945000777fcee6714abe
2025-03-10 06:49:43 +00:00
Jacky Wang
0fb23e3a7e Merge "[Catalyst] Extract datastore for VibrationMainSwitchPreference" into main 2025-03-07 03:25:48 -08:00
Treehugger Robot
b9f1396ddc Merge "fix(hct): Hardcode the names of Outline text and HCT in our notif." into main 2025-03-07 01:55:12 -08:00
Jacky Wang
206d27d778 [Catalyst] Extract datastore for VibrationMainSwitchPreference
NO_IFTTT=Catalyst only

Bug: 368360218
Flag: EXEMPT refactor
Test: atest
Change-Id: I3c308b0ed1462a10ddd0daf55f30996a23e747d7
2025-03-07 16:53:26 +08:00
Riley Jones
b15a8557c0 Merge "Fix for next button contentdescription in TextReadingPreviewPreference" into main 2025-03-06 16:14:03 -08:00
Treehugger Robot
ccadee76e0 Merge "Use correct shortcut preference key on Magnification screen" into main 2025-03-06 12:47:54 -08:00
Daniel Norman
1a983ff386 fix(hct): Hardcode the names of Outline text and HCT in our notif.
This should help prevent localization issues caused by capitalization of
this templated string, since these feature names should not be
capitalized unless they are at the beginning of the sentence.

The 'Settings' app name should always be capitalized since it's the
proper name of an app, so that remains templated.

Bug: 399358129
Test: atest HighContrastTextMigrationReceiverTest;
      (this test asserts against a hardcoded version of the entire
       string)
Flag: com.android.graphics.hwui.flags.high_contrast_text_small_text_rect
Change-Id: Iaaa2ac10a56c1e4f7e5a8fd0d1c8eaf8b0293a27
2025-03-06 20:44:21 +00:00
Riley Jones
fd0c711002 Fix for next button contentdescription in TextReadingPreviewPreference
Test: Enable talkback and verify next button outputs a correct description
Bug: None
Flag: EXEMPT small cleanup change
Change-Id: Ib71e2a42b810b0ba5d92ec630f90ca7a32fbba46
2025-03-06 19:41:26 +00:00
Chun-Ku Lin
d16e449ae2 Use correct shortcut preference key on Magnification screen
Bug: 401279127
Test: manual
Flag: EXEMPT low risk bugfix
Change-Id: I26e7fcf82c5141ceb740b5d9561dd15c5a5829bd
2025-03-06 19:15:41 +00:00
Candice
7f70f5b633 Add a content description for the illustration if it is an animation
Since `isAnimatable` is decided in `onBindViewHolder`, we need to register
an onBindListener and update the content description if the current
illustration is an animation.
For the static images, we would like to skip them in Talkback since they
are decorative images.

Bug: 395882764
Test: manually. attach screenshot to the bug
Test: atest ToggleFeaturePreferenceFragmentTest
flag: EXEMPT. bugfix
Change-Id: I57bf96d0891ba553ef29d25ae9489f34b2a832e9
2025-03-06 06:53:48 +00:00
Yongshun Liu
e5e3803470 Merge "a11y: Add cursor following mode dialog" into main 2025-03-05 18:04:17 -08:00
Menghan Li
86fa16ba52 Merge changes from topics "A11yFeedback1P", "A11yFeedbackTopLevelPage", "AccessibilityPageIdFeatureProvider" into main
* changes:
  refactor(A11yFeedback): Rename AccessibilityMetricsFeatureProvider
  feat(A11yFeedback): Add feedback entry for downloaded Accessibility
  chore(A11yFeedback): Removing Legacy Android M Menu Behavior
  feat(A11yFeedback): Implements page ID to feedback bucket ID mapping
2025-03-05 00:06:01 -08:00
Menghan Li
b511fe690b refactor(A11yFeedback): Rename AccessibilityMetricsFeatureProvider
The AccessibilityMetricsFeatureProvider currently provides page IDs
derived from component names, primarily for metrics purposes.
However, its functionality should be expanded to also support
feedback needs, not just metrics collection, by returning
appropriate settings enum values.

Bug: 393980229
Test: atest AccessibilityMetricsFeatureProviderGoogleImplTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: I2d64db866010ae5e3c6a9738f92860df3d0b86aa
2025-03-05 05:25:05 +00:00
Menghan Li
9ffca7cbfc feat(A11yFeedback): Add feedback entry for downloaded Accessibility
This entry point allows users to access in the action bar.
Visibility is controlled by the aconfig and FeedbackManager#isAvailable

Bug: 393980229
Test: Manual testing on Pixel and non-Pixel devices
Test: atest ToggleFeaturePreferenceFragmentTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: Ie6dfb6a887fe5a894622e86bab39878f8adea758
2025-03-05 05:24:38 +00:00
Menghan Li
bcddc529ba chore(A11yFeedback): Removing Legacy Android M Menu Behavior
Removed legacy code that suppressed search and help menus for
accessibility features. This workaround was implemented in Android M
(ag/10438579) and is no longer needed.

Bug: 393980229
Test: Manual testing on Pixel and non-Pixel devices
Flag: EXEMPT cleanup
Change-Id: Ide4978bb5d2fdacad48399fb8525c6a0dfcd4277
2025-03-05 05:23:50 +00:00
Menghan Li
c26eb7fd24 feat(A11yFeedback): Implements page ID to feedback bucket ID mapping
This change adds a new API to a Pixel overlay feature provider,
allowing Android to map page IDs to feedback bucket IDs.

Bug: 393980229
Test: Manual testing for Pixel and non-Pixel overlay in real device
Test: atest AccessibilitySettingsTest
            FeedbackManagerTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: I8a110b08816cac9c8a8e8c3e1218530fffb6f121
2025-03-05 05:23:00 +00:00
Yongshun Liu
20d1a7d1b6 a11y: Add cursor following mode dialog
This a pure UI change that adds a new magnification cursor following
mode dialog behind a flag. The framework support will be added
separately later.

There are 3 modes as the following:
  - continuous mode
  - center mode
  - edge mode

It also renames magnification mode dialog xml file for general purpose
within accessibility.

NO_IFTTT=linter not working

Bug: b/388335935
Flag: com.android.settings.accessibility.enable_magnification_cursor_following_dialog
Test: SettingsRoboTests:com.android.settings.accessibility.ToggleScreenMagnificationPreferenceFragmentTest &&
      SettingsRoboTests:com.android.settings.accessibility.MagnificationModePreferenceControllerTest &&
      SettingsRoboTests:com.android.settings.accessibility.MagnificationCursorFollowingModePreferenceControllerTest
Change-Id: If2672186faf7443cc210d79630b1ea4f3808d7e4
2025-03-04 23:47:56 +00:00
Casey Burkhardt
046b5038b9 Ensure accessibility shortcut preference summaries are not focusable
In this case, keyboard focusability causes TalkBack to exclude summary
text from the grouped content surfaced when focusing the top-level list
item.

Bug: 400538324
Test: Manually with TalkBack, including ClickableSpan in summaries
Flag: EXEMPT bug fix
Change-Id: Ib8bc3276aee857121381de7bc4e23e05cd512383
2025-03-03 20:26:05 -08:00
Jacky Wang
531fe9df34 Use OnPreferenceChangeListener for VibrationMainSwitchPreference
NO_IFTTT=Catalyst only

Bug: 400335057
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: Id517a7246ba797fd6bcd9baeb6169acf913bcf7f
2025-03-03 20:21:52 +08:00
Treehugger Robot
11b78c6fef Merge "[Mag] Keyboard shortcut info shown when physical keyboard present" into main 2025-02-28 18:09:04 -08:00
Treehugger Robot
d13dc6a1b7 Merge "fix(SUW): Update A11y Settings pages to use new expressive style" into main 2025-02-28 16:26:49 -08:00
Katie Dektar
e94d88c74e [Mag] Keyboard shortcut info shown when physical keyboard present
Shows keyboard shortcut info in magnification settings when a
physical keyboard is present. See bug for screenshots.

Hides touchscreen info in magnification settings when a touchscreen
is not present.

Adds ShadowInputDevice support for physical full keyboards.

Bug: b/388847050
Test: Manual, atest ToggleScreenMagnificationPreferenceFragmentTest
Flag: com.android.server.accessibility.enable_magnification_keyboard_control
Change-Id: Ib53fbd8f929d1cc8e294f6f04bab405c9bb576a9
2025-02-27 23:00:12 +00:00
Yuhan Yang
01d938228a Merge "Add revert to left click to autoclick settings page" into main 2025-02-27 12:24:48 -08:00
Daniel Norman
91538bb9ac fix(SUW): Update A11y Settings pages to use new expressive style
Bug: 346560989
Test: Keep flags disabled; observe no visual change
Test: Flip Setup and Settings flags; observe visual changes
      See bug for screenshots
Flag: EXEMPT using non-standard flagging from ThemeHelper
Change-Id: Ie81594dd113af38a03f4215e8bb5c928bcfb1ef5
2025-02-27 20:23:53 +00:00
Riley Jones
e8a5eae1dd Merge "Left & right buttons for display size & text preview" into main 2025-02-27 11:13:55 -08:00
Yuhan Yang
d96bcf8f85 Add revert to left click to autoclick settings page
Screenshot: go/screenshot-4sdpfqk5rf3u23l
UI mock: go/screenshot-vcu7ui2ar9bjrm6

Bug: 388845719
Test: ToggleAutoclickRevertToLeftClickControllerTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: I813613f3d920ce6795e6750c440449e78d9b9c37
2025-02-27 17:32:41 +00:00
Angela Wang
03faf6b111 Merge "Filter out non-discoverable scan result in hearing device pairing page" into main 2025-02-26 17:11:05 -08:00
Treehugger Robot
de81197c74 Merge "Migrate SeekBarPreference to SliderPreference for haptics" into main 2025-02-26 13:01:19 -08:00
Angela Wang
5097cbe1ca Filter out non-discoverable scan result in hearing device pairing page
Flag: EXEMPT bugfix
Bug: 381027984
Test: atest HearingDevicePairingFragmentTest
Test: check with real device
Change-Id: I7ab70d5508d71472cbd2d0959bb749599d039058
2025-02-26 03:17:36 +00:00
Riley Jones
998929d688 Left & right buttons for display size & text preview
Test: manually open page and verify buttons work. Make sure to check the buttons during setup wizard.
Bug: 386906497
Flag: EXEMPT xml-dependent change
Change-Id: I488d74591d698ad918fd864cf39b2f3133abd463
2025-02-25 20:21:29 +00:00
Ebru Kurnaz
35e725d4eb Merge "Call DisplayDensityUtils from ExternalDisplay settings to adjust display size" into main 2025-02-25 04:55:58 -08:00
Ebru Kurnaz
8054a152b9 Call DisplayDensityUtils from ExternalDisplay settings to adjust display size
Flag: com.android.settings.flags.display_size_connected_display_setting
Test: atest ExternalDisplayPreferenceFragmentTest
Bug: 392853666
Change-Id: Iaa97f461e80a4e749ec3d2b47985a6be4a81a95b
2025-02-25 11:10:19 +00:00
Jack Yu
0b2effb371 Merge "Cleaned up the flag enforce_telephony_feature_mapping_for_public_apis" into main 2025-02-24 17:45:03 -08:00
Yuhan Yang
664df0f4cc Update autoclick shortcut searchable
Add autoclick shortcut to search index when
enable_autoclick_indicator flag is enabled.
Hide it when the flag is off.

Bug: 397719419
Test: atest ToggleAutoclickPreferenceFragmentTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: Ib6d25067d024ff0dbea64d17d38fc544c615db97
2025-02-21 22:36:53 +00:00
Yuhan Yang
4d52d72337 Only create shortcut preference when no existing shortcut found
Update onCreateView in AccessibilityShortcutPreferenceFragmen
so it only create a new shortcutPreference when no existing
shortcut preference is found.

Bug: 397719419
Test: Manually verified on test devices
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: Ic4747240cfd3d48fd97c61fd0b15d44f6ba5cf0a
2025-02-21 22:36:53 +00:00
Yuhan Yang
7c467be118 Merge "Add autoclick shortcut to a11y autoclick settings" into main 2025-02-21 11:15:54 -08:00
Daniel Norman
165f4ea76e feat(expressive): Add new magnification banner for expressive design
Fix: 378876803
Flag: EXEMPT custom flagging helpers from Settings and Setup
Test: observe new image; see bug screenshots
Change-Id: I3654563352e223af1a0d679318da45da2b4bc8be
2025-02-20 16:00:04 -08:00
Treehugger Robot
69c4f2dff0 Merge "Make ColorAndMotionFragment fully in Catalyst" into main 2025-02-20 12:39:07 -08:00
Riley Jones
e6b7908366 Merge "Revert "Left & Right buttons for Display size & text preview"" into main 2025-02-20 12:38:24 -08:00
Daniel Norman
b1691756e2 Revert "Left & Right buttons for Display size & text preview"
This reverts commit 30e63f6178.

Reason for revert: Can cause crash for some users?

Change-Id: I4b4e71157b668bbf4320a610ad14ddd10f2eade3
2025-02-20 11:26:35 -08:00
Yuhan Yang
0516a06a02 Add autoclick shortcut to a11y autoclick settings
Add a shortcut row that toggles floating icon and pops edit
shortcut type dialog.

Screencast:
 - autoclick indicator flag on:
   go/njiwntmwmjuwnzu2ote1mnw2m2nhmzflzi0znq
 - autoclick indicator flag off:
   go/screenshot-anpqrzv6ewplyjs

Bug: 397719419
Test: Manually verified on test devices
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: I5f0b51adfaea5c3f8b077af07f34f61d78cb34ac
2025-02-20 18:19:23 +00:00
Yongshun Liu
67c5db13ff Merge "a11y: Clean up magnification mode controller and fix lint errors" into main 2025-02-18 17:28:49 -08:00