Commit Graph

494 Commits

Author SHA1 Message Date
Michal Brzezinski
38dd287e01 Launching touchpad tutorial as user 0
It's required to properly intercept touchpad gestures which is happening
in process of user 0. By default activity was launched in the current
user process.
Also targeting sysui package directly with intent.

Bug: 361518125
Test: launch touchpad tutorial with HSUM and see touchpad gestures intercepted
Flag: com.android.systemui.shared.new_touchpad_gestures_tutorial
Change-Id: I904df93758e49a7b10cf6d7a5398550405daafbb
2024-08-22 15:41:39 +00:00
Vaibhav Devmurari
1c7bed6c11 Fix: User main user for personal profile
Bug: 356879517
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ia75ad08f5c2e585ab20478e045c8165dc42c3da8
2024-08-12 12:05:37 +00:00
Pat Manning
2649a7bf56 Merge "Log metrics for pointer icon settings changes." into main 2024-07-24 15:05:57 +00:00
Pat Manning
15ed707dbc Log metrics for pointer icon settings changes.
Bug: 269100659
Test: PointerFillStylePreferenceControllerTest
Test: PointerStrokeStylePreferenceControllerTest
Test: PointerScaleSeekBarControllerTest
Flag: android.view.flags.enable_vector_cursor_a11y_settings
Change-Id: I5966abff27122269e59f20e63bd708b9739f4875
2024-07-19 14:58:16 +00:00
Asmita Poddar
78b485a3bb Add Mouse keys A11Y settings to PK settings page
Add the mouse keys toggle in the Settings under
System > Keybord > Physical Keyboard > Mouse Keys.
The toggle is shown when a physical keyboard is connected.

DD: go/mouse-keys-android
Bug: 341799888
Flag: com.android.hardware.input.keyboard_a11y_mouse_keys
Test: manual
Steps:
1. Connect a physical keyboard
2. Toggle the mouse keys setting to switch on the feature.
3. Mouse keys is enabled.
4. Switch off the mouse keys toggle under the setting.
5. Mouse keys is disabled.

Change-Id: Ifda8c93fcc1f8b7c1fb2eccb7c91266360ff1fc8
2024-07-16 11:45:24 +00:00
Pat Manning
c8c8c53760 Merge "Update Touchpad settings page to include mouse." into main 2024-07-15 10:52:10 +00:00
Treehugger Robot
33549c6dc7 Merge "Add Settings for vector-specific PointerIcon stroke colors." into main 2024-07-12 02:04:21 +00:00
Pat Manning
620755c293 Add Settings for vector-specific PointerIcon stroke colors.
Bug: 305193969
Test: PointerIconLoadingTest
Flag: android.view.flags.enable_vector_cursor_a11y_settings
Change-Id: I72213e8806fed451a0edb16d497406ffae5c1a44
2024-07-11 15:40:03 +00:00
Pat Manning
1257610b0e Update Touchpad settings page to include mouse.
Make each setting conditionally available based on touchpad or mouse
connected to device.

Bug: 269100659
Test: TrackpadBottomPreferenceControllerTest
Test: TrackpadReverseScrollingPreferenceControllerTest
Test: TrackpadTapToClickPreferenceControllerTest
Test: TrackpadSettingsControllerTest
Flag: android.view.flags.enable_vector_cursor_a11y_settings
Change-Id: I601c29e20d69227779481c0a491256e36cfd268f
2024-07-11 13:32:44 +00:00
shaoweishen
60eae5e01c [Touchpad Setting] Hide Touchpad page when there's no connected one
The option for entering page already has complete check condition.
Update the same check logic to isSeachable in setting page to hide
page when there's no touchpad connected.
Also apply check on trackpadTouchGesture.

Test: verify on device
Bug: 346497646
Flag: EXEMPT bugfix
Change-Id: I1730c7bd1fd2615dc1725ec0cc32293254e5b54a
2024-07-05 08:18:48 +00:00
Fan Wu
ec5df5cd1e Remove Use on-screen keyboard preference from Physical Keyboard page
Bug: 304460009
Flag: EXEMPT removing preference from xml
Test: on device
Change-Id: Ibb0517c5ffa4addb52f1b0469f30c5126bd5828a
2024-07-03 06:29:54 +00:00
Yalan Yiue
c291f22722 Merge "Launch oobe from Settings" into main 2024-07-02 17:22:14 +00:00
yyalan
dc9701f427 Launch oobe from Settings
Bug: 344860480
Flag: com.android.systemui.shared.new_touchpad_gestures_tutorial
Test: Manual
Change-Id: Iabc155d2f99717c6489308ffb1e63ef4e59f0332
2024-07-01 15:35:55 +00:00
Pat Manning
d303afbbd7 Add Settings for vector-specific PointerIcon scale.
Bug: 305193969
Test: PointerScaleSeekBarControllerTest
Flag: com.android.systemui.enable_vector_cursor_a11y_settings
Change-Id: I2f344f1d5fc6d5c8eb7159570287b8ce6f9ac070
2024-06-25 13:55:59 +00:00
Treehugger Robot
87334e9c38 Merge "Add Settings for vector-specific PointerIcon fill colors." into main 2024-06-07 16:31:59 +00:00
Pat Manning
577965f9c2 Add Settings for vector-specific PointerIcon fill colors.
Bug: 305193969
Test: PointerIconLoadingTest
Flag: com.android.systemui.enable_vector_cursor_a11y_settings
Change-Id: I84b4a6d5fde48309c2e3374963f92b8246167628
2024-06-06 14:41:00 +00:00
shaoweishen
0dc2d69d85 [Physical Keyboard Setting] Update navigation path
When launch setting page for specific keyboard, it will route to PK
setting first, add flag NO_HISTORY to make PK setting not been added in
stack.
So that when user navigate back, it will not back to PK setting,
which will be more consistent.

Update navigation path from:
Device Detail -> Physical Keyboard Setting -> Keyboard Detail Setting
to
Device Detail -> Keyboard Detail Setting

Bug: 330130137
Flag: N/A
Test: verify on device
Change-Id: I8d6d6a8a534dec5cd7330c4d47b38a46be76fc4d
2024-06-03 03:54:53 +00:00
shaoweishen
90e70b15d7 [Physical Keyboard] Clean up old ui and flag
Change-Id: I9423d0e9debcef37338e5733aab56b98920621e3

Test: n/a
Bug: 330517633
Change-Id: I485848f67e0eb3ab207413a6ed8f7de809f80c5c
2024-04-16 05:21:30 +00:00
Jason Chiu
a18f9e5014 [Safer intents] Input method
To avoid implicit intents, make intents launch explicitly.

Test: build
Bug: 323061508
Change-Id: I8d9e8e2b70c3ef913087b72800cd40e0c3df8164
2024-03-28 02:44:09 +00:00
Treehugger Robot
b9895a2438 Merge "Touchpad: add metric for tap dragging setting changes" into main 2024-03-11 16:00:28 +00:00
Harry Cutts
f8ffe79669 Touchpad: add metric for tap dragging setting changes
Bug: 321978150
Bug: 324058706
Test: $ m statsd_testdrive
      $ ./out/host/linux-x86/bin/statsd_testdrive -e 97
      Then toggle the setting, press Enter in the terminal, and check
      the new actions are logged
Change-Id: I55b7cc3377e7b27e9570f3f1b79c1f300d5d5686
2024-03-05 16:59:33 +00:00
Harry Cutts
175a901f2c Merge "Touchpad: add Framework Input team as owners" into main am: a3a04112fd am: 3c1a5bb3c0
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2982053

Change-Id: Ifae971d2fd89374e8e0c1d3a147c6390a85dee46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-05 12:45:49 +00:00
Harry Cutts
3c1a5bb3c0 Merge "Touchpad: add Framework Input team as owners" into main am: a3a04112fd
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2982053

Change-Id: Idf76ff1bf592de800d224052910927285c47c42e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-05 12:05:02 +00:00
Harry Cutts
01bd498503 Merge changes I0c0a76c7,Iccfbe842 into main
* changes:
  Touchpad: remove icons
  Touchpad: add tap dragging setting
2024-03-05 11:39:22 +00:00
Vaibhav Devmurari
d3dbe6ce23 Merge "Modify PK Settings page to make it more user friendly" into main 2024-03-05 10:53:48 +00:00
Vaibhav Devmurari
8754f114ac Modify PK Settings page to make it more user friendly
PK Settings page:
    - Show current PK layout selected for the current user profile and current IME language instead of a list of IMEs

PK layout mapping page:
    - Show IME name in header only if multiple active IMEs
    - Show the PK layout selection criteria (Automatic v/s User selected)

Bug: 325925410
Bug: 326195401
Test: manual
Change-Id: I93a2e169742a800fa116fa5d55e1a91e5548cebb
2024-03-04 10:55:47 +00:00
Shaowei Shen
624e1beca8 Merge "[A11y Setting] Add keyboard keys preferences under A11y page" into main 2024-03-01 13:37:03 +00:00
shaoweishen
a5f5ff4add [A11y Setting] Add keyboard keys preferences under A11y page
Bug: 325851068
Test: make RunSettingsRoboTests
Change-Id: Ic7eb1ec9e260a95d040bee784cbff479a4f087d0
2024-03-01 12:05:30 +00:00
shaoweishen
6c02c6ab25 [Physical Keyboard Setting] Update layout for one pane land screen
If device is one pane and is land orientation, set new layout for it to
match with UX markup, this change will not effect on tablet, which is
two pane setting.

Bug: 325878673
Test: verify on device
Screenshot: https://screenshot.googleplex.com/BkETMhqp9GXM3cc.png
Change-Id: I066c3d782a2de8993a3fe9632676b67c2203d638
2024-02-29 07:31:21 +00:00
Harry Cutts
cf1a34ab93 Touchpad: add tap dragging setting
Screenshot: go/ag-26012379-screenshot

Bug: 321978150
Bug: 324058706
Test: with the flag disabled, check the new entry doesn't appear
Test: with the flag enabled, toggle the setting and check that it
    enables and disables tap dragging (tapping then immediately putting
    your finger back on the touchpad and moving it)
Test: with the flag enabled, check the setting appears in search results
Test: atest SettingsRoboTests:com.android.settings.inputmethod
Change-Id: Iccfbe842ff655ea295edc764cfc400709948df7d
2024-02-28 14:40:35 +00:00
Harry Cutts
3715b07684 Touchpad: add Framework Input team as owners
Also replace references to
frameworks/base:/services/core/java/com/android/server/input/OWNERS with
ones directly to frameworks/base:/INPUT_OWNERS.

Bug: 324058706
Test: none
Change-Id: Ib8943ca749887da7d5eebae908516e86310f2077
2024-02-28 14:37:10 +00:00
Ben Murdoch
59a3ed3f38 Add settings search synonyms for touchpad.
Also fixes a bug in TrackpadTouchGestureSettings that used the wrong
preference ID for search indexing.

Bug: 300611520
Test: Verified on device
Flag: NA
Change-Id: I62ccf6d0b410be977f59f101edc5c42233d9474a
2024-02-21 11:38:45 +00:00
Vaibhav Devmurari
bd26b3a43e Add Slow keys A11Y settings to PK settings page
Test: manual
Bug: 294546335
Change-Id: I9e20973e648d04b907e4d2225bd49b78e42d2089
2024-01-22 21:52:48 +00:00
shaoweishen
ff74d9db0b [Physical Keyboard Setting] Add log and null check
update getParcelable api usage, add null check and logging.

Bug: 317416208
Test: Verified on device
Change-Id: I125a6c9cdb5c86be7582ad5102257efb1fa6a1a4
2024-01-11 03:48:07 +00:00
Sunny Shao
bee65b4109 Merge "Revert^2 "Nullability Annotations replacement"" into main 2024-01-10 08:35:06 +00:00
Sunny Shao
076ed573eb Revert^2 "Nullability Annotations replacement"
This reverts commit 19d1d3d15d.

Reason for revert: revert it because this is not the root cause.

bug: 316867690
Change-Id: I0f168dbb64044aa720202af7b1040afd4f028c9c
2024-01-10 07:34:01 +00:00
Vaibhav Devmurari
da30b549be Merge "Add A11Y settings for Bounce keys and Sticky keys" into main 2024-01-02 13:05:59 +00:00
Sunny Shao
19d1d3d15d Revert "Nullability Annotations replacement"
This reverts commit cf0501e4d7.

Reason for revert: b/317462033, it seems a flaky but revert it first.

Change-Id: Ie1d5e279cca6477fc17d8c27c1ecda8d7a6b2553
2023-12-29 02:28:24 +00:00
Vaibhav Devmurari
315f2546fc Add A11Y settings for Bounce keys and Sticky keys
Test: manual
Bug: 294546335
Change-Id: I943300c31d0c8e142f64f084f4c65e05249a72ec
2023-12-28 21:02:11 +00:00
sunnyshao
cf0501e4d7 Nullability Annotations replacement
-- Replace the android.annotation.Nullable / android.annotation.NonNull
   with androidx.annotation.Nullable / androidx.annotation.NonNull

Bug: 316867690
Test: build pass
Change-Id: I0c1da55dfb09ece855151c47e0492d6f46538621
2023-12-20 08:50:09 +08:00
shaoweishen
5446813ac5 [PK Setting] Refine layout for Keyboard review
1. add background for keyboard review
2. add text for showing selected keyboard's name

Test: Verified on device
Bug: 305588594
Change-Id: Icf0f2b7798cc5cbddefc1b3a95480b48271b276f
2023-12-19 09:41:17 +00:00
shaoweishen
c08aad0ab4 [PK Setting] add keyboard review under keyboard selection page
Demo video as attached in bug.
Add new image view for keyboard layout review.
Reuse NewKeyboardLayoutPickerController under
NewKeyboardLayoutPickerFragment when get update for keyboard layout, get
preview image from inputManager and set to the view.

This feature will be guided with keyboard_layout_preview_flag, if the
flag is off, preview image from InputManager will be null.

Bug: 305588594
Test: Verified on device
Change-Id: Ic6f8e469d3cf7114dab6935304706ad42bf83608
2023-12-14 06:44:07 +00:00
Josep del Río
1dde9a3aeb Merge "Sort keyboard layouts" into main 2023-12-05 12:53:20 +00:00
Josep del Rio
cdc4fb5559 Sort keyboard layouts
At the moment it's not easy to find a layout in the physical
keyboard layout list as they are not sorted; this CL will sort the
keyboard layout list before it is  presented to the user.

Bug: 279281653
Test: Flashed on device, confirmed the layout list is sorted
Change-Id: Ibc7e329190785cce9a8d9c33bc2fcaca6b8c169a
2023-12-05 11:16:04 +00:00
Shaowei Shen
9f03501179 Merge "[PK Setting] update searchable if page is not visible" into main 2023-11-30 07:17:47 +00:00
shaoweishen
365f55efc5 [PK Setting] update searchable if page is not visible
if PK setting is not available, also make it not searchable.

Test: verified on device
Bug: 301881819
Change-Id: I6e71634ce5ddc6d5db3d31f5614fef7ccabc6d3d
2023-11-29 09:02:08 +00:00
Edgar Wang
40cc58f5a1 Merge "Update SpellCheckerPreference layout to support divider" into main 2023-11-23 07:50:41 +00:00
Edgar Wang
523d39266c Update SpellCheckerPreference layout to support divider
Bug: 246499664
Test: robotest and visual
Change-Id: I96908f4b566820b20a57e0161d74dfed2c566ea5
2023-11-22 14:59:17 +08:00
shaoweishen
543a7589b1 [PK Setting] Add null check on NewKeyboardSettingUtils.getInputDevice()
return null if InputDeviceIdentifier is null in getInputDevice.

Test: n/a
Bug: 307109888
Change-Id: Ie2f951d97e0ff66833d74170e625fb0368d6de42
2023-11-22 05:02:49 +00:00
Treehugger Robot
ccf02dcb11 Merge "Fix crash when clicking Spell Checker" into main am: e4f376f7ef am: 8a2a127435 am: 1e4c05ef7c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2828056

Change-Id: I4b6a924d4672cf4b101606a499c5f4f5143159d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-21 04:54:24 +00:00