Commit Graph

41682 Commits

Author SHA1 Message Date
Jeff Sharkey
019f31b499 DO NOT MERGE. ActivityPicker shouldn't grant permissions.
This picker has no business granting any Uri permissions, so remove
any grant flags that malicious apps may have tried sneaking in.

Test: builds, boots
Bug: 32879772
Change-Id: I91c48c73287a271bd6c99e60e216dead22e68764
(cherry picked from commit 3f218e8431)
2017-10-03 20:31:34 +00:00
Jeff Sharkey
f32a4fad5d DO NOT MERGE. ActivityPicker shouldn't grant permissions.
This picker has no business granting any Uri permissions, so remove
any grant flags that malicious apps may have tried sneaking in.

Test: builds, boots
Bug: 32879772
Change-Id: I91c48c73287a271bd6c99e60e216dead22e68764
(cherry picked from commit 3f218e8431)
2017-10-03 20:31:23 +00:00
Jeff Sharkey
1cdc675d7d DO NOT MERGE. ActivityPicker shouldn't grant permissions.
This picker has no business granting any Uri permissions, so remove
any grant flags that malicious apps may have tried sneaking in.

Test: builds, boots
Bug: 32879772
Change-Id: I91c48c73287a271bd6c99e60e216dead22e68764
(cherry picked from commit 3f218e8431)
2017-10-03 20:30:43 +00:00
Jeff Sharkey
8441943bfa DO NOT MERGE. ActivityPicker shouldn't grant permissions.
This picker has no business granting any Uri permissions, so remove
any grant flags that malicious apps may have tried sneaking in.

Test: builds, boots
Bug: 32879772
Change-Id: I91c48c73287a271bd6c99e60e216dead22e68764
(cherry picked from commit 3f218e8431)
2017-10-03 20:30:31 +00:00
Jeff Sharkey
b5e93969a5 DO NOT MERGE. ActivityPicker shouldn't grant permissions.
This picker has no business granting any Uri permissions, so remove
any grant flags that malicious apps may have tried sneaking in.

Test: builds, boots
Bug: 32879772
Change-Id: I91c48c73287a271bd6c99e60e216dead22e68764
(cherry picked from commit 3f218e8431)
2017-10-03 20:30:15 +00:00
TreeHugger Robot
a8ecc3907e Merge "Make WifiTracker lifecycle aware" 2017-10-03 20:21:46 +00:00
jeffreyhuang
464da0b267 Introduce FileEncryptionPreferenceController
- Create new FileEncryptionPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I19f68fa719442bad03fee7ab3939510095257dee
2017-10-03 13:19:13 -07:00
Salvador Martinez
bb4ef4d1b6 Update support to not need dialog fragment
This CL update support to not need the dialog fragment.

Test: robotests
Bug: 65552746
Change-Id: Ic4a21f05f04384795f4e616c2d6d914fc7dd3510
2017-10-03 12:28:43 -07:00
jeffreyhuang
c97c9d4615 Introduce LocalBackupPasswordPreferenceController
- Create new LocalBackupPasswordPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I86d0d2402e8092e9f03498254ae4e3bf7bb9bf3d
2017-10-03 11:55:04 -07:00
Soroosh Mariooryad
d644a835ae Merge "Fix ANR issue caused by sharedpref commit() on suggestion event logging" into oc-mr1-dev am: 0193e69597
am: 73679c124f

Change-Id: I25949dd1c2bdf31ec07cd3b963ac6b693cf3a0e4
2017-10-03 18:38:27 +00:00
Soroosh Mariooryad
73679c124f Merge "Fix ANR issue caused by sharedpref commit() on suggestion event logging" into oc-mr1-dev
am: 0193e69597

Change-Id: I5c65bd4965fa66150b3537e7654834630340ed5f
2017-10-03 18:36:05 +00:00
TreeHugger Robot
0193e69597 Merge "Fix ANR issue caused by sharedpref commit() on suggestion event logging" into oc-mr1-dev 2017-10-03 18:31:56 +00:00
Fan Zhang
e7337b3ec7 Bind icon and remote views for Suggestion
Bug: 65065268
Test: robotests
Change-Id: I181a9e092c56f4e45addfc1cde166fb7dac7becd
2017-10-03 11:18:12 -07:00
jeffreyhuang
aa4bf8c266 Introduce WebViewAppPreferenceControllerV2
- Create new WebViewAppPreferenceControllerV2
 - Deprecate WebViewAppPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I45bb7beb98ef9c7a998f64e81d180613c795ed3a
2017-10-03 10:41:58 -07:00
Jeffrey Huang
aded3c3bce Merge "Introduce ClearAdbKeysPreferenceController" 2017-10-03 16:48:56 +00:00
Jeffrey Huang
ecf5b81163 Merge "Introduce ResizableActivityPreferenceController" 2017-10-03 16:48:20 +00:00
Jeffrey Huang
0ad753b33a Merge "Introduce NotificationChannelWarningsPrefCtrl" 2017-10-03 16:47:48 +00:00
Svet Ganov
e53d1caedc Use new no overlay flag instead app ops
Test: updated DrawOverlayDetailsTest passes

bug:66936547

Change-Id: I7c17c95a2b44fd2ffd593a6eb03a16be034e9192
2017-10-02 21:00:43 -07:00
Kevin Chyn
9c8739c8e1 Fix logic error / possible NPE in AuthenticationSidecar
Fixes: 67329646

Test: manual
Change-Id: Ifec339dbc9112c0a1e1ad6595deaab4ec328d365
2017-10-02 19:03:07 -07:00
TreeHugger Robot
13b500297d Merge "Return false if can't find package info" 2017-10-03 00:30:35 +00:00
jeffreyhuang
97dbff233d Introduce ClearAdbKeysPreferenceController
- Create new ClearAdbKeysPreferenceController
 - Added ClearAdbKeysWarningDialog
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ia12bfee753f2c9222e6d833b1fb7e099f3602fdf
2017-10-02 17:22:43 -07:00
Jeffrey Huang
78922b8a75 Merge "Introduce BugReportInPowerPreferenceControllerV2" 2017-10-02 22:59:04 +00:00
Fan Zhang
883d8e7ed1 Return false if can't find package info
Change-Id: Iaf667e0977f60abcbf3eb76c46c46f591c00123e
Fixes: 66981347
Test: robotests
2017-10-02 15:38:07 -07:00
Eric Schwarzenbach
c069669ddf Fix "Add Network" button on SavedAccessPoints page.
The old onSubmit was a no-op. It now correctly pipes onSubmit to
WifiManager#save() with the new WifiConfiguration. On successful save,
it displays the new network in the list, and on failure, it displays a
toast indicating that the save action failed. Adds a test for the
WifiDialog behaviors on this page.

Bug: 66177765
Test: make RunSettingsRoboTests, manual - tested with Wifi enabled and
disabled, and with networks that were visible and not.
Change-Id: I27446aa49bc9efaf1ea1d6c6158928b62ce01ba2
Merged-In: I27446aa49bc9efaf1ea1d6c6158928b62ce01ba2
2017-10-02 15:05:59 -07:00
Eric Schwarzenbach
ac8a3f24c4 Merge "Fix "Add Network" button on SavedAccessPoints page." 2017-10-02 21:57:21 +00:00
TreeHugger Robot
fad7215cd1 Merge "Make robotest less flaky" 2017-10-02 21:46:35 +00:00
jeffreyhuang
a19a24930b Introduce ResizableActivityPreferenceController
- Create new ResizableActivityPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I401db1fe3a051ee70ab9afe2bf8c377b3b0b4e2f
2017-10-02 14:10:30 -07:00
jeffreyhuang
421fee270f Introduce NotificationChannelWarningsPrefCtrl
- Create new NotificationChannelWarningsPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I232b24ee0505eae254bd1d43b7d91ab8860285e2
2017-10-02 14:08:51 -07:00
Jeffrey Huang
498e883d52 Merge "Introduce VerifyAppsOverUsbPreferenceControllerV2" 2017-10-02 20:54:53 +00:00
Jeffrey Huang
f1c3e8f479 Merge "Introduce AllowAppsOnExternalPreferenceController" 2017-10-02 20:53:52 +00:00
Fan Zhang
feaa82ce8f Make robotest less flaky
Change-Id: Ic9ed1ccbb7b7f802b6a5cf915aeb96c799007a7d
Fixes: 67307841
Test: rerun robotest
2017-10-02 13:10:08 -07:00
Bill Yi
301cfcda4c Import translations. DO NOT MERGE am: 6fe50e7224 -s ours
am: 2032410de4  -s ours

Change-Id: Idba6ac65fea909285d64e6fe2f883d3e80e6b8c2
2017-10-02 19:22:06 +00:00
jeffreyhuang
abda723cc2 Introduce BugReportInPowerPreferenceControllerV2
- Create new BugReportInPowerPreferenceControllerV2
 - Deprecate BugReportInPowerPreferenceController
 - Create controller inside the DashboardFragment
 - Copy logic from BugReportInPowerPreferenceController with
 slight modifications for dashboard fragment compatibility

Bug: 34203528
Test: make RunSettingsRoboTests -j40# Please enter the commit message for your changes. Lines starting
Change-Id: I8ec0c84fa9c4e59aca48586cc081822d78d8c0d5
2017-10-02 12:21:14 -07:00
Bill Yi
2032410de4 Import translations. DO NOT MERGE
am: 6fe50e7224  -s ours

Change-Id: I2ac5d233d10ca35a6d8ed24b29f8eb05fe4bba9c
2017-10-02 19:09:02 +00:00
Carsten Hauge
2ba36fa491 Merge "Avoid NullPointerException when updating preference intents" am: c4b0fa5858 am: f38ed428dc am: 5d2919907b
am: 143b31959b

Change-Id: I9f2b3769658200c332a38a943f2bc1331bdae3f9
2017-10-02 18:53:32 +00:00
Jeffrey Huang
8fac8cf868 Merge "Introduce AppsNotRespondingPreferenceController" 2017-10-02 18:16:51 +00:00
Jeffrey Huang
d4ef5fc94e Merge "Introduce KeepActivitiesPreferenceController" 2017-10-02 18:16:25 +00:00
Jeffrey Huang
dd75dead9e Merge "Introduce UsbAudioRoutingPreferenceController" 2017-10-02 18:16:14 +00:00
Jeffrey Huang
748c5d6cc0 Merge "Introduce HardwareOverlaysPreferenceController" 2017-10-02 18:16:03 +00:00
Jeffrey Huang
34e3535da5 Merge "Introduce GpuViewUpdatesPreferenceController" 2017-10-02 18:15:47 +00:00
Jeffrey Huang
9e9025acde Merge "Introduce ShowLayoutBoundsPreferenceController" 2017-10-02 18:15:34 +00:00
Carsten Hauge
143b31959b Merge "Avoid NullPointerException when updating preference intents" am: c4b0fa5858 am: f38ed428dc
am: 5d2919907b

Change-Id: I542ba13fe05f1027e0199c2a57ade93c6dd0bccb
2017-10-02 18:10:49 +00:00
Carsten Hauge
5d2919907b Merge "Avoid NullPointerException when updating preference intents" am: c4b0fa5858
am: f38ed428dc

Change-Id: I3fcc041677b4d739952902076184a8fa1dd73dad
2017-10-02 18:06:32 +00:00
Carsten Hauge
f38ed428dc Merge "Avoid NullPointerException when updating preference intents"
am: c4b0fa5858

Change-Id: I403d380ebfbbb0c70fdf5b6c9ff51267a5163e6f
2017-10-02 18:03:40 +00:00
Treehugger Robot
c4b0fa5858 Merge "Avoid NullPointerException when updating preference intents" 2017-10-02 17:56:02 +00:00
Bill Yi
6fe50e7224 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import

Bug: 64712476
Change-Id: Ib580d3bc9d6b979d5da92cc4ef3f207acdfaa48e
2017-10-02 08:23:49 -07:00
Bill Yi
bb082f4720 Import translations. DO NOT MERGE
Change-Id: I3be6845a3c0c062387defa8349461b08be25df7f
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
2017-10-02 08:12:09 -07:00
Carsten Hauge
f35cb6bc91 Avoid NullPointerException when updating preference intents
Comparisons changed on the intent action. Sometimes an account
preference intent does not have an action specified.

Fixes: 67075850
Test: manual - go to Settings > Users & accounts and tap an account.

Change-Id: I54cebbc983b55aa1487a122d37ccd5c79bbf519d
2017-10-02 02:01:49 +00:00
jeffreyhuang
7b216bae94 Introduce VerifyAppsOverUsbPreferenceControllerV2
- Create new VerifyAppsOverUsbPreferenceControllerV2
 - Deprecate VerifyAppsOverUsbPreferenceController
 - Create controller inside the DashboardFragment
 - Copy logic from VerifyAppsOverUsbPreferenceController with
 slight modifications for dashboard fragment compatibility

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I37c01cd262c9e12307ec9cbe6effc5470496550f
2017-09-29 17:51:17 -07:00
TreeHugger Robot
1e7c3f83c2 Merge "Create suggestion state provider." 2017-09-30 00:43:39 +00:00