Commit Graph

23787 Commits

Author SHA1 Message Date
Matthew DeVore
d73552fca5 Merge "Simplify pane sizing and scaling algorithm" into main 2025-01-31 10:30:40 -08:00
Matthew DeVore
a23e3cb774 Simplify pane sizing and scaling algorithm
Simplify the scaling parameters and algorithm and reduce vertical
padding.

Originally a maxBlockRatio was specified at .12, which would have
caused a block length to typically be 2560 * 0.12 = 307. However, this
fails to account for smaller displays and high-DPI displays which have
smaller dip dimensions. So instead choose a maximum edge length of
256dp, which I have found to give good results on a laptop device
and a high DPI tablet, and which does not assume typical sizing for
configured displays, and still accomplishes the purpose of limiting
scrolling and dragging size.

Using the aspect ratio of the display bounds in setting the height
frequently caused a very large amount of padding, and limiting based on
the max block height only reduced it slightly. Now we set the vertical
height based on the minEdgeLength. This length is considered the
smallest size that can be comfortably interacted with, and we use it to
give ballpark ideal padding size.

Note that the unit test cases have increased pane height but in
practice (real-world pane width and constraints) this change seems to
decrease the pane height in general.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/352650922
Test: atest DisplayTopologyPreferenceTest.kt
Test: atest TopologyScaleTest.kt
Test: compare appearance on mid-dpi and high-dpi screens with a single 1080p external display, or with two external displays of smallish logical size
Change-Id: Id189892c88a1e833c1f54b0e5447a15f92e3310f
2025-01-30 20:37:03 +00:00
Jack Yu
6e26457b84 Cleaned up the flag enable_identifier_disclosure_transparency_unsol_events
Cleaned up the 24Q3 flag
enable_identifier_disclosure_transparency_unsol_events

Bug: 276752426
Test: Basic telephony functionality tests
Test: atest FrameworksTelephonyTests
Flag: EXEMPT removing flag
Change-Id: Ia96d406bd354f766e57363b74700ca07ac79c895
2025-01-29 14:07:28 -08:00
Yomna N
aea18e40d0 Merge "Fix broken Safety Center redirect when SafetySourceData is null" into main 2025-01-29 12:13:17 -08:00
Jack Yu
5161aff82e Merge "Cleaned up the flag enable_identifier_disclosure_transparency" into main 2025-01-28 18:09:37 -08:00
Riley Jones
6e12194015 Merge "Disabling elements on the A11y Shortcut setting subpage" into main 2025-01-28 13:24:42 -08:00
Matthew DeVore
ec58402c03 Merge "Apply display density to topology pane scaling" into main 2025-01-28 11:39:34 -08:00
Zhou Liu
56170c3f53 Merge "Create "Manage PIN" settings UI menu" into main 2025-01-28 10:48:39 -08:00
Matthew DeVore
e22d46aa9b Apply display density to topology pane scaling
Account for high DPI screens in topology pane scaling.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/352650922
Test: atest DisplayTopologyPreferenceTest.kt
Test: atest TopologyScaleTest.kt
Test: compare appearance on mid-dpi and high-dpi screens with a single 1080p external display
Change-Id: I192fccd402c20e00beacdb5ad55eed406252eb93
2025-01-28 17:24:05 +00:00
Yvonne Jiang
bf54835a94 Merge "Add handling for main Supervision settings toggle." into main 2025-01-28 08:23:39 -08:00
Yvonne Jiang
4f74b50b3a Add handling for main Supervision settings toggle.
This change introduces the basic behavior for the main toggle switch to
enable supervision. There is currently no PIN setup dialog when the
toggle is clicked. That will be added as a follow-up.

Intake bug: b/379312924

Change-Id: I75d6b2de1a7234c6da26fcdcf1d933eed3106a8c
Test: atest SupervisionMainSwitchPreferenceTest
Bug: 392694561
Flag: android.app.supervision.flags.enable_supervision_settings_screen
2025-01-28 02:35:14 -08:00
William Leshner
5035bede60 Merge "Add "Hub Mode" settings to mobile settings." into main 2025-01-27 20:28:02 -08:00
yomna
d4dc1fed9e Fix broken Safety Center redirect when SafetySourceData is null
Bug: b/373942609
Test: m & atest CellularSecurityPreferenceControllerTest
Flag: EXEMPT bugfix
Change-Id: I2373ccb5cb51bca23815db9f7645efccc3e0cd88
2025-01-28 02:06:27 +00:00
Zhou Liu
82356f6e93 Create "Manage PIN" settings UI menu
Test: atest SupervisionPinManagementScreenTest
Test: manually on real device
Bug: 390186179
Flag: android.app.supervision.flags.enable_supervision_settings_screen
Change-Id: Ib53dce2a32fe9551e8877145a61c8834505d389d
2025-01-28 01:12:22 +00:00
Jack Yu
506c3e04e3 Cleaned up the flag enable_identifier_disclosure_transparency
Cleaned up the 24Q3 flag enable_identifier_disclosure_transparency

Bug: 276752426
Test: Basic telephony functionality tests
Test: atest FrameworksTelephonyTests
Flag: EXEMPT removing flag
Change-Id: Id3355ef2416f75df8ca43cc4d261583e92c17fba
2025-01-27 14:14:45 -08:00
Treehugger Robot
532bd7f19e Merge "Add initial settings for summarization" into main 2025-01-27 07:04:49 -08:00
Julia Reynolds
50e720b03b Add initial settings for summarization
Test: SummarizationGlobalPreferenceControllerTest
Test: SummarizationPreferenceControllerTest
Flag: android.app.nm_summarization
Bug: 390415383
Change-Id: I773d69c707ae5f902860196fb44821ede15261f5
2025-01-27 05:54:01 -08:00
Vitor Carvalho
3aaf114753 Merge "Update ParentalControlsUtils to call the new internal API that is aware of SupervisionManager, introduced in ag/31120568." into main 2025-01-27 04:03:47 -08:00
Nikhil Nayunigari
3db5f484ce Merge changes from topic "Ethernet Settings" into main
* changes:
  Adding EthernetInterfaceTracker to support EthernetSettings
  Adding middleware to support EthernetSettings
2025-01-25 18:05:21 -08:00
Nikhil Nayunigari
4d662c5bde Adding EthernetInterfaceTracker to support EthernetSettings
This class is part of the middleware and will be used to be notified
when an EthernetInterface is added or removed.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest
SettingsRoboTests: com.android.settings.network.EthernetInterfaceTrackerTest
Change-Id: If3a1f4d7a96b301cd47ffbea55864bcc780cd1e0
2025-01-25 13:01:35 -08:00
Nikhil Nayunigari
6d2152fb10 Adding middleware to support EthernetSettings
Adds EthernetInterface class and its unit tests. This class encapsulates
all operations performed on an EthernetInterface. EthernetManager and
ConnectivityManager are its dependencies to execute operations.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest SettingsRoboTests:com.android.settings.network.EthernetInterfaceTest

Change-Id: I640a607c8d9705a10dc4c4c609e036a1afa6b5f7
2025-01-25 19:18:50 +00:00
Treehugger Robot
fe44ea6c87 Merge "Add the new Desktop Experience dev options" into main 2025-01-24 16:27:43 -08:00
Matthew DeVore
50cee5bf76 Merge "Show border highlight when dragging display" into main 2025-01-24 14:37:12 -08:00
Marzia Favaro
271fb3ea63 Merge "UserAspectRatioManager call AtivityRecord#canBeUniversalResizeable" into main 2025-01-24 02:46:03 -08:00
Matthew DeVore
1fb8fb0b4f Show border highlight when dragging display
In the process of adding highlight we use an extra feature of
LayerDrawable to add insets so that we can add padding without changing
the actual dimensions or position of the DisplayBlock Views.

To make it easier to keep the values consistent and to aid in conversion
between px and dp, use dimen values to store padding and highlight
metrics.

Bug: b/352650922
Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: atest DisplayTopologyPreferenceTest.kt
Change-Id: I51ff2ce4a086e84a0c529346f8ede90430090b11
2025-01-23 23:26:53 -06:00
Yiyi Shen
09c8f4fabb Merge "[Audiosharing] add profile service listener when BT just on" into main 2025-01-23 18:23:17 -08:00
Riley Jones
94621548c1 Disabling elements on the A11y Shortcut setting subpage
Elements on the subpage get disabled if there are no enabled shortcut targets for the relevant type.
In the case of A11y button, the items on its fragment become unsearchable when the setting is disabled.

Test: Manually verify conditions described above & in bug
Bug: 349180207
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: Id39e2eda6c9d1de4cdbfcbc22b8a1f443e2822d9
2025-01-24 00:59:25 +00:00
Pierre Barbier de Reuille
8a42cd7171 Add the new Desktop Experience dev options
This option, when available, replaces the enable freeform ones.

Bug: 390625230
Bug: 389092752
Test: atest DesktopExperiencePreferenceControllerTest
Test: atest DesktopModeSecondaryDisplayPreferenceControllerTest
Test: atest DesktopModePreferenceControllerTest
Test: atest FreeformWindowsPreferenceControllerTest
Flag: com.android.window.flags.show_desktop_experience_dev_option
Change-Id: Ib2eaa99fab1fbcae6ed9afa997cfe92676a75c70
2025-01-23 11:01:11 +00:00
Jacky Wang
7a24cd61ac [Catalyst] Migrate WifiCallingScreen to parameterized screen
Bug: 388420844
Bug: 372732219
Flag: com.android.settings.flags.catalyst_wifi_calling
Test: devtool
Change-Id: I322001acc453eae0d69761f7a585c6f33087ef6a
2025-01-23 17:16:41 +08:00
Yiyi Shen
e9b6016b8d [Audiosharing] add profile service listener when BT just on
If receive BT on while profile service not ready, add profile service
listener and do things, e.g. update preference, when all relative
profile services connected.

Test: atest
Bug: 305620450
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ie56ed70190285785f1750a7cbbb16029b566fcbe
2025-01-23 15:36:48 +08:00
Chelsea Hao
f956509b8c Merge "Show qr code in "Share your audio" dialog" into main 2025-01-22 23:35:39 -08:00
chelseahao
b6ba9c3bbc Show qr code in "Share your audio" dialog
Test: atest
Bug: 381775542
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I6fe339beb50803989d4110fca681e609d2d600c1
2025-01-23 14:23:38 +08:00
Vilas Bhat
3b6958253a Merge "16KB: Fix failing tests for AOSP targets" into main am: 62c017beb5 am: 78c5a735ad
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3455768

Change-Id: Ia25f358582c9e5a7b515b08bbeb9040e7e76c700
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-22 14:58:37 -08:00
Vilas Bhat
62c017beb5 Merge "16KB: Fix failing tests for AOSP targets" into main 2025-01-22 13:55:06 -08:00
Riley Jones
9707e4039f Merge "Cleanup of deprecated A11y settings functions" into main 2025-01-22 10:41:05 -08:00
Treehugger Robot
3d626d8e8b Merge "Partial flag clean up: Remove large mouse pointer in A11y Setting screen" into main 2025-01-22 10:13:34 -08:00
Will Leshner
f5a840c417 Add "Hub Mode" settings to mobile settings.
Bug: 389782624
Test: atest CommunalPreferenceControllerTest
WhenToDreamPreferenceControllerTest
Flag: com.android.settings.flags.enable_hub_mode_settings_on_mobile

Change-Id: Ic823b43e094722e467bcca5c16fc480af11e2d9e
2025-01-22 10:12:31 -08:00
Vitor Carvalho
4c9232dda4 Merge "Fix ActionDisabledByAdminDialogHelperTest by setting a mock SupervisionManager as system service." into main 2025-01-22 10:07:22 -08:00
Marzia Favaro
cc4d5a3b6a UserAspectRatioManager call AtivityRecord#canBeUniversalResizeable
instead of duplicating the method locally.

Fix: 374903057
Flag: EXEMPT same behavior
Test: UserAspectRatioManagerTest
Change-Id: I7b362bf9aaf06e1af0288e0ce8c43e7c3b3472e3
2025-01-22 17:48:32 +00:00
Vitor Carvalho
e866c91b84 Fix ActionDisabledByAdminDialogHelperTest by setting a mock SupervisionManager as system service.
A shadow of DPM is automatically added as system service by Robolectric infra. Since SupervisionManager is new, it doesn't have that.

We will consider changing Robolectric to do the same thing when SupervisionManager becomes more stable.

Flag: TEST_ONLY
Bug: 382034839
Test: atest ActionDisabledByAdminDialogHelperTest
Change-Id: I389938df10ce97c563511473b0aeaee52225f419
2025-01-22 16:53:16 +00:00
Chung Tang
bb094b877c Merge "Accommodate BATT protocol modifications." into main 2025-01-22 02:58:57 -08:00
Yiyi Shen
a618a8a241 Merge "[Audiosharing] Move entry preference out of group category" into main 2025-01-22 01:09:08 -08:00
Chung Tang
8a6ea1a106 Accommodate BATT protocol modifications.
Bug: 380790573
Test: atest com.android.settings.bluetooth.AdvancedBluetoothDetailsHeaderControllerTest and Manual
Flag: com.android.settings.flags.enable_battery_level_display

Change-Id: Ibc4eb66aacedaf3a4111d4a411dada6cde1a5b9c
2025-01-22 00:14:53 -08:00
Yiyi Shen
001ec9d33e Merge "[Audiosharing] Avoid popup dialog when broadcast start in SysUI" into main 2025-01-22 00:02:30 -08:00
Shawn Lin
047c38856a Merge "[Biometric Onboarding & Edu] move screen lock settings to choose lock" into main 2025-01-21 22:34:40 -08:00
Shawn Lin
d6df87cca6 [Biometric Onboarding & Edu] move screen lock settings to choose lock
- Hide gear menu in LockScreenSafetySource
- Move screen lock settings to ChooseLockGeneric

Bug: 370940762
Test: atest ScreenLockPreferenceDetailsUtilsTest
Flag: com.android.settings.flags.biometrics_onboarding_education

Change-Id: I07c7bb16ecc2ea6e7cd64a4e1d6bf4f493c5b951
2025-01-22 03:28:19 +00:00
Vilas Bhat
d30433c92e 16KB: Fix failing tests for AOSP targets
UiAutomator is case sensitive. On AOSP builds, the "Erase all data"
string is displayed in all caps in the dialog box on trying to erase all
data and switch to ext4 mode. This is a workaround fix for the issue.

Bug: 390535191
Flag: EXEMPT bugfix
Test: Enable16kbTest on AOSP Pixel 8 targets
Change-Id: I119fe076eb3eb037a23f07af77b9ad4935cb4064
2025-01-22 00:12:56 +00:00
Riley Jones
75500c02b2 Cleanup of deprecated A11y settings functions
Bug: 367414968
Test: atest com.android.settings.accessibility
Flag: EXEMPT cleanup
NO_IFTTT= Change does not alter preference list

Change-Id: I64f5f7fba112b6fb5035b88f01c04d9ee309f2c0
2025-01-21 21:07:34 +00:00
Yvonne Jiang
777378996f Merge "Initial skeleton of new "Supervision" settings screen with top-level entry point." into main 2025-01-21 11:27:13 -08:00
Joy Babafemi
64769aae17 Merge "Credential Manager Settings Improvement Bug fixes" into main 2025-01-21 11:12:25 -08:00