Commit Graph

210 Commits

Author SHA1 Message Date
Winson Chung
d16e3233af Updating settings to use resource overlay instead of setting.
Bug: 127366543
Test: Manual test on device
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationLegacyPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationSwipeUpPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationEdgeToEdgePreferenceControllerTest

Change-Id: I021d05a21e00136c6f3651247964319274bdab91
2019-03-25 00:26:39 -07:00
Beverly
efd88a9a7c Move WakeScreenGesturePrefController
Test: n/a
Bug: 127955764
Change-Id: Ib4ca072e1ade3d2c0fd015e25d95807d8804d74d
2019-03-21 10:13:19 -04:00
Tracy Zhou
ecb94f5466 Enable nav bar overlay when gestural nav is enabled and tune edge swipe
width.

Fixes: 128680874, 128711028
Test: Manual
Change-Id: I371819c6f6206f2bbc8599c0b14b4da9b67a2e14
2019-03-18 15:14:57 -07:00
Beverly
575a856709 Move WakeGestureScreenGestureSettings
Test: robosettings tests
Bug: 127955764
Change-Id: I058a960d6e51afd6e92b9a035993f6bfd91025b8
2019-03-15 09:34:05 -04:00
Mehdi Alizadeh
43502549a3 Adds Edge to Edge option in gesture settings page
Bug: 125489141
Test: Manual test on device
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationLegacyPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationSwipeUpPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationEdgeToEdgePreferenceControllerTest
Change-Id: I1b274cc053de8235d0c664150cabe5dadc618419
2019-03-07 14:50:27 -08:00
Issei Suzuki
1ac14708e8 Merge "Move AmbientDisplayConfiguration class out of internal package." 2019-02-27 14:28:36 +00:00
Issei Suzuki
fd85a9fae6 Move AmbientDisplayConfiguration class out of internal package.
Test: m droid (run full build)
Bug: 126327497
Change-Id: Idc07c811864edb4f88151051e25d6e05e4caf3b2
2019-02-27 13:25:15 +01:00
Beverly
986f2ecc55 Make PreventRingingSwitch preference clickable
- Talk back says the preference is clickable

Test: make ROBOTEST_FILTER=PreventRingingSwitchPreferenceControllerTest RunSettingsRoboTests -j40
Bug: 124827588
Change-Id: Ia409bbc6516f6aa11975726691131f1fad1518fd
2019-02-25 16:36:45 -05:00
Fan Zhang
7db118e367 Mass clean up: don't cast class when not needed.
Bug: none
Test: rebuild
Change-Id: Ie3f58a3d5ae99ade28a33dcac80c18de90d4d5b2
2019-02-14 12:26:09 -08:00
Lucas Dupin
862aaed38c Make WakeScreen conditionally avaialable
Also moving the setting closer to 'Always On'

Fixes: 124389844
Test: manual
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WakeScreenGesturePreferenceController
Change-Id: Ic19e01bf4259608dc0430507fbb3ce5ebf6fa456
2019-02-13 13:39:28 -08:00
Lucas Dupin
b55e5f1360 Consolidate wake-screen settings page
UX decided to have a single settings page instead of two

Test: manual
Bug: 111414690
Change-Id: I8e0eee3ea00b1eb9cbe534cc60bfccec43cf8e31
2019-01-30 15:06:14 -08:00
Beverly Tai
77a586bb76 Revert "Settings for skip and silence gestures"
This reverts commit d5428a5cd4.
Test: manual, builds
Reason for revert: moving to SettingsGoogle

Change-Id: Iad954e22c9484c2bc059b52e5f17a244be461394
2019-01-28 19:23:02 -05:00
Fan Zhang
31b210017b Migrate all MetricsProto enums to SettingsEnums
Bug: 122855168
Test: rebuild
Change-Id: I962d9a71179f86b7cae9dc5e9a00e0aa1557dc76
2019-01-17 14:55:42 -08:00
Lucas Dupin
dbaa5459b8 Merge "Tap gesture settings" 2019-01-17 02:38:09 +00:00
Beverly
d5428a5cd4 Settings for skip and silence gestures
Test: make RunSettingsRoboTests
Bug: 118388808
Change-Id: Ic906b42476283d245b423ef8842b6818cf7893a5
2019-01-16 15:37:47 -05:00
Lucas Dupin
97b8aae933 Tap gesture settings
Tap setting is similar to double tap, it will wake-up the phone
when invoked. This setting page allows for configuration since both
gestures aren't mutually exclusive.

Change-Id: Ia62a1fafcc108e3c0b14613cb30224eae7b35f6a
Fixes: 121198822
Test: make RunSettingsRoboTests
2019-01-16 11:41:44 -08:00
Beverly
8b4d3c3f0c Prevent ringing gesture uses master switch
Test: make ROBOTEST_FILTER=PreventRingingGesturePreferenceControllerTest RunSettingsRoboTests
Test: make ROBOTEST_FILTER=PreventRingingSwitchPreferenceControllerTest RunSettingsRoboTests
Change-Id: Iaf356ccd3623e67c39810955093fc353ae0d10a0
Fixes: 119787033
2019-01-03 12:56:13 -05:00
Lucas Dupin
1e971fe9be Renamed method
Test: make
Bug: 111405682
Change-Id: If3e48c5ee5f90aefb2795ce31025fabec689e7ad
2018-12-26 14:11:41 -08:00
Stanley Wang
9c4e2d6767 Fix top level "Gestures" not appearing in search result
If the availability status equals AVAILABLE_UNSEARCHABLE,
the preference won't appear in the serch result so we change
the status to AVAILABLE.

Change-Id: Id3ab28c4974f42be9b06a58d9c0d284f23ef160f
Fixes: 117951603
Test: manual and robotests
2018-12-03 11:28:39 +08:00
Fan Zhang
1e4e80162e Revert "Revert "Add a new logger for StatsLog""
This reverts commit f14d4af767.
Test: rebuild

Reason for revert: Fixes build

Change-Id: I003af1d9c973e58c09b1d8b9717c427febd6f809
2018-11-10 10:29:15 -08:00
Todd Kennedy
f14d4af767 Revert "Add a new logger for StatsLog"
This reverts commit b2b84372b5.

Reason for revert: Causes build failures

Change-Id: I04f4a6e6d6082903056c296d543870dd165b6eea
2018-11-10 13:51:50 +00:00
Fan Zhang
b2b84372b5 Add a new logger for StatsLog
Bug: 117860032
Test: robotests
Change-Id: I4f3f5b1fb47df9427140a22f1e78126ad391ff68
2018-11-09 15:54:12 -08:00
Beverly
c1fd6dc5a3 Use inline radio buttons for Prevent Ringing
Test: atest PreventRingingGesturePreferenceControllerTest
Fixes: 79867902

Change-Id: I3c9f949e038bba98e5be972adc01f35f5513432a
2018-11-06 10:12:08 -05:00
Lucas Dupin
8e57afb2cb Wake screen gesture
Settings page for gesture that allows the display to wake up.
Can be configured via overlays using config_dozeWakeScreenSensorType

Bug: 111414690
Test: manual
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WakeScreenGesturePreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WakeScreenGestureSettingsTest
Change-Id: Ic44f0ee9e781bda3b06cf4896217b324b9e3606c
2018-09-28 16:25:47 -07:00
Lucas Dupin
ade9180e7b Renaming gesture
Bug: 111414690
Test: manual
Test: ReachGesturePreferenceControllerTest, ReachGestureSettingsTest
Change-Id: I34cd4aacabc912122c553bf9c955a8ca4494230b
2018-09-28 12:53:12 -07:00
Fan Zhang
23f8d59d02 Sort imports
Having consistent import order will reduce chance of merge
conflict between internal and external master

Test: rebuild
Change-Id: I0b1a170967ddcce7f388603fd521f6ed1eeba30b
2018-08-28 22:13:15 +00:00
Fan Zhang
85a5f96051 Merge "Use searchable="false" to suppress nonIndexables." 2018-08-21 16:19:12 +00:00
Fan Zhang
9ce4a1fcde Use searchable="false" to suppress nonIndexables.
When possible, remove or simplify getNonIndexable() logic in fragments,
and use searchable="false" in xml to suppress index.

Change-Id: I5bdf5bc7d5494a64cdd9e230a51321a4b210af69
Fixes: 112608186
Test: robotest and manual search
2018-08-17 09:21:05 -07:00
TreeHugger Robot
259986da75 Merge "Add 'Reach to check' to lock screen settings" 2018-08-16 21:45:53 +00:00
Fan Zhang
a79c377fbc Declare "searchable" attribute for preferences.
Now we can easily mark a preference nonIndexable in xml instead of
adding key into searchIndexProvider.

Bug: 112608186
Test: robotests
Change-Id: I0ff16d44bb7b6ad148d3d35f09ca0da0163f73f4
2018-08-16 09:06:39 -07:00
Lucas Dupin
1dfb9421b4 Add 'Reach to check' to lock screen settings
Also added to Gestures page to make sure we're following the
same structure for all gestures.

Change-Id: Iaa9e53e870165801decfa427441d01ee69bcce6d
Note: using dummy video. dependency on b/112442049
Bug: 111414690
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ReachGesturePreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ReachGestureSettings
2018-08-14 14:21:57 -07:00
Lucas Dupin
3f773b3be3 Always enable double tap and pick up gestures
Both gestures should also work when AOD is on.

Test: make RunSettingsRoboTests ROBOTEST_FILTER=DoubleTapScreenPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PickupGesturePreferenceControllerTest
Test: manual
Bug: 111414690
Change-Id: I6552b6b6581a942dbc54f5320dda102c2ac62517
2018-08-10 13:43:57 -07:00
Fan Zhang
176ccd0c35 Clean up: fix incorrect @VisibleForTesting imports
Test: rebuild and robotests
Change-Id: I33d7ee1c0622c01f592920baaf01d44ad19d9a13
2018-07-13 13:08:53 -07:00
tmfang
27c84de325 Settings Fragment Migration (Build pass app)
This patch focused on fixing compile errors and some runtime errors.

Test: We can't test it now. But we will have an integration test later.
Bug: 110259478
Change-Id: I16c471ddcd0fa1460c665b7f74d86fcace5ee67b
2018-07-11 18:24:51 -07:00
Fan Zhang
d7d1e8063a Fix NPE when querying AmbientDisply through ExternalSeting
Bug: 110403709
Test: manual
Change-Id: I5c037b010e296cbd011f8c141932e6befd341c99
2018-07-09 17:35:35 -07:00
Fan Zhang
b80aee943c Fix NPE when querying AmbientDisply through ExternalSeting
Bug: 110403709
Test: manual
Change-Id: Iee9994061c2b5c4bdd7aefe2d25a73e8ed4c9db0
2018-07-03 13:16:48 -07:00
Fan Zhang
7431c91de6 Remove search indexing pipeline from Settings
Index is already handled by SettingsIntelligenec. No longer needed in
Settings.

Change-Id: Id43fb3100dc2759185744441cff8cb9cd2d2da20
Fixes: 69808376
Test: robotests
2018-06-21 09:38:36 -07:00
Fan Zhang
c7162cd24d Reorder and clean up imports.
Test: rebuild
Change-Id: I178485c84ae7146f991fd77b6d7504b029942a68
2018-06-18 15:45:09 -07:00
Fan Zhang
877fcd8013 Suppress some gesture search when there is no hardware
Change-Id: I780fe337da25d144b6966a098e95de52b1513e39
Fixes: 110250839
Test: robotests
2018-06-18 13:58:31 -07:00
Beverly
756e3b6caf Add summary to PreventRingingParent
Parent preference previously didn't have a summary
Moved summary test to PreventRingingParentPreferenceControllerTest

Test: PreventRingingParentPreferenceControllerTest.java
Change-Id: I2891e1ccffc4ea8007c8bd25689f242ee34c652c
2018-06-11 10:45:34 -04:00
Beverly
486d1facfa Add help uri for prevent ringing gesture
Test: build
Bug: 79270169
Change-Id: Iea5598f26649854521202363cad6ee297cef3057
2018-06-08 09:53:28 -04:00
Fan Zhang
752350c8d8 Suppress prevent ringer gesture parent page in search.
The full page verion of prevent ringing is still searchable.

- Created a new controller for parent entry.
- On the child controller, inherit the same getAvailabilityStatus() but
  override AVILABLE_UNSEARCHABLE to AVAILABLE so it becomes searchable.

Fixes: 72748524
Test: existing robotests for PreventRingingPreferenceController

Change-Id: Id2454db110c81b59fa4a98338602b03de0812f8a
2018-06-05 15:10:45 -07:00
Fan Zhang
7c1233116b Clean up some search nonIndexableKeys.
- Make the entire gesture setting page unsearchable. This is safe
  because each row in gesture setting page lead to a child page, we are
  only removing duplicates.
- Make the pref controller for System -> gesture return
  AVILABLE_UNSEARCHABLE so it's also suppressed.
- Suppres the parent page for adaptive brightness.

Bug: 72748524
Test: manual
Change-Id: Id7317f5f126af88b1bde8d87b8a206d9909df904
2018-06-04 18:50:44 +00:00
Matthew Fritze
bf1f5b5813 Add isSliceable API to BasePrefController
Only support explicitly approved Settings Slices,
dictated by controllers which return true for the new
method isSliceable.

Updating the supported settings to a whitelist means that
the method to return all available slices must be updated,
and checking slicability when we index slices.

Test: robotests
Bug: 79779103
Change-Id: Ib2b9690cdd0036b5cc4a1cb846c52bce7c824ab9
2018-05-22 11:06:42 -07:00
Matthew Fritze
f59a77ca23 Fix availability status for AOD gestures
Double tap screen to wake and lift to check phone
are dependent on AOD - and should return DISABLED DEPENDENT
SETTING when AOD is turned on.

Test: robotests
Change-Id: Ib246070ee853185459628b2584ddbae72e15a2f8
2018-05-21 15:41:39 -07:00
Mehdi Alizadeh
6ed77203e8 Merge "Moves Swipe Up overlay from Settings app to android.internal" into pi-dev am: 9a93a1dbe9
am: 84586334b2

Change-Id: Ic2818dc965defb3b2df3192604cedbfcddf36714
2018-05-16 16:53:44 -07:00
Mehdi Alizadeh
16db9e14d7 Merge "Adds two overlay settings fields for Swipe Up gesture" 2018-05-16 19:52:02 +00:00
Mehdi Alizadeh
5ab8077f44 Adds two overlay settings fields for Swipe Up gesture
Adds two overlay settings for Swipe Up gesture, one for the default
value (enabled/disabled), and another one to show/hide the Swipe Up
settings page in Settings app.

Bug: 78908915
Bug: 78641268
Test: Robotests and Manual test
Change-Id: If7bea967f3af9ebe96ab87e8a4d6d05c5daa4ed5
2018-05-16 11:54:27 -07:00
hjchangliao
2f73a6646f Convert Magnify controller to TogglePrefController
Convert below to TogglePreferenceController:
MagnificationNavbarPreferenceController
(Magnify with Button)
MagnificationGesturesPreferenceController
(Magnify with triple-tap)

The two controllers share the same fragment,
Add static method for set/get state in fragment,
And use them in controllers and fragment.

Change-Id: I2bdbdb36be71e1a3ffb557abc5a6115d48de53cf
Fixes: 67997698
Fixes: 67997726
Test: make RunSettingsRoboTests
2018-05-16 16:05:41 +08:00
Mehdi Alizadeh
7c69ec7cfe Moves Swipe Up overlay from Settings app to android.internal
Bug: 79778025
Test: Robo tests
Change-Id: I0cfe5876c5d15552bd4a8e6a96931056846c880d
2018-05-15 18:11:32 -07:00