Commit Graph

2402 Commits

Author SHA1 Message Date
Roshan Pius
65291297a9 Settings: Use new API for wifi wakeup feature toggle
Bug: 148514485
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi
Test: Verified wifi wakeup feature toggle in wifi settings.
Change-Id: I1e7c0b3ca053a9b7d6105cad16362df38517b51e
2020-02-07 12:33:18 -08:00
Edgar Wang
4af4f276bd Merge "Make the fragment title can’t searchable" 2020-02-07 08:07:01 +00:00
Bonian Chen
ae405030f7 Merge "[Settings] Apply ImsQueryProvisioningStat to WFC" 2020-02-07 06:49:16 +00:00
David Su
2ad3a3e0ab Merge "Migrate to getNetworkSelectionStatus()" 2020-02-06 18:15:44 +00:00
Edgar Wang
0934babbfc Make the fragment title can’t searchable
we shouldn't take users so deep into the settings IA because it's easy
to feel lost in settings after clicking on a result without additional
context.

Bug: 143055215
Test: robotest & manual
Change-Id: I337cb5ead31e1e4e7bf9be78132e90630f83ee43
2020-02-06 19:07:11 +08:00
lesl
561d041f7b tether setting: Remove dual mode check for band convert
Some conutries don't support 5G only hotspot. Thus band convert should
not only work for dual mode device. It should general design since it
will be country dependency.

Bug: 148924644
Bug: 148764406
Test: Manual Test, use command to force country
1. adb root && adb shell cmd wifi force-country-code enabled GB
2. Change Band Setting to 5G prefer

Turn on hotspot to check log and make sure it will enable succeed.
Test:make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest

Change-Id: I7828c62ef399244531a72aa35c89b71549e0d623
2020-02-06 09:49:41 +00:00
Bonian Chen
a8f14cb11e [Settings] Apply ImsQueryProvisioningStat to WFC
1. Code refactor
2. Apply ImsQueryProvisioningStat class to WFC's use case

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingPreferenceControllerTest
Change-Id: I8a09264f83b9fc4fce3f79ec3aeb6ae757b004e4
2020-02-05 16:55:17 +08:00
TreeHugger Robot
638b45e4f3 Merge "[Wi-Fi] Apply cache in WifiTracker to update the signal icon immediatelly." 2020-02-05 05:54:17 +00:00
TreeHugger Robot
21276e72d6 Merge "[Wi-Fi] Fix strange split line when there is no connected network" 2020-02-04 07:16:39 +00:00
Arc Wang
9c11f68c8f [Wi-Fi] Fix strange split line when there is no connected network
Shows connected network preference only if connected network is available.

Bug: 147990798
Test: manual visual
Change-Id: I119a2617a33df628c4f2cd5087a674f7b9b653fc
2020-02-04 10:52:58 +08:00
govenliu
e88f5efeb9 [Wi-Fi] Apply cache in WifiTracker to update the signal icon immediatelly.
issue: Signal icon on the add wifi network feature need to wait for the scan result.
Solution: Apply the cache in the WifiTracker to update signal icon for
shortening the waiting time of new scan result.

Bug: 146842198
Test: Add following unit test cases to test signal level has been updated correctly:
      1. withOneSuggestion_whenScanResultChangedButWifiOff_uiListShouldHaveZeroLevel.

Change-Id: Id72e2b43e020f2cafa2af4af5ffb1c28529002bd
2020-02-04 10:40:55 +08:00
David Su
f38bff9e0b Merge "Rename WifiConfiguration.getHasEverConnected()" 2020-02-03 21:12:03 +00:00
David Su
7e7b59e46e Merge "Settings: remove usage of WifiConfig helper methods" 2020-02-03 21:09:52 +00:00
TreeHugger Robot
6068d12752 Merge "Use feature flag to show/hide AllInOneTetherSettings" 2020-02-03 08:32:29 +00:00
TreeHugger Robot
23331b2983 Merge "[Wi-Fi] Hide Connect button when passpoint is expired" 2020-02-01 05:27:04 +00:00
TreeHugger Robot
b7f0145c02 Merge changes I8194476e,I9d21909f
* changes:
  [Wi-Fi] Fix some test failures of com.android.settings.wifi.details2
  [Wi-Fi] Remove passpoint methods in WifiEntryShell
2020-02-01 05:24:09 +00:00
Arc Wang
e16ce3dcea [Wi-Fi] Hide Connect button when passpoint is expired
If the passpoint is connected and expired, we still show
Disconnect button.

Bug: 148317997
Test: manual
      Observe a connected passpoint and see Disconnect button.
      Observe a disconnect passpoint and see no Connect button.
      Should add test case in WifiDetailPreferenceController2Test
      at later CL.

Change-Id: I07f22804eccce80c44ac709412cb594faaf6ccb0
2020-01-31 17:06:29 +08:00
Arc Wang
f591fe0901 [Wi-Fi] Remove passpoint methods in WifiEntryShell
Bug: 143326832
Test: build
Change-Id: I9d21909f18df03d50f69447c3f2014b75ecd2d8b
2020-01-31 15:19:35 +08:00
David Su
68913c5a8b Migrate to getNetworkSelectionStatus()
isNetworkEnabled() & isNetworkPermanentlyDisabled()
should not be formal APIs. Instead,
getNetworkSelectionStatus() with a set of constants
is sufficient as an API surface, and will be more
maintainable in the future.

Bug: 146046526
Test: atest SettingsUnitTests
Change-Id: If599ce88f68a87fa7186ef96156c2bb1fdc1c2c3
2020-01-30 20:36:53 -08:00
David Su
fa6e9f7283 Rename WifiConfiguration.getHasEverConnected()
Renamed to hasEverConnected() to conform to API
guidelines.

Bug: 146046526
Test: make RunSettingsRoboTests -j40
Change-Id: Ie88945326977ea11a05721e40a81c338fee61cb6
2020-01-30 20:36:30 -08:00
TreeHugger Robot
1608f9da49 Merge "Support metered choice for subscription WifiEntries" 2020-01-31 00:23:13 +00:00
Zhen Zhang
d2a7f9ae79 Use feature flag to show/hide AllInOneTetherSettings
This partially reverts commit 0ccc849de7
which added a config value. Instead, we will use feature flag to switch
between the fragments.

This CL also adds a postfix to keys in all_tether_prefs to
de-duplicate with keys in tether_prefs and wifi_tether_settings.

Bug: 148182953
Change-Id: I92832c786473990065a965409072e4117a7e75a8
Fix: 148618984
Test: make RunSettingsRoboTests
Test: make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest
2020-01-30 16:01:42 -08:00
David Su
59ab4ce478 Settings: remove usage of WifiConfig helper methods
These methods can be replaced with methods on
IpConfiguration itself. There is no need to expose
these as a @SystemApi, and they are being removed.

Bug: 146046526
Test: make RunSettingsRoboTests -j40
Change-Id: I592f277f5e23bf58e76b8c48a0f0370d53cc6b81
2020-01-30 10:53:48 -08:00
David Su
eb21975e89 Merge "Rename removeDoubleQuotes to sanitizeSsid" 2020-01-30 18:16:57 +00:00
David Su
5676b6fe36 Merge "Migrate WifiManager.isDualModeSupported() to isStaApConcurrencySupported()" 2020-01-30 17:42:41 +00:00
Quang Luong
a59bc1c0f5 Support metered choice for subscription WifiEntries
Add a check for subscription WifiEntries so they can also set their
metered overrides.

Test: manual
Bug: 70983952
Change-Id: Icd45f416e47251f914aa803d5190566746fb9779
2020-01-30 09:07:48 -08:00
Quang Luong
94f10ec0b5 Remove WifiEntry.METERED_CHOICE_UNKNOWN
METERED_CHOICE_UNKNOWN should represent the default value of the metered
choice, but this can be represented by METERED_CHOICE_AUTO already.

Bug: 70983952
Test: build
Change-Id: I3bea9217e197ff88eba606be9235b1db65158425
2020-01-29 16:45:06 -08:00
David Su
8ab62a8750 Migrate WifiManager.isDualModeSupported() to isStaApConcurrencySupported()
isDualModeSupported is being removed, replace it
with isStaApConcurrencySupported.

Bug: 144925765
Test: compiles
Change-Id: Ia3a0417a154ea401579a039113e96ba4578ffd80
2020-01-29 14:46:33 -08:00
David Su
930a4ec30e Rename requirePMF to requirePmf
Rename to conform to API guidelines.

Bug: 146046526
Test: compiles
Change-Id: Ib888ca3fc14cf30c9217b1f573c2279627c65a22
2020-01-27 17:47:15 -08:00
David Su
6c6e77ed32 Rename removeDoubleQuotes to sanitizeSsid
Bug: 145745815
Test: compiles
Change-Id: Ic2fbb78b30d2c64d584cd94a79b2ed7e5e234440
2020-01-23 18:57:49 -08:00
Quang Luong
f21a9b0b11 Merge "Remove WifiEntry transitional security types" 2020-01-23 19:49:43 +00:00
Zhen Zhang
0c2e4d3c94 Merge "Add config value to switch between Tether Settings UIs." 2020-01-23 07:07:09 +00:00
TreeHugger Robot
ed4dd70f53 Merge "[Wi-Fi] Replace WifiEntryShell#getSecurityString with WifiEntry#getSecurityString" 2020-01-23 01:41:19 +00:00
Bonian Chen
b053cd63a4 Merge "[Settings] replace isNonTtyOrTtyOnVolteEnabled() and isWfcEnabledByUser() in WFC" 2020-01-21 19:32:23 +00:00
David Su
77b86b1e55 Migrate AddAppNetworksFragment to use public getWifiConfiguration()
Field wifiConfiguration is @hide and cannot be
used, instead use public getter.

Bug: 138801922
Test: compiles
Exempt-From-Owner-Approval: Fix broken build
Change-Id: Idcaa2fee1950651b1a60e52838083ac8d75e9462
2020-01-21 18:13:27 +00:00
David Su
f56c4defc7 Merge "Settings: migrate usage of @hide NetworkSuggestion APIs" 2020-01-21 17:05:24 +00:00
Bonian Chen
c4413a850f [Settings] replace isNonTtyOrTtyOnVolteEnabled() and isWfcEnabledByUser() in WFC
1. Code refactor
2. Replace ImsManager#isNonTtyOrTtyOnVolteEnabled() by combination of
   TelecomManager#getCurrentTtyMode() and
   ImsMmTelManager#isTtyOverVolteEnabled()
3. Replace ImsManager#isWfcEnabledByUser() by
ImsMmTelManager#isVoWiFiSettingEnabled()

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSettingsForSubTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSliceHelperTest
Change-Id: I57c91a095fc4d454d92e8d78e0b647b4f098c6a3
2020-01-22 00:24:16 +08:00
Bonian Chen
ff1863451f Merge "[Settings] replace isNonTtyOrTtyOnVolteEnabled() in WFC" 2020-01-21 16:11:07 +00:00
Bonian Chen
2c0088be68 Merge "[Settings] apply WifiCallingQueryImsState" 2020-01-21 14:57:10 +00:00
Bonian Chen
72717cb537 [Settings] replace isNonTtyOrTtyOnVolteEnabled() in WFC
1. Code refactor
2. Replace ImsManager#isNonTtyOrTtyOnVolteEnabled() by combination of
   TelecomManager#getCurrentTtyMode() and
   ImsMmTelManager#isTtyOverVolteEnabled()

Bug: 140542283
Test: manual
Change-Id: Ia5179ee1a23f054899bc74c796542bae40cdc8d5
2020-01-21 22:40:33 +08:00
Bonian Chen
00a964bc0f Merge "[Settings] Allow more user to take responsibility" 2020-01-21 12:12:57 +00:00
Bonian Chen
a498eae245 [Settings] apply WifiCallingQueryImsState
1. Code refactor
2. Apply WifiCallingQueryImsState to more WifiCalling classes

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSettingsForSubTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSliceHelperTest
Change-Id: Idd4935a6d8ceed77c15e90f96781014d1940a427
2020-01-21 19:33:16 +08:00
TreeHugger Robot
38403f465b Merge "Implement new design of Wi-Fi card" 2020-01-21 10:31:33 +00:00
Bonian Chen
106ac9b648 [Settings] Allow more user to take responsibility
1. Add owner to wifi calling folder
2. Add songferngwang and tomhsu to telephony part

Bug: None
Test: Not required
Change-Id: I455685eb26df69d929ff3ed3c26ce84aa5f6b1f8
2020-01-21 18:16:19 +08:00
Jason Chiu
fbf3d7574a Implement new design of Wi-Fi card
- always show Wi-Fi card
- collapse the card in the new UI session when connecting to a stable
  network
- hide toggle, show a level icon and subtext in the new collapsed mode
- show loading row when the AP list is not full

Test: robotest
Fixes: 147473096
Change-Id: I893064ef04d40d8e7cb8e62c1e72a2cb5e97f6ac
2020-01-21 17:26:29 +08:00
Zhen Zhang
0ccc849de7 Add config value to switch between Tether Settings UIs.
Adding this config value to make it easy to switch to developing
Tethering settings UI. Also, using this config value to make sure
that preferences from new AllInOneTetherSettings screen won't show up in
the search results.

Bug: 147915366
Test: make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=TetherSettingsTest
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=TetehrPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiTetherSettingsTest

Change-Id: I8c88816a8f2b40fc219cae8d0d442454c5270b2b
2020-01-21 07:37:56 +00:00
govenliu
7e1018c0d0 [Wi-Fi] Add Wifitracker mechanism to update the signal icon.
Signal icon on the add wifi network feature is constant, didn't change with real signal level.

Bug: 146842198
Test: Add following unit test cases:
      1. withOneSuggestion_uiElementShouldHaveInitLevel() to test init level.
      2. withOneSuggestion_whenScanResultChanged_uiListShouldHaveNewLevel() to test level should updated according to scan result.

Change-Id: I212a825da9455a09a5c7777f87c0a74ec030c890
2020-01-20 17:34:20 +08:00
David Su
453d88568f Settings: migrate usage of @hide NetworkSuggestion APIs
Settings uses @hide WifiNetworkSuggestion.
wifiConfiguration/passpointConfiguration.
Migrate to @SystemApi getters.

Removed call to PasspointConfiguration.validate()
as it is an @hide API, instead
WifiManager.addOrUpdatePasspointConfiguration()
will perform the required validation.

Bug: 138801922
Test: make RunSettingsRoboTests -j40
Change-Id: I748010b66634b1d24e89a175917492f638267cb1
2020-01-17 15:41:40 -08:00
Arc Wang
33c6e65371 [Wi-Fi] Replace WifiEntryShell#getSecurityString with WifiEntry#getSecurityString
Bug: 143326832
Bug: 146407136
Bug: 147781156
Test: manual
      Check if security information correct

Change-Id: I32c247763783a38fed14eb06de863d9819cd6bdd
2020-01-17 17:12:05 +08:00
Goven Liu
4fa11dcb93 Merge "[Wi-Fi] Refactor add wifi networks feature to use WifiNetworkSuggestion." 2020-01-17 08:14:53 +00:00