Commit Graph

146698 Commits

Author SHA1 Message Date
Matthew DeVore
eeec7d0d66 Run body of applyTopology for all non-noop drags
In onBlockTouchUp, if DisplayTopology.rearrange happened to revert the
change made by the drag so that it matched the before-drag layout, the
blocks would not be moved, so the block would be in the dragged position
but not the normalized position.

This will happen when rearrange has a bug or is otherwise optimizing the
layout, which is dependent on the implementation of rearrange.

The test field mTimesReceivedSameTopology has been replaced with one
that represents an observable positive operation:
mTimesRefreshedBlocks, the validation of which has been added to some
existing tests.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: move display so that rearrange reverts the change, then exit and re-enter the external display fragment, and verify it matches the state when left
Test: DisplayTopologyPreferenceTest
Bug: b/394361999
Bug: b/394355269
Change-Id: Ic3028747d283db77f144831352b7687fe2706391
2025-02-07 12:58:06 -06:00
Yuhan Yang
999564498b Merge "Add mouse scrolling category title" into main 2025-02-07 10:19:14 -08:00
Aleksander Morgado
035a15ac37 Added unit test for MobileNetworkPhoneNumberPreferenceController visibility
The new test checks whether the item is available when the
SubscriptionUtil.isSimHardwareVisible() method returns true, i.e. if
the config_show_sim_info boolean flag is true on non-test runtime.

The default visibility status for all tests is defined in the test
setup() method, as this will also simplify the addition of new checks
later on.

Bug: 392808943
Flag: EXEMPT test only
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: Icedef190a8140fd8164dd8035ae93735a666b9f0
2025-02-07 14:53:25 +00:00
Aleksander Morgado
616fbc4f93 Added unit tests for PhoneNumberPreferenceController visibility
The tests check whether the item is available based on the result of
the SubscriptionUtil.isSimHardwareVisible() method, which is the one
allowing to check the value of the config_show_sim_info boolean flag
on non-test runtime.

Bug: 392808943
Flag: EXEMPT test only
Test: atest PhoneNumberPreferenceControllerTest

Change-Id: I2d1361ecef8a9c1083b4fd6fd4462c7815574827
2025-02-07 14:53:16 +00:00
Andreea Costinas
a185b43616 Ensure certificate alias is always visible
If the user credentials dialog displays multiple elements (e.g. if the
certificate is used by a wifi configuration), the content size exceedes
the available space.

Currently, the alias text view is the only element which declares a
`layout_weight`. The LinearLayout failes to distribute the space
correctly, pushing it beyond the bounds.

Bug: 287533409
Flag: EXEMPT bugfix
Test: manual
Change-Id: Ieff1b3011080dabf823c7689a3781c6e52b9791d
2025-02-07 13:46:57 +00:00
Treehugger Robot
cbecb7e5b8 Merge "[Catalyst] Introduce the Tags for Get/Set APIs" into main 2025-02-07 04:06:32 -08:00
Yiyi Shen
5732773031 [Audiosharing] Set temp bond metadata for just bonded lea buds in sharing
Test: atest
Flag: com.android.settingslib.flags.enable_temporary_bond_devices_ui
Bug: 392004799
Change-Id: I99e9955d00362125b7cbf54e2013c99dd2f9b457
2025-02-07 19:20:29 +08:00
Treehugger Robot
ad9576aacf Merge "[Catalyst] Implement metrics/tags for "Screen attention"" into main 2025-02-07 02:51:23 -08:00
Treehugger Robot
e07b3e8860 Merge "[Catalyst] Implement metrics/tags for "Bluetooth"" into main 2025-02-07 02:33:20 -08:00
Sunny Shao
8397f1056b [Catalyst] Introduce the Tags for Get/Set APIs
NO_IFTTT=Catalyst only

Test: atest ExternalSettingsProviderTest
Bug: 394002861
Flag: EXEMPT bugfix
Change-Id: I630a9f5ffbaaeed16e13674efa507f3a7b681839
2025-02-07 10:29:49 +00:00
Treehugger Robot
b729305ad3 Merge "[Catalyst] Implement metrics/tags for "Adaptive brightness"" into main 2025-02-07 01:57:12 -08:00
Treehugger Robot
b7ac496c3d Merge "[Catalyst] Implement metrics/tags for "Battery Saver"" into main 2025-02-07 01:56:28 -08:00
Treehugger Robot
a477817f06 Merge "[Catalyst] Implement metrics/tags for "Wi-Fi"" into main 2025-02-07 01:55:53 -08:00
Treehugger Robot
dff59dfde7 Merge "[Catalyst] Implement metrics/tags for "Wi-Fi Calling"" into main 2025-02-07 01:54:32 -08:00
Treehugger Robot
3c79d2d267 Merge "[Catalyst] Implement metrics/tags for "Mobile data"" into main 2025-02-07 01:51:10 -08:00
Shawn Lin
ec6db75081 Merge "Fixed incorrect screen lock settings category title" into main 2025-02-07 01:28:24 -08:00
Sunny Shao
1995fb420d [Catalyst] Implement metrics/tags for "Bluetooth"
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I793f81bc5195ae83927acd19f5da3e96a09ba430
2025-02-07 09:16:56 +00:00
Sunny Shao
d5915b775a [Catalyst] Implement metrics/tags for "Screen attention"
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I1ed0d0113d7efac4c6cfa9b95ea130b8edd04407
2025-02-07 09:03:44 +00:00
Sunny Shao
ea89c3ebfc [Catalyst] Implement metrics/tags for "Adaptive brightness"
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: Ida22810a8e3335eeff3632a989885fa7b6da433d
2025-02-07 08:50:35 +00:00
Shawn Lin
bf3f9a0bda Fixed incorrect screen lock settings category title
Bug: 394999568
Test: manual - Go to Screen lock settings page and check the title
Flag: com.android.settings.flags.biometrics_onboarding_education
Change-Id: I51352a43297e226cd1a72bd9edfe1211f02a4191
2025-02-07 00:34:48 -08:00
Aleksander Morgado
4799b02066 Merge "Avoid explicit reference to 'mobile' in tethering_footer_info" into main 2025-02-07 00:19:24 -08:00
Sunny Shao
763d2e3b6c [Catalyst] Implement metrics/tags for "Battery Saver"
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I1adb1795a566275989db4ff1fbed180531af4d89
2025-02-07 07:46:15 +00:00
Sunny Shao
476dfa9131 [Catalyst] Implement metrics/tags for "Wi-Fi"
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I5c271aca902d74eadb7f8d462c967a31472d0c9f
2025-02-07 07:21:20 +00:00
Sunny Shao
dcc13e91f3 [Catalyst] Implement metrics/tags for "Wi-Fi Calling"
Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I5cd0141639415eee0d230187beb056692cd7694e
2025-02-07 06:48:09 +00:00
YK Hung
fc86da0f6d Merge "Use BatteryOptimizeUtils to add packageName into PowerSaveWhitelistUserApps allowlist, which will force set app into Unrestricted Mode" into main 2025-02-06 22:44:33 -08:00
Sunny Shao
916643c8fe [Catalyst] Implement metrics/tags for "Mobile data"
Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I9990c8295b26b4b4ed85db41179a8c93d07f48cd
2025-02-07 06:06:51 +00:00
Kevin Liu
8384d162d0 Merge "Temp disable test that contains custom shadow within it" into main am: d1b8b3a7e1 am: 0db2f6c60f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3479734

Change-Id: Ibb99bff0e14112bab302f89de9da40d4910c78a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-06 11:55:15 -08:00
Kevin Liu
0db2f6c60f Merge "Temp disable test that contains custom shadow within it" into main am: d1b8b3a7e1
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3479734

Change-Id: Ia857f69d48d14a8f30d4e43c1fee7cbf273d019d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-06 11:30:23 -08:00
Kevin Liu
d1b8b3a7e1 Merge "Temp disable test that contains custom shadow within it" into main 2025-02-06 11:11:35 -08:00
Liefu Liu
9852033728 Merge "Update the sub title of SIM preference in Contacts Storage Setting, to be consistent with "Device-only" preference." into main 2025-02-06 10:52:40 -08:00
Yuhan Yang
ba7738cba0 Add mouse scrolling category title
Add a scrolling category title in mouse settings page to match
the new design.

Mock: go/al-peripherals-ux page 3.
Screenshot: go/screenshot-8mtcgnjkabci8qt

Bug: 383555305
Bug: 384795606
Test: Local DUT with aconfig flags enabled
Flag: com.android.hardware.input.mouse_scrolling_acceleration
Change-Id: I3aa734a9e588c41dc9d48c40d779544074654a0a
2025-02-06 18:29:55 +00:00
Yvonne Jiang
3a7e3cb6f9 Merge "Register the category key mapping for the SupervisionDashboardFragment." into main 2025-02-06 10:14:29 -08:00
Angela Wang
6f0f6e7cf6 Merge "Hide ambient control when there's no valid control point" into main 2025-02-06 09:17:37 -08:00
Shawn Lin
6f4f66e5ed Support customization for biometrics SafeSourceIssue
Notify issue action launch when enrollment process is canceled

Bug: 370940762
Test: atest FaceEnrollTest FingerprintEnrollTest
Flag: com.android.settings.flags.biometrics_onboarding_education
Change-Id: I91e2dcf44ee8cfd3e7c74d05f51a1ef30ea6f8b2
2025-02-06 16:30:55 +00:00
Kevin Liu
a9e22be8a5 Temp disable test that contains custom shadow within it
We need proper support or Exception throw for this scenario

Test: atest SettingsRoboTests
Bug: 394813533
Change-Id: I8b552f7b2bff166643bdaa492dceff23679116ff
2025-02-06 14:48:43 +00:00
Jacky Wang
bf792b4081 Merge "[Catalyst] Enforce WRITE_SYSTEM_PREFERENCES permission" into main 2025-02-06 05:03:02 -08:00
shaoweishen
538cc35aed [Physical Keyboard] Fix bugs for input keys dialog
set content description on custom radio button and seekbar.
fix typo

Bug: 374229004
Bug: 374229189
Bug: 374229597
Bug: 389973787
Flag: com.android.settings.keyboard.keyboard_and_touchpad_a11y_new_page_enabled
Test: atest
packages/apps/Settings/tests/robotests/src/com/android/settings/inputmethod/

Change-Id: I3df4b1558c2bad73d9411a0160725d7a35590cc3
2025-02-06 02:21:06 -08:00
Shaowei Shen
086c8b7955 Merge "[Physical Keyboard] Move Dialog to DialogFragment" into main 2025-02-06 02:20:41 -08:00
Jacky Wang
68bb5a04c9 [Catalyst] Enforce WRITE_SYSTEM_PREFERENCES permission
Bug: 374115149
Bug: 394744563
Flag: com.android.settingslib.flags.settings_catalyst
Test: manual
Change-Id: I63b84aea001033e81b1d811a2de983d8d107015c
2025-02-06 18:03:58 +08:00
Yuri Ufimtsev
ec78150e69 Merge "Allow the LockPatterUtils to be null" into main 2025-02-06 01:37:56 -08:00
Shaowei Shen
259cc0f30d Merge "[Physical Keyboard] Correct key string for mouse key" into main 2025-02-06 01:33:54 -08:00
Edgar Wang
c2776b9945 Merge "Update background color of Settings search" into main 2025-02-06 01:30:18 -08:00
Treehugger Robot
91fcb2c8ab [automerger skipped] Merge "Fix crash due to over limited length." into main am: 646fa2d5fa am: 17d0097a46 -s ours
am skip reason: Merged-In I5c72c3c9ca9cb2e4058959abc5a0b4fdd60907bf with SHA-1 a66f9dc362 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3478846

Change-Id: I5fae2b57f0f0b9611b406e74ad12dd706981e371
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-06 01:20:28 -08:00
YK Hung
436cce3aaf Merge "[Expressive Battery] Update screen on time text preference style." into main 2025-02-06 01:07:40 -08:00
Treehugger Robot
17d0097a46 Merge "Fix crash due to over limited length." into main am: 646fa2d5fa
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3478846

Change-Id: I25eafcb494be249eafda49e64e682dc3fbe77866
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-06 00:56:44 -08:00
Aleksander Morgado
1b6ffcbecb Avoid explicit reference to 'mobile' in tethering_footer_info
The Hotspot & Tethering feature allows sharing the current primary
data connection of the device with others using either a Wi-Fi hotspot
or USB/Bluetooth/Ethernet tethering.

The primary data connection is typically a mobile data connection on a
phone, but that is not the case on other form factors, e.g. in the
desktop experience, where sharing your Ethernet connection via Wi-Fi
(i.e. Ethernet is the 'upstream' technology instead of
cellular/mobile) may be a much more common usecase.

Given that devices can support Hotspot & Tethering without supporting
Telephony, there should be no explicit reference to a "mobile data
connection", as it is not accurate.

Bug: 393312760
Test: Manual check
Flag: EXEMPT strings only change

Change-Id: If71134deca4610a2304630f331e3a4fe62f0bc63
2025-02-06 08:43:16 +00:00
Treehugger Robot
646fa2d5fa Merge "Fix crash due to over limited length." into main 2025-02-06 00:31:51 -08:00
Treehugger Robot
fb4be96958 Merge "Support disable extend Fingerprint Settings" into main 2025-02-06 00:07:50 -08:00
mxyyiyi
45ac3f280d [Expressive Battery] Update screen on time text preference style.
For expressive style:
- Update the enlarge font size
- Remove the background

Bug: 349652542
Test: visual
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Change-Id: If85d2903eec6d1f7c3b58e71daef2409325ac83d
2025-02-06 16:00:10 +08:00
tom hsu
d9b78ebc97 Fix crash due to over limited length.
Flag: EXEMPT bug fix
Fix: b/388404115
Test: Manual test
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a66f9dc3629586c3543952566f05f1b720dfa50c)
Merged-In: I5c72c3c9ca9cb2e4058959abc5a0b4fdd60907bf
Change-Id: I5c72c3c9ca9cb2e4058959abc5a0b4fdd60907bf
2025-02-05 23:55:33 -08:00