Commit Graph

19136 Commits

Author SHA1 Message Date
Aleksander Morgado
d58d0be2e1 Return UNSUPPORTED_ON_DEVICE in deviceinfo/simstatus when no telephony
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest SimStatusPreferenceControllerTest
Change-Id: I0735c949a590190cdc177cbca835444691c50faa
2025-02-17 00:44:30 -08:00
Aleksander Morgado
4cc14d6553 Added unit tests for SimStatusPreferenceController visibility
The new test checks whether the item is available when
config_show_sim_info=false, when telephony is not data capable and
when the user is not admin,

The default visibility status for all tests is defined in the test
setup().

Bug: 395714454
Flag: EXEMPT test only
Test: atest SimStatusPreferenceControllerTest
Change-Id: I8791d9fd4d7ab8648946f044d7aa6a0e77283a00
2025-02-17 00:44:30 -08:00
Aleksander Morgado
64fb695d9b Return DISABLED_FOR_USER in IMEI availability if not admin user
The correct return when checking for the IMEI field availability
for non-admin users is DISABLED_FOR_USER.

UNSUPPORTED_ON_DEVICE should only be used when the setting is
unconditionally hidden as the device does not support the feature.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest ImeiInfoPreferenceControllerTest
Test: atest MobileNetworkImeiPreferenceControllerTest

Change-Id: I4ee89a84953993daad539d33d3a2e576540c580f
2025-02-17 00:44:30 -08:00
Aleksander Morgado
4f4580e5f5 Added unit tests for ImeiInfoPreferenceController visibility
The new test checks whether the item is available when
config_show_sim_info=false, when telephony is not data capable and
when the user is not admin,

The default visibility status for all tests is defined in the test
setup().

Bug: 395714454
Flag: EXEMPT test only
Test: atest ImeiInfoPreferenceControllerTest
Change-Id: Ic4df12da216e5c343cf696d931ff02dc942d105f
2025-02-17 00:44:30 -08:00
Menghan Li
972e7a320c Merge changes from topics "A11yFeedback", "AccessibilityFeedbackFeatureProvider" into main
* changes:
  feat(A11yFeedback): Pixel overlay to expose the feedback bucket ID
  feat(A11yFeedback): Add feedback entry for Accessibility page
  feat(A11yFeedback): Add FeedbackManager for Accessibility page
2025-02-16 19:45:09 -08:00
Nikhil Nayunigari
2c90d30415 Merge "Changes to add Ethernet settings row item" into main 2025-02-15 11:46:13 -08:00
Nikhil Nayunigari
bfd3722e06 Changes to add Ethernet settings row item
Adds EthernetSettings row item to NetworkProviderSettings and its
controller.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest
SettingsRoboTests:
com.android.settings.network.EthernetSwitchPreferenceControllerTest

Change-Id: I27965ad0c8563657b17e0aa6d3bd19b97fcf5615
2025-02-15 18:20:46 +00:00
Pierre Barbier de Reuille
f4505d8b82 Make sure the flags are setup correctly in the test.
Test: atest DesktopModePreferenceControllerTest
Flag: EXEMPT (bug fix)
Fix: 396663349
Change-Id: I8954dfad0a15791545f6c2ff88a488c553e02c69
2025-02-14 21:47:25 +00:00
tom hsu
63242bc3ff [Satellite Settings] Add a new API to SatelliteRepository
Flag: com.android.internal.telephony.flags.satellite_25q4_apis
Bug: b/395813844
Test: atest pass
Change-Id: Ife9e370dbcb3694adfd0bfbcc2ec2a742fbc4434
2025-02-14 06:39:45 -08:00
Treehugger Robot
d20e849d56 Merge "Create new sections for developer options" into main 2025-02-14 03:40:28 -08:00
Yiyi Shen
6dda673bf0 Merge "Show device in Media devices section if has LEA member connected" into main 2025-02-14 02:03:04 -08:00
Yiyi Shen
9b106ddf42 Merge "[Audiosharing] Avoid concurrent issue when adding preference" into main 2025-02-14 00:11:41 -08:00
Yiyi Shen
fb21686468 Show device in Media devices section if has LEA member connected
Test: atest
Bug: 396009828
Flag: EXEMPT simple fix
Change-Id: Icc6bd1c4fa7cf3c43eec1c4c950fbf778975f803
2025-02-14 14:53:56 +08:00
Yiyi Shen
80b28cb6cc [Audiosharing] Avoid concurrent issue when adding preference
Bug: 394685943
Flag: EXEMPT bug fix
Test: atest
Change-Id: I0d50dee9a36fd719236b52ab633a18818c3e10bb
2025-02-14 14:01:42 +08:00
Menghan Li
6b916e6f29 feat(A11yFeedback): Pixel overlay to expose the feedback bucket ID
This change introduces a feature provider for Pixel overlays, allowing
customization of the feedback bucket ID on Android.

Bug: 393980229
Test: Manual testing for Pixel and non-Pixel overlay in real device
Test: atest AccessibilitySettingsTest
            FeedbackManagerTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: Ieeb1dba4de5c13a275e66781621cbfcca7219a5e
2025-02-14 03:01:41 +00:00
Menghan Li
c86e2f3472 feat(A11yFeedback): Add feedback entry for Accessibility page
This entry point allows users to access in the action bar.
Visibility is controlled by the aconfig and FeedbackManager#isAvailable

Bug: 393981463
Test: atest AccessibilitySettingsTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: I8c219b8220b5839121d14959fe526e6200afeecb
2025-02-14 03:01:13 +00:00
William Leshner
e732852cfb Merge "Only show "hub mode" settings when the glanceable_hub_v2 flag is true." into main 2025-02-13 11:46:32 -08:00
Treehugger Robot
63e919d927 Merge "Inline MODES_API flag" into main 2025-02-13 09:43:04 -08:00
Pierre Barbier de Reuille
bf50c0baef Create new sections for developer options
To group desktop experience and window management options

Test: Build and check
Bug: 390625230
Flag: EXEMPT (refactor)

Change-Id: Ie076501da68045fa5f1098423a42d32f16a02838
2025-02-13 15:18:39 +00:00
Ze Li
c66d7bdcf3 Merge changes If4a471e2,I5ed1713d into main
* changes:
  [Temp bonding] Clean up old guest device logic as requirements changed
  [Temp bonding] Move audio sharing settings up
2025-02-13 06:59:22 -08:00
Pragya Bajoria
ea1cad3776 Merge "Rename DesktopMode API back" into main 2025-02-13 05:36:02 -08:00
Chelsea Hao
a219b4dabc Merge "Fix npe when broadcast code is null." into main 2025-02-13 02:09:35 -08:00
Ze Li
220312eab7 [Temp bonding] Clean up old guest device logic as requirements changed
Test: manual test
Bug: 362859132
Flag: com.android.settingslib.flags.enable_temporary_bond_devices_ui
Change-Id: If4a471e2058873be5cdb0ee43371333ebdc9a38a
2025-02-13 17:17:29 +08:00
Menghan Li
267251aae3 feat(A11yFeedback): Add FeedbackManager for Accessibility page
This change introduces a new FeedbackManager class to identify and
determine the availability of user feedback. This API will be used
to check if feedback is available for a user to provide.

Bug: 393980229
Test: atest FeedbackManagerTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: I577aa626c18f5c449dc3970d1324cc4940d20639
2025-02-13 09:08:07 +00:00
chelseahao
af4b7112f0 Fix npe when broadcast code is null.
Test: atest
Bug: b/381775542
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Id342a4b3ce26927d5ae76c866da07763bf8fbfbe
2025-02-13 00:56:12 -08:00
Xinyi Mao
a000daad53 Merge changes from topic "improve_battery_usage" into main
* changes:
  [Expressive Battery] Implement the expressive style for anomaly hint chip
  [Expressive Battery] Refactor pref with anomaly hint.
2025-02-13 00:32:59 -08:00
Zoey Chen
23885c6351 Merge "[Settings] Add a flag to control show new System language picker UI or not" into main 2025-02-12 22:31:27 -08:00
mxyyiyi
a2bdafaf5e [Expressive Battery] Refactor pref with anomaly hint.
- WarningFramePreference & warning_frame_preference.xml is a battery customized layout which looks like a standard Preference layout with an optional app icon & warning chip.
- PowerGaugePreference extends the WarningFramePreference to display the app Preference with optional warning chip in Battery > Battery Usage.
- PowerUsageTimePreference extends the WarningFramePreference to display the usage time with optional warning chip in Battery > Battery Usage > App battery usage.

Bug: 349652542
Test: atest BatteryUsageBreakdownControllerTest PowerGaugePreferenceTest PowerUsageTimeControllerTest
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Change-Id: I5d22703ccc487c54a2bbbc1d9737b92a2de54ba5
2025-02-13 13:16:10 +08:00
Treehugger Robot
793a6802ac Merge "Fix accessibility issues in Private DNS Settings" into main 2025-02-12 21:08:22 -08:00
Treehugger Robot
8efba3fee5 Merge "Do not disable LE audio offload as the developer option being disabled" into main 2025-02-12 20:25:04 -08:00
Weng Su
b3938a0244 Fix accessibility issues in Private DNS Settings
- Keep the Save button enabled at all times

- Show error in the Hostname view to remind the user
  - "The field is required" error
  - "The hostname you typed isn't valid" error

Bug: 386323822
Flag: EXEMPT bugfix
Test: Manual testing
atest -c PrivateDnsModeDialogPreferenceTest \
         PrivateDnsPreferenceControllerTest

Change-Id: I63973bd5001b838d7f27827e6a6d4ac96ac78ca9
2025-02-13 12:05:25 +08:00
Zoey Chen
997cd29458 [Settings] Add a flag to control show new System language picker UI or not
Bug: 394542699
Test: manual
Test: atest SettingsRoboTests:com.android.settings.localepicker.LocaleListEditorTest
Flag: EXEMPT refactor
Change-Id: I694e92cb7f61d208c36cb4b40aa3182cd838d5bb
2025-02-13 01:38:12 +00:00
Zoey Chen
ceaa16575a Merge "[Settings] Apply new style to dialog" into main 2025-02-12 17:28:45 -08:00
Alice Kuo
4251ebecca Do not disable LE audio offload as the developer option being disabled
The logic wrong to check the a2dp offload disable status to disable LE
audio offload together as the user turn off the developer option. Change
to use the support status, and reset the state to align the support
status.

Bug: 395725497
Fix: 395725497
Flag: EXEMPT, trivial bug fix
Test: Manual turn off developer option to check the status change
Test: atest SettingsRoboTests:com.android.settings.development.BluetoothLeAudioHwOffloadPreferenceControllerTest
Change-Id: I59d3e378495c90f007b46f05b74fdaf19d1520ce
2025-02-12 13:56:27 -08:00
Ben Lin
32f7568cd4 Rename DesktopMode API back
Also fix some indentation.

Bug: 395826065
Test: atest, Manual
Flag: EXEMPT bugfix
Change-Id: I50d30a8508d387e36981fb3bdd13b99480baedcf
2025-02-12 21:31:07 +00:00
Kanyinsola Fapohunda
22e56834fd Merge changes from topic "feedback_and_help" into main
* changes:
  Hide "Send feedback" button if no target exists.
  Move "Send feedback" button to the end of the list
2025-02-12 08:24:55 -08:00
Yuri Lin
c6675e5452 Merge "Update ZenModeAddBypassingApps to not binder call for every app" into main 2025-02-12 08:05:39 -08:00
Matthew DeVore
f6ad8e392e Merge "Detect when user wanted to drag vs. click" into main 2025-02-12 07:13:45 -08:00
Zoey Chen
09841d6bb4 [Settings] Apply new style to dialog
Bug: 394542699
Test: manual
Test: atest SettingsRoboTests:com.android.settings.localepicker.LocaleListEditorTest
Flag: EXEMPT refactor
Change-Id: Idfed52722d1113e432742342fd8a56958e84406e
2025-02-12 12:59:54 +00:00
Kanyinsola Fapohunda
8c427e654e Hide "Send feedback" button if no target exists.
This change hides the "Send feedback" button  when a target for
the intent is not found. This will ensure the button is not
visible in cases when clicking it would have done nothing.

Bug: 283239837
Flag: com.android.settings.flags.datetime_feedback
Test: Test: atest TimeFeedbackPreferenceControllerTest.java
Change-Id: I8bb18c313925a7dc7ac07a1fb4c2f9e2d98352db
2025-02-12 03:42:29 -08:00
Ashley Newson
6fc2502a7b Merge "Add developer settings link to WebView DevTools" into main 2025-02-12 02:28:26 -08:00
Jason Hsu
29557d6017 Merge "Show intro and footer string according to the device's supported status" into main 2025-02-11 23:44:01 -08:00
Yuri Lin
1500f3ecc0 Update ZenModeAddBypassingApps to not binder call for every app
This update already happened for ZenModeAllBypassingApps to use the new single binder call to get all packages bypassing DND. This change uses that method for bypassing apps as well as collecting the set of all apps with a nonzero number of channels.

Bug: 368623163
Bug: 394614704
Test: ZenModeAddBypassingAppsPreferenceControllerTest, manual to confirm correct behavior
Flag: android.app.nm_binder_perf_get_apps_with_channels
Change-Id: I72a1edcb07d18f5707591a5341d7a7338c23f42b
2025-02-11 17:20:46 -05:00
Matías Hernández
7235474792 Inline MODES_API flag
Bug: 310620812
Test: Preexisting
Flag: EXEMPT Inlining flag
Change-Id: I54ad81d87ea4ce85940400b0e8680a1bac0ca342
2025-02-11 15:14:24 +01:00
Jacky Wang
afbcf06654 [Catalyst] Move metrics class
NO_IFTTT=Catalyst only

Bug: 389886085
Flag: EXEMPT refactor
Test: atest
Change-Id: I8c24a4edf768aa2286adf66f16077e962080bb48
2025-02-11 20:18:30 +08:00
jasonwshsu
9cfc96d948 Show intro and footer string according to the device's supported status
Bug: 390078046
Bug: 386121967
Test: atest HearingAidHelperTest HearingDeviceFooterPreferenceControllerTest HearingDeviceIntroPreferenceControllerTest BluetoothDetailsHearingDeviceSettingsControllerTest
Flag: EXEMPT bugfix
Change-Id: I564cdb80cd14f4d2d8e882b64db939449c6936b7
Signed-off-by: Jie Wang <jie.x.wang@sony.com>
Signed-off-by: Jason Hsu <jasonwshsu@google.com>
2025-02-11 17:26:37 +08:00
Yiyi Shen
009747cef9 Merge "[Audiosharing] Block pairing during audio sharing" into main 2025-02-10 21:10:43 -08:00
Matthew DeVore
da0bd7b412 Detect when user wanted to drag vs. click
In order to avoid sending a new topology to DisplayManager
unnecessarily, which could cause some disruptive visual effect, don't do
anything if the drag was both (a) brief and (b) did nto deviate from
start position.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: DisplayTopologyPanePreferenceTest
Test: manual - quickly drag as few pixels as possible and verify the block moved back after drag, with no scale change
Bug: b/352648432
Change-Id: I29ffb51c54c9dbac970149cffd86a8027f0a42f5
2025-02-11 01:52:28 +00:00
Will Leshner
6f21b063f8 Only show "hub mode" settings when the glanceable_hub_v2 flag is true.
Bug: 395320922
Test: atest CommunalPreferenceControllerTest
Flag: com.android.systemui.glanceable_hub_v2
Change-Id: I46e5931205a219806917fafcc1a7aac3b7046796
2025-02-10 09:57:23 -08:00
Yiyi Shen
93f9061794 [Audiosharing] Block pairing during audio sharing
When a) there are two sinks in sharing b) there is at least one temp
bond device connected

Test: atest
Flag: com.android.settingslib.flags.enable_temporary_bond_devices_ui
Bug: 392004799
Change-Id: Id093b4c0b67bdc1db621e0241e79900abbd26c0f
2025-02-10 18:38:53 +08:00