Commit Graph

40 Commits

Author SHA1 Message Date
Andy Wickham
cc10abe1c2 Merge "Allows for system navigation settings to be added dynamically." into main 2024-03-20 03:00:10 +00:00
Andy Wickham
07109c158a Allows for system navigation settings to be added dynamically.
This allows for controller-backed preferences to be added or
overridden via xml.

Similarly, if the controllers cause all of the preferences for
2 or 3 button nav to be unavailable, we hide the settings button.

Bug: 324036308
Test: Manual and unit tests
Flag: NA
Change-Id: I2371f3173076172489966728ac69c8767570cd56
2024-03-14 20:07:33 +00:00
Randy Pfohl
ea76c296d3 Setting content description when illustration is clickable
Test: Built and tested with other cls in topic and verified talkback works properly.

Flag: None

Bug: 319747547

Change-Id: I37cbcc9bc4c830c73913cdad0734a874bd0eac7c
2024-03-13 21:11:30 +00:00
Daniel Norman
6c229865c9 Revert "Replace ShortcutType with UserShortcutType to reduce dup..."
Revert submission 25959129-chunkulin-replace-shortcutTypeConstant

Reason for revert: Reverting refactoring, to land after 24Q2 branches off of main. See b/323463488

Reverted changes: /q/submissionid:25959129-chunkulin-replace-shortcutTypeConstant

Change-Id: I323637727f4b642b3a6c626eae62bdaf0032eaf2
2024-02-03 00:23:15 +00:00
Chun-Ku Lin
c2d7daf645 Replace ShortcutType with UserShortcutType to reduce duplicate
declaration.

Bug: 317424693
Test: atest
Flag: N/A. Not able to flag the refactor
Change-Id: I20aea442cb08f047f98422176058acf4b344d2f1
2024-01-20 05:40:52 +00:00
Chaohui Wang
8e2ae547d6 Clean up FeatureFactory.getFeature()
Bug: 286764889
Test: m Settings
Change-Id: I7e472e6b0ca6b7a735c1b92742ddf06c545176fc
2023-08-08 08:41:48 +00:00
Riley Jones
b4bfea5c54 Expanded accessibility search terms
Items with new keywords:
-Accessibility
-Accessibility Menu
-Autoclick
-Live Caption
-Hearing Aids/Devices
-3-button navigation
-Touch & Hold
-Accessibility Timeout

Bug: 278091482
Test: Build SettingsGoogle, change your system language a few times, then check that the search bar responds to the new terms
Change-Id: Iddaf4f378b63f13141c1c52fbb4daa20f90a5ff8
2023-08-02 17:56:06 +00:00
Randy Pfohl
f572cc569e Ensure we launch gesture tutorial as new task
test: built for two pane device and verified it opens full screen
bug: 278918583
Change-Id: Icee33cb4a931e3037eab8e0146eddca55a5fd09d
2023-04-21 16:53:04 +00:00
Pfohl
b094ed8e7d adding new animation to be used when gesture tutorial package is available
test: built and verified animation shows up and is clickable to gesture tutorial menu on handheld devices

bug:248342586
Change-Id: I29a68accf67c4efc6b94058c2702f106edfec0a8
2023-04-07 18:20:15 +00:00
Edgar Wang
0fd7e6e3e7 Merge "Update lottie illustration for tablet" into tm-qpr-dev am: b5215abde7 am: 366ed57197
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154459

Change-Id: I7ba454aa3a58ec6c8f848ac5d09ea2385fdb3a33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 23:06:50 +00:00
Edgar Wang
2f5f6d4ee6 Update lottie illustration for tablet
Bug: 243889662
Bug: 243889643
Test: visual
Change-Id: Icac10e4401da3d704350aef6ef2723ff92ca34f8
2023-02-01 07:27:18 +00:00
Chaohui Wang
80a11a251e Remove the redundant constructor of SuggestionFeatureProviderImpl
Fix: 175167313
Test: robotest
Change-Id: I7ebbaf92398a8300971d592e2ee7a6e0d82c1d2f
2022-07-13 03:44:26 +00:00
Edgar Wang
257ebe4a5e Index the gesture options in System Navigation Settings page
Fixes: 167536360
Test: manual verify & robotest
Change-Id: Ie1a24a7206153dc1405f8a28369a6bade11ddd39
2022-04-11 21:05:37 +08:00
Jernej Virag
97ea279c45 Add setting to allow configuration of long press home gesture
This allows configuration of long press home gesture on 2-/3-button navigation configurations. It allows the user to enable and disable the invocation of assistant app using said gesture.

Bug: 191888710
Test: Unit tests and on a physical device.
Change-Id: I18cb290058ac5c2a748d40802b942404f548b868
2021-10-26 13:34:02 +00:00
Menghan Li
45d410ed91 Merge "[Material Next] Accessibility gesture tutorial dialog" into sc-v2-dev am: f7db8d7ee4 am: 2fa8b94643
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15501580

Change-Id: I275ea531be18bc1b0aa3fe372f59f89e4d4590ba
2021-08-20 22:10:23 +00:00
menghanli
5af9c64110 [Material Next] Accessibility gesture tutorial dialog
Problem: The dialog does not follow the Material Next guideline
Proposal:
1. Apply the dynamic color by removing SettingsTutorialDialogWrapperActivity which set extra theme
2. Hanlde the recreate case if shows the dialog directly
3. Update new Illustration in Pixel Lottie asset

Bug: 195980595
Test: Manual test
Change-Id: Ib6267128bbe5522ac8720c15fc2720c9a78f8671
2021-08-18 11:22:08 +08:00
Julia Reynolds
17dda0faec Merge "Rename RadioButtonPreference -> SelectorWithWidgetPreference." 2021-08-05 20:34:13 +00:00
TreeHugger Robot
750dc4a067 Merge "Add back the accessibility gesture tutorial dialog in system navigation" into sc-v2-dev 2021-07-22 18:54:00 +00:00
Yuri Lin
e9f13fbd5e Rename RadioButtonPreference -> SelectorWithWidgetPreference.
This change is to reduce ambiguity as we're adding the option to style the preference like a checkbox as well.

Bug: 190180868
Test: SelectorWithWidgetPreferenceTest, RunSettingsLibRoboTests
Change-Id: Ie414347bf67ed394ef495604890c5851fc42dbc7
2021-07-20 17:01:21 -04:00
Stanley Wang
602f59ba42 Update the illustrations of System navigation page.
- Upate 3 types of navigation illustrations.

Fix: 189426848
Test: robotest and see the UI
Change-Id: Ie56057713d528398a2e3ddad5580c6de2f60bd3f
2021-07-15 19:33:24 +08:00
menghanli
6a2fe65a64 Add back the accessibility gesture tutorial dialog in system navigation
Show the accessibility gesture tutorial dialog when user choose the
system gesture navigation.

Partial rollback from commit 1a0e2b1be5

Bug: 190563948
Test: Manual test
Change-Id: Iabc14cc7f8024b574bc96fe4f5ba8c86e01633e7
2021-06-24 01:18:02 +00:00
Yanting Yang
863d2e50e7 Remove silky flag for searching and help menu
Bug: 183670633
Test: robotests
Change-Id: Ia62936e9f48a111ab36d74b852ec04090e42039a
2021-06-02 16:49:27 +08:00
jasonwshsu
e2c69bcd7b Remove the accessibility gesture tutorial dialog in system navigation
Accessibility gesture is replaced by the accessibility floating menu, remove the accessibility gesture tutorial dialog when choosing to use gesture navigation mode.

cherry picked from commit 1a0e2b1be5

Bug: 173990914
Test: manual test
Change-Id: Iae5297747594fcc73fc9bc14537c8fdecb86b660
Merged-In: Iae5297747594fcc73fc9bc14537c8fdecb86b660
2021-03-17 23:03:45 +08:00
Mill Chen
46cf90af0e Remove search and help menu items from toolbar
Based on the Settings UI guideline, both of search and help menu items
will be removed from toolbar on Android S.

Bug: 179332520
Test: visual verified
1) Settings -> System -> Gestures -> System navigation
2) Observe the toolbar and check if search and help icons are existing

Change-Id: I3d71eddffb8876f936cf56858d0604aba7d4ee4b
2021-02-18 23:29:21 +08:00
Edgar Wang
c0e7328a88 Replace some customized RadioButtonPreferences
- Deleted ZenCustomRadioButtonPreference
- Deleted RadioButtonPreferenceWithExtraWidget
- Replaced with RadioButtonPreference

Bug: 173472216
Test: robotest
Change-Id: I645b59d65ae14af1f384f16ee7b76b3c98e23e1f
2021-01-06 05:37:29 +00:00
menghanli
be11a370e6 Fix gesture navigation popup is displaying inconsistently on the System navigation page.
- Need to use new api to get the accessibility service list.

Bug: 149665916
Test: local test
Change-Id: Ib712769436bf7be5fbea34ba2251bdbe6bcefb95
2020-04-07 22:42:20 +08:00
Mehdi Alizadeh
3857e6f936 Use Gesture nav settings activity instead of dialog
Bug: 146004827
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest

Change-Id: I2d77842b6a470000be818123d845de745ca0318f
2020-03-03 12:03:11 -08:00
Mehdi Alizadeh
3ea61b66af Rename methods to reflect the correct names of nav modes
Bug: 146004827
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationPreferenceControllerTest

Change-Id: I00602c41aed5e675b8e0d3df7a3b3b318e6ec903
2019-12-17 11:39:40 -08:00
Mehdi Alizadeh
58b02e0ed5 Adds search and help icons to system navigation page
Bug: 135042958
Test: Manually verified icons are shown and they work
Change-Id: I1dc9ddd3e3a5a1f76eb6c1f28290e177bb43ba9e
2019-12-10 14:11:14 -08:00
Raff Tsai
966fa01423 Use SettingsLib Indexable
- Use SettingsLib Indexable
- Directly use resource id in getPreferenceScreenResId

Bug: 135053028
Test: roboletric
Change-Id: I05f493b55e8b6e2091301e9231ba5615215618e6
2019-09-25 18:24:56 +08:00
Raff Tsai
ac3e0d0988 Directly use BaseIndexableProvider
- Add function getXmlResourceId, Fragments don't need to write
xml resource id twice.
- Remove getPreferenceControllers from Indexable.java. Because it will
move to SettingsLib later for other apps which don't need this function

Bug: 135053028
Test: robolectric
Change-Id: I1e74519aecdea3dde64a5aea79f08d766dbc0003
2019-09-24 00:35:52 +08:00
Edgar Wang
0f8c7a71d0 Handle Aware sensor status for Always On
- "Always On" preference will be hiden when aware
sensor is available
- Extract NavModeCandidateInfo from SystemNavigationGestureSettings

Bug: 136610131
Test: robotest & manual
Change-Id: If58c70549339b66116f19df7193d85bb04e3f1b7
2019-09-21 07:19:35 +08:00
Raff Tsai
1f30b1cd67 Merge similar BaseSearchIndexProvider code together
Bug: 135053028
Test: robolectric, check search_index.db contains the same items
Change-Id: If3c18a170b0e671690df1fdf26e59a421d2c48cd
2019-09-12 11:09:09 +08:00
Raff Tsai
71a37d138b Import RadioButtonPreference from SettingsLib
Bug: 138620011
Test: manual, robolectric
Change-Id: I3b8a2be021a1b4a07aae61483f2329b7a5bd4655
2019-08-01 07:16:55 +00:00
Mehdi Alizadeh
1aaf41b2dc Removes logic to disable gesture nav when default home app changes
Bug: 137197916
Test: Manual test with setting a 3P launcher as default
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=RadioButtonPreferenceWithExtraWidgetTest
Change-Id: Id397cfa1c2439222aa21a7b7fe5f69818bf1fe97
2019-07-18 15:27:05 -07:00
Mehdi Alizadeh
7d43125964 Show a dialog with a slider to set the back gesture's sensitivity
Bug: 131447780
Test: Manual test on device
Test: make RunSettingsRoboTests ROBOTEST_FILTER=RadioButtonPreferenceWithExtraWidgetTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest

Change-Id: I9fcd1a50c77689118857326de0cf8082e835b491
2019-06-14 23:40:11 +00:00
Kevin Chang
9ff00646d0 Add tutorial dialog for gesture navigation
Add new tutorial dialog for gesture navigation in order to teach
users how to use the gesture

Fixes: 133650388
Test: Manual
Change-Id: I7cc6a950af49044b27cf7ca41e3bcf67ef40b5fd
Merged-In: I7cc6a950af49044b27cf7ca41e3bcf67ef40b5fd
2019-06-06 06:20:49 +00:00
Mehdi Alizadeh
ffea2ae488 Disables the Gesture nav option if 3P launcher is default
Disables the Gesture navigation radio button if 3P launcher is set as
default for current user. Also shows an info icon on the right side that
opens a dialog explaining why it is disables.

Bug: 129532605
Test: Manual test with 3P launcher
Test: make RunSettingsRoboTests ROBOTEST_FILTER=RadioButtonPreferenceWithExtraWidgetTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationPreferenceControllerTest

Change-Id: I90000c74246699fa9391ac042c87d7f0ece03637
2019-05-31 12:26:28 -07:00
Mehdi Alizadeh
36f32a46ca Refactors the System Navigation settings page
Bug: 130915285
Bug: 128855215
Bug: 127718810
Bug: 129115299
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationPreferenceControllerTest

Change-Id: If11e1fe4bf150d2dd9578f731e71abf6b74f5d90
2019-05-13 14:31:20 -07:00
Mehdi Alizadeh
43502549a3 Adds Edge to Edge option in gesture settings page
Bug: 125489141
Test: Manual test on device
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationLegacyPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationSwipeUpPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationEdgeToEdgePreferenceControllerTest
Change-Id: I1b274cc053de8235d0c664150cabe5dadc618419
2019-03-07 14:50:27 -08:00