This can happen if the activity is recreated; our approach doesn't support this case very well. With this change, the dialog is not reshown when the activity is recreated, which is not optimal but better than crashing (as it does today). There is no lost work because it's the first choice, and the follow-on steps (icon picker, etc) can be recreated without problems.
Fixes: 359746551
Test: manual, with don't keep activities
Flag: android.app.modes_ui
Change-Id: I84bdeb0007e8c50ec9dd8af61991c7e55ddb8298
The toggle state used to be set on creation and only changed onSwitchToggled(). But the state can also change when restrictions are applied from outside of settings, or when user is added with toggle being off by default.
This change updates the state during execution of onResume() in Users Settings, which also aligns with the update strategy of other Toggles on this Settings page.
Bug: 362706097
Test: atest MultiUserSwitchBarControllerTest
Flag: EXEMPT bugfix
Change-Id: I8a994b2e0ddb672362e69653374b87f85ae1548c
Currently, this setting depends on whether wifi calling is supported,
since wifi calling could takes some time to provision after sim is
turned on, this state could be wrong when set cross sim calling.
Use wifiCallingReadyFlow() to retrieve the latest state, and update
setting when state changes.
Fix: 352736998
Fix: 348529996
Flag: EXEMPT bug fix
Test: manual - by turn on / off sim
Change-Id: Id4b099e0c5d7cf47b007f37e6f278d1c46e58659
Broadcast <-> unicast costs some time, so we grey out the audio
sharing toggle until the device get active on unicast when users toggle
off the sharing.
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Test: atest
Bug: 359755881
Change-Id: I868a470430f6fb54c142f17552d70fa5fa8a2476
Revert submission 28993807-hdop-cleaup
Reason for revert: Droidmonitor created revert due to b/363275535. Will be verifying through ABTD before submission.
Reverted changes: /q/submissionid:28993807-hdop-cleaup
Change-Id: I89127e1c6e445adb21dbf96c6bbbec8935bf6296
The summary (i.e. description under the toggle title in Android settings) from AutoTimeZonePreferenceController is only used in wifi-only devices, like Tangor. We have found that since V, the summary was no longer displayed in the Date and time settings page. This fix brings the summary back.
Bug: b/363176828
Test: tested on a Tangor tablet
Flag: EXEMPT bugfix
Change-Id: I1f118b8e1d5e0d8d1b0f5b515d79522b72fb4fa4
Whenever setInterruptionFilter() is called with NONE or ALARMS, the Do Not Disturb mode now shows the current policy (nothing allowed or alarms/media allowed), instead of the normal PRIORITY policy. This policy is read-only in the UI since it cannot be customized.
This should be, or at least become, pretty rare (with small exceptions, apps targeting V that call setInterruptionFilter() will use an implicit mode instead of changing the global zen mode, plus using these filters is quite nonstandard in itself).
Fixes: 361586248
Test: atest & manual (toggling DND via cmd shell)
Flag: android.app.modes_ui
Change-Id: If2439480235d30aa310ad8925341183b9761784c
Use this instead of mSubscriptionInfoEntity, so MobileNetworkSettings
not closed unexpectedly.
Bug: 358238959
Flag: EXEMPT bug fix
Test: force stop settings & settings search - mobile settings
Test: adb shell am start -a android.settings.NETWORK_OPERATOR_SETTINGS
Change-Id: I34286da808600d8b9faa0da85a59665707ecfde3
When sub id is invalid.
Bug: 325956182
Flag: EXEMPT bug fix
Test: adb shell am start -a android.settings.NETWORK_OPERATOR_SETTINGS
Change-Id: I09995095e2f38030eca0c9b5898d910530ee6237
Currently in TelephonyProvider, it uses tm.getSimSpecificCarrierId() to
get the specific carrier id to retrieve the apns, update Settings to
match.
Fix: 360917123
Flag: EXEMPT bug fix
Test: manual - new apn
Test: atest ApnRepositoryTest
Change-Id: I982e0026acdf34ccec7508c41f83718894f7da57
The package name doesn't match the one used in
development_memtag_page.xml. This would result in the controller can't
be found when the DashboardFragment trying to instantiate the controller
defined in xml.
Bug: 245624194
Flag: EXEMPT low risk bugfix
Test: Examing the log and verify there is no "Cannot instantiate controller
from reflection" for DevelopmentMemtagFooterPreferenceController
Change-Id: I63ba96d587525c08cf1409883e2bd09bc85bfc41
**Root cause**
The PreferenceController can be constructed by the
SettingsSearchIndexablesProvider where the looper of the thread is not
prepared. This result in not able to construct the PreferenceController
that will be used as part of the SettingsSearch.
Currently, if the SettingsSearchIndexablesProvider is not able to
construct the PreferenceController defined in xml, it would just
silently failed.
Test: atest SettingsUnitTests
Test: atest SettingsRoboTests
Flag: EXEMPT low risk bugfix
Bug: 352622249
Change-Id: I72a4ce24ec6842b9efe067e3cb7d1c73cd98a566
Bug: 326057017
Change-Id: I83ab4461f28e7f40c676099213c840a1a7dc932a
Test: atest; open app info pages from both primary and secondary profile -> verify they open as expected
Flag: EXEMPT bug fix
