AccessPointPreference.refresh() is being called in different threads.
The refresh of the preference should only be updated in the main thread.
When access point updates is received not in the main thread, will post
the refreshing of the preference to the message queue to make the update
on the UI thread.
Test: auto - run monkey to verify there is no ANR or crash
manual - go to Settings->Wifi, toggle on/off many times and verify
there is no crash.
Change-Id: I656a70ecf2e7b9446c7b95b6b42ab19a5cc2e51c
Fixes: 30902893
When we add the preference "Searching for Wi-Fi networks...", we didn't
provide a key to the preference. As a result, each time when we get
access point update and try to show such tile, it creates a new one, and
results in multiple entries of such tile. Adding a key to the preference
will prevent the multiple entry from being added.
Test: Manual -
1. Turn wifi off and on several times, verify that there is only one entry
of "Searching for Wi-Fi networks..." when initializing the wifi access
point list.
2. Verifies that when the access point list is established, the
"Searching for Wi-Fi networks..." entry is gone.
Change-Id: Iaad329d89f8e4b52129d0661501aa34fbd956692
Change-Id: I1bfa77051e068926e8c876a89adf14d143970e7e
Fixes: 31143961
Bug: 30870531
Removing wifi preferences every time will force update create a new set
of preferences, which leads to higher chance of GC.
Change-Id: Ifea2f63a3b54fa0d5861fb34a348d81e99bcab68
Bug: 30870531
Removing wifi preferences every time will force update create a new set
of preferences, which leads to higher chance of GC.
Change-Id: Ifea2f63a3b54fa0d5861fb34a348d81e99bcab68
Made changes to WifiSettings that customizes
the preference icon so that the icon is never
null. This greatly reduces jittering.
Bug: 29979747
Change-Id: I3d2767310513389c09a37e34674a304278f4d0de
(cherry picked from commit 47568de003)
Bug: 30681771
Test: SettingsUnitTests
Refactor visibility logging from InstrumentedFragment into a mixin. And
apply mixin in remaining fragments.
Change-Id: Ibbb59904336254a3e4bb9e8c7d0b36e5a6bc2622
Made changes to WifiSettings that customizes
the preference icon so that the icon is never
null. This greatly reduces jittering.
Bug: 29979747
Change-Id: I3d2767310513389c09a37e34674a304278f4d0de
The background thread is not stopping listening fast enough and is
resulting in first a receiver leak message followed by a crash when
trying to finally unregister the receiver.
Fix this by adding a registerReceiver to SummaryLoader that will
automatically unregister the receiver on the main thread to ensure
it happens in time.
Change-Id: I0104e929d5505eb53993f6765e4c90120df35cf6
Fixes: 28211606
There are still some remaining animation issues on the wifi screen.
To avoid regressions from M, just disable animations on the entire
wifi screen.
Change-Id: Iabf8ace731638ae7af483c6f3887ca351b17ac60
Fixes: 26271353
Disable animations for all SettingsPreferenceFragments, unless they
explicitly ask for them before creating their preference screens.
Turn it on for all fragments using the cached removal currently.
Bug: 27713314
Change-Id: I1bc14e7aeb3ee5b8ddb4f3547f472305cd312edf
Show policy transparency dialog if user tries to modify a
wifi configuration locked by device owner.
Bug: 27375948
Change-Id: I504082282f57bc5de9f097e962d195ecd2cc9da4
Removing all prefs causes ugly animations, so avoid it at all cost
and cache all the prefs (while still added) as long as possible.
Bug: 26271353
Change-Id: I33b84d751938b460f4b66c0158057407dd45d974
When the admin has set disallow_config_wifi, menu items are not added.
we need to check if the menu items can be added after this fragment is
resumed. And for remove account menuitem, check whether any admin has
disabled management of a specific account type.
Change-Id: I58f5a59fe0614c9bc7068b15f43f89527939359d
Add a gear on Settings menu, and move a bunch of stuff from
overflow and advanced screen to there. Also move add network
to be the last item in the list rather than in overflow.
Also fix WifiP2p breakage.
Change-Id: I5c84c25e5ba9224f77dcd988b0b2850ae6e71168
Add a Wi-Fi dialog activity that can be started by setup wizard to
connect to a Wi-Fi access point.
Also refactored mEdit and mModify in WifiConfigController into an
int-enum mMode, with modes view, connect and modify. This is how the
new modes maps to the old flags:
MODE_VIEW -- mEdit = false, mModify = *
MODE_CONNECT -- mEdit = true, mModify = false
MODE_MODIFY -- mEdit = true, mModify = true
Bug: 23426311
Change-Id: I8e2221fd3c42577068e07686dab245dd5888e0ae
Add a OnKeyListener for hardware keyboards and an
OnEditorActionListener for on-screen IMEs to submit the Wi-Fi dialog
with the currently entered information.
Before committing the action, check for whether the dialog is
submittable -- that is checking whether all necessary information has
been entered. If not the enter key behaves the same as it is before
the change.
Bug: 22211604
Change-Id: Idede4233a7385d3bcd8fd6614948270280536bf1
- Fix view recycling for AccessPointPreferences by adding a dummy
during initial inflation
- Cut down on what is done during onBindView and refresh()
- Try to re-use AccessPointPreferences when possible
Some jank still occurs when scan results come in, but it is less
than before.
Bug: 16518752
Change-Id: I2619303281dd50aa3864783c49738ae9f221834a
