Commit Graph

8513 Commits

Author SHA1 Message Date
Goven Liu
483f58ce3c Merge "[Wi-Fi] [a11y] The "Advanced options" should be accessible by Voice Access and pronounced by talkback correctly." 2019-10-18 09:00:07 +00:00
Raff Tsai
dfba9a0f6d Change Panels creation interface to take a bundle
Fixes: 124399577
Test: robolectric
adb shell am start -a android.settings.panel.action.WIFI
adb shell am start -a android.settings.panel.action.VOLUME

Change-Id: I9e13357444e4ebeee50fb8cc68fbc974ce5fffb6
2019-10-18 13:21:18 +08:00
TreeHugger Robot
4b4b7e76c4 Merge "Hide search box if it is called in initial setup wizard" 2019-10-18 04:00:32 +00:00
Raff Tsai
c898775914 Hide search box if it is called in initial setup wizard
- Search box is hidden if user set intent extra isSetupFlow true

Fixes: 135717823
Test: search box is hidden in the following command
adb shell am start -a android.settings.SETTINGS --ez isSetupFlow true

Change-Id: Ia3d955c9390d6b0eef9391b9b35b6a483eb63d26
2019-10-18 02:08:38 +00:00
Philip P. Moltmann
0b0a500833 Switch to new internal API
Test: atest RunSettingsRoboTests
Change-Id: I2ecfa651031bcb431f28d55512cf93c442686d71
2019-10-17 09:01:24 -07:00
govenliu
116060e011 [Wi-Fi] [a11y] The "Advanced options" should be accessible by Voice Access and pronounced by talkback correctly.
The checkbox is unclickable via Accessibility.

Solution: Refine the solution of b/30079196 to let checkbox be focusable and clickable by Accessibility, and remove unnecessary Accessibility pronunciation strings.

Bug: 141588638
Bug: 141588161
Test: Add unit test to check the content description of the checkbox.
Change-Id: I2e7932f64ae29a13b793276eab6705009af20104
2019-10-17 17:10:17 +08:00
Pavel Grafov
7bdfda7775 Merge "Password constraints cleanup." 2019-10-16 17:49:12 +00:00
Pavel Grafov
69cac2c986 Password constraints cleanup.
Unified password validation code between DPMS and Settings.

Bug: 138375712
Test: atest tests/robotests/src/com/android/settings/password/ChooseLockPasswordTest.java
Change-Id: I55e4dae47526659594af3fcdbfc1292edceb5807
2019-10-16 15:36:21 +01:00
TreeHugger Robot
fd747e663c Merge "[Wi-Fi] Refine code for saved AccessPoints" 2019-10-16 08:55:30 +00:00
TreeHugger Robot
56aa5f831d Merge "Update string" 2019-10-16 08:43:50 +00:00
Kevin Chang
5f39bd261f Merge "Change string of switchbar and installed service category title" 2019-10-16 08:12:38 +00:00
Arc Wang
21683140e9 [Wi-Fi] Refine code for saved AccessPoints
SubscribedAccessPointsPreferenceController extends from
SavedAccessPointsPreferenceController to remove duplicate
code.

Bug: 127206629
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi.savedaccesspoints
      Manual: Add and forget Wi-Fi accesspoints and observe UI display.

Change-Id: Ia494117ae98f043ce65b2f9f6e4b4daccc8df543
2019-10-16 07:52:45 +00:00
Raff Tsai
65866290ce Add tablayout for work/personal profile
- Add Tablayout in ProfileSelectFragment
- Add AccountWorkProfileDashboardFragment inherited from
ProfileSelectFragment
- Add ProfileFragmentBridge to convert AccountDashboardFragment
to AccountProfileSelectFragment
- Use flag settings_work_profile to guard the new fragment

Bug: 141601408
Test: Settings->developer options->feature flags->
turn settings_work_profile on/off, then go to settings->account
to see if UI is changed.

Change-Id: Ifb32c22cdeab69c51517664081cacf4a401c46a1
2019-10-15 18:01:08 +08:00
Rubin Xu
7a3ebe7c61 Merge "Introduce LockscreenCredential" 2019-10-14 13:45:15 +00:00
hughchen
946c6f0dfe Update string
Change the headers from:
"Available media devices" → "Media devices"
"Available call devices" → "Call devices"
"Currently connected" → "Other devices"

Bug: 110920548
Test: manually
Change-Id: Idf283576353c9f65caa15ba8beca39f24721caa5
2019-10-14 16:16:24 +08:00
Kevin Chang
a6308c09a8 Change string of switchbar and installed service category title
Bug: 122897712
Test: Visual
Change-Id: I0f56b4b7375e651a74189dd17e6b3bd8b99ccfca
2019-10-14 11:05:59 +08:00
Rubin Xu
010116a173 Introduce LockscreenCredential
Bug: 65239740
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.password
Change-Id: Icb73d639291d6d2eda8015e18e93d0906f916bb2
2019-10-13 21:20:02 +01:00
Julia Reynolds
3b10e450cb Rename class
Test: atest
Bug: 137397399
Change-Id: Idae73251bb67fbef2cf29f730f1420e98e38a8f3
2019-10-11 11:45:51 -04:00
Arc Wang
abe59ac849 Merge "[Wi-Fi] Refine code for saved AccessPoints" 2019-10-09 11:15:16 +00:00
Arc Wang
1f7d2dc54c [Wi-Fi] Refine code for saved AccessPoints
The change targets to refine SavedAccessPointsPreferenceController and
SubscribedAccessPointsPreferenceController

1. Remove feature flag check for saved Passpoint display.
2. They do not implements WifiManager.ActionListener.
3. Separate the code to collect saved AccessPoints data and the code to
   update preferences.
4. Let getAvailabilityStatus() returns result according to the saved
   AccessPoints data.
5. Update preferences at SavedAccessPointsWifiSettings#onStart()
   instead of life cycle onStart() of these 2 controllers.
   This is for the change of 2.
6. Do not use PreferenceGroupChildrenCache in
   SubscribedAccessPointsPreferenceController, this is for code
   alignment of SavedAccessPointsPreferenceController.
   Now these 2 controllers have very similar design, it will be easier
   to refine SubscribedAccessPointsPreferenceController as a child of
   SavedAccessPointsPreferenceController.

Bug: 127206629
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi.savedaccesspoints
      Manual: Add and forget Wi-Fi accesspoints and observe UI display.

Change-Id: Id6f95d5b64e57a98c2c2e6ab09a4dec70a71b615
2019-10-09 08:56:36 +00:00
Arc Wang
ccf9715464 Merge "[A11Y] Improve data usage chart TalkBack content" 2019-10-09 07:17:24 +00:00
Arc Wang
351ee3a882 [A11Y] Improve data usage chart TalkBack content
1. Set null content description for all labels of the chart.
2. Set 2 parts in the content description of the chart:
  I.  Brief description of the chart.
  II. Stats of the data usage.

Bug: 141093026
Test: ChartDataUsagePreferenceTest
      Manually listen to TalkBack speaking
Change-Id: I82cefd9987793f40a5bba5bf3ea5f4017da37640
2019-10-09 10:20:15 +08:00
Goven Liu
a4ef70fa22 Merge "[Wi-Fi] Un-relevant string flash then disappear in WiFi direct page." 2019-10-07 06:06:47 +00:00
govenliu
623e8570b9 [Wi-Fi] Un-relevant string flash then disappear in WiFi direct page.
The "PEER DEVICES" and "REMEMBERED GROUPS" two strings appear then disappear suddenly.

Solution: Set those two PreferenceGroups, which with empty preference
child, invisible before showing.

Bug: 141830944
Test: 1.Manual test. 2.Modify isAvailable() test case for make sure the
initial visible of empty group is invisible.
Change-Id: Ifb074ac758196096ca63b6f7fa1285f8148d98d4
2019-10-07 12:03:34 +08:00
Jason Chiu
92cd7b40f3 Merge "Refactor Settings for injection v2 inline toggle" 2019-10-07 03:46:05 +00:00
TreeHugger Robot
2f6fe971d0 Merge "Tethering shouldn't indicates on when SIM without tethering option" 2019-10-07 02:50:01 +00:00
SongFerngWang
d9ebbb93d0 Preferred network list add 5G item am: dd7f9b57f6
am: a72e1c4612

Change-Id: I734eb57e32fe51bdc1570da86fd66c3b16b99f7f
2019-10-06 09:26:02 -07:00
SongFerngWang
a72e1c4612 Preferred network list add 5G item
am: dd7f9b57f6

Change-Id: I70f89c6c5e5c43107788c58f1fc3ca44383b4ce5
2019-10-06 09:20:09 -07:00
Jason Chiu
1a1f9314b6 Refactor Settings for injection v2 inline toggle
Bug: 132808482
Test: robotest
Change-Id: I0b74e05bc26b97259a15859c669060ce3da7972a
2019-10-04 18:32:11 +08:00
TreeHugger Robot
ab1277f6a5 Merge "Fix the display abnormal of Tap & pay screen in landscape mode" 2019-10-04 08:33:20 +00:00
hughchen
d6ec2ac7be Tethering shouldn't indicates on when SIM without tethering option
Before this CL, If SIM doesn't have tethering option then UI will not
back to previous option when press "USB tethering" in
[Default USB configuration].

This CL added receiver to observe USB state that get correct state
from UsbManager.

Bug: 138630479
Test: make -j42 RunSettingsRoboTests
Change-Id: I6cc8da508f6ab142142ca8c28460125bad93925b
2019-10-04 15:41:45 +08:00
SongFerngWang
dd7f9b57f6 Preferred network list add 5G item
Preferred network list add 5G item, and change "recommended" from 4G to
5G, and add summary for 5G.

Bug: 138544359
Test: 1.fake the device network type bitmask to 5G, UI show 5G list
2.atest EnabledNetworkModePreferenceControllerTest.java :pass

Change-Id: I4a78e2e7fbb067ce841df4aaf1d5161607fdcf90
2019-10-04 04:53:31 +00:00
Goven Liu
834c301139 Merge "[Wi-Fi] Wrong MAC address shown in Settings." 2019-10-04 01:13:03 +00:00
Raff Tsai
a80a7c16f2 Merge "Remove summary provider" 2019-10-03 15:23:21 +00:00
govenliu
228cf200ae [Wi-Fi] Wrong MAC address shown in Settings.
The MAC addresses in "About phone" and "Saved networks" may be different
because of new Randomized MAC mechanism.

1.Add new UIs to guide users to saved network and use different titles to
show different conditions.
2.Remove MAC address and IP fields in WifiPreference by new design.

Bug: 133466540
Test: add test case to check if the title changed according to the
privacy level.

Change-Id: Idb5972dc2565f6fe58a83f6aa7124abbc035888f
2019-10-03 19:36:58 +08:00
Sunny Shao
3526f666a8 Fix the display abnormal of Tap & pay screen in landscape mode
- Add a new layout for the landscape mode.
- Update the logic to show image when has no any visible preference.

Bug: 141559275
Test: manual view
make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.nfc
Change-Id: Ib59ad3347e0635c07d61d557d75f8feaf78ff23c
2019-10-03 18:56:36 +08:00
Raff Tsai
590042b3ba Hide sliceView if Slice is null
Fixes: 142035673
Test: robolectric, visual
Change-Id: I2b5b34d068ba4590f65a284d4f62a1cc77f9666f
2019-10-03 17:23:35 +08:00
Raff Tsai
6db277ebb7 Remove summary provider
- use SummaryProvider to provide the summary of UserSettings
- use WifiDisplayPreferenceController to replace the summary loader
in WifiDisplaySettings
- use ConfigureNotificationPreferernceController to replace the
sumary load in ConfigureNotificationSettings

Fixes: 141653158
Test: robolectric
Change-Id: Id5f5ed645707caa0b25ecae5252174cbf017651c
2019-10-03 15:04:36 +08:00
Raff Tsai
9e3a9fd255 Add fragment in xml instead of using injected way
- It can improve performance because we use less injected item
- Also remove summary provider from those fragments

Bug: 141653158
Test: robolectric
Change-Id: I6255f71b3b8300aea064a4fefd6711c1ff59e08a
2019-10-02 11:49:51 +08:00
Bonian Chen
f726a31457 Merge "[Settings Telephony] Carrier name API replacement" into qt-qpr1-dev
am: 556b34d03d

Change-Id: Ibffb60c57aa4152b4681f3fe95dae7175f2e878e
2019-10-01 19:53:31 -07:00
Bonian Chen
c7c84d2c87 [Settings Telephony] Carrier name API replacement
Replacing TelephonyManager.getNetworkOperatorName() by
Obtaining carrier name from SubscriptionInfo.getCarrierName().

TelephonyManager.getNetworkOperatorName() only be used when there's no
SubscriptionInfo can be found.

Bug: b/140443508
Test: Manual testing
  atest MobileNetworkUtilsTest
  atest OpenNetworkSelectPagePreferenceControllerTest

Change-Id: I7a86395c86d31fe2ba54c04ac16b1a0ebfc843f3
2019-10-01 17:59:43 +00:00
Bonian Chen
527a43530e Merge "[AutoTest] Settings Telephony part" 2019-10-01 11:13:25 +00:00
Mill Chen
649ec4ba16 Merge "Fix BatteryInfo test case failures" 2019-10-01 11:01:29 +00:00
Mill Chen
0ac194de10 Fix BatteryInfo test case failures
Fixes: 141901539
Test: robotests
Change-Id: I63140c36996e463862bb2dc77d26acdaa96530b2
2019-10-01 08:53:38 +00:00
Bonian Chen
199cae427b [AutoTest] Settings Telephony part
Change design to avoid using Robolectric.setupActivity()

Bug: 140707056
Test: make RunSettingsRoboTests ROBOTEST_FILTER=EuiccPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=DataServiceSetupPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=ApnPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkActivityTest
make RunSettingsRoboTests ROBOTEST_FILTER=DataUsagePreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=ApnEditorTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkSummaryControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=SubscriptionsPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkListControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkPreferenceControllerTest

Change-Id: Ifacd2e6c8733d8e814a277cf34d6f7eb1a9ddba4
2019-10-01 16:15:59 +08:00
TreeHugger Robot
14772ca9f2 Merge "Fix FaceSetupSlice test cases failure." 2019-10-01 08:13:21 +00:00
Yi-Ling Chuang
8a4cf7c903 Fix FaceSetupSlice test cases failure.
Fixes: 141900531
Test: robotests
Change-Id: I0c68928e99b9fe12ae8d41b37a173ec1b1ecf44c
2019-10-01 14:58:42 +08:00
Raff Tsai
129c98bba1 Remove summary loader in some fragments
- Summary Loader only works in injected items, but those fragments
are not injected to Settings UI. The SummaryLoader class them are
useless.

Bug: 141653158
Test: robolectric
Change-Id: I1ca0bf5a1f417b7fe86b28e96aff7d4aee2cf2d3
2019-10-01 10:02:26 +08:00
Kevin Chyn
7ce886bdd7 Fix FaceSetupSliceTest am: acde97cf90
am: a9c14ab4b1

Change-Id: Ic96ff261766e750e0fff6b3ff73e21d0588b0222
2019-09-28 01:20:03 -07:00
joshmccloskey
be7d733886 Added different flow for re-enrollment am: bba7632f28
am: 3511ad89ca

Change-Id: I2b06407f4df37f8d16f95c6068de0ac3523df293
2019-09-27 18:38:20 -07:00