Commit Graph

53584 Commits

Author SHA1 Message Date
Jason Chiu
d1b0ad25fa Suppress rawData settings from indexing when page is disabled for search
Test: robotest, manual
Fix: 324424783
Change-Id: Ie8423d16df387f13cf35c03005640cfd08a5b492
2024-05-28 17:26:18 +08:00
Xinyi Mao
a05fab6dc5 Merge "Update view alpha to improve text color constract in Battery usage" into main 2024-05-21 05:39:46 +00:00
Chaohui Wang
e0d86be017 Fix default mode for AlarmsAndRemindersAppList am: 83aeb45f3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/27391745

Change-Id: Ib16f3abadd2428f090ff9f28c9ea5045f64897be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-21 05:35:34 +00:00
Roy Chou
575259e049 Merge changes Ife935485,Ic9b44d73,I44f7f058,I39868ac1,I05c59a76 into main
* changes:
  chore(magnification suw): hide joystick toggle in setup wizard
  chore(magnification suw): hide one finger pan toggle in setup wizard
  refactor(magnification suw): hide follow typing toggle in setup wizard
  chore(magnification suw): hide always on toggle in setup wizard
  chore(magnification suw): create MagnificationFeaturePreferenceController
2024-05-21 05:25:12 +00:00
mxyyiyi
431c14fa18 Update view alpha to improve text color constract in Battery usage
- For light themes, first set the text color of title/summary/widget_summary to be consistent, then apply alpha = 0.65

[Before] https://screenshot.googleplex.com/4nVMMFBK7odhQju
A11y Scanner result: https://screenshot.googleplex.com/4nVMMFBK7odhQju

[After] https://screenshot.googleplex.com/B4r79v89HnWr4tw
A11y Scanner result: https://screenshot.googleplex.com/3zQfRMe4HToc8Xm

Dark mode:
[before] https://screenshot.googleplex.com/BfLxR6tqQRgP4mQ
[after]  https://screenshot.googleplex.com/8KeG62i7R5hW8Ks

Bug: 317139415
Bug: 265364351
Test: Accessibility Scanner
Change-Id: I65a71525bbce41c37ee364f3f73c0d2d1d9ace38
2024-05-21 11:52:49 +08:00
Chaohui Wang
83aeb45f3c Fix default mode for AlarmsAndRemindersAppList
When app ops permission's app ops mode is default, should check if
permission is grant.

Fix: 339846642
Test: manual - on AlarmsAndRemindersAppList
Test: unit test
Change-Id: Ia0f05211f5774637304502ead79dd98a1cf89886
2024-05-21 03:37:47 +00:00
Roy Chou
a511ddb75a chore(magnification suw): hide joystick toggle in setup wizard
Although we haven't implemented joystick feature, but the joystick
preference controller is already in the codebase, so we also add hiding
logic for joystick toggle when in setup wizard.

Bug: 340721852
Flag: NONE
Test: manually
      atest MagnificationJoystickPreferenceControllerTest
Change-Id: Ife93548583c3e82eac030e6e3aa55b9f643b055a
2024-05-21 03:37:37 +00:00
Roy Chou
f094c19d0a chore(magnification suw): hide one finger pan toggle in setup wizard
Bug: 340721852
Flag: NONE
Test: manually
      atest MagnificationOneFingerPanningPreferenceControllerTest
Change-Id: Ic9b44d73f75b47e6b97c5f4994b2e0b23bfb623b
2024-05-21 03:37:12 +00:00
Roy Chou
c9d3b39a62 refactor(magnification suw): hide follow typing toggle in setup wizard
Originally we cache mFollowingTypingSwitchPreference in fragment so in
ToggleScreenMagnificationPreferenceFragmentForSetupWizard we can set the
preference visible to false to hide it. After creating MagnificationFeaturePreferenceController,
the MagnificationFollowTypingPreferenceController can extend it and
check isInSetupWizard internally then dicide whether to hide. Therefore,
we don't need to cache mFollowingTypingSwitchPreference in fragment
and let the fragment control the preference visibility anymore.

Bug: 340721852
Flag: NONE
Test: manually
      atest MagnificationFollowTypingPreferenceControllerTest
      atest ToggleScreenMagnificationPreferenceFragmentForSetupWizardTest
      atest ToggleScreenMagnificationPreferenceFragmentTest
Change-Id: I44f7f0589b2df3d83a27139323fc68a0561f1cfa
2024-05-21 03:36:51 +00:00
Roy Chou
3761f61c7e chore(magnification suw): hide always on toggle in setup wizard
Bug: 340721852
Flag: NONE
Test: manually
      atest MagnificationAlwaysOnPreferenceControllerTest
Change-Id: I39868ac1d4423584e43473683db20a2259311049
2024-05-21 03:36:38 +00:00
Roy Chou
9780020f6b chore(magnification suw): create MagnificationFeaturePreferenceController
Add a new abstract class MagnificationFeaturePreferenceController
that extends TogglePreferenceController, to wrap inSetupWizard
setter/getter. Then for magnification feature preference controllers
like alwaysOn or followTyping, they can just check isInSetupWizard to
decide whether hiding in setup wizard.

Besides, in ToggleScreenMagnificationPreferenceFragment we cache a flag
mInSetupWizard when fragment created, so we can pass the info to the
preferece controllers when creating them.

Bug: 340721852
Flag: NONE
Test: build pass
Change-Id: I05c59a766219862117d2a6ede775d68a4c3dedac
2024-05-21 03:36:06 +00:00
Chaohui Wang
7a8d8fd091 Reapply "Migrate AppOps"
This reverts commit 19b01bd68b.

Bug: 341016088
Test: manual - on Special app access
Change-Id: I000274ae9c725f848e1c8910120ba886fcc5be95
Merged-In: I000274ae9c725f848e1c8910120ba886fcc5be95
2024-05-21 03:20:04 +00:00
Treehugger Robot
1a5eb3ed59 Merge "Avoid update the le audio mode as bluetooth turn off" into main 2024-05-20 22:36:48 +00:00
Joshua Mccloskey
03a0812931 Merge "UDFPS Enrollment Refactor (4/N)" into main 2024-05-20 21:53:16 +00:00
Julia Reynolds
f60595d0d5 Merge "Fix test failures" into main 2024-05-20 18:24:42 +00:00
Julia Reynolds
44044a1898 Fix test failures
Test: ZenModesBackendTest
Flag: android.app.modes_ui
Fixes: 341693051
Change-Id: I4149db371a85abe8008c10cf76a84206f75143f6
2024-05-20 13:31:40 -04:00
Yuri Lin
fdb948df20 Add mode names to search results dynamically.
The resulting search result takes the user to the modes aggregator page.

Flag: android.app.modes_ui
Bug: 332937523
Test: ZenModesListPreferenceControllerTest, manual with modes_ui on and off
Change-Id: I7372307cb995667f6f7234530a3140f5295ab06a
2024-05-20 11:29:29 -04:00
Treehugger Robot
1b1c159d9f Merge "Kill tasks that are neither visible nor in focus" into main 2024-05-20 14:27:25 +00:00
Julia Reynolds
1be83b6466 Merge "Some minor additions (icons, sorting) to modes" into main 2024-05-20 12:34:12 +00:00
Chaohui Wang
c6b49c4f99 Merge "Sort selectable subscriptions by sim slot index" into main 2024-05-20 08:35:41 +00:00
Edgar Wang
ea5e44f1d7 Merge changes I53ea81ce,I84505033,I4bd5c343 into main
* changes:
  Apply round corner group background for large screen
  Update suggestion card padding in Homepage
  Update Search Bar layout in Homepage
2024-05-20 08:29:03 +00:00
Edgar Wang
542cd44266 Apply round corner group background for large screen
Bug: 340510477
Test: manual

Change-Id: I53ea81cee3b6bf543a71237030a61df6aef0e967
2024-05-20 06:49:24 +00:00
Edgar Wang
66c16d57af Update Search Bar layout in Homepage
Bug: 340513864
Bug: 340773713
Bug: 340799397
Bug: 340759836
Test: visual
Change-Id: I4bd5c3438aa55ca764f61b180a37c10206ee78be
2024-05-20 06:49:12 +00:00
Faye Yan
a7065f4d36 Revert "Add Voice activation apps into Settings->Apps->Special a..."
Revert submission 25108596-va-special-access

Reason for revert: voice activation is not going in V

Reverted changes: /q/submissionid:25108596-va-special-access

Bug: 306447565
Bug: 393727896

Test: presubmit

Change-Id: I4977e7d543cb800fc9fb6962bba3afebb9480dcc
Merged-In: I4977e7d543cb800fc9fb6962bba3afebb9480dcc
2024-05-20 11:56:48 +08:00
Faye Yan
f6b5904511 Revert "Add Voice activation apps into Settings->Apps->Specific app->AppInfo->Voice activation apps"
This reverts commit 7f2fbc2e4c.

Reason for revert: voice activation is not going in V

Test: manual - on Special app access
Change-Id: Idfabfd48f45d2ace7de9f8498181f281ad0358a1
Merged-In: Idfabfd48f45d2ace7de9f8498181f281ad0358a1
2024-05-20 11:56:47 +08:00
Chaohui Wang
ec8ce02ba4 Sort selectable subscriptions by sim slot index
To match the sorting order in
SubscriptionManagerService.getAvailableSubscriptionInfoList.

Fix: 340361264
Test: manual - on SIMs
Test: unit test
Change-Id: I06b6c61304f9e6c9515b5f989294417ac3f82a60
2024-05-20 11:38:58 +08:00
Chaohui Wang
fb48926fe8 Reapply "Migrate AppOps"
This reverts commit 19b01bd68b.

Bug: 339846642
Test: manual - on Special app access
Change-Id: I000274ae9c725f848e1c8910120ba886fcc5be95
2024-05-20 10:39:30 +08:00
Chris Antol
c4c5ad5642 Merge "Fix NPE in AudioSwitchPreferenceController" into 24D1-dev 2024-05-17 16:19:32 +00:00
Aurélien Pomini
5c8d8a295b Merge "Remove old contrastDialog from dev options" into main 2024-05-17 16:10:36 +00:00
ELIYAZ MOMIN
67c0cd96d9 Revert "Migrate AppOps" am: 19b01bd68b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/27382787

Change-Id: Iaa26113d70e2ee8792aa75bc625b2c68bc50f81d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-17 14:52:17 +00:00
Julia Reynolds
b42553dccc Some minor additions (icons, sorting) to modes
Test: manually viewing pages
Flag: android.app.modes_ui
Fixes: 331429435
Fixes: 308819461
Bug: 322373473
Change-Id: I17e6df82e17a4cfadc2948258829746cdb5473db
2024-05-17 14:21:54 +00:00
Manish Singh
9447b63197 Kill tasks that are neither visible nor in focus
Bug: 336754145
Test: manual
Change-Id: I559886b172c0f2e6a5d9882f8109b8d51644315c
2024-05-17 13:22:42 +00:00
ELIYAZ MOMIN
19b01bd68b Revert "Migrate AppOps"
Revert submission 27392016-cherrypick-AppOpsController-AppOps-w48m53c1or

Reason for revert: <Potential culprit for b/341210811- verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Reverted changes: /q/submissionid:27392016-cherrypick-AppOpsController-AppOps-w48m53c1or

Change-Id: Ib9813a48170f4ef38de9eee811c677ad75f5401e
2024-05-17 10:48:57 +00:00
Yiyi Shen
66b69fbbb8 Merge "[Audiosharing] Migrate feature from overlay to Settings" into main 2024-05-17 09:30:14 +00:00
Xinyi Mao
4f1920f215 Merge "Update view alpha to improve text color constract in Battery usage" into main 2024-05-17 08:39:08 +00:00
Manish Singh
29cd25e8a8 Merge "Apply the AlertDialog theme" into main 2024-05-17 08:08:44 +00:00
mxyyiyi
0903173391 Update view alpha to improve text color constract in Battery usage
- Update alpha of dark theme from 0.5 to 0.65

[Before] https://screenshot.googleplex.com/3UZicUb7iQa7ovh
A11y Scanner result: https://screenshot.googleplex.com/36wWZDoyJwRy4AK

[After] https://screenshot.googleplex.com/6LRyQMhw2xX6RKk
A11y Scanner result: https://screenshot.googleplex.com/4tWu4RW7VPdJUCP

Bug: 317139415
Bug: 265364351
Test: Accessibility Scanner
Change-Id: I5c1c5c321301da7b148b911a9687a258cc15c87d
2024-05-17 15:24:40 +08:00
Hakjun Choi
f0d2581cd3 Merge "Add activity expose condition for Satellite messaging activity" into main 2024-05-17 07:16:23 +00:00
Chaohui Wang
d005d01a12 Merge "Fix CellInfoUtilTest" into main 2024-05-17 07:06:03 +00:00
Chaohui Wang
d5d70536e8 Migrate AppOps am: 4573df2aaf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/27378716

Change-Id: I2f099b8dd3c205f1eb467b3fc3d03a19cc978b74
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-17 06:31:51 +00:00
Treehugger Robot
ae230aa12c Merge "Fixed issue with pattern not appearing disabled." into main 2024-05-17 04:38:45 +00:00
Chaohui Wang
6f01512762 Fix CellInfoUtilTest
Fix: 337417936
Fix: 337417222
Test: unit test
Change-Id: I47dfa05fd4839885ad7f2115a279a7b4675e85fc
2024-05-17 12:29:58 +08:00
Chaohui Wang
4573df2aaf Migrate AppOps
Bug: 339846642
Test: manual - on Special app access
Change-Id: I988bdf85036478d8e6d87a3b5a1a46a35df38422
2024-05-17 02:57:31 +00:00
Chaohui Wang
201ca1e202 Merge "Create VoNrRepository" into main 2024-05-17 02:21:31 +00:00
Joshua McCloskey
ee5ddeda6f Fixed issue with pattern not appearing disabled.
Test: Verified that the pattern option now appears disabled when
setting up COPE profile
Fixes 288081292

Change-Id: I43992dc4518a47a41e58e7b9cfd47fb22542e749
2024-05-16 19:13:24 +00:00
Manish Singh
a270176634 Apply the AlertDialog theme
so that the correct colors are applied when the system contrast is
changed.

Bug: 335712994
Test: manual
Change-Id: I2f6ba3360fc4935db302e8d89f4df8d200a43a29
2024-05-16 18:26:34 +00:00
Isaac Chai
504ac0cf2a Merge "Color correction saturation level settings" into main 2024-05-16 17:27:26 +00:00
Hakjun Choi
2bc6d77cbf Add activity expose condition for Satellite messaging activity
In case carrier_enabled_satellite_flag or KEY_SATELLITE_ATTACH_SUPPORTED_BOOL is not supported, activity invocation intent will be ignored.
Because the guidance description of the activity cause misunderstanding to users when the satellite feature is not set properly.

Bug: 338377564
Test: manual test adb shell am start -a "android.settings.SATELLITE_SETTING" --ei sub_id (test sub id) for each key's enable/disable combination for KEY_SATELLITE_ATTACH_SUPPORTED_BOOL and carrier_enabled_satellite_flag
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:308ced3fc8e69378611ce333ed5f0e8337ff91fe)
Change-Id: Ib5401f433f802e7aa74cc175179776deb576edfc
2024-05-16 15:32:30 +00:00
Aurélien Pomini
22119f516a Remove old contrastDialog from dev options
Flag: NA
Bug: 333905689
Test: treehugger, manual

Change-Id: I400ab2b14cf8589be97123f3bcf3b26c98009d07
2024-05-16 13:15:23 +00:00
Chaohui Wang
3e8e8ff87e Create VoNrRepository
Migrate to flow and not call setVoNrEnabled in main thread.

Fix: 339846642
Fix: 339542743
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I27fe7cb2ddadc9a0aaa8c589af4703210b33612d
2024-05-16 14:50:16 +08:00