Commit Graph

104491 Commits

Author SHA1 Message Date
Edgar Wang
019eb77224 Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:51:09 +00:00
Edgar Wang
f600c05a5a Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:50:33 +00:00
Edgar Wang
f8f45888e6 Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:50:03 +00:00
Edgar Wang
1b9da55a31 Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:49:26 +00:00
Edgar Wang
aeb36e5c28 Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:48:46 +00:00
Edgar Wang
b3eecdd13d Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:47:24 +00:00
Edgar Wang
a4a14e9bdc Merge "Fix LaunchAnyWhere in AppRestrictionsFragment" into tm-dev 2022-04-13 04:38:57 +00:00
Edgar Wang
b6582aa68c Merge changes from topic "presubmit-am-5513fca9a4904e75827e4e4077587542" into tm-mainline-prod
* changes:
  [automerge] Fix LaunchAnyWhere in AppRestrictionsFragment 2p: 90e095dbe3
  Fix LaunchAnyWhere in AppRestrictionsFragment
2022-04-13 04:38:57 +00:00
Edgar Wang
2c52db547b Merge changes from topic "presubmit-am-020809e13415452dbdf7bee571efa369" into tm-mainline-prod
* changes:
  [automerge] Index the gesture options in System Navigation Settings page 2p: 257ebe4a5e
  Index the gesture options in System Navigation Settings page
2022-04-13 04:34:04 +00:00
Edgar Wang
5a539c5cb2 Merge "Index the gesture options in System Navigation Settings page" into tm-dev 2022-04-13 04:34:04 +00:00
Edgar Wang
e40e18c10d Merge changes from topic "presubmit-am-020809e13415452dbdf7bee571efa369"
* changes:
  [automerge] Index the gesture options in System Navigation Settings page 2p: 257ebe4a5e 2p: 739a359b07
  [automerge] Index the gesture options in System Navigation Settings page 2p: 257ebe4a5e
  Index the gesture options in System Navigation Settings page
2022-04-13 04:34:04 +00:00
Edgar Wang
f797153708 Merge "Fix "Factory Reset" fails to reset the device" into tm-dev 2022-04-13 04:33:07 +00:00
Edgar Wang
e19f7f4222 Merge changes from topic "presubmit-am-d486feda52034c51a2dd75eb56afa2c2" into tm-mainline-prod
* changes:
  [automerge] Fix "Factory Reset" fails to reset the device 2p: f8739eda93
  Fix "Factory Reset" fails to reset the device
2022-04-13 04:33:07 +00:00
Edgar Wang
8f0606d350 Merge changes from topic "presubmit-am-d486feda52034c51a2dd75eb56afa2c2"
* changes:
  [automerge] Fix "Factory Reset" fails to reset the device 2p: f8739eda93 2p: 8b50a41576
  [automerge] Fix "Factory Reset" fails to reset the device 2p: f8739eda93
  Fix "Factory Reset" fails to reset the device
2022-04-13 04:33:07 +00:00
Presubmit Automerger Backend
68c5cbbf29 [automerge] [Security] Verify the permission first before querying installed apps 2p: 42d5979f69 2p: cc44f71530
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17730673

Bug: 227753723
Change-Id: Ia961edd92d096c60e9cc4826dc4d57aa168f9ddb
2022-04-13 03:27:22 +00:00
Presubmit Automerger Backend
cc44f71530 [automerge] [Security] Verify the permission first before querying installed apps 2p: 42d5979f69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17730673

Bug: 227753723
Change-Id: I6d6e57e086a694b992d847eca7f91617be3ef4d0
2022-04-13 03:27:15 +00:00
ykhung
42d5979f69 [Security] Verify the permission first before querying installed apps
Verify the target app "REQUEST_IGNORE_BATTERY_OPTIMIZATIONS" permission first before querying installed apps information to avoid the exposed the installed apps information and improve the performance by applying the early return flow.

Bug: 227753723
Test: make RunSettingsRoboTests
Change-Id: Ib5826b8082f4bf14f93d5ff4d2d332dc395bf9a8
2022-04-13 03:27:06 +00:00
PETER LIANG
45824fe888 Merge "Fix that device isn't responding for a while when resetting all settings on “Display size and text” page." into tm-dev am: 8bd6647885 am: 0d32cefec6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17614845

Change-Id: I34e74968dd35c195d7a80af1e6956e6baf349293
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 01:29:43 +00:00
Presubmit Automerger Backend
8eadfcd0d6 [automerge] Fix that device isn't responding for a while when resetting all settings on “Display size and text” page. 2p: 09a2a49bd3 am: 74dd53583b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17614845

Change-Id: I76f447e38c77aff30b587694088d053d50a524c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 01:25:25 +00:00
TreeHugger Robot
4b92f32bce Merge "Add missing extra when launching apps" into tm-dev am: 14a3861f0b am: 628dd51d0d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17721989

Change-Id: I8dabb8240062f5e1af7aac7ae9ead69c40c26f66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 01:21:46 +00:00
Julia Reynolds
773c7e937e [automerge] Add missing extra when launching apps 2p: 87bb1b34c5 am: 3d8de3e21f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17721989

Change-Id: I305aa504ba2c4b242078341b9af15e62b8a25a04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 00:52:16 +00:00
PETER LIANG
c18637a51f Merge "Fix that device isn't responding for a while when resetting all settings on “Display size and text” page." into tm-dev am: 8bd6647885
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17614845

Change-Id: Ia7c99a555600f57989dcecd6afe7235640282a1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 00:44:51 +00:00
PETER LIANG
0d32cefec6 Merge "Fix that device isn't responding for a while when resetting all settings on “Display size and text” page." into tm-dev am: 8bd6647885
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17614845

Change-Id: I8337840a07930756098dcc2809a71141c38766fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 00:44:15 +00:00
Julia Reynolds
110a86073e Merge "Fix some history issues" into tm-dev am: b28925ad48 am: e2ef0bcdfc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17710594

Change-Id: I85b0462d686e9893982588e5d5cb606faaa781ca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 00:43:55 +00:00
Julia Reynolds
82f3a1e68a Merge changes from topic "presubmit-am-1e7fa8f458a24c9bb07a3501870823fc" into tm-mainline-prod am: 7ba6728cd8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17710594

Change-Id: Iea4c076da135dddaa338e7be490abbb91dc6639a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 00:41:25 +00:00
PETER LIANG
8bd6647885 Merge "Fix that device isn't responding for a while when resetting all settings on “Display size and text” page." into tm-dev 2022-04-13 00:39:27 +00:00
Presubmit Automerger Backend
74dd53583b [automerge] Fix that device isn't responding for a while when resetting all settings on “Display size and text” page. 2p: 09a2a49bd3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17614845

Bug: 223747686
Bug: 220082104
Bug: 220070773
Change-Id: If66da507a1e49fa2abec0f4a36507cb73fb176b4
2022-04-13 00:38:51 +00:00
Peter_Liang
09a2a49bd3 Fix that device isn't responding for a while when resetting all settings on “Display size and text” page.
Goal:
Probably has the race condition issue between "Bold text" and  the other features including "Display Size", “Font Size” if they would be enabled at the same time, so our workaround is that the “Bold text” would be reset first and then do the remaining to avoid flickering problem.

Bug: 223747686
Bug: 220082104
Bug: 220070773
Test: make RunSettingsRoboTests ROBOTEST_FILTER=TextReadingPreferenceFragmentTest
Change-Id: If1425fe2579bec8dded69680ac73fbfb03c37321
2022-04-13 00:38:44 +00:00
TreeHugger Robot
6a489ca8b7 Merge "Apply only RING_VIBRATION_INTENSITY to ringtone vibrations" into tm-dev am: 7a4f6a5ba3 am: 54f6f65f13
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17474927

Change-Id: I221b376e3d1f844aa970b84936570d6bfd5c70ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 00:36:36 +00:00
TreeHugger Robot
71f87d544e Merge "Add missing extra when launching apps" into tm-dev am: 14a3861f0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17721989

Change-Id: Ib9e96390eb5b388ce8cc65bc41071de860450083
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 00:35:55 +00:00
TreeHugger Robot
628dd51d0d Merge "Add missing extra when launching apps" into tm-dev am: 14a3861f0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17721989

Change-Id: I80b10681ce6d99697eacd905210e21b317edd4b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 00:34:23 +00:00
TreeHugger Robot
14a3861f0b Merge "Add missing extra when launching apps" into tm-dev 2022-04-12 23:27:14 +00:00
Weng Su
0a89ef862d [automerge] Remove redundant WiFi tethering listener 2p: 37edbd33b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17716525

Bug: 227719584
Change-Id: I5466de3a13ac0e9d2b1bb4c86904379bdb1b42ae
2022-04-12 21:07:09 +00:00
Weng Su
37edbd33b8 Remove redundant WiFi tethering listener
- WiFi tethering settings currently listeners two sets of WiFi tethering
  state from framework at the same time, There is a timing issue when
  the deprecated callback is sent earlier than the available callback,
  it will cause WiFi tethering settings to start tethering twice in a
  short period of time, causing the WiFi framework to respond with a
  startup error.

- Remove redundant obsolete WiFi tethering state listener to avoid
  WiFi tethering startup error.

Bug: 227719584
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=WifiTetherSettingsTest

Change-Id: I59cb5222acb763f630fb621250d7740a240bbd92
2022-04-13 05:04:47 +08:00
Julia Reynolds
3d8de3e21f [automerge] Add missing extra when launching apps 2p: 87bb1b34c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17721989

Change-Id: Ib37af2c92b1da8de0ce14f643db2e4ad1775408b
2022-04-12 20:21:07 +00:00
Julia Reynolds
87bb1b34c5 Add missing extra when launching apps
As promised in the api docs

Test: AbstractZenModeAutomaticRulePreferenceControllerTest, view
schedule DND page
Fixes: 221423986

Change-Id: I7ddc1b112950da225afa2ba13ebf5df481922177
2022-04-12 16:20:01 -04:00
Julia Reynolds
2c6c99e1f1 Merge "Fix some history issues" into tm-dev am: b28925ad48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17710594

Change-Id: I1e3c6396c2a6570bee3d18f68a5c0e9e810f92ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 17:44:43 +00:00
Julia Reynolds
e2ef0bcdfc Merge "Fix some history issues" into tm-dev am: b28925ad48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17710594

Change-Id: Ib20da3b6a4d75fab7fd4aef8b3acf35216c9643c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 17:43:45 +00:00
Julia Reynolds
b28925ad48 Merge "Fix some history issues" into tm-dev 2022-04-12 17:39:55 +00:00
Julia Reynolds
45dccd14f3 Merge changes from topic "presubmit-am-1e7fa8f458a24c9bb07a3501870823fc"
* changes:
  [automerge] Fix some history issues 2p: 4d46dddbe7 2p: cf0c8f9868
  [automerge] Fix some history issues 2p: 4d46dddbe7
  Fix some history issues
2022-04-12 17:39:55 +00:00
Julia Reynolds
7ba6728cd8 Merge changes from topic "presubmit-am-1e7fa8f458a24c9bb07a3501870823fc" into tm-mainline-prod
* changes:
  [automerge] Fix some history issues 2p: 4d46dddbe7
  Fix some history issues
2022-04-12 17:39:55 +00:00
TreeHugger Robot
54f6f65f13 Merge "Apply only RING_VIBRATION_INTENSITY to ringtone vibrations" into tm-dev am: 7a4f6a5ba3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17474927

Change-Id: I15d78ec410d16d8e13e96a0ece2c583fa722010f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 17:28:52 +00:00
TreeHugger Robot
f0d733d51f Merge "Apply only RING_VIBRATION_INTENSITY to ringtone vibrations" into tm-dev am: 7a4f6a5ba3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17474927

Change-Id: Idf69f945ca458d3abcc71be9a0f98f18193afd2f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 17:28:36 +00:00
TreeHugger Robot
7a4f6a5ba3 Merge "Apply only RING_VIBRATION_INTENSITY to ringtone vibrations" into tm-dev 2022-04-12 17:24:05 +00:00
Victor Truong
1a35538f72 Disable dream highlight when screensaver is disabled in Settings. am: cd11aa887a am: 1f977b0e8c am: 00047b4c64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17712388

Change-Id: I1adc97149b50fc72f3174cbabe1ca29bb69846b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 16:52:39 +00:00
Victor Truong
e493fafa88 Disable dream highlight when screensaver is disabled in Settings. am: cd11aa887a am: 9475c3d575
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17712388

Change-Id: I93c4c904c82be8f9caa2c8e278bc8d3bf561594e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 16:26:49 +00:00
Victor Truong
00047b4c64 Disable dream highlight when screensaver is disabled in Settings. am: cd11aa887a am: 1f977b0e8c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17712388

Change-Id: I6f6a255a1a9c195e324e0934b44440954025831a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 16:26:34 +00:00
Victor Truong
1f977b0e8c Disable dream highlight when screensaver is disabled in Settings. am: cd11aa887a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17712388

Change-Id: I4b14a6811de245ab6f44f650e7d9ce71d20f6fc0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 16:06:13 +00:00
Victor Truong
9475c3d575 Disable dream highlight when screensaver is disabled in Settings. am: cd11aa887a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17712388

Change-Id: I098d86efd92d1cf4db45360482aabb88be2380de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 16:05:05 +00:00
Julia Reynolds
9987091312 [automerge] Fix some history issues 2p: 4d46dddbe7 2p: cf0c8f9868
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17710594

Change-Id: Ifd3bfdd17efdd12b4e0aa49a83d96d570d3942dd
2022-04-12 15:16:12 +00:00