Commit Graph

34170 Commits

Author SHA1 Message Date
Daniel Nishi
8325e80fdb Merge "Count legacy games as games in Storage view." 2017-03-14 00:11:59 +00:00
TreeHugger Robot
d9c62979d7 Merge "Update string s/celluar/mobile/g" 2017-03-13 23:38:55 +00:00
TreeHugger Robot
6ea894bbb8 Merge "Swipe to dismiss suggestions" 2017-03-13 23:38:40 +00:00
Fan Zhang
c49ab99007 Add misc logging:
- Button clicks in app detail page:
  uninstall/disable/clear data/clear cache
- More logging in search:
  log inline search result click, and its metadata such as
  name/value/rank.

Fix: 32652772
Fix: 32798201
Test: make RunSettingsRoboTests
Change-Id: I90cef7c9ea9ea69ea9cf083013a38417097f8594
2017-03-13 16:30:55 -07:00
Yohei Yukawa
0617a7aebe Merge "Make IME handling deterministic in CryptKeeper" 2017-03-13 23:30:19 +00:00
Bartosz Fabianowski
ba66a0ef09 Update strings and layout for enterprise privacy
This CL continues the finalization of UI layout and strings for the
enterprise privacy page:
* Turn footer into a header
* Update strings
* Dynamically generate summaries for entry points in security page

Bug: 32692748
Test: m RunSettingsRoboTests

Change-Id: Ibf248ac269380fb1b919b01f88f721130060b7f9
2017-03-13 23:59:35 +01:00
Daniel Nishi
26a5a71d31 Merge "Don't show owner as a secondary user." 2017-03-13 22:11:00 +00:00
Fan Zhang
94733b0096 Update string s/celluar/mobile/g
Change-Id: If2f8d8ceca709c61d435894ab31d12b6bf8f3582
Fix: 34833792
Test: builds
2017-03-13 15:05:02 -07:00
Yohei Yukawa
4ae46cd1ad Make IME handling deterministic in CryptKeeper
We have been receiving more and more strange bug reports regarding
the initial IME visibility on CryptKeeper (Bug 31915865, Bug 35198715,
and Bug 36148078).  Most likely we have introduced more bugs before
fixing previous bugs.

As the first step to disentangle multiple problems, this CL addresses
a long standing issue that CryptKeeper relies on @hide internal API
InputMethodManager#showSoftInputUnchecked().  As explained in
Bug 36015425, IMM#showSoftInputUnchecked() is considered harmful in
terms of bypassing standard IME focus handling flows, which prevents
us from taking advantage of historical debugging mechanism that we
have added recently in Bug 35079353.

Test: Manually verified that Bug 31915865 is still broken but this CL
      does not make it worse.
      1. Flash an image into a non direct-boot device.
      2. Set up a device boot password.
      3. adb reboot
      After the step 3, the software keyboard shows up automatically
      then suddenly disappears (Bug 35198715).
Bug: 36015425
Change-Id: I3cffeec286d9372ff05e85a49b82287cb1add8a2
2017-03-13 22:00:15 +00:00
Fan Zhang
a5b620e738 Swipe to dismiss suggestions
- Move dismiss suggestion logic into feature provider
- In DashboardData, use hashcode as suggestion's stable id. This is much
  more likely to provide a truely stable id for each suggestion card.
  Eventually I want to use hash for all tiles to provide stable id.
- Add a SuggestionDismissionController to handle swipe to dismiss
  callbacks

Change-Id: If3770f07a90c5469a0b86fc28f3eb5e4c17227cd
Fix: 35159816
Test: make RunSettingsRoboTests
2017-03-13 14:39:00 -07:00
TreeHugger Robot
bb5509f84f Merge "Extends the touch area for the switch in Master Switch preference." 2017-03-13 21:26:30 +00:00
TreeHugger Robot
14ed46c5a3 Merge "Prevent whitelisted apps from blocking and silencing" 2017-03-13 21:02:27 +00:00
Daniel Nishi
fd82752694 Count legacy games as games in Storage view.
The old Games flag was being ignored for categorization.
This caused the very few games which used the flag to be
miscategorized as "Other apps."

Change-Id: Ib8650d1c43579bc1698576c09c884e5a7bc4626d
Fixes: 36109122
Test: Settings robotest
2017-03-13 13:20:30 -07:00
TreeHugger Robot
15e53a3f57 Merge "Specify disallowed action in AdminSupportDetailsDialog" 2017-03-13 20:11:35 +00:00
Matthew Fritze
8145b0f35a Merge "Add optional feedback button for settings search" 2017-03-13 19:39:50 +00:00
Doris Ling
033a58b9c2 Update the ordering of the homepage tiles.
Lower the priority of System and Support settings to be negative so that
they will appear below dynamic tiles with default priority.

Change-Id: I4c0122aa54c5947cfcc7beb7f50b5ef720c8b9f0
Fix: 35928954
Test: make RunSettingsLibRoboTests
2017-03-13 12:29:48 -07:00
Daniel Nishi
092e3c0b3c Don't show owner as a secondary user.
Change-Id: I0a67eb176528a0f95595107b12c6ecc679a1041f
Fixes: 36138657
Test: Robotest
2017-03-13 12:27:22 -07:00
TreeHugger Robot
a6b01f19da Merge "Add battery percentage switch to display settings" 2017-03-13 19:09:46 +00:00
Julia Reynolds
dcee38d02e Prevent whitelisted apps from blocking and silencing
Change-Id: I34cb5c2c59d56b68ed1500c8c79cd65676c0af25
Fixes: 35841524
Test: manual
2017-03-13 18:46:03 +00:00
Jeff Sharkey
d29c6aedbd Only crop photos owned by Settings.
A recent security change locks down the ability for the system UID to
issue Uri permission grants.  This helps mitigate an entire class of
confused deputy security issues.

However, Settings (which runs as the system UID) was still relying on
issuing Uri permission grants to the photo cropper.  The simplest way
to keep that working is to add the "com.android.settings.files"
authority to a whitelist, and only request cropping of Uris from that
location.

This means that if the GET_CONTENT decides to return a Uri (instead
of streaming it into mTakePictureUri), then we need to copy it
ourselves locally before we can send it along to the cropper.

Test: builds, boots, both take/choose photos work
Bug: 33019296, 35158271
Change-Id: I2541c33e8d9452357cb9fc2e021ca74d5a43d5ff
2017-03-13 12:40:48 -06:00
Saige McVea
6c2f9fe6d7 Merge "Revert "Accessibility settings refresh."" 2017-03-13 18:30:41 +00:00
Saige McVea
31d855e739 Revert "Accessibility settings refresh."
This reverts commit 89a5c62963.

Change-Id: I97e420e4f78ee3e48b8aa10c8f5c1e2861032fab
2017-03-13 18:04:00 +00:00
phweiss
15931742ac Specify disallowed action in AdminSupportDetailsDialog
The title of an AdminSupportDetailsDialog "Action not allowed" is
replaced by specialized strings such as "Screenshot not allowed" if
the action is specified by the extra DevicePolicyManager.EXTRA_RESTRICTION
in the calling intent.

This is done because these intents can be created by
third-party apps via the new public API
DevicePolicyManager.createAdminSupportIntent, and the disallowed action
might not be obvious in context of the third party app.

Bug: 31215663
Test: CtsVerifier in separate CL
Change-Id: I0c9e360cea34bec8eda29d86c5bf55d8c38c47ec
2017-03-13 18:53:18 +01:00
Doris Ling
6467d2027e Extends the touch area for the switch in Master Switch preference.
- set view click listener on the entire widget view instead of only
listening to the switch button event.
- move the preference layout end padding into the widget frame, so that
clicking on the empty space at the end will send the click event to the
widget frame instead of the preference view.

Change-Id: I98025f723465f3941cebbbd03b812209c0240590
Fix: 35872094
Test: make RunSettingsRoboTests
2017-03-13 10:29:34 -07:00
Doris Ling
397a1b80ef Merge "Add logging to Bluetooth settings." 2017-03-13 17:24:14 +00:00
Maurice Lam
019593072b Update fingerprint enrolling flow
1. Make FingerprintEnrollFinish stay on the back stack during "add
   another"
2. Remove skip button from the enrolling screen, since the user can
   now back out of the enrollment flow, or back to
   FingerprintEnrollFinish and press "done" there.

Test: Run FingerprintEnrollFinishTest with `am instrument`
Bug: 32054268
Change-Id: Icaf017952d6582a14b4d0904b7ee67ad22e5280d
2017-03-13 10:22:06 -07:00
Matthew Fritze
2beb03f4b7 Add optional feedback button for settings search
Adds mechanism for adding a button in the search screen
and stubs to show and hide the button.

Fixes: 35164702
Test: make -j40 RunSettingsRoboTests
Change-Id: I34d245e84b62cedf2dc6e5de4ea336c5a99ffd31
2017-03-13 09:55:05 -07:00
Paul Lawrence
5b729c3216 Fix convert to fbe
Bug: 35231198
Test: Convert to fbe now works
Change-Id: Icc468d4f9328aacc18ba9e7b053e8db1a9aa9c8d
2017-03-13 09:19:04 -07:00
Gustav Sennton
72c7a83141 Merge "WebView implementation Dev setting: Show the version number after name" 2017-03-13 14:25:28 +00:00
Jeff Sharkey
0f0e3adac8 Merge commit '11324dcedfd9d4cccba0b1e493c44fe80bb05da4' into manual_merge_11324dcedf
Change-Id: Icd2605fd1572dd21bb27a7d42bc62ba9b06bd9ad
2017-03-12 17:22:21 -06:00
Jeff Sharkey
11324dcedf Merge "Fix network name for Passpoint network" am: 742bd03f12
am: a41debeacd

Change-Id: I6cffc06b4d792501fd3cc158cbc119b3c388c9be
2017-03-12 23:13:42 +00:00
Jeff Sharkey
a41debeacd Merge "Fix network name for Passpoint network"
am: 742bd03f12

Change-Id: Ia9ae9d6034f72be5f8d34340efce5b52d71fa6c2
2017-03-12 23:09:11 +00:00
Jeff Sharkey
742bd03f12 Merge "Fix network name for Passpoint network" 2017-03-12 23:03:20 +00:00
Bill Yi
dfd82f4c33 Import translations. DO NOT MERGE
Change-Id: I941f388954df5fb352ae2020def665c2600884f0
Auto-generated-cl: translation import
2017-03-12 10:30:17 -07:00
TreeHugger Robot
9ba477b62b Merge "Add setting for the assist gesture sensitivity control." 2017-03-11 03:17:38 +00:00
TreeHugger Robot
75ff40e409 Merge "Add DynamicAvailabilityPreferenceController" 2017-03-11 03:07:31 +00:00
Philip Quinn
5473f68cdd Add setting for the assist gesture sensitivity control.
The sensitivity control is only visible when the assist gesture itself
is enabled.

Test: make -j RunSettingsRoboTests; manual test on supported/unsupported
      configurations.

Change-Id: I584975794c5cf9d788e93167292d142ae2faf1c5
2017-03-10 17:23:14 -08:00
TreeHugger Robot
700fc363ef Merge "Fix the Storage settings title." 2017-03-11 00:01:15 +00:00
TreeHugger Robot
f0110a1de7 Merge "Use color accent as background color for app info pages." 2017-03-10 23:58:30 +00:00
TreeHugger Robot
85478422e2 Merge "Disable wifi display activity if device can't support it." 2017-03-10 23:35:26 +00:00
Daniel Nishi
325d38043f Category breakdown size should match total size.
The system apps' base size was not being properly attributed
to the system. This was causing the storage to go totally
unattributed (and causing roughly a 1GB gap in sizes.) On my
test device, the sizes now sum properly.

Change-Id: Ibc13015e40f854090a7a3ec09eef4c5c52918e0f
Fixes: 35144717
Test: Settings robo
2017-03-10 15:15:42 -08:00
Fan Zhang
6a56b8feb0 Merge "Refactor sound setting -> work profile initialization logic." 2017-03-10 22:39:31 +00:00
Bartosz Fabianowski
436873f156 Add DynamicAvailabilityPreferenceController
This is a PreferenceController that correctly handles the case of
isAvailable() changing dynamically, while the Settings page containing
the preference in question is open.

Bug: 32692748
Test: m RunSettingsRoboTests

Change-Id: I95e22bbc7bdc17bacd2bf6b82fa5b535494d5bce
2017-03-10 23:25:36 +01:00
Doris Ling
b2032416e9 Use color accent as background color for app info pages.
Bug: 34977561
Test: visual
Change-Id: Idc03d33a318d7908a47e76738f7d098ab60fb0fe
2017-03-10 14:15:14 -08:00
TreeHugger Robot
f11c16710c Merge "Update the Manage Storage preference." 2017-03-10 22:01:58 +00:00
Daniel Nishi
f4febcc7bb Fix the Storage settings title.
The wrong resource id was passed in for the title.

Change-Id: I5d4bc4d127903f58c0df671504a140fe883c2f17
Fixes: 35961000,36126458
Test: Manual
2017-03-10 13:15:25 -08:00
Fan Zhang
4fcd5ed29f Disable wifi display activity if device can't support it.
Change-Id: I19ab9d0d480b66e56b87cef7c49d4391a3608111
Fix: 36069170
Test: make RunSettingsRoboTests
2017-03-10 13:03:47 -08:00
Evan Laird
3822f122a7 Add battery percentage switch to display settings
Test: mmma packages/apps/Settings/tests/robotests
Bug:32539932
Change-Id: I08c1d0f3b6cb8be7d1456268498356f7ed833e5c
2017-03-10 14:35:40 -05:00
Anton Philippov
a540a978bc Merge "Hide "Factory reset" item for secondary users" 2017-03-10 19:05:19 +00:00
Marie Janssen
14ef1e4417 Bluetooth: leave screen off for permission request
Test: pair to a carkit, disable pbap, reconnect from carkit
Bug: 32555940
Change-Id: I06d6cc0873f9f991e68f1de9b629dbe3a7bb7701
2017-03-10 09:57:03 -08:00