Commit Graph

47686 Commits

Author SHA1 Message Date
Mill Chen
cbe56e8b6e Merge "Add a rule to keep classes that implements CustomSliceable" 2018-09-18 00:53:31 +00:00
TreeHugger Robot
134e24d171 Merge "Fix inconsistent icon size in app list." 2018-09-18 00:42:16 +00:00
Doris Ling
ff33e9bc13 Merge "Use the new network stats loader to get usage data for all apps." 2018-09-17 23:55:03 +00:00
Bill Yi
dcc8230713 Import translations. DO NOT MERGE
Change-Id: Idacabf81cf4dae12f8a9f0174a13901088a3a5d1
Auto-generated-cl: translation import
2018-09-17 16:51:13 -07:00
Raff Tsai
0a39e43316 Fix Homepage wrong color in dark theme
Change-Id: Id22f8baff0b97c0e7081fb8c68241bc8d0d01a45
Fixes: 113964702
Fixes: 115789360
Test: manual
2018-09-18 07:14:57 +08:00
Fan Zhang
e5109ce28c Fix inconsistent icon size in app list.
Some app icons are really small. This is technically a bug in app, but
not handling it well makes settings UI look strange.

So in addition to setting a max size app icon can use, we just set that
as a only supported size (min == max == 36dp)

Change-Id: I4b3a1b83ab67be469ac74e7d4bb382ae855624d0
Fixes: 115788294
Test: visual
2018-09-17 16:06:23 -07:00
Philip P. Moltmann
a5918a6a68 Make Settings use system-api restricted icon.
Test: Browsed around settings
Bug: 110953302
Change-Id: I1b19be721719ed8946cb558b93119b1b0e173794
2018-09-17 15:48:31 -07:00
Bill Yi
ea18741986 [automerger skipped] Import translations. DO NOT MERGE am: 1a84e070b3 -s ours
am: 7c6679fac0  -s ours

Change-Id: Ib4dc327c3c76a7d59fbe9b892340d6b546a3ac2f
2018-09-17 15:25:52 -07:00
Lei Yu
16a0e416fd Merge "Revert "call getName() from CachedBluetoothDevice, not CachedBluetoothDeviceManager"" 2018-09-17 22:16:00 +00:00
Lei Yu
499013b05e Revert "call getName() from CachedBluetoothDevice, not CachedBluetoothDeviceManager"
This reverts commit 3029efc5f7.

Reason for revert:
To fix null pointer crash in Pairing dialog. Dialog maybe triggered by intent, in which LocalBluetoothManager couldn't have instance for BluetoothDevice and will return null. As a result, we need to depend on method in CachedBluetoothManager to handle it.

Bug: 115754654
Bug: 112735753
Change-Id: I1ebf1f1c2829cfb75e6c382df5acf785fe54a185
2018-09-17 22:15:14 +00:00
Doris Ling
27ee2f0865 Use the new network stats loader to get usage data for all apps.
- change to use the new NetworkStats.Bucket instead of
NetworkStats.Entry when iterating through the detail data.

Bug: 111751694
Test: make RunSettingsRoboTests
Change-Id: I305cc384320e4a72531d80dd9a00a3034ab12837
2018-09-17 15:02:06 -07:00
Bill Yi
7c6679fac0 [automerger skipped] Import translations. DO NOT MERGE
am: 1a84e070b3  -s ours

Change-Id: I7b757cb1cc4622b05a2b1b2e277f680eb7e19898
2018-09-17 14:51:52 -07:00
Bill Yi
1a84e070b3 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I0c4b9cded799380c969e2acf1aac3c5a785dc81f
2018-09-17 12:35:35 -07:00
TreeHugger Robot
8dbbb01f19 Merge "Add DataUsageListV2 for showing network stats detail." 2018-09-17 19:20:16 +00:00
Doris Ling
6127d9de4c Add DataUsageListV2 for showing network stats detail.
Initial step: simply duplicate the existing DataUsageList class.

Bug: 111751694
Test: make RunSettingsRoboTests
Change-Id: I4d48405cd127cccb041ba0457638337f6918ce2e
2018-09-17 10:19:39 -07:00
Mill Chen
fb4992111b Add a rule to keep classes that implements CustomSliceable
Bug: 115862774
Test: visual, SliceViewer
Change-Id: Iff52a61423ef6822430a1f269a897b46d46f5253
2018-09-17 22:06:05 +08:00
Raff Tsai
8685c8562e Merge "Fix popup dialog show wrong device name" 2018-09-17 01:31:21 +00:00
Ben Lin
f66f042009 Merge "Follow up comments to 0cdc103e8287d3bd01944cdd2afb5c11897998fe." 2018-09-15 01:25:02 +00:00
TreeHugger Robot
6ca83b53a9 Merge "Fix bug in Add network fragment" 2018-09-15 00:45:17 +00:00
Ben Lin
30ed7c7c72 Follow up comments to 0cdc103e82.
Bug: 74763823
Test: Manually check; sending an Intent with package:// scheme works, if
originated from app of same cert.

Change-Id: I8206197c2147cc91ef72ad89f330320781428bb9
2018-09-14 16:27:24 -07:00
TreeHugger Robot
2508560eeb Merge "Fix a bug where custom cards are not refresh when removed" 2018-09-14 21:57:24 +00:00
Fan Zhang
45fc707474 Fix a bug where custom cards are not refresh when removed
When the last custom card for a specific type is removed,
onContextualCardUpdated should receive the cardtype info so we can
remove it from main data set.

- Reverted onContextualCardUpdated method signature back to before
- Force ConditionContextualCardController to send an empty list if
  everything is removed.

* Note: the update logic is pretty complicated to handle
  add/update/remove all together. In the future we should consider
  spliting the removal logic to simplify this area.

Change-Id: Ied688deb693ec33e0017be02cf5c743a754a6e61
Fixes: 115572494
Test: visual
2018-09-14 12:37:01 -07:00
jackqdyulei
0c6f8065c2 Fix bug in Add network fragment
After we switch secutiry from EAP to WPA, add button will become
disabled forever. Main reason is that we use view visibility to decide
which security type it is. In this case target view is visible while its
parent view is gone. So even though UI shows correctly however we still
think it is in EAP mode.

This CL check the mAccessPointSecurity directly instead of depending on
fragile view.

Fixes: 114689178
Test: RunSettingsRoboTests

Change-Id: I4284d25e6bf86ee7c5e7c0e17f0834c719d8d587
2018-09-14 11:10:31 -07:00
Raff Tsai
b20bfc949a Fix popup dialog show wrong device name
- Current EditText value will set to preference text if we click
OK in EditTextPreferenceDialogFragment. We will set preference
text to default when click cancel in DeviceNameWarningDialog.

Change-Id: Iab9561953b58276e98ee68d9196fa18e0dc3d78c
Fixes: 115693838
Test: make RunSettingsRoboTests
2018-09-14 23:53:30 +08:00
TreeHugger Robot
e5791f3c99 Merge "Prevent non-blockable app from being blocked" 2018-09-14 02:34:20 +00:00
Fan Zhang
a6b9102e34 Don't index icon for support setting.
Change-Id: I86c32f45e462330ea74060d60f987d80e45348e5
Fixes: 115555140
Test: reindex
2018-09-13 17:31:01 -07:00
Fan Zhang
29aaf62410 Only replace updated cards after loading from db.
There are currently 2 ways a list of contextual cards can be updated:
1. through loader onFinishLoading
2. onContextualCardUpdated

We need to make the data handling logic consistent between the 2 paths.

Also changed some loops to stream for simplicity.

Change-Id: I242732e180a14092f5745271e5f63c18a6e482e0
Fixes: 115572494
Test: robotests
2018-09-13 14:04:07 -07:00
Fan Zhang
0f8536b034 Merge "Create custom card controller/render as soon as possible." 2018-09-13 20:05:58 +00:00
Julia Reynolds
7217c4421f Prevent non-blockable app from being blocked
In the recent notifications display.

Test: manual
Change-Id: I0b14dfbcb8c4a971bb028def7751d083d37958de
Fixes: 111863327
2018-09-13 14:02:50 -04:00
Fan Zhang
a93743f9c4 Create custom card controller/render as soon as possible.
Custom cards might need to monitor lifecycle events, waiting for
onFinishLoading is too late.

Also make sure custom cards cannot change card type.

Test: manual
Change-Id: Ib8f8e6e48926a63c9d241ed9e9843c025e3f634a
2018-09-13 09:20:59 -07:00
TreeHugger Robot
a95584eed5 Merge "Revert the mandatory backups feature." 2018-09-13 08:45:34 +00:00
TreeHugger Robot
75e2bdbcc9 Merge "Do not include disabled activity in Default Browser." 2018-09-13 01:57:53 +00:00
TreeHugger Robot
7e8ea8db98 Merge "Fix nits in contextual card package." 2018-09-13 01:36:37 +00:00
Fan Zhang
ff6f6f6991 Merge "Clean up: delete unused methods" am: 41f9566da8 am: b371dea0cb
am: 88cbe51f27

Change-Id: Ib166230d692cc7a3973355239161ed88ffd6af60
2018-09-12 17:44:52 -07:00
Fan Zhang
88cbe51f27 Merge "Clean up: delete unused methods" am: 41f9566da8
am: b371dea0cb

Change-Id: I0545f7f9914337d64d8d91eb152005e4858b6869
2018-09-12 17:39:21 -07:00
Fan Zhang
b371dea0cb Merge "Clean up: delete unused methods"
am: 41f9566da8

Change-Id: I973b289c688c04c00f70a6c0ba15a5b205d6633a
2018-09-12 17:12:54 -07:00
Fan Zhang
e81063a40d Merge "Changes on Settings UI for a better user experience" am: 7737b64159 am: 97cb71e978
am: 309d86f613

Change-Id: I47d4fba4fddb44c270b37f590c86b736d2ca5271
2018-09-12 16:52:35 -07:00
Fan Zhang
41f9566da8 Merge "Clean up: delete unused methods" 2018-09-12 23:46:31 +00:00
Bill Yi
b05b93e28b [automerger skipped] Import translations. DO NOT MERGE am: 85c82c5681 -s ours
am: a0bfe20b35  -s ours

Change-Id: Ifcf837e01890110d0015ca19fd6fa922d70d8188
2018-09-12 16:33:35 -07:00
TreeHugger Robot
4d44c02b0e Merge "Remove battery app list feature flag" 2018-09-12 23:26:20 +00:00
Fan Zhang
309d86f613 Merge "Changes on Settings UI for a better user experience" am: 7737b64159
am: 97cb71e978

Change-Id: I2862387d1cc18fb8536ed1a1e1c9441b64395977
2018-09-12 16:25:12 -07:00
Fan Zhang
97cb71e978 Merge "Changes on Settings UI for a better user experience"
am: 7737b64159

Change-Id: I591b6eac611109bd903c99f79ecd63d37ca59511
2018-09-12 16:13:08 -07:00
Fan Zhang
7737b64159 Merge "Changes on Settings UI for a better user experience" 2018-09-12 22:44:39 +00:00
TreeHugger Robot
b01d15aab1 Merge "Fix visibility of AddUser when toggling multiuser." 2018-09-12 22:34:55 +00:00
Doris Ling
dfe663879d Do not include disabled activity in Default Browser.
- query the intent activites with flags 0, so that only
enabled activities will be returned.

Change-Id: I6ec4e3f3fdff850228a723bcb2d2bdc5721b41eb
Fixes: 111796304
Test: make RunSettingsRoboTests
2018-09-12 15:34:49 -07:00
Bill Yi
a0bfe20b35 [automerger skipped] Import translations. DO NOT MERGE
am: 85c82c5681  -s ours

Change-Id: I0e777523597d91407f23f1f5c1ae8f84dd27c051
2018-09-12 15:30:03 -07:00
Fan Zhang
089ed21526 Fix nits in contextual card package.
We missed to catch a few nits in previous CLs. This change cleans up
some of it.

Test: manual
Change-Id: Ibd3466f781952f998e1183a49f56e812cbce99a1
2018-09-12 14:07:12 -07:00
Fan Zhang
de3ff1eee1 Merge "Implemented the CardContentLoader" 2018-09-12 20:14:56 +00:00
Fan Zhang
409a5f8c98 Clean up: delete unused methods
Test: rebuild
Change-Id: I144ebbdaf137ee091af949a9e38f68d02941f705
2018-09-12 13:08:15 -07:00
jackqdyulei
94b26f12ad Remove battery app list feature flag
It is not used anymore

Bug: 115542275
Test: Build
Change-Id: I931d081a13d5d4b698c785205d356182fec3e02d
2018-09-12 12:58:04 -07:00