Commit Graph

23172 Commits

Author SHA1 Message Date
Quang Anh Luong
5aa95553cd Do not auto-downgrade WPA3->Transition mode if password too short
Hotspot security is auto-downgraded from WPA3->Transition mode if the
band is changed from 6Ghz -> 2.4/5GHz. However, Transition mode requires
a password of 8 chars or more, but WPA3 SAE does not. Avoid changing the
security type if the current password is less than 8 chars.

Flag: EXEMPT minor bugfix

Bug: 366452667
Test: atest WifiHotspotRepositoryTest
Change-Id: I1abadd59966e170b51899782746b9f14e33e6186
2024-09-26 07:09:47 +00:00
Chaohui Wang
9969334647 Fix Can't Able to Click Sims
The root cause is SubscriptionManager.OnSubscriptionsChangedListener
.onSubscriptionsChanged() not invoked in some cases.

Even the SubscriptionManager.addOnSubscriptionsChangedListener's doc
says the onSubscriptionsChanged() method will also be invoked once
initially when calling it, there still case that the
onSubscriptionsChanged() method is not invoked initially.
For example, when the onSubscriptionsChanged event never happens before,
on a device never ever has any subscriptions.

Adding a .onStart { emit(Unit) } to fix.

Also make the subscriptionsChangedFlow() a shared flow to mitigate the
extra emit cost.

Bug: 369276595
Flag: EXEMPT bug fix
Test: manual - factory reset & no any sim
Test: atest SubscriptionRepositoryTest
Change-Id: Ic32a5666f14373926b5dfedb5dedadb4369acfc7
2024-09-26 13:29:47 +08:00
Yiyi Shen
d375984779 Merge "[Audiosharing] Use DialogFragment instead of raw AlertDialog" into main 2024-09-26 02:49:38 +00:00
Treehugger Robot
e3bc83b7b0 Merge "Fixed elapsed_time_millis in SettingsUIChanged event" into main 2024-09-25 23:55:49 +00:00
Yi-an Chen
781cbcdbf0 Merge "Correct behavior on Google Location History preference click" into main 2024-09-25 20:27:33 +00:00
David Liu
2f39a808fc Fixed elapsed_time_millis in SettingsUIChanged event
This change stores timestamp when received com.google.android.setupwizard.SETUP_WIZARD_FINISHED. This timestamp will be used to calculate elapsed_time_millis for SettingsUIChanged event after SUW complete. This enables to analyze how the user uses Settings in a specific time span after setup.

Bug: 344466251
Test: metrics related change only
Flag: EXEMPT metrics change only

Change-Id: I85b15f1eb5e5a4502a27d8588bb01e59b7ad83b5
2024-09-25 18:44:26 +00:00
Treehugger Robot
d6f73f35b6 Merge "Update titles and summaries of the Date and time settings page" into main 2024-09-25 16:54:05 +00:00
Geoffrey Boullanger
8b7399a8d9 Update titles and summaries of the Date and time settings page
Design doc: go/dd-android-settings-time-2024

This change covers Part 1, which consists of adding user-friendly summary under each toggle and rewording titles.

Bug: 296835792
Test: on-device and atest
Flag: EXEMPT resource only update
Change-Id: I0b685743599880fc1c4ad680eca9c36e4e64d0ff
2024-09-25 15:19:10 +00:00
Yiyi Shen
54b0d18a04 [Audiosharing] Use DialogFragment instead of raw AlertDialog
FragmentManager can help manage the state of the dialog and automatically restore the dialog when a configuration change occurs

Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858921
Change-Id: If63c7891cfb92e06c457e37eb5556f3eaf3f6121
2024-09-25 17:31:14 +08:00
Haijie Hong
7e7530bfd1 Merge "Fix two-panel issue in tablet" into main 2024-09-25 07:36:43 +00:00
Haijie Hong
1020e7132d Fix two-panel issue in tablet
Keep the logic same as BlockingPrefWithSliceController.

BUG: 343317785
Test: atest BluetoothDeviceDetailsViewModelTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I77e62479def433869ae5e93987ec7069cc61173a
2024-09-25 13:48:33 +08:00
Yiyi Shen
28d1551870 Merge "[Audiosharing] Apply new string resid" into main 2024-09-25 05:19:49 +00:00
Treehugger Robot
fc2ccb61fd Merge "Use hasScrollAction in ApnEditPageProviderTest" into main 2024-09-25 04:00:01 +00:00
Treehugger Robot
00c90b0e6f Merge "Migrate Android version preference" into main 2024-09-25 03:30:59 +00:00
Chaohui Wang
0b530fd405 Use hasScrollAction in ApnEditPageProviderTest
Instead of assuming a fixed tree structure in testing.

Fix: 369416630
Flag: EXEMPT gradle only
Test: atest ApnEditPageProviderTest
Change-Id: I0a50e7665d9049e089b5a0877f17d1f736ee3332
2024-09-25 10:26:47 +08:00
Menghan Li
26392847f0 Merge "refactor(brightness suw): decouple auto brightness initialization logic for setup flow" into main 2024-09-25 01:23:55 +00:00
Yi-an Chen
73ab82f52f Correct behavior on Google Location History preference click
Fixes: 366060896
Bug: 360240563
Flag: EXEMPT bugfix
Test: Manually and RecentLocationAccessPreferenceControllerTest
Change-Id: Ibe3c49c3060bcc0967f93a3a88aa45b04ab8a41d
2024-09-25 01:23:52 +00:00
Treehugger Robot
adb3d1f1d4 Merge "Migrate the Legal Info page to Catalyst" into main 2024-09-25 00:39:10 +00:00
Dongzhuo Zhang
c51a76014a Merge "Add contacts storage setting entry in app settings page." into main 2024-09-25 00:20:32 +00:00
Jacky Wang
4329d8371e Migrate Android version preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I0a15cd460543a7dd84edc5c3a5a2ff900aeba13f
2024-09-25 07:28:52 +08:00
Dongzhuo Zhang
6231453e91 Add contacts storage setting entry in app settings page.
Test: atest SettingsRoboTests:com.android.settings.applications.contacts.ContactsStoragePreferenceControllerTest

Bug: 368641291
Flag: com.android.settings.flags.enable_contacts_default_account_in_settings

Change-Id: I8da16f24b17e44dc0ea417cffabd85c36d7edc5f
2024-09-24 22:28:22 +00:00
Treehugger Robot
35740d2542 Merge "Fix for GestureShortcutOptionControllerTest" into main 2024-09-24 20:19:20 +00:00
Julia Reynolds
2fe4cb6393 Merge "Make legacy DND pages not searchable" into main 2024-09-24 20:19:17 +00:00
Riley Jones
214af3c7d2 Fix for GestureShortcutOptionControllerTest
Flag: android.provider.a11y_standalone_gesture_enabled
Bug: 368704597
Test: atest GestureShortcutOptionControllerTest
Change-Id: I8736fe5f79ea527702640087de1f9b7fcc9a046a
2024-09-24 18:36:30 +00:00
Julia Reynolds
0c5eb711a9 Make legacy DND pages not searchable
Flag: EXEMPT unflaggable
Fixes: 341726633
Test: manual, searching in settings
Change-Id: I592a1775a890711086db1099fb333c1dc1a11e0b
2024-09-24 15:18:16 +00:00
Sunny Shao
e060aeb1e1 Migrate the Legal Info page to Catalyst
Test: atest LegalPreferenceTest
Test: atest LegalSettingsScreenTest
Test: atest WallpaperAttributionsPreferenceTest
Bug: 360061554
Flag: com.android.settings.flags.catalyst_legal_information
Change-Id: Ic15384e853584b72a847e1a10713a0c3c29273a7
2024-09-24 23:15:27 +08:00
Jacky Wang
84d31c2ad9 Migrate Android security update preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I745358d8dfc17b68535336653a149c334b266c91
2024-09-24 17:49:30 +08:00
Jacky Wang
b8d2bc12b1 Migrate mainline module version preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I1f3f69b08fe22c66d1b1c6786f9cd7e7ff413529
2024-09-24 16:52:13 +08:00
Menghan Li
e0f734526d refactor(brightness suw): decouple auto brightness initialization logic for setup flow
The AccessibilitySettingsForSetupWizard class should not be responsible for managing the initial
logic of controllers, such as determining which controllers need to be dynamically added or updated
using setInSetupWizard APIs. This logic should be handled directly by the controllers themselves.

Bug: 311093618
Flag: EXEMPT bugfix
Test: atest AccessibilitySettingsForSetupWizardTest
            AutoBrightnessPreferenceControllerForSetupWizardTest
            AutoBrightnessPreferenceControllerTest
            BrightnessLevelPreferenceControllerForSetupWizardTest
            BrightnessLevelPreferenceControllerTest

Change-Id: I6065a10e72d002981c0f514543e6933d79c2aa1b
2024-09-24 05:41:23 +00:00
Riley Jones
62449dd61b Fix for broken tests in Accessibility Settings
Updates tests that were broken by the rollout of the standalone_a11y_gesture_enabled flag

Test: atest com.android.settings.accessibility
Bug: 368704597
Flag: android.provider.a11y_standalone_gesture_enabled
Change-Id: Ie90e7495dd4a134538bae6e3e08eea0d02134b14
2024-09-23 23:24:25 +00:00
Jacky Wang
9cdd1108c3 Merge changes from topic "catalyst-firmware-version" into main
* changes:
  Migrate "Build number" preference
  Migrate "Kernel version" preference
  Migrate "Baseband version" preference
2024-09-23 15:44:09 +00:00
Matías Hernández
a78f2b834c Merge "Don't add the "Events" mode anymore, and delete it if disabled" into main 2024-09-23 12:49:05 +00:00
Yiyi Shen
5ea28f5f0a [Audiosharing] Apply new string resid
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858921
Bug: 362858894
Change-Id: I4c80d834515e43bade5f2207dc013dc30c6ab7be
2024-09-23 18:56:04 +08:00
Jacky Wang
9cbb04c5e0 Migrate "Build number" preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: Iee68b5414713118ad3d1b9b3ec04437729bb2d0b
2024-09-23 16:43:34 +08:00
Jacky Wang
fb349fad1a Migrate "Kernel version" preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: Icb50e2d5200f7de40b6f8383c114982cd45d34b5
2024-09-23 16:43:34 +08:00
Jacky Wang
6fe2f89f7c Migrate "Baseband version" preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I8e4f946d01169e8008b8a336d308f5874ee918e6
2024-09-23 16:43:20 +08:00
Yiyi Shen
51fc7a8239 Rename AudioSharingRetryDialogFragment
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858894
Change-Id: I157b036541e9a7b21205ee45437bfd4562c49118
2024-09-23 16:20:48 +08:00
Yiyi Shen
322e153350 Rename AudioSharingLoadingStateDialogFragment and layout
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858894
Change-Id: I05e29b248541511daca355f1bbe4a13b17b4d20d
2024-09-23 15:46:27 +08:00
Yiyi Shen
de7ab402f9 Merge "[Audiosharing] Show retry dialog when error occurs in start sharing" into main 2024-09-23 06:48:39 +00:00
Chaohui Wang
73fb290969 Check DISALLOW_CONFIG_MOBILE_NETWORKS when search
If disallowed, not show mobile related search results.

Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search Mobile Settings
Test: atest MobileNetworkSettingsSearchIndexTest
Change-Id: I79b984f41f09dd9612bcd0c9942089756d5d365d
2024-09-23 11:17:55 +08:00
Yiyi Shen
302b26ff74 [Audiosharing] Show retry dialog when error occurs in start sharing
Errors including:
1. onBroadcastStartFailed
2. onSourceAddFailed

Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858894
Change-Id: I0fe13bd675672c57219d0f6f3e735515a7ed7a06
2024-09-23 11:07:20 +08:00
Alina Zaidi
8be12edf9c Merge "[dev_option] Use DesktopModeFlags from core instead of Shell" into main 2024-09-20 09:49:16 +00:00
Edgar Wang
3f2d009c66 Merge "Refactor layout of ProcessStatsPreference" into main 2024-09-20 05:51:54 +00:00
Daniel Santiago Rivera
9ccb389b6d Use NATIVE SQLiteMode in Robolectric
As that is more consistent with the framework SQLite implementation.

Bug: 368395032
Flag: TEST_ONLY
Test: atest SettingsRoboTests
Change-Id: I367bd28fec7170c3727948ec65a3b56992a07267
2024-09-20 01:46:57 +00:00
George Lin
5406db9d6e Adding launch source info in the wallpaper picker intent (1/3)
When launching Wallpaper & Style from the settings search, we should
also append the launch source information to the intent.

The major purpose if for logging. So that we know then entrypoint of the
Wallpaper & Style app.

Test: Manually tested that the intent contains the extra we need
Bug: 368052505
Flag: EXEMPT bugfix
Change-Id: I9af663dad7cb79bfe74431e6a61cd34393e60dbd
2024-09-19 14:13:53 +00:00
Yiyi Shen
133fcf3dc5 Merge "[Audiosharing] Refine share then pair flow" into main 2024-09-19 13:29:37 +00:00
Treehugger Robot
4f6b56277c Merge "Fix crash when phone process has problem." into main 2024-09-19 13:04:54 +00:00
Matías Hernández
97f06864f8 Don't add the "Events" mode anymore, and delete it if disabled
Fixes: 368227085
Test: atest ZenModeHelperTest
Flag: android.app.modes_ui
Change-Id: Idd5563505ca92463485b433e80f29bf3e0f98d39
2024-09-19 13:51:19 +02:00
tomhsu
56ff329900 Fix crash when phone process has problem.
- Phone process may not exist in some situation. It shall catch the
   exception to avoid Settings crash.

Flag: EXEMPT bugfix
fix: 365669913
Test: build pass
Change-Id: I2b95f46b8887a9c8416fb4a5724537ad27e86850
2024-09-19 11:37:02 +00:00
Treehugger Robot
2b9e976cbb Merge "Hide the Default Notification Sound if enabling customized vibration" into main 2024-09-19 10:07:01 +00:00