Commit Graph

1794 Commits

Author SHA1 Message Date
shafik
ea6f37e1d7 Use AppOpsManager#setUidMode instead of #setMode
Security related app-ops should be set with AppOpsManager#setUidMode
instead of AppOpsManager#setMode.

Test: manual - toggle All Files Access for a test app, reboot device and
observe in /data/system/appops.xml that the mode was for UID instead of
package
Test: ensure that the right state is reflected in the relevant Settings
activities
Bug: 146425146
Merged-In: ac8aba0c4a

Change-Id: I261953ff88bc049cf0a2f04f8caac00b8cc6f704
(cherry picked from commit ac8aba0c4a)
2020-02-24 11:28:41 +00:00
Jason Chiu
c56ce8d647 Guard NPE in getAvailabilityStatus of InstantAppDomainsPreferenceController
Fixes: 149373695
Test: build, manual
Change-Id: I7501ef393e226bb38c72a1ee465bf9c72586716b
Merged-In: I7501ef393e226bb38c72a1ee465bf9c72586716b
(cherry picked from commit c0543e833f)
2020-02-24 06:19:11 +00:00
Rajeev Kumar
67c149bfe7 Settigns app changes to enable Notification listeners on Android Go.
Bug: 148575561
Test: make RunSettingsRoboTests -j40 and manual tests
Change-Id: I1832529edd55d9ba2053ccc0ff7e2bc93f4a00b5
2020-02-18 15:22:47 -08:00
TreeHugger Robot
c799e9236b Merge "Fix Battery optimization page broken" 2020-02-17 06:25:11 +00:00
TreeHugger Robot
0eba407374 Merge "UX changes for the new cross profile settings page" 2020-02-14 13:44:59 +00:00
kholoud mohamed
00c46041b6 UX changes for the new cross profile settings page
Bug: 136249261
Bug: 140728653
Bug: 148594054
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesDetailsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesSettingsTest

Change-Id: I9666b34a03e5c082eed7c4120e70a07017ab7ef0
2020-02-14 11:51:39 +00:00
Raff Tsai
50a0aafdfe Fix Battery optimization page broken
- mCompositeFilter is not changed after toggling filter, so the
list items are not changing. Fixed by changing mCompositeFilter
after toggle is changed.
- Because mSession.rebuild returns null, removes some dead code.

Fixes: 149362024
Test: 1. Settings > App & notifications > Special app access >
         Battery optimization
      2. Toggle Not optimized and All apps
      3. App list should change after step 2

Change-Id: Ifd5c7b0f1d809ae7a49d62b39e34fa899700326c
2020-02-14 10:45:14 +08:00
TreeHugger Robot
be94018ba9 Merge "Handle null case in AppStateAppOpsBridge" 2020-02-13 06:44:30 +00:00
Tsung-Mao Fang
59e1e64258 Handle null case in AppStateAppOpsBridge
AppStateAppOpsBridge#getEntries returns null if no app
is requesting AppStateAppOpsBridge#mPermissions,
which would cause the settings app to crash in
AppStateAppOpsBridge#loadAllExtraInfo or
AppStateAppOpsBridge#loadAppOpsStates.

Try to skip null case here and set null for extraInfo
when we get null from AppStateAppOpsBridge#getEntries.

Change-Id: Iac03ec11869eeac62fa055da26b4b7a10dc65bb8
Fix: 147479269
Test: Open All files access and no crash.
2020-02-12 18:17:08 +08:00
Raff Tsai
a2e77a0e85 Fix no action in Settings storage
- Pass wrong user id in view holder

Fixes: 149028747
Test: 1. Add new user, and change th new user
      2. Take a camera shot under the new user
      3. go to Settings -> Storage -> photo & video -> Image
      4. Should open file brower

Change-Id: I0af532748ec19f62897911b1bb6ece9b21b844c3
2020-02-12 13:20:19 +08:00
TreeHugger Robot
5a5ca79af4 Merge "Link PACKAGE_USAGE_STATS with LOADER_USAGE_STATS" 2020-02-12 01:56:31 +00:00
TreeHugger Robot
2db8d1d88f Merge "Tweak summary for permission manager" 2020-02-10 12:13:32 +00:00
Tsung-Mao Fang
70238907dc Tweak summary for permission manager
Summary appends "and more" while the items of permission are larger
than 3.

Change-Id: Ic3c16404237fb0cb81f0ed5d2cbdff32cf23c452
Fix: 136258315
Test: Robo test and visual
2020-02-10 19:15:59 +08:00
Tsung-Mao Fang
b4fc67ea24 Revert "Revert "Use system-api lib to get badged, shadowed icons(2/n)""
This reverts commit 94b8055f1c.

Reason for revert: Revert this cl and fix broken test cases.

Change-Id: I61a190b4beba8db2fe2faab45e5dd6921dc681ec
Fix: 149112222
Fix: 149090275
Test: Run all Setting robo tests
2020-02-10 15:01:43 +08:00
Bill Peckham
f78295c11a Merge "Revert "Use system-api lib to get badged, shadowed icons(2/n)"" 2020-02-07 22:27:34 +00:00
Bill Peckham
94b8055f1c Revert "Use system-api lib to get badged, shadowed icons(2/n)"
This reverts commit dbecbe6f61.

Reason for revert: b/149112222

Change-Id: I11981b2daacf8b07177fe906d88de05ca40810c1
2020-02-07 21:52:25 +00:00
TreeHugger Robot
cdd797e2bd Merge "Use system-api lib to get badged, shadowed icons(2/n)" 2020-02-07 11:50:41 +00:00
Kholoud Mohamed
83589187ae Merge "Add settings page to control cross profile appop" 2020-02-07 11:14:08 +00:00
Tsung-Mao Fang
dbecbe6f61 Use system-api lib to get badged, shadowed icons(2/n)
In order to prevent DoS attack from icon size, we're using
a system lib to help convert any loaded drawable into a flattened
bitmap with an appropriate size.

Test: Open recent app screen and then no crash
Bug: 33646131
Change-Id: Ib7eae56e19cd86667bd63b6061000c6a92deaf3b
2020-02-07 18:45:45 +08:00
Edgar Wang
4af4f276bd Merge "Make the fragment title can’t searchable" 2020-02-07 08:07:01 +00:00
kholoud mohamed
14a887fbf1 Add settings page to control cross profile appop
This does not have the final UX changes.
Strings are marked as non-translatable since they are not yet finalized.

Bug: 136249261
Bug: 140728653
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesDetailsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesSettingsTest
Change-Id: Ia3ebebc9bb53dcb5097bda71df9cfa5c4442fc59
2020-02-06 12:14:34 +00:00
Edgar Wang
0934babbfc Make the fragment title can’t searchable
we shouldn't take users so deep into the settings IA because it's easy
to feel lost in settings after clicking on a result without additional
context.

Bug: 143055215
Test: robotest & manual
Change-Id: I337cb5ead31e1e4e7bf9be78132e90630f83ee43
2020-02-06 19:07:11 +08:00
TreeHugger Robot
ab06fc2454 Merge "Leverage the code from qt-qpr1-dev to master" 2020-02-06 10:29:39 +00:00
Sunny Shao
8d0d90096c Leverage the code from qt-qpr1-dev to master
Fixes: 147124412
Test: manual test

Change-Id: I6e937c6d34b635ecfdd2e29b22d0023f23f695e3
2020-02-06 17:20:58 +08:00
Tsung-Mao Fang
4620cddba4 Merge "Use system-api lib to get badged, shadowed icons" 2020-02-06 09:01:21 +00:00
Tsung-Mao Fang
323347afcc Use system-api lib to get badged, shadowed icons
In order to prevent DoS attack from icon size, we're using
a system lib to help convert any loaded drawable into a flattened
bitmap with an appropriate size.

Test: Open recent app screen and then no crash
Change-Id: Ie148890fbbbf71f42863a8fe727a90615158b8c1
Fix: 33646131
2020-02-06 15:02:56 +08:00
robertluo
81c79bb239 Merge Tap & Pay settings entries with NFC
Bug: 142231537
Test: make -j42 RunSettingsRoboTests
Change-Id: I54ea0cdf711f2c381f5bba8575fc22bd6329f3c6
2020-02-06 12:15:39 +08:00
Automerger Merge Worker
35afeb8c4e Merge "Use IEC units in app info data usage." am: 1668f18a16 am: d9d463013f am: b04872c35d
Change-Id: I4fea31a06be212c397099a313e9159740b4406a8
2020-02-04 04:56:36 +00:00
Chalard Jean
bbd637d391 Use IEC units in app info data usage.
Settings > Apps & notifications > select some app that has done
some internet traffic.
Observe "Mobile data & Wi-Fi" summary data and take note of the
numbers. Then tap on it and observe that the numbers on the
details page don't match the one in the summary. This is because
the details use IEC units while the summary uses SI units.

This fix changes the summary to use IEC units too, removing
the discrepancy.

Bug: 137917003
Test: manually cause some traffic, see that the numbers are now
      consistent between the app info and usage details page

Change-Id: I4be5830d4e98a1c4739001c812e59d82415bf24a
2020-01-28 20:22:45 +09:00
Todd Kennedy
b6aaed1bfc Link PACKAGE_USAGE_STATS with LOADER_USAGE_STATS
Bug: 148374455
Test: Manual
Test: Create three packages; 1) only request PACKAGE_USAGE_STATS, 2) only request LOADER_USAGE_STATS, 3) request both
Test: Go to Settings -> Apps & Notifications -> Special app access
Test: See that there is only a single entry for "Usage access"
Test: Under "Usage access", see all three test apps appear
Test: Disable access for each application and verify that only the appop for the declared permisson is flipped using
Test: adb shell cmd appops get <<PACKAGE_NAME>>
Change-Id: I7741a703fd4494832347e51e113adf974cc31d2b
2020-01-27 15:15:02 -08:00
TreeHugger Robot
b2fe109956 Merge "Create a new Open supported links page" 2020-01-20 10:06:31 +00:00
TreeHugger Robot
8caac569be Merge "Fix broken links in @ChangeId javadoc." 2020-01-17 12:49:49 +00:00
Mathew Inwood
5800245d1b Fix broken links in @ChangeId javadoc.
We will soon have javadoc generated from the doc comments on all
@ChangeId annotated constants. Since the link target referred to
here is a @hide constant, it cannot be resolved as part of DAC doc
generation. Replace it with {@code} specifying the constants value
instead.

Bug: 144927670
Test: In follow up CLs
Change-Id: I9947e722dca228705190e8f2c49e47104c04dea6
2020-01-17 11:22:52 +00:00
Betty Chang
af2e3afb04 Merge "[Mainline] Copy the findBestComponent method from EuiccConnector to Settings" 2020-01-17 03:27:32 +00:00
Bonian Chen
66349e21c3 Merge "[Mainline] Use @SystemApi constants in SmsManager instead of in SmsUsageMonitor" 2020-01-16 20:13:37 +00:00
changbetty
bbc757e01a [Mainline] Copy the findBestComponent method from EuiccConnector to Settings
Make a copy of EuiccConnector#findBestComponent() into local method findEuiccService().

Bug: 147275124
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ApplicationFeatureProviderImplTest
Change-Id: Ie81569d940fc354053469570e1506b1954d9f24d
2020-01-16 20:46:06 +08:00
Sunny Shao
6b032f4e2d Create a new Open supported links page
- Add a new OpenSupportedLinks fragment
- Add a new AppHeaderPreferenceController
- Add a new AppOpenSupportedLinksPreferenceController

Fixes: 143185713
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.applications
Change-Id: I6568950b7b918378baaa80e2ca0d596913620928
2020-01-16 18:18:14 +08:00
Edgar Wang
e19ee9a01f Revert "Settings search - Navigate user to exact page"
This reverts commit 08f2a58459.

Reason for revert: design changed, we decide to take the user to
the entry after clicking on a search result.
It's opposite with what we did, so we revert related CL first.

Test: robotest

Change-Id: Iadb9a94a7ef7838be34a54499e2d934d6396c336
2020-01-16 14:07:38 +08:00
changbetty
64b8981502 [Mainline] Use @SystemApi constants in SmsManager instead of in SmsUsageMonitor
Bug: 146808981
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PremiumSmsAccessTest
Change-Id: I7dd74a390e9a69ad71d83a0db07bef979fab7f1d
2020-01-16 11:27:22 +08:00
Betty Chang
d60c780c0d Merge "[Mainline] Use SmsManager method instead of ISms" 2020-01-14 03:51:34 +00:00
changbetty
04a3ef6e67 [Mainline] Use SmsManager method instead of ISms
Bug: 146808981
Test: make
Change-Id: I388f9e9979ce9d83d7e3daf510c9dcb3303cc5c7
2020-01-13 16:15:03 +08:00
Raff Tsai
4536fae5b7 Fix work tab app doesn't launch correct user intent
- Pass user.getIndentifier() to intent

Fixes: 147357696
Test: 1. go to Settings -> Storage -> Music&Audio
      2. switch to work tab
      3. tab "Audio files"
      4. should display work profile files

Change-Id: I0d2883c45eb7b883adbaf034c0a49c5e52ba82f6
2020-01-11 09:16:24 +08:00
Shafik Nassar
2751c43f1d Merge "Add settings UI for MANAGE_EXTERNAL_STORAGE" 2020-01-08 11:54:18 +00:00
shafik
430b94bbc1 Add settings UI for MANAGE_EXTERNAL_STORAGE
Adds a Special App Access setting for the app-op
OP_MANAGE_EXTERNAL_STORAGE. All apps requesting the corresponding
permission will be displayed in the settings page. Toggling the
preference switch for an app will grant/revoke the app-op.

All of the external references to the permission, app-op and their
corresponding activities and logic use the name "Manage External
Storage". All of the external displays and strings use the name "All
files access"

Test: * Install app with uses-permission MANAGE_EXTERNAL_STORAGE
      * Observe it appearing the All files access page
      * Toggle the switch and observe the change in
        'adb shell dumpsys appops'
Bug: 146425146

Change-Id: If5c9c5daa3616a3310c090283acfda933bf9df26
2020-01-08 09:24:25 +00:00
Jason Chiu
2d609759cd Add preference click metric logs for some special cases
Bug: 137559984
Test: visual, robotest
Change-Id: If8624b49abcd0000487065160ce4a7ba861f234c
2020-01-02 17:45:23 +08:00
Edgar Wang
08f2a58459 Settings search - Navigate user to exact page
- remove duplicate index preference
- default set searchable = false when the preference has fragment
- make some fragments indexable

Bug: 143057584
Test: robotest & manual

Change-Id: I4d64f6106d2f92f0a45e8c7e26388677f593f412
2019-12-24 21:04:11 +08:00
Philip P. Moltmann
b4e5b0bd78 Merge "Adjust to changed internal API" 2019-12-20 03:04:55 +00:00
Bernardo Rufino
9e32620854 Report if app-specific SAW intent
Log using PlatformCompat framework if the app tried to deep-link into
the app-specific screen for managing SAW permission.

Bug: 146327570
Bug: 135920175
Test: 1. adb shell am start -a
android.settings.action.MANAGE_OVERLAY_PERMISSION -d package:com.foo.bar
      2. adb logcat -s -v color CompatibilityChangeReporter:*
      3. Verify compat change id reported 135920175 and state LOGGED

Change-Id: I1d6c571d524d70c11156aeea27a8800d2a0ba42b
2019-12-17 14:49:00 +00:00
Raff Tsai
1e5d8146b5 Change ProfileType definition
Bug: 141601408
Test: rebuild
Change-Id: Ia4d4fabe8a4daad4ce54c243748fa3c29bf944ba
2019-12-12 13:44:35 +08:00
Raff Tsai
c75aea1552 Change tab text to sentense text
- Also remove duplicated string

Bug: 141601408
Test: manual
Change-Id: I840bdf4c12ca6d815d7c54092aa32a40c80d95e0
2019-12-11 15:38:12 +08:00