In addition to looking nicer, this fixes two accessibility issues ("no hint when text is entered" and "reason for disabled button is unclear").
This requires a bit of theme merging black magic, because TextInputLayout requires a Theme.AppCompat descendant, which the Settings theme isn't.
Fixes: 356398157
Fixes: 370654542
Fixes: 369942776
Test: atest ZenModeEditNamePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I92d8ec044dabc6daed5d755e206120ec7abc143e
Touch targets should be at a minimum 48x48 dp; this view was 47 dp high. ¯\_(ツ)_/¯
Fixes: 369963437
Test: manual
Flag: android.app.modes_ui
Change-Id: I8fda0cd505f02abb561e24e583b3ab509b5ef4dd
Also fixed paddings a bit (e.g. Done button was too close to the icon grid).
Fixes: 369503296
Test: manual
Flag: android.app.modes_ui
Change-Id: Ic7b7dc9584db1f04b448fce828a8ec70cf17f06a
A notification was shown when upgrading from pre-P to P because default DND settings had changed. The default was later changed back so it was already obsolete at that point. Moreover, it should be impossible to upgrade from pre-P to V in one step.
Bug: 346789065
Test: N/A
Flag: EXEMPT Unflaggable -- removing resources, manifest entries, etc.
Change-Id: I2862211dc9709b741e60beca5fc029cc054745a3
Due to the sufficient space between sub-description and illustration,
modify the layout_marginTop to avoid the cut off problem.
Flag: NONE bug-fixing
Bug: 336981217
Test: build ABTD ROM and perform a visual inspection.
Change-Id: Id69549968341ee59e3cb7ee8838a90fda7a78b3a
This reverts commit e1faf0c8a9.
Reason for revert: Likely culprit for b/367986833 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Change-Id: I0f5120cfd4a4cc44c5ef5c431deedfa3b38ee576
When the "end time" text label is wider than the actual time, then aligning it with the start of the time causes it to wrap, even when there's plenty more space on the screen. This change right-aligns it in all cases (even when it's shorter), as it's hard to get all three of "right-aligned when too long", "left-aligned to the time display when short enough", and "wraps when it hits the center line instead of overflowing".
Fixes: 367054151
Test: manual, in English & Danish
Flag: android.app.modes_ui
Change-Id: I106864d6fb09aeac5fcc8d22e8d3d67b1b31ce4e
Add an error dialog to help user recover from biometric error for
identity check feature
Flags: android.hardware.biometrics.flag.mandatory_biometrics
Fixes: 358641110
Fixes: 358179610
Test: atest DevelopmentSettingsDashboardFragmentTest
Change-Id: I6099bc57672b945fa4fa4de98be35bd097403b22
The volume bars with layout preference_volume_slider won't align title text right in RTL mode (Force RTL layout direction is Developer options),
e.g. Sound & vibration page, Audio sharing page.
Test: manual
Bug: 359514080
Flag: EXEMPT minor layout change
Change-Id: I43daa46438e3fa0a879d831a97d05b31c7dcb52f
R.id.sud_layout_description no longer works any more, migrate to
setDescriptionText().
Fix: 365582830
Flag: EXEMPT bug fix
Test: manual - on erase all data
Test: atest MainClearConfirmTest
Change-Id: Icfb492ada862fb0584ffdb8da440d94ce719e518
- only this preference use AppPreference.setProgress()
- create layout to handle progressbar in this class
Bug: 365506467
Test: atest
Flag: EXEMPT bugfix
Change-Id: Ie0daf4e4fc1736943afe243566392d57c63fe65a
1. Change SPFS ring progress bar and lottie animaiton from
layout_marginLeft/ layout_marginRight to marginStart/marginEnd for
RTL language.
2. Modify SPFS ring progress bar and lottie animaiton dimensioin for
RTL language and check three different SFPS projects.
Flag: NONE bug-fixing
Bug: 338911438
Test: manual build and check UI visually.
Change-Id: I88edad459eefbb3c6be337263045cd87685810e9
Previous change is reverted due to test failure in b/362901443.
BUG: 360031750
Test: atest BluetoothKeyMissingDialogTest
Flag: com.android.settings.flags.enable_bluetooth_key_missing_dialog
Change-Id: I05b940e8aac26c14f93baa19c224ad98c291b891
Revert submission 28985385-bt_key_missing_dialog
Reason for revert: Likely culprit for b/362901443 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Reverted changes: /q/submissionid:28985385-bt_key_missing_dialog
Change-Id: I2a3ab8f0dbd2c81eda49d11abc6d586f59f149e9
Flag: com.android.settings.flags.updated_suggestion_card_aosp
Bug: 323258154
Test: Enable flag and trigger suggestion cards to show
Change-Id: Iee47d05d8d75c10ba073ae3541f108bc37b4c09b
For large enough screens, always use the portrait (all vertical in one column) layout for the intestitial, since the landscape split in two halves only makes sense for smaller screens.
Renames the layout to mode_interstitial_layout_base and uses an alias so that we can reuse the same layout but with additional padding.
Fixes: 361344824
Test: manual
Flag: android.app.modes_ui
Change-Id: I4e02e9a246ee799e3a79508f11290397a236574c
* Sometimes would cause an unending stream of accessibility events (particularly if starting off-screen). This would break TalkBack and anything that depends on UiAutomator (although the system itself took it like a champ).
* Sometimes would not load images (because the ViewTreeObserver would never fire onGlobalLayout after being added because measured width was 0, even though a new width was calculated later).
* Would not recalculate the number of icons that fit if the width changes after the first layout.
Combining ViewHolders with waiting for measuring and/or ViewTreeObservers was always a wonky approach, even though it should've worked in theory. This should be more robust.
Also fixes the unwanted animation on mode screen load related to the absence of the header name being applied a tad too late.
Fixes: 359948417
Fixes: 360072876
Fixes: 360328804
Test: atest SettingsRoboTests + manual + adb shell uiautomator events
Flag: android.app.modes_ui
Change-Id: I7e5dfbdab220d1ebc1c68e5e87ce544ee86b6a65
The description of the segment is already "App 1, App 2, and x more can interrupt", from its text. If the icons don't fit, there's a "+N" at the end. Accessibility services reading this is confusing, especially because the icons that don't fit are not the same as the names that don't fit, so you could get something like "App 1, App 2, and 9 more can interrupt, plus 4".
The whole circular-icons section is irrelevant for a11y so we just mark the container as "noHideDescendants" to save Talkback some work.
Fixes: 359837977
Test: Manual with Talkback
Flag: android.app.modes_ui
Change-Id: I346abcc94e25ef60c5e91f77b8e13f38ade39c71
