Commit Graph

14635 Commits

Author SHA1 Message Date
Linus Tufvesson
59c0a7bc63 Make WifiDppEnrolleeActivity launches explicit
Bug: 180518134
Test: make RunSettingsRoboTests \
ROBOTEST_FILTER=WifiDppUtilsTest\|WifiDialogActivityTest
Test: Manually verified b/180518134 attack is no longer possible

Change-Id: I8c4e1e17117582c78671d0e4658bd87715a9a046
2021-07-06 12:09:10 +00:00
Treehugger Robot
5dfa9cde19 Merge "Add a developer option to increase nfc stack log level" am: 9d7b0beb87 am: 4909b81006 am: b6e44d16ac am: 957ece6934
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1733952

Change-Id: I159684580a0f018e7d41dc2982c7d7001e88cf55
2021-07-06 09:15:20 +00:00
Treehugger Robot
b6e44d16ac Merge "Add a developer option to increase nfc stack log level" am: 9d7b0beb87 am: 4909b81006
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1733952

Change-Id: I257c6806afcef6211eedc8cf60829f90930a0d32
2021-07-06 08:52:25 +00:00
Treehugger Robot
9d7b0beb87 Merge "Add a developer option to increase nfc stack log level" 2021-07-06 08:05:47 +00:00
Jason Hsu
1cbac4bc53 Merge "Fix accessibility button footer preference did not announced correct by TalkBack" into sc-dev am: bf6af8ac92 am: 336cfe271f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15204641

Change-Id: I6a7e5b327e3931bef3af2a51cceb1003ef7758fb
2021-07-06 07:27:28 +00:00
jasonwshsu
3cb889fc78 Fix accessibility button footer preference did not announced correct by TalkBack
Root Cause: Description would be altered after displayPreference(), but getSummary() would be called after it.

Solution: Update title before displayPreference(), then it could be set correctly.

Fix: 192738520
Test: atest AccessibilityButtonFooterPreferenceControllerTest
Change-Id: I068994fca8202b166fedf43f9d9657b0c1a64c4e
2021-07-06 06:57:22 +00:00
Bonian Chen
76bf6ff525 [Settings] Settings within each SIM not been displayed to the user
The display of content is in majority depending on the callback result
of SIM card (in order to display the content).

However, to reduce the number of access of SubscriptionManager and
improve performance, a proxy has been design in between to reduce the
traffic and the latency required.

Within this situation, content didn't get displayed when Activity get
restarted since Proxy avoid to reduce the traffic through reducing the
callback to the Activity and even not generating request for update when
Activity resume.

Bug: 188982508
Test: local & unit test
Change-Id: Ia3b946a853f87a469ce07a398f3811f605d38f1d
2021-07-05 15:12:39 +08:00
TreeHugger Robot
5432cf9eba Merge "Add permission checking to WifiDialogActivity" into sc-dev am: 27c928856e am: 48ddec81c9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15187819

Change-Id: I45a70c5bf9ad7fb24f4f51fb6dc4abde1db1c156
2021-07-05 03:21:35 +00:00
TreeHugger Robot
27c928856e Merge "Add permission checking to WifiDialogActivity" into sc-dev 2021-07-05 02:54:05 +00:00
TreeHugger Robot
9c41116855 Merge "Align with the visibility logic from Dialer" into sc-dev am: 6d06f9bcad am: abbcd960cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15080735

Change-Id: Ie9739c235b10bd2e3ab37239419eaa368f37c44d
2021-07-02 16:45:54 +00:00
TreeHugger Robot
6d06f9bcad Merge "Align with the visibility logic from Dialer" into sc-dev 2021-07-02 16:17:09 +00:00
TreeHugger Robot
d5f9f65390 Merge "Switch back to sync IInputMethodManager" into sc-dev 2021-07-02 15:22:21 +00:00
Weng Su
71e728e934 Add permission checking to WifiDialogActivity
- Use getCallingPackage() to get calling package.

- Check if the calling package has ACCESS_COARSE_LOCATION or
ACCESS_COARSE_LOCATION permission.

- Only set result data to permission granted callers

Bug: 185126813
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=WifiDialogActivityTest

Change-Id: If7ca069c842ed2bd1aed23f9d4041473c68a4dad
2021-07-02 23:10:11 +08:00
Yohei Yukawa
b6ab3ad813 Merge "Switch back to sync IInputMethodManager" 2021-07-02 14:28:50 +00:00
Stanley Wang
2f42899da0 Merge "Fix the problem that when the MainSwitchPreference is gone, there will be a blank area." into sc-dev am: 371f699681 am: 1db13f7a60
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15173151

Change-Id: Ib6efd95a638af34be93b0e9f7bb97a74a2642456
2021-07-02 13:20:24 +00:00
Tsung-Mao Fang
770f064d36 Align with the visibility logic from Dialer
Copy most visiblity logic from the Dialer app
We should check whether RTT is supported or not by querying Telecom.

Also, the rtt configuration won't be initialized properly before
user goes into the RTT page.
Prior to this cl, we set a wrong default value when we're showing
the subtext of RTT, this is not correct.
Currently, we simple show nothing in subtext if RTT haven't initilized
properly.

Test: Work with testing team to verify the behavior.
Fix: 188110773
Change-Id: I47c1983d15e22ef5a1fb3027334117a38a479558
2021-07-02 21:13:31 +08:00
Stanley Wang
371f699681 Merge "Fix the problem that when the MainSwitchPreference is gone, there will be a blank area." into sc-dev 2021-07-02 12:51:23 +00:00
Syaoran Kuo
3c505155e1 Merge "Fix mobile network test cause process crashed." 2021-07-02 12:11:50 +00:00
TreeHugger Robot
ce38106111 Merge "Autofill settings: Fix search" into sc-dev am: 68f3726375 am: 82b4b46b4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15171260

Change-Id: Ic8a4129f979186e343ef855a7ece95b8c13e57e0
2021-07-02 10:35:40 +00:00
Arc Wang
496b898bac Merge "Fix incorrect storage size in Storage Settings" into sc-dev am: 68caefba32 am: 1e7e8d8104
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15175229

Change-Id: I86e6806cf37736696aef427f1c8c59a3e5aad6f0
2021-07-02 10:35:27 +00:00
Syaoran Kuo
2fbf3efb09 Fix mobile network test cause process crashed.
Bug: 192428680
Test: atest com.android.settings.network.telephony.MobileDataPreferenceControllerComponentTest
Change-Id: If51950381071b6cbafb98d3282c201f5872ebbe0
2021-07-02 18:24:31 +08:00
TreeHugger Robot
68f3726375 Merge "Autofill settings: Fix search" into sc-dev 2021-07-02 10:12:18 +00:00
Arc Wang
68caefba32 Merge "Fix incorrect storage size in Storage Settings" into sc-dev 2021-07-02 10:05:16 +00:00
Jernej Virag
36f9888e3b Merge "Update Prevent Ringing setting to avoid conflict with long press power" into sc-dev am: 1d2371eecd am: 4efb8652a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15175451

Change-Id: Id9520cb76d7bca2449f013d6f8e344fedb9c444f
2021-07-02 09:07:58 +00:00
TreeHugger Robot
25854227de Merge "Password settings: Fix work profile" into sc-dev am: e6cff5497d am: e77a10c6e5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15153211

Change-Id: Id6ccd62924cc433f9eddb1ba3a2e70a74a6c29c1
2021-07-02 09:07:51 +00:00
Jernej Virag
1d2371eecd Merge "Update Prevent Ringing setting to avoid conflict with long press power" into sc-dev 2021-07-02 08:51:17 +00:00
Stanley Wang
b757a6e9f2 Fix the problem that when the MainSwitchPreference is gone,
there will be a blank area.

- Disable the visibility of preference when the the hide() method
  is invoked.

Fix: 192332931
Test: robotest and see the UI
Change-Id: Iec5a06ca689843ebb692b1b7040f1d2be9f45bc2
2021-07-02 16:43:21 +08:00
TreeHugger Robot
e6cff5497d Merge "Password settings: Fix work profile" into sc-dev 2021-07-02 08:42:26 +00:00
Jeremy Goldman
53dc808764 Merge "ManageablePreferenceTest created for VpnSettings" 2021-07-02 07:20:02 +00:00
Yohei Yukawa
a78e1f51fe Switch back to sync IInputMethodManager
This logically reverts two recent CLs [1][2] to submit a corresponding
logical revert [3] into frameworks/base to address Bug 190486491.

 [1]: I767069892c713023b064525105ef2b55946b7bb8
      8279b8ee5a
 [2]: I6733e8b500f5e02d4e14cde4ab7a46f4f716f5d0
      fa01bf30ba
 [3]: If16ac0de536d9089eb04f6e07b1ee47378124658

Bug: 163453493
Bug: 190486491
Test: make RunSettingsRoboTests ROBOTEST_FILTER="WinscopeTraceTest"
Change-Id: Idea98bd36935a27d886ca337154112e7dd293080
Merged-In: Idea98bd36935a27d886ca337154112e7dd293080
2021-07-01 21:24:02 -07:00
Yanting Yang
b7f21e9723 Merge "Remove stale search result about "Recent location requests" page" into sc-dev am: 62315005fd am: 4e4cae07b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15172993

Change-Id: I56c9d4c8a80006e2a1186a1a573c3acd669e2b4e
2021-07-02 04:18:17 +00:00
Yohei Yukawa
3e20e0ec37 Switch back to sync IInputMethodManager
This logically reverts two recent CLs [1][2] to submit a corresponding
logical revert [3] into frameworks/base to address Bug 190486491.

 [1]: I767069892c713023b064525105ef2b55946b7bb8
      8279b8ee5a
 [2]: I6733e8b500f5e02d4e14cde4ab7a46f4f716f5d0
      fa01bf30ba
 [3]: If16ac0de536d9089eb04f6e07b1ee47378124658

Bug: 163453493
Bug: 190486491
Test: make RunSettingsRoboTests ROBOTEST_FILTER="WinscopeTraceTest"
Change-Id: Idea98bd36935a27d886ca337154112e7dd293080
2021-07-01 21:17:59 -07:00
Yanting Yang
62315005fd Merge "Remove stale search result about "Recent location requests" page" into sc-dev 2021-07-02 03:59:29 +00:00
Arc Wang
25880d0d0e Fix incorrect storage size in Storage Settings
From Android S, Storage Settings queries file sizes
from MediaProvider, it's not necessary to count size
data from getExternalStorageStats when calculating
size data.

Bug: 185542752
Test: make RunSettingsRoboTests ROBOTEST_FILTER=testMeasurementCompletedUpdatesPreferences
      manual
      1. Connect device to PC via USB File transfer.
      2. Copy large files from PC to device.
      3. Observe size information in Storage Settings.
Change-Id: I43cbec764e97f5003a4ec981717c9f213a21b614
2021-07-02 10:57:57 +08:00
Jeremy Goldman
cfb194d605 ManageablePreferenceTest created for VpnSettings
Creating unit tests for VPN settings to increase the reliability of that
settings component.

Note that because S build is locked down but the T sdk has not been
started, the test suite was seeing the following error:

java.lang.IllegalArgumentException: Error: Failed to parse APK file: /data/local/tmp/SettingsUnitTests.apk: Requires development platform T but this is a release platform

In order to resolve this error, specifically set the SDK as android
S in the manifest. When the SDK transitions to android T, this may need
to be updated.

Test: atest -c tests/unit/src/com/android/settings/vpn2/ManageablePreferenceTest.java
Bug: 187245804
Change-Id: Ifa1450c23b1ade46809541252e22950b76b4faa5
2021-07-02 09:47:28 +08:00
Jernej Virag
bb75bb911e Update Prevent Ringing setting to avoid conflict with long press power
Long press power setting overrides Prevent ringing setting key chord. This updates the Prevent Ringing setting to disable it when LPP setting conflicts and adds a string describing why this setting is disabled.

Bug: 191971326
Test: Manually on device
      Unit tests in PreventRingingParentPreferenceController
Change-Id: If9fc8318381def7e4bbd71a0f5db3f38c474cb3d
2021-07-01 17:28:45 +00:00
Yanting Yang
007d1b2a57 Remove stale search result about "Recent location requests" page
Based on the new design, RecentLocationRequestSeeAllFragment was no
longer used on Location, but it still implemented the indexable
interface to provide stale search result “Recent location requests”
to Settings Search.

Remove the indexable interface from RecentLocationRequestSeeAllFragment
as a quick fix and also correct the related test method name.

Fixes: 192542283
Test: visual
Change-Id: I1a3df5d7319b8831db2f3d3abba19a11b5a83c81
2021-07-01 20:31:05 +08:00
TreeHugger Robot
6b424d264d Merge "Change One-handed mode controls states in the Settings pages for improving better UX experience" into sc-dev am: 150ed0b071 am: 8ea6f6382e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15109467

Change-Id: I8c2c85944500d0a050516f923d41babaf709c479
2021-07-01 10:57:36 +00:00
TreeHugger Robot
150ed0b071 Merge "Change One-handed mode controls states in the Settings pages for improving better UX experience" into sc-dev 2021-07-01 10:09:08 +00:00
Jason Chang
d9a4197d9d Change One-handed mode controls states in the Settings pages for
improving better UX experience

According to UX feedback to adjust One-handed mode UI
controls’ status in the Settings page for better UX experience.

Bug: 192171369

Test: manual verified on Settings > System > Gesture page
> System controls page
Test: make RunSettingsRoboTests ROBOTEST_FILTER=
      "com.android.settings.gestures
      .OneHandedEnablePreferenceControllerTest"
Test: make RunSettingsRoboTests ROBOTEST_FILTER=
      "com.android.settings.gestures
      .OneHandedMainSwitchPreferenceControllerTest"
Test: make RunSettingsRoboTests ROBOTEST_FILTER=
      "com.android.settings.gestures
      .OneHandedActionPullDownPrefControllerTest"
Test: make RunSettingsRoboTests ROBOTEST_FILTER=
      "com.android.settings.gestures
      .OneHandedActionShowNotificationPrefControllerTest"
Test: make RunSettingsRoboTests ROBOTEST_FILTER=
"com.android.settings.gestures
.OneHandedPreferenceCategoryControllerTest"

Change-Id: I76242fe70c3ec06cd5e2f9bb059c87293cc686dd
2021-07-01 17:05:27 +08:00
Ahaan Ugale
239b58e60a Autofill settings: Fix search
Ia012232ba2856e0757289982bc3045d948ff4aa8 replace the "Autofill service"
preference title with the earlier summary string. The change in title
causes search to not find the preference anymore. This change adds back
the title in xml, which makes search find it again. The Controller code
still overwrites the title with the application name.

Also fixes DefaultAutofillPreferenceControllerTest.

Bug: 192403526
Test: manual - clear Settings Services storage -> search "fill" -> click
 link
Test: make -j64 RunSettingsRoboTests \
 ROBOTEST_FILTER="com.android.settings.applications.defaultapps.DefaultAutofillPreferenceControllerTest"
Change-Id: I9714b3efd2a5a7d9ee7eef345415fa020ef0dc61
2021-07-01 01:58:29 -07:00
Syaoran Kuo
1eaddbac90 Merge "Fix dark mode activity in incorrect stage exception" 2021-07-01 03:10:38 +00:00
Ahaan Ugale
d4ce558f33 Password settings: Fix work profile
Currently, the work profile password settings just point to the personal
profile app. This change fixes this using the forWork metadata tag, that
sets the work profile user in BasePreferenceController.

Also fixes and re-enables the
displayPreference_withPasswords_addsPreference test.

Fix: 192417100
Test: manual - work profile link works, password count is accurate
Test: atest PasswordsPreferenceControllerTest
Change-Id: I6345b69b9c03ff13b8e2784e69dc0188abc436e3
2021-06-30 17:22:07 -07:00
Syaoran Kuo
28da952fb2 Merge "Add test case for on off airplane mode repeatly" 2021-06-30 13:58:41 +00:00
Syaoran Kuo
b5c5dd5fe8 Merge "Add test to launch all sub items in Settings home." 2021-06-30 13:58:22 +00:00
Syaoran Kuo
4225944fc0 Add test case for on off airplane mode repeatly
Bug: 191831494
Test: atest com.android.settings.network.AirplaneModePreferenceControllerComponentTest
Change-Id: I407f4435bb02fed77fc91458e732b8a6573539cd
2021-06-30 17:59:12 +08:00
TreeHugger Robot
be3afca13f Merge "Fix 'No Apps' UI issues of ManageApplications" into sc-dev am: cb00a65a0d am: f695195dd4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15124032

Change-Id: If20eb1c8705353feacfe8af481bb0b245dbc05ea
2021-06-30 09:51:02 +00:00
TreeHugger Robot
cb00a65a0d Merge "Fix 'No Apps' UI issues of ManageApplications" into sc-dev 2021-06-30 09:47:11 +00:00
Syaoran Kuo
d9f8711188 Add test to launch all sub items in Settings home.
Bug: 189723084
Test: atest com.android.settings.homepage.HomepageComponentTest
Change-Id: I4d49f0b9f7859fcf2de15e28867e995a19990913
2021-06-30 17:14:05 +08:00
PETER LIANG
35373bf94e Merge "Replace the AnimatedImagePreference with IllustrationPreference." into sc-dev am: 1a77fce131 am: aeb28e87f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15080037

Change-Id: I2f8de8fbd589df6b9ecdb7048e11c7ddca69264a
2021-06-30 01:07:03 +00:00