Commit Graph

4383 Commits

Author SHA1 Message Date
TreeHugger Robot
bd261ff8b1 Merge "Remove support v1" 2018-01-08 18:29:18 +00:00
TreeHugger Robot
7937798b9d Merge "Bluetooth MaxConnectedAudioDevices show correct number" 2018-01-06 05:57:23 +00:00
TreeHugger Robot
f3fa890bd6 Merge "Add tests for some security setting controllers" 2018-01-06 03:31:24 +00:00
Salvador Martinez
616397d28c Remove support v1
Support v1 is no longer used and we want to keep the codebase clean.

Test: robotests still pass
Bug: 70620533
Change-Id: Ic8af0f34aab510a533bd7a7ec5c059834395baf5
2018-01-05 16:34:33 -08:00
TreeHugger Robot
39e6bc2356 Merge "Add help info at the bottom of the dialog" 2018-01-06 00:15:43 +00:00
Hansong Zhang
de2855abdf Bluetooth MaxConnectedAudioDevices show correct number
* When the preference is changed by the user, it will update the UI
* When the Developer options is enabled, it will set the system property
to default number
* Change string "Maximum number of connected Bluetooth audio devices" to
"Maximum connected Bluetooth audio devices" per discussion with Lindsay

Bug: 71603731
Test: m
ROBOTEST_FILTER="BluetoothMaxConnectedAudioDevicesPreferenceControllerTest"
RunSettingsRoboTests -j40
Change-Id: I3e59534585065c84530da73ffded21894c845ce9
2018-01-05 16:12:00 -08:00
Fan Zhang
cf97f0b643 Add tests for some security setting controllers
Bug: 32953042
Test: robotests
Change-Id: Ieab4e6434bbb80313f6d1b25ff1cdea5713038f0
2018-01-05 15:45:53 -08:00
TreeHugger Robot
de4bef0243 Merge "Remove toggles in battery settings." 2018-01-05 22:47:31 +00:00
jackqdyulei
fd69cd4c33 Add help info at the bottom of the dialog
It contains a link to help center

Bug: 68030013
Test: RunSettingsRoboTest
Change-Id: I79260eff35e604fa97cf21c62f58c02f3bbe5cfb
2018-01-05 14:39:16 -08:00
TreeHugger Robot
6bc03f9550 Merge "Add developer menu to select max number of connected audio devices" 2018-01-05 22:11:56 +00:00
Ajay Nadathur
a63075f0eb Merge "Show 'screen lock options' on all lock screen types" 2018-01-05 21:19:14 +00:00
TreeHugger Robot
6ee11a6178 Merge "Use proper DashboardFragment APIs for SecuritySettingsV2" 2018-01-05 21:18:17 +00:00
Hansong Zhang
b2730b7b10 Add developer menu to select max number of connected audio devices
The new developer option modifies the system property
"persist.bluetooth.maxconnectedaudiodevices"; it allows testing
multiple connected devices for A2DP, AVRCP, HFP.

Bug: 71603731
Test: Robolectric test
Change-Id: Ie7887065f98193f4f34e0ff4a29959694e417124
2018-01-05 12:28:20 -08:00
Fan Zhang
361e55bb4c Use proper DashboardFragment APIs for SecuritySettingsV2
Next CL will add tests.

Bug: 32953042
Test: TODO
Change-Id: I0cb0e4eb216d3e9408675486f1cd73ba82d8ca36
2018-01-05 11:20:59 -08:00
Ajay Nadathur
a1314df69c Show 'screen lock options' on all lock screen types
bug: 66239135
Test: Manually tested and verified, robo tests updated
Change-Id: I42ae63661b5d5061fea848e2c1e8a0c8943864e4
2018-01-05 11:03:31 -08:00
Ben Lin
69084b3a8d Add ability to show/hide assist_and_voice_input preference.
This adds a new boolean flag, config_show_assist_and_voice_input, which
when set to false will hide the assist_and_voice_input preference item.

Bug: 62379282
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=DefaultAssistPreferenceControllerTest
Change-Id: I3bfc84f0fba07cd52679269daadbdcfccd205ff1
2018-01-05 10:03:17 -08:00
jackqdyulei
5c56588d59 Remove toggles in battery settings.
In Android P, we only show "Battery saver" and "Power management"
in battery settings. So we need to remove other preferences.

Keep "Battery percentage" toggle for now because it is not
cross-listed in other places.

Bug: 71502850
Test: Screenshot
Change-Id: Ia3c919f61239ff71f9343f2bce961aa4b89533c0
2018-01-04 19:54:06 -08:00
TreeHugger Robot
ac870bed2f Merge "Add a new widget MasterCheckBoxPreference." 2018-01-05 02:11:09 +00:00
TreeHugger Robot
5aaa8c5637 Merge "Bluetooth: Use "Disable" in-band ringing instead of "Enable"" 2018-01-05 01:45:14 +00:00
TreeHugger Robot
b8b9b283fe Merge "Merge sub pages for lock/unlock into 1 xml." 2018-01-05 00:36:17 +00:00
Doris Ling
c7f8bd49eb Add a new widget MasterCheckBoxPreference.
This is similar to the master switch preference, but instead of the
toggle button, it provides a checkbox as the preference widget.

Change-Id: Ic2392f6a828298ab85494e7dd127fd2d787ce121
Fixes: 71603100
Test: make RunSettingsRoboTests
2018-01-04 16:31:07 -08:00
TreeHugger Robot
2c3c8c8537 Merge "Support getDynamicSummary in BasePreferenceController" 2018-01-05 00:02:48 +00:00
Jack He
1eca8141bf Bluetooth: Use "Disable" in-band ringing instead of "Enable"
* Given that in-band ringing is enabled by default on supported devices,
  the corresponding development settings should be rephrased from
  "Enable in-band ringing" to "Disable in-band ringing" to hint that it
  is enabled by default
* This also gets rid of special logic to check that option in
  initialization
* Add strings to reflect this update
* Modify BluetoothInbandRingingPreferenceControllerTest to reflect this
  change

Bug: 65383086
Test: make, try toggling the preference and verify whether in-band
ringing works or not, RunSettingsRoboTests
Change-Id: I29f91c7d12c725b12452ec163b75051ff28f500d
2018-01-04 15:48:21 -08:00
Fan Zhang
928ddbe731 Merge sub pages for lock/unlock into 1 xml.
And create PreferenceControllers for each setting

The page is still pretty janky and controllers are invoked manually.
Next CL will clean these up.

Bug: 32953042
Test: TODO
Change-Id: I1d7478324f5de4fdb464d79f89086f7e79c0ee67
2018-01-04 15:02:36 -08:00
TreeHugger Robot
efac313a9b Merge "Add ability to show/hide accessibility_shortcut_preference." 2018-01-04 22:57:35 +00:00
Matthew Fritze
c69f73f4d1 Support getDynamicSummary in BasePreferenceController
Adds dynamic summary getter in relevant BasePreferenceControllers.
Preferece controllers that don't have dynamic summaries or which
are not yet BasePreferenceControllers are not changed right now.

Change-Id: I435ccab7758d90515583fd8ca10a9b1ef0c858b9
Fixes: 71514936
Test: robotests
2018-01-04 13:58:01 -08:00
TreeHugger Robot
266bc0fae7 Merge "Add ability to show/hide items for Special Access." 2018-01-04 21:53:21 +00:00
Victor Chang
2d43a1ed84 Merge "Revert "Don't use framework strings for formatting file sizes"" 2018-01-04 17:35:19 +00:00
TreeHugger Robot
820df35539 Merge "Change underlying preferenceControllers to an ArrayMap of Lists." 2018-01-04 02:45:27 +00:00
TreeHugger Robot
4082c6b266 Merge "Convert trust agent pref list logic to PreferenceController" 2018-01-04 01:49:38 +00:00
Ben Lin
9275177002 Change underlying preferenceControllers to an ArrayMap of Lists.
Previously, DashboardFragment stores preference controllers in an
ArrayMap of <Class, AbstractPreferenceController>. Thus when there are
multiple controllers of same class (ie. multiple
PreferenceCategoryControllers), they cannot be stored simultaneously.
This changes the value to a List so we can store multiple controllers of
the same Class without extraneous sub-classing.

Bug: 70949662
Test: All existing tests still pass.
Added
DashboardFragmentTest#testPreferenceControllerSetter_shouldAddAndNotReplace
and DashboardFragmentTest#updateState_doesNotSkipControllersOfSameClass.
Change-Id: I397e8c91977ea1180d48a3af75dd4058bf1175c0
2018-01-03 17:03:59 -08:00
Ben Lin
1ed3e36134 Add ability to show/hide items for Special Access.
This adds five new boolean flags:
config_show_high_power_apps
config_show_device_administrators
config_show_premium_sms
config_show_data_saver
config_show_enabled_vr_listeners

Which when individually set to false, will hide the respectively item
from "Special Access" in Apps & notifications. It will also hide them
from surfacing in search results.

Bug: 70907131
Test: Updated SpecialAccessSettingsTest, and created:
HighPowerAppsControllerTest
DeviceAdministratorsControllerTest
PremiumSmsControllerTest
DataSaverControllerTest
EnabledVrListenersControllerTest

Change-Id: I5ad58755643e71d4fb71774404ad96c127440ae4
2018-01-03 16:25:09 -08:00
TreeHugger Robot
00dcd71297 Merge "Update EncryptionStatusPrefController to BasePrefController" 2018-01-03 22:35:18 +00:00
Fan Zhang
9a38ed459b Convert trust agent pref list logic to PreferenceController
Bug: 32953042
Test: robotests
Change-Id: I1420e90d4910a11fc5837ef2e150c822635b74a5
2018-01-03 14:32:41 -08:00
TreeHugger Robot
ed32f1dac7 Merge "Add ability to show/hide Wi-Fi settings, and all related sub-settings." 2018-01-03 21:56:32 +00:00
Ben Lin
848f67d17a Add ability to show/hide Wi-Fi settings, and all related sub-settings.
This adds a new boolean flag, config_show_wifi_settings, which when set
to false will hide the "Wi-Fi" page in network & internet (there is no
key value associated with this preference page). It will also hide
nested pages from search results, such as Wi-Fi preferences.

Bug: 62379554
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=ConfigureWifiSettingsTest
and
make RunSettingsRoboTests
ROBOTEST_FILTER=WifiSettingsTest
and
make RunSettingsRoboTests
ROBOTEST_FILTER=WifiMasterSwitchPreferenceControllerTest
all pass.

Change-Id: Iedc6bc272e0cb2b561c6bf25968e70f355aaaa8e
2018-01-03 20:05:55 +00:00
TreeHugger Robot
0590137ab2 Merge "Remove Suggestion v1 code." 2018-01-03 19:31:34 +00:00
TreeHugger Robot
5ae6073c19 Merge "Convert some security setting logic to PreferenceController" 2018-01-03 18:46:32 +00:00
Fan Zhang
e9394d828c Update EncryptionStatusPrefController to BasePrefController
Bug: 32953042
Test: robotests
Change-Id: I273d299c433e9886cb09a8527cdb6cdd0d755d0e
2018-01-03 10:36:27 -08:00
Ben Lin
4983dc1227 Add ability to show/hide accessibility_shortcut_preference.
This adds a new boolean flag,
config_show_accessibility_shortcut_preference, which when set to false
will hide the accessibility shortcut preference item.

Bug: 62387367
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=AccessibilitySettingsTest
Change-Id: I3fd941695df1ad89f717f464d2383be909839a3b
2018-01-03 10:36:01 -08:00
Victor Chang
75325675de Revert "Don't use framework strings for formatting file sizes"
This reverts commit ded99003c4.

- Add java import in order to build successfully
- Fix RunSettingsRoboTests

Test: adb shell am instrument -w -e class
com.android.settings.utils.FileSizeFormatterTest
com.android.settings.tests.unit/android.support.test.runner.AndroidJUnitRunner
Test: make -j RunSettingsRoboTests
Bug: 70005649
Bug: 36994779
Change-Id: I1c0ff48c749e9fbb82fd670c27243bd3922ed373
2018-01-03 14:33:24 +00:00
TreeHugger Robot
2c0cee4143 Merge "Fork SecuritySettings page and hide behind a feature flag." 2018-01-03 02:02:58 +00:00
Fan Zhang
0b47bb4bf3 Convert some security setting logic to PreferenceController
- Manage trust agent
- Show password
- Sim lock
- Screen pinning

Bug: 32953042
Test: robotests
Change-Id: I0c781a505238cae7a6643b701b750ca63a87a8a5
2018-01-02 16:32:53 -08:00
Fan Zhang
1e27d2b28e Remove Suggestion v1 code.
Change-Id: Ie6e9c8f2b1b5b609d44e287accb9fbbef9054d34
Fixes: 68719093
Test: robotests
2018-01-02 14:48:56 -08:00
Fan Zhang
f314494f32 Fork SecuritySettings page and hide behind a feature flag.
Bug: 32953042
Test: robotests
Change-Id: Ibbb4221eef87f09ccd024146517707680180a100
2018-01-02 13:42:53 -08:00
Julia Reynolds
9c3d329de6 Allow switchbars to have alternate text
For when On and Off aren't descriptive enough.

Bug: 63927402
Test: make -j20 RunSettingsRoboTests
Change-Id: I1e12d8d92dbe2f0a4c5202667cf1a76f0428e048
2018-01-02 15:34:58 -05:00
TreeHugger Robot
0dad10bc99 Merge "Import translations. DO NOT MERGE" 2017-12-23 00:47:11 +00:00
Bill Yi
bf2ff34004 Import translations. DO NOT MERGE
Change-Id: I7e2bf66b896c6fab42a643a7c74535b354b0d94c
Auto-generated-cl: translation import
2017-12-22 15:05:08 -08:00
Lei Yu
ef61c27865 Merge "Add summary placeholder for bt preference" 2017-12-22 22:17:28 +00:00
jackqdyulei
6c94769e56 Add summary placeholder for bt preference
Then UI won't be janky(as everything slide down a little bit)

Bug: 63910184
Test: RunSettingsRoboTests
Change-Id: Ie4074694f54af92da52f09d2caaab5490fa73647
2017-12-22 10:25:04 -08:00