Commit Graph

43063 Commits

Author SHA1 Message Date
Doris Ling
dc72c9dc52 Add a default preference controller for developer options.
- some of the preferences in the developer options page do not have a
preference controller associated with them, because they are simple
preference that do not require any update on the preference state at
all. However, they still need to be enabled/disabled when the master
developer options switch is turned on/off. Adding a default controller
to be used for these preferences.

Bug: 73955632
Test: manual
Change-Id: Ifb757dee2e5957d266ebb6ad5421d8ff9adbb142
2018-03-01 17:41:04 -08:00
TreeHugger Robot
3a7404ec69 Merge "Support Slice type in SliceData" 2018-03-02 00:48:08 +00:00
Antony Sargent
b513ca9303 Move force stop button back out of options menu
In ag/3485781 we moved the force stop button up into the options
menu, but it turns out we didn't actually want to do that. This
CL reverts that change.

Bug: 72948647
Test: make RunSettingsRoboTests
Change-Id: Id687dbde378dc9d95d88a9c188762094d05b6561
2018-03-01 16:06:42 -08:00
Doris Ling
92ffa4e4f0 Merge "Reduce max suggestion to show to 2." 2018-03-01 23:48:55 +00:00
TreeHugger Robot
c610324099 Merge "Remove unnecessary onDeveloperOptionsSwitchEnabled/Disabled override." 2018-03-01 23:35:45 +00:00
Matthew Fritze
1e9d9c7054 Support Slice type in SliceData
Add a getter for Slice type for BasePreferenceController.
This facilitates the generation of all possible Slices for Settings
search and discovery for AGSA.

Bug: 62807132
Test: robotests
Change-Id: I2cba1fc72c95769ecc26c76d1f2faa49a285d077
2018-03-01 15:25:14 -08:00
Sean Callanan
1619695402 Merge "Add a preview image to the color mode preference." 2018-03-01 22:39:23 +00:00
TreeHugger Robot
63c34f1e0c Merge "Gateway whitelist AdvancedConnectedDeviceDashboardFragment" 2018-03-01 22:33:30 +00:00
Bill Yi
509d7bbc5d Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I22bc99cc231771403dd9be9ec77fa0391e4e874d
2018-03-01 14:23:13 -08:00
Doris Ling
7d59c441b8 Reduce max suggestion to show to 2.
- since we now either have 1 or 2 suggestions, putting most layout
configuration in the xml instead of dynamically setting it in code.
- remove the suggestion header
- vertical center align the suggestion title text for 2 cards to make
the card with single line looks better.
- tint all suggestions icons.

Change-Id: I0130f15d530264e164e5afd7c091f165a4a6adc2
Fixes: 70573674
Fixes: 73293989
Fixes: 64986736
Test: visual and make RunSettingsRoboTests
2018-03-01 14:16:07 -08:00
Jack He
3acb158d01 Merge "Bluetooth: Use config value for default max connected audio devices" am: 57f8e717c7 -s ours am: 786fa66b6d
am: 6852928a75  -s ours

Change-Id: I5b67825bd9ff42bc467b078225630f4bafa7de2c
2018-03-01 21:59:07 +00:00
Doris Ling
4fbf04cd10 Remove unnecessary onDeveloperOptionsSwitchEnabled/Disabled override.
- default implementation has been added in the super class to handle
enabling/disabling the preference when the master developer options
switch it turned on/off. Removing all subclass that originally
implemented the methods that only contains the default behavior.

Bug: 73955632
Test: make RunSettingsRoboTests
Change-Id: I13c372c2ab498a5786b40cdc1ad3b5f3424abb5a
2018-03-01 13:58:29 -08:00
Jack He
6852928a75 Merge "Bluetooth: Use config value for default max connected audio devices" am: 57f8e717c7 -s ours
am: 786fa66b6d

Change-Id: Ibec2e409300f36f36f2ec005233d32bd4c712e51
2018-03-01 21:44:28 +00:00
Jack He
786fa66b6d Merge "Bluetooth: Use config value for default max connected audio devices"
am: 57f8e717c7  -s ours

Change-Id: I9b6e16237723c8a5903d011d2ee6a948c4f3ed47
2018-03-01 21:40:20 +00:00
Bill Yi
b01f2e9d8c Import translations. DO NOT MERGE
Change-Id: If2bca1217c41be1c07ef882014759419562cea81
Auto-generated-cl: translation import
2018-03-01 13:27:27 -08:00
Fan Zhang
747f0e14ef Gateway whitelist AdvancedConnectedDeviceDashboardFragment
- Discovered a few more fragments that weren't whitelisted, so I
  whistlisted those as well.
- Also found ZenModeExternalRuleSettings is misconfigured in manifest
  and no longer needed, so deleted all artifacts about this activity.

Fixes: 74060141
Test:  atest
Change-Id: I159e403bfa6707e2939d075ecc2b8d2f13514153
2018-03-01 13:17:21 -08:00
Sean Callanan
2dd4377423 Add a preview image to the color mode preference.
For high-color displays, it's desirable to have a preview of the
impact the user's color preference will have on images.  This commit
adds that functionality to ColorModePreferenceFragment by extending
RadioButtonPickerFragment to support static content.

The image used here is a placeholder pending UX.

Bug: 73670362
Test: Added a test verifying that the preview is added correctly.
Change-Id: Id54316bbef6a22291a8e8acbda5fcb2839b88c23
2018-03-01 13:10:26 -08:00
Treehugger Robot
57f8e717c7 Merge "Bluetooth: Use config value for default max connected audio devices" 2018-03-01 19:34:20 +00:00
Oscar Shu
46d6ecc2b1 Merge "Adding Wifi setting to special_access settings" 2018-03-01 17:20:50 +00:00
Anton Hansson
9ee4eda7e8 Merge "packages/apps/Settings: Set LOCAL_SDK_VERSION where possible." 2018-03-01 10:26:48 +00:00
TreeHugger Robot
e00a14b14c Merge "ChooseLockPassword should not show "confirm" until min length is met" 2018-03-01 04:45:25 +00:00
TreeHugger Robot
bb2dc211fc Merge "Bluetooth: Use config value for default max connected audio devices" 2018-03-01 03:25:41 +00:00
Kevin Chyn
8fa48999ed Merge "ChooseLockPassword shows wrong string when confirmed password is wrong" 2018-03-01 03:02:00 +00:00
Jack He
77ee7ea00d Bluetooth: Use config value for default max connected audio devices
* The first option in Bluetooth max connected audio devices preference
  should be using system default
* Added template based string array to show system default in the list
  preference and in preference summary when default is chosen
* Reset max connected audio devices property to empty string when
  development setting is disabled or when system default is chosen
* Fix a bug by saving selected value to list preference so that it
  persists when user re-opens development settings

Bug: 64767509
Test: Enable and disable multi-device mode in development settings
Change-Id: I4915f12df0ac0e6f715e44e0df4a3707dde8d1a4
Merged-In: I4915f12df0ac0e6f715e44e0df4a3707dde8d1a4
2018-02-28 18:34:52 -08:00
Jack He
2b0dbf7d24 Bluetooth: Use config value for default max connected audio devices
* The first option in Bluetooth max connected audio devices preference
  should be using system default
* Added template based string array to show system default in the list
  preference and in preference summary when default is chosen
* Reset max connected audio devices property to empty string when
  development setting is disabled or when system default is chosen
* Added instrumentation test to check preference array size and whether
  default value is within range of preference array values
* Modified robolectric tests to verify the updated behaviors

Bug: 64767509
Test: Enable and disable multi-device mode in development settings
      make -j32 RunSettingsRoboTests
      atest SettingsUnitTests:BluetoothMaxConnectedAudioDevicesPreferenceControllerInstrumentationTest
Change-Id: I4915f12df0ac0e6f715e44e0df4a3707dde8d1a4
2018-03-01 02:01:30 +00:00
Kevin Chyn
405a426a36 ChooseLockPassword should not show "confirm" until min length is met
Fixes: 70561465

Test: manual test with setting pin/pw
Change-Id: I545202f508fa7b1a73b9a2e66a8f8216deba7555
2018-02-28 17:52:34 -08:00
TreeHugger Robot
43a2878215 Merge "Auto update summary for mobile network preference." 2018-03-01 01:42:32 +00:00
TreeHugger Robot
f5b8aedcf5 Merge "Remove custom updateState() if it's just setting summary" 2018-03-01 01:29:22 +00:00
Kevin Chyn
d7b4b1b951 ChooseLockPassword shows wrong string when confirmed password is wrong
Fixes: 70561469

Test: try to setup a password/pin, but type in a wrong pw/pin
      when confirming. the button should stay as "confirm" instead of
      reverting to "next"

Change-Id: Iea570c2d869b9d561b26046d30d08f40abca0c93
2018-02-28 17:28:15 -08:00
TreeHugger Robot
6f271c4287 Merge "Under "recent location requests", add "See all"" 2018-02-28 23:46:32 +00:00
TreeHugger Robot
220d403643 Merge "Update tests for string changes" 2018-02-28 23:22:30 +00:00
Fan Zhang
b3b5082536 Auto update summary for mobile network preference.
Change-Id: Ic7854ef4d2d710dff528244a5e5fb75708740d2e
Fixes: 73504707
Test: robotests
2018-02-28 15:22:09 -08:00
Fan Zhang
04f1423bfa Remove custom updateState() if it's just setting summary
Change-Id: I6311d67d6ba11961a6814b91dcd8e37a2e17df40
Fixes: 73950519
Test: rerun robotests
2018-02-28 15:22:09 -08:00
Maggie
51fc2889f8 Under "recent location requests", add "See all"
Under Settings -> Security & Location -> Location, add "See all" button
under recent location requests

On location settings page, display at most 3 recent location requests.
If there are more than 3, show a "see all" button.
When user clicks "See all", take them to a new fragment with all recent
location requests.

Test: Robo
Test: Manual
Bug: 70350519
Change-Id: Id1f9a8da1593814a8f30f8e6ec8ac75fb10f6672
2018-02-28 12:58:42 -08:00
TreeHugger Robot
14fa2df9f4 Merge "Add summary for Display->Color settings." 2018-02-28 20:52:27 +00:00
TreeHugger Robot
9bd9e464c9 Merge "Force shortcuts to launch as the root of a new task" 2018-02-28 20:27:32 +00:00
TreeHugger Robot
6eb62e4115 Merge "Fix crash when launching about phone v2 through intent" 2018-02-28 19:37:57 +00:00
Doris Ling
be2a265bda Add summary for Display->Color settings.
Change-Id: Ia1332b4e3333099878ee52342c64b3d8595fdd94
Fixes: 73773857
Test: make RunSettingsRoboTests
2018-02-28 11:29:36 -08:00
Fan Zhang
a85dd50842 Force shortcuts to launch as the root of a new task
Otherwise it will try to find a existing task affinity, which can be
stale.

Test: manual
Change-Id: If2982612bf8789e726757e9fda1f70af47274a9e
Fixes: 73710228
2018-02-28 11:12:05 -08:00
Salvador Martinez
b77347619a Update tests for string changes
Some tests were validating strings for enhanced estimates. Since
those strings have been updated the tests in Settings need to be
updated to reflect those changes.

Test: Is a test change
Bug: 73290523
Bug: 72996609
Bug: 73904361
Change-Id: I5a175eb89539544bc10647a5373bd064efa3dbf7
2018-02-28 10:23:58 -08:00
Fan Zhang
cfd79a9a7a Fix crash when launching about phone v2 through intent
Change-Id: Ife6c24a7127fc9821760f9f5b58a33437711bc25
Fixes: 73971752
Test: atest
2018-02-28 10:21:32 -08:00
TreeHugger Robot
49620e85c6 Merge "Remove duplicate test" 2018-02-28 18:03:14 +00:00
Jan Nordqvist
7bcddb1f3c Merge "Fixed failing launch of Data usage activty from data saver suggestion." 2018-02-28 17:21:16 +00:00
Anton Hansson
d42d31eaa0 packages/apps/Settings: Set LOCAL_SDK_VERSION where possible.
This change sets LOCAL_SDK_VERSION for all packages where
this is possible without breaking the build, and
LOCAL_PRIVATE_PLATFORM_APIS := true otherwise.

Setting one of these two will be made required soon, and this
is a change in preparation for that. Not setting LOCAL_SDK_VERSION
makes the app implicitly depend on the bootclasspath, which is
often not required. This change effectively makes depending on
private apis opt-in rather than opt-out.

Test: make relevant packages
Bug: 73535841
Change-Id: I8dbe76fee202a571b1492b598035cc7b92e4433f
2018-02-28 11:26:29 +00:00
Victor Chang
614de3b79a Merge "Fix not delivering result to fragment using SubSettingLauncher" 2018-02-28 10:59:36 +00:00
TreeHugger Robot
fc9eeb6397 Merge "Change PreferenceController#getSummary return type." 2018-02-28 08:40:29 +00:00
Fan Zhang
906572b127 Change PreferenceController#getSummary return type.
Return CharSequence instead of String.

All user visible string should be modeled as CharSequence.

Bug: 73950519
Test: robotest
Change-Id: I30befef0c33f94351d4a2774e283bd1ed804aa8b
2018-02-27 22:30:12 -08:00
Andreas Gampe
f6cba5d9b5 Merge changes I06df032d,Ib923de28 am: 59a548b940 am: 34f43b50ce
am: fd99b8b009  -s ours

Change-Id: I0eab3f2bdcbacb8a4fc3bc4d171299c74c806c56
2018-02-28 05:16:29 +00:00
Andreas Gampe
fd99b8b009 Merge changes I06df032d,Ib923de28 am: 59a548b940
am: 34f43b50ce

Change-Id: I0bb87911c11685bcc8caa58d5a3ce9cf044e4ee1
2018-02-28 04:51:14 +00:00
Andreas Gampe
34f43b50ce Merge changes I06df032d,Ib923de28
am: 59a548b940

Change-Id: I4d1314379ba77c07b64c3ca5c77a61f9a54d4c1d
2018-02-28 04:37:06 +00:00