Commit Graph

43063 Commits

Author SHA1 Message Date
Treehugger Robot
f94ff6ce6f Merge "Fix memory leak of page "Languages & input"" 2018-02-01 23:41:43 +00:00
Doris Ling
e679e9b1b4 Fixes crash from selecting uninstalled app info from recents.
- when the package is uninstalled, also remove it from the recent tasks
- move retrieveAppEntry() from onCreate() to getPreferenceControllers()
so that if the package info is invalid, do not create any controllers,
as the activity will be finished anyway.

Change-Id: Ibbfa16e3d1f941a0a200e78ec73a06ca8511f82b
Fixes: 72656345
Test: make RunSettingsRoboTests
2018-02-01 14:37:25 -08:00
Beverly
c5ae162768 Zen Condition text and primary click changes
- Zen condition in settings has same secondary text as dnd qs tile
- Zen condition's primary click brings user to DND settings instead of
ZenPanel

Test: manual
Change-Id: I0090c09e19376d3aafff45a893485d19cd7b91da
Fixes: 72570739
2018-02-01 17:24:49 -05:00
TreeHugger Robot
a03335e0b9 Merge "Hide "Phone number" from About page if not call enabled." 2018-02-01 21:08:51 +00:00
Fan Zhang
3d516e7607 Highlight row (instead of ripple) when come from search.
- Moved HighlightableAdapter to its own class
- Replaced ripple with blue background
- Bluebackground only stays for 5 seconds. After that it's replaced by
  ?attr/selectableBackground

Misc fixes.

- Fix NPE in UserSettings
- Update char limit on a new string

Change-Id: I4687e54e71fd7b9243f520b7630563df58be23d4
Fixes: 71715698
Fixes: 72761974
Test: robotests
2018-02-01 12:35:25 -08:00
TreeHugger Robot
b67375876c Merge "Enforce disallow switch user in user settings" 2018-02-01 19:47:44 +00:00
TreeHugger Robot
0186c9d223 Merge "Check icon tintable flag of the Suggestion." 2018-02-01 19:12:35 +00:00
TreeHugger Robot
12fd732b55 Merge "Handle the Settings.DEVICE_NAME_SETTINGS intent." 2018-02-01 18:24:51 +00:00
Alex Chau
ffae4c1a0e Enforce disallow switch user in user settings
Disallow the following actions which result in switch user when DISALLOW_USER_SWITCH is set
- Creating guest
- Showing user setup dialog for newly created user
- Clicking uninitialized user preference

Bug: 71694430
Test: CTSVerifier DeviceOwnerPositiveTest - DISALLOW_USER_SWITCH
Test: m -j ROBOTEST_FILTER=UserCapabilitiesTest RunSettingsRoboTests
Test: m -j ROBOTEST_FILTER=AddUserWhenLockedPreferenceController RunSettingsRoboTests
Test: m -j ROBOTEST_FILTER=UserSettingsTest RunSettingsRoboTests
Change-Id: Ia4c7e7b4947bfaf2ebeef4d32a473bdac542d6a6
2018-02-01 17:49:41 +00:00
TreeHugger Robot
3d8e2c44cb Merge "Enable the Advanced Connected settings." 2018-02-01 04:52:34 +00:00
Dmitry Shmidt
6e5c590d0c Merge "Fix dev settings crash when no OEM unlock service" am: 44cacaa8f1 am: f6d960ac31
am: 2ac3120a01  -s ours

Change-Id: I6df41d962d18ba21424dc408340f6eaaa239c095
2018-02-01 03:25:52 +00:00
jackqdyulei
dbaea5af63 Clean up WifiTetherPreferenceController
In previous code there are two main issues:
1. It listens to update from both WIFI_AP_STATE_CHANGED_ACTION and
ACTION_TETHER_STATE_CHANGED. It is unnecessary because they provides
same info(whether wifi hotspot is enabled, enabling...)

2. New API softApCallback already covers the
WIFI_AP_STATE_CHANGED_ACTION, so we don't need this broadcast anymore.

This cl fixes those two issues by cleaning up BroadcastReceiver and
update the tests.

Bug: 72702183
Test: RunSettingsRoboTests
Change-Id: I21c2818e0f0185172f34447a1716dc47ee065e23
2018-01-31 18:21:53 -08:00
Daniel Nishi
b4b448e9f5 Enable the Advanced Connected settings.
This allows the intent to work. Otherwise, the receiver isn't there.

Change-Id: I0005d451e9fa4565f5a27a83a5464a8db59ef5a8
Fixes: 72764649
Test: Predictive settings test spec manually ran
2018-01-31 17:47:33 -08:00
TreeHugger Robot
e333b46d2c Merge "Tweak searchbar padding" 2018-02-01 00:55:32 +00:00
Doris Ling
0e96107ddc Check icon tintable flag of the Suggestion.
- instead of checking the icon resource package, check the icon tintable
flag to see if we should tint the suggestion icon.

Bug: 72330968
Test: make RunSettingsRoboTests
Change-Id: I4767df05bebf815774dbd8e528c7ac0f5b902d44
2018-01-31 16:55:10 -08:00
Dmitry Shmidt
2ac3120a01 Merge "Fix dev settings crash when no OEM unlock service" am: 44cacaa8f1
am: f6d960ac31

Change-Id: I536daa3948be136524e35e35448df09eaa6ad9da
2018-02-01 00:29:23 +00:00
Dmitry Shmidt
f6d960ac31 Merge "Fix dev settings crash when no OEM unlock service"
am: 44cacaa8f1

Change-Id: Ica60f5411908a8edb34b9263ee8d6d6b4617587b
2018-02-01 00:19:30 +00:00
Dmitry Shmidt
44cacaa8f1 Merge "Fix dev settings crash when no OEM unlock service" 2018-01-31 23:46:54 +00:00
Jerry Zhang
240f8c14bf Merge "Add new USB details screen for Connected Devices 2.0" 2018-01-31 23:41:32 +00:00
TreeHugger Robot
644bea8e0e Merge "Use SystemUpdateManager to provide system update info." 2018-01-31 22:05:21 +00:00
Fan Zhang
49d82be744 Tweak searchbar padding
Change-Id: Ied7b803ae05eb8d69b478675c7c3e66fb39e4d1c
Fixes: 72317470
Test: visual
2018-01-31 13:35:46 -08:00
TreeHugger Robot
b832f737c3 Merge "Remove suggestion UI v1 codes." 2018-01-31 21:15:18 +00:00
Fan Zhang
74731f9fa6 Merge "Misc fixes for account/users fragments" 2018-01-31 21:13:31 +00:00
Fan Zhang
5c2699962b Use SystemUpdateManager to provide system update info.
Change-Id: I38b631cda8aa63e478c74625eba3d18f9a5723bd
Fixes: 36874007
Test: robotests
2018-01-31 12:16:17 -08:00
Jason Monk
8337ad3be6 Fix dev settings crash when no OEM unlock service
Test: Open dev settings, no crash
Change-Id: I028c52ee58d7262e9fbd015289d7848b397c82e3
2018-01-31 14:55:58 -05:00
TreeHugger Robot
295a55b2fd Merge "AR/FR: Keyboard challenge takes precedence." 2018-01-31 19:42:03 +00:00
Jerry Zhang
d18d6f1022 Add new USB details screen for Connected Devices 2.0
Also updated UsbBackend to use the new UsbFunctions
api.

Added new unit tests for UsbDetailsHeaderController
and UsbDetailsProfilesController.

Bug: 69333961
Test: make RunSettingsRoboTests
Change-Id: I133750190bb61dfe0e20b06f50e50ea13b347f1e
2018-01-31 11:23:08 -08:00
Doris Ling
a5d0c3e36e Remove suggestion UI v1 codes.
- remove the check for feature flag for suggestion UI v2 and switch to
use the v2 codes.
- remove all code related to v1 of suggestion UI

Fixes: 70573674
Test: make RunSettingsRoboTests

Change-Id: I99ab318c1c0192508a9c5e9e708e86319120d55b
2018-01-31 10:59:40 -08:00
Fan Zhang
dc2a3528d5 Misc fixes for account/users fragments
- Hide add user button when it's not functional
- Display "No accounts added" under accounts setting when there is no account.

Change-Id: Iefede9939d206eb3064fa22bdcfbcb1e826f29ab
Fixes: 72643060
Test: robotest
Test: 72713118
2018-01-31 10:55:40 -08:00
Julia Reynolds
07c2cdee1f Merge "Notification settings updates" 2018-01-31 17:09:51 +00:00
Maurice Lam
f5b42777c1 Support GLIF v3 for lock screen settings
Also removed setup_divider_color because it's unused and is causing
a lint error.

Test: cd tests/robotests && mma
Bug: 72702989
Change-Id: I81894be6458439f688c0144d1136d3d7f75afa25
2018-01-30 21:01:42 -08:00
TreeHugger Robot
54e304b897 Merge "Fix homepage icon margin" 2018-01-31 03:18:29 +00:00
Carlos Valdivia
4b34dad4cd AR/FR: Keyboard challenge takes precedence.
Tested manually by:
(1) Setting up a gmail account.
(2) Setting up a screen pattern.
(3) Going to Settings > System > Reset Options > Factory Wipe
(4) Hit the Erase button.
(5) Enter pattern into the Screenlock prompt.
(6) Notice the Google credential confirmation screen.

Prior to this change we would skip (5) if there was a Google account on
the device.

Test: make RunSettingsRoboTests ROBOTEST_FILTER=andorid.settings.MasterClear
Bug: 72694056

Change-Id: Ie07c678ecbc8361e8e1792f82efdfb1261db49fb
2018-01-30 18:39:45 -08:00
TreeHugger Robot
ac1fc5c9b7 Merge "Re-add isSuggestionEnabled check" 2018-01-31 01:11:52 +00:00
Ben Lin
7190f85392 Add ability to show/hide different device information.
This introduces 3 boolean flags:

config_show_device_model
config_show_wifi_ip_address
config_show_wifi_mac_address

Which when set to false will hide their individual panes from "About
Phone" page.

Bug: 62414913
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=com.android.settings.deviceinfo
Change-Id: Iaaf91ef41c9ec7b5bf233344e6a48d4b87fad291
2018-01-30 16:53:57 -08:00
Ben Lin
9703a9757a Hide "Phone number" from About page if not call enabled.
Bug: None
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=com.android.settings.deviceinfo
Change-Id: Ib056bae12d23fe68e71fe78c92741b8dc7887de0
2018-01-30 16:04:11 -08:00
Fan Zhang
d186874b35 Fix homepage icon margin
Change-Id: Ie9a7be625bb51336ef4eda05d24c61ec9cc264e8
Fixes: 69314641
Test: visual
2018-01-30 15:54:48 -08:00
Fan Zhang
0ec6b02fe4 Re-add isSuggestionEnabled check
It was accidentally removed previously

Test: robotest
Change-Id: I5b7707e746d6b825d835a007727b29c9a81a7fc1
2018-01-30 15:41:33 -08:00
TreeHugger Robot
10cdf29b53 Merge "Center align suggestion tile action button." 2018-01-30 22:44:27 +00:00
TreeHugger Robot
818b37d337 Merge "Add a few UI tests" 2018-01-30 22:01:25 +00:00
Julia Reynolds
4f3b556388 Notification settings updates
- Footer preferences were too dim
- Fix text and target on recently sent apps
- Make 'behavior' a dialog
- reorder settings on apps page

Change-Id: Idf8056bc77ead89fe2025bbde3346861e23a3c8d
Fixes: 72652526
Fixes: 72651810
Fixes: 72652024
Bug: 72651953
Test: make RunSettingsRoboTests
2018-01-30 16:59:12 -05:00
TreeHugger Robot
3b04494ac6 Merge "Change automatic brightness summary to absolute brightness." 2018-01-30 21:39:16 +00:00
Doris Ling
1fcd60c4b6 Center align suggestion tile action button.
Bug: 70573674
Test: visual
Change-Id: I9be36cb0f1c35c2062f01d03e01e0a74cb39f3a0
2018-01-30 12:50:17 -08:00
Fan Zhang
9a465f3f7f Add a few UI tests
- Verify storage setting display items
- Battery

Test: atest
Change-Id: Ia892e0e3265aa8bebda74df26dd67e6b12f5cb67
Fixes: 72461383
2018-01-30 12:12:58 -08:00
TreeHugger Robot
5dda7faac0 Merge "Remove app info page v1 related codes." 2018-01-30 19:57:48 +00:00
TreeHugger Robot
85fd529cc4 Merge "Remve menu item in battery settings" 2018-01-30 19:04:26 +00:00
TreeHugger Robot
e0bc26d6dd Merge "Use the correct prebuilts for lifecycles." 2018-01-30 18:50:45 +00:00
TreeHugger Robot
4b1f25ada4 Merge "Add UI tests for new time zone picker" 2018-01-30 12:04:25 +00:00
Jin Dong
d39c52f99e Fix memory leak of page "Languages & input"
When enter/exit from "Languages & input" screen repeatedly, memory
leak happens since InputDeviceListener is not unregistered.

Listener registration is called in onPause() when exiting from the
screen, but new activity is created when enter the screen and the
listener registered by previous activity is not unregistered in
onResume().

Bug: 72675680
Test: Manual - Repeat enter and exit "Language & input" page for
several times and check if the count of activity doesn't increase.
Change-Id: I8e0be0ab4b1d13d53c3868b10f409d1e06387c2f
2018-01-30 10:54:00 +00:00
TreeHugger Robot
7ad6c403e2 Merge "Update summary for fingerprint unlock suggestion." 2018-01-30 06:54:53 +00:00