Commit Graph

2673 Commits

Author SHA1 Message Date
Chaohui Wang
6e4ac4bdc0 Fix empty network scan result
Settings use TelephonyScanManager.NetworkScanCallback to scan, and its
onComplete() could happens before onResults().

We will change Settings to fix.

Fix: 338986191
Test: manual - on NetworkSelectSettings
Test: unit test
Change-Id: If41d957f916a99eacc1becb6b460e58722a4dca7
2024-05-10 16:19:40 +08:00
Chaohui Wang
e216fd4248 No show DisableSimFooterPreference when sub not found
DisableSimFooterPreferenceController.getAvailabilityStatus() used to
return AVAILABLE when the subscription is not found in selectable
subscription info list.

Return CONDITIONALLY_UNAVAILABLE in this case to fix.

Bug: 336232487
Test: manual - on Mobile Settings
Change-Id: I88642fc9853ce6603a78dfdc0e5fed1da1553adc
2024-05-10 15:08:53 +08:00
Kangping Dong
da0be0f6f4 Merge "[Thread] update Thread settings screen" into main 2024-05-10 02:39:46 +00:00
Kangping Dong
ab7f48dcde [Thread] update Thread settings screen
Per b/327098435 the new Thread settings design proposed
(go/android-thread) is approved.

As a summary, this commit adds a new "connected devices > connection
preference -> Thread" list item and decidated config page for Thread.
Also, we simplified the airplane mode to delegate it to the mainline
code to handle it

Bug: 327098435
Test: atest SettingsUnitTests
Merged-In: Iffbb2471f5a28ec57d30a378f22642fe6ac0b9cc
Change-Id: Iffbb2471f5a28ec57d30a378f22642fe6ac0b9cc
2024-05-09 14:19:13 +08:00
Kangping Dong
d454ac2963 [Thread] update Thread settings screen
Per b/327098435 the new Thread settings design proposed
(go/android-thread) is approved.

As a summary, this commit adds a new "connected devices > connection
preference -> Thread" list item and decidated config page for Thread.
Also, we simplified the airplane mode to delegate it to the mainline
code to handle it

Bug: 327098435
Test: atest SettingsUnitTests
Change-Id: Iffbb2471f5a28ec57d30a378f22642fe6ac0b9cc
2024-05-09 14:04:52 +08:00
tomhsu
c0b39601bf Show dialog on Wifi, and APM' entries in Settings
- When satellite mode is switched on Wifi, and APM entry shall show the warning dialog and avoid user uses these functions.

Bug: 337154438
Test: Manual test.
Test: atest pass
Change-Id: I45cd92a8688e7a619613361ea4a8d58a0984d99f
(cherry picked from commit 29b2f16edf)
Merged-In: I45cd92a8688e7a619613361ea4a8d58a0984d99f
2024-05-08 05:40:36 +00:00
Tom Hsu
c495d92a25 Merge "Show dialog on Wifi, and APM' entries in Settings" into main 2024-05-08 04:37:28 +00:00
tomhsu
29b2f16edf Show dialog on Wifi, and APM' entries in Settings
- When satellite mode is switched on Wifi, and APM entry shall show the warning dialog and avoid user uses these functions.

Bug: 337154438
Test: Manual test.
Test: atest pass
Change-Id: I45cd92a8688e7a619613361ea4a8d58a0984d99f
2024-05-08 03:53:32 +00:00
Mill Chen
63742cabe4 Merge "Deprecated Wifi panel and relevant objects" into main 2024-05-08 01:28:15 +00:00
Mill Chen
42ef04eb80 Merge "Deprecate Nfc panel and relevant objects" into main 2024-05-08 01:27:49 +00:00
Mill Chen
cf28a1bd8e Merge "Redirect Volume Panel to settings page" into main 2024-05-07 23:58:33 +00:00
Wesley Wang
9b68d1b5fb Fix AppStateAppBatteryUsageBridge test fail
- Remove mock context to fix the component cast issue

Bug: 337417563
Fix: 337417563
Test: atest SettingsUnitTests
Change-Id: I2d375a4828d2a7b020f15535383c07e4f017bb84
2024-05-07 16:38:12 +08:00
Mill Chen
f6895743cf Deprecate Settings panels and its infrastructure
Bug: 328525899
Test: robotest
Change-Id: I30bc423e31e9202e70c509459f4397c296c8423f
2024-05-06 22:47:07 +00:00
Mill Chen
840aa5e40b Deprecate Nfc panel and relevant objects
Bug: 328528962
Test: robotest
Change-Id: Ia2acf4268e9a444d8b4cfe36c6eb2bd198f4be64
2024-05-06 22:27:02 +00:00
Mill Chen
4c061771b7 Deprecated Wifi panel and relevant objects
Bug: 328529085
Test: robotest
Change-Id: I960718acbdf1d2be6c3b6b396cf2ac69d4aa3046
2024-05-06 22:22:52 +00:00
Mill Chen
e4f785c773 Redirect Volume Panel to settings page
Flag: com.android.settings.flags.slices_retirement
Bug: 328529042
Bug: 202262476
Test: manual test
adb shell am start -a android.settings.panel.action.VOLUME

Change-Id: I54f30d18eb10db864dcf5ee745b168b03e388b14
2024-05-06 18:13:37 +00:00
Chaohui Wang
ffcbbd375a Clean up MobileNetworkSummaryStatus
Fix: 338904413
Test: m Settings
Change-Id: Ic26bf7833c8fbdbeffc4f47dcd6dcd6191394e1b
2024-05-06 07:26:06 +00:00
Treehugger Robot
b48c66ebea Merge "settings: Make use of ACTION_NETWORK_PROVIDER_SETTINGS" into main 2024-04-30 21:44:24 +00:00
Manish Singh
0f4d761d93 Merge "Don't send data for non-main users" into main 2024-04-29 11:51:46 +00:00
Rafael Higuera Silva
1d307afd95 Merge "Extract and fix logic for showing rac dialog." into 24D1-dev am: 958b737fcc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/27072479

Change-Id: I9f5c4c8dea3c7aebc73b5121d6ace7aca22c1dfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-25 19:07:24 +00:00
Manish Singh
50b5bae531 Don't send data for non-main users
This is a regression caused by ag/26661827

Fix: 333872544
Test: manual
Test: atest PrivateSpaceSafetySourceTest
Change-Id: I0465899af3745fa39eab8806dbceb347d70b0aa3
2024-04-25 12:23:40 +00:00
Joseph Vincent
19d7d5be78 Merge "Mock LockPatternUtils.isSecure() method in test setup" into main 2024-04-25 11:53:15 +00:00
josephpv
6655fcd04e Mock LockPatternUtils.isSecure() method in test setup
Added mockd for LockPatternUtils class in test setup as per the comment
in b/323649600#comment7 to handle for the test failure bug.
The tests are passing locally without this.

Bug: 336518132
Test: atest com.android.settings.privatespace
Change-Id: Ie042bb7dd6edefef094d3b658946ff6eaaa6f801
2024-04-25 10:13:35 +00:00
Rafael Higuera Silva
36d99e8b09 Extract and fix logic for showing rac dialog.
Added tests to make sure the logic makes sense.

Bug: 335745726
Test: make, manual, atest SubscriptionUtilRoboTest, atest SubscriptionUtilTest, atest ResetNetworkTest
Change-Id: I7092f2747f1ca1f9ef4dc99275a916b9e24d8b28
2024-04-25 01:34:47 +00:00
David Jacobo
240b32fa91 settings: Make use of ACTION_NETWORK_PROVIDER_SETTINGS
This CL makes use of the newly introduced action for
NETWORK_PROVIDER_SETTINGS.

Bug: None
Test: atest -c ProviderModelSliceTest
Change-Id: Ie0ccde2f49502a634801401e1b33f1d4b9c7d728
2024-04-24 17:08:42 -07:00
Treehugger Robot
3d435c7283 Merge "Fix failure in BiometricsSafetySourceTest" into main 2024-04-24 08:35:59 +00:00
paulzhchen
5f391359e3 Reland add FeatureProvider for SyncAcrossDevices Settings integration.
Prior CL ag/26930404 was reverted because an unused class was
trimmed in AOSP, causing test cases to throw NoClassDefFoundError
exceptions. This CL combines ag/26930404 and ag/26995936 to address
the failure.

Bug: 330498032
Test: atest FakeFeatureFactory, atest SyncAcrossDevicesPreferenceControllerTest
Change-Id: I0a7ebccdebcad20e06d7542d7c4a0005885f393b
2024-04-24 02:02:35 +00:00
Elliot Sisteron
4fffb3ad64 Fix failure in BiometricsSafetySourceTest
Bug: 335886401
Change-Id: I07ce2a1f3b4938348c93208a35b1407960617917
Test: atest BiometricsSafetySourceTest
2024-04-23 10:57:47 +00:00
Pechetty Sravani
dbb7d1772b Merge "Revert "Add FeatureProvider for SyncAcrossDevices Settings integ..."" into main 2024-04-23 09:12:48 +00:00
Pechetty Sravani
ea26f2d729 Revert "Add FeatureProvider for SyncAcrossDevices Settings integ..."
Revert submission 26930404-syncacrossdevices

Reason for revert: Potential culprit for b/336431732- verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:26930404-syncacrossdevices

Change-Id: I9da0de82978fa6984a4636e0c9ccc891d9287fd2
2024-04-23 07:43:47 +00:00
Paulz Chen
319245cdbe Merge "Add FeatureProvider for SyncAcrossDevices Settings integration." into main 2024-04-22 23:52:23 +00:00
Elliot Sisteron
365c16b217 Reset SafetyCenterManagerWrapper instance between tests.
This is because some other tests may set a mock on this static value, which will persist across test cases (whereas in this test we want to test the real thing).

Bug: 335557039
Change-Id: I14fc81922761159241636c78dbd47fce7bfeb533
Test: atest SafetyCenterManagerWrapperTest
2024-04-22 14:49:57 +00:00
paulzhchen
132e7341ea Add FeatureProvider for SyncAcrossDevices Settings integration.
Bug: 330498032
Test: FakeFeatureFactory
Change-Id: Iccf7ca4411a03d29e9eeba6c1544ccbd95b97654
2024-04-22 06:58:31 +00:00
Chaohui Wang
ea89a3cb1d Not include user input in regex am: 4f5920c3f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/27048156

Change-Id: I2a3740b52b65ff650f309aa62a42e57f9ba8dffb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-22 06:34:24 +00:00
Chaohui Wang
4f5920c3f5 Not include user input in regex
Check prefix and remove prefix first, to avoid include user input in
the regex to fix.

Fix: 335136289
Test: manual - on SIMs
Test: unit test
Change-Id: Iff4dcfc3662c744d00b586d05e64b4f5fe33a0d8
2024-04-22 04:56:57 +00:00
Becca Hughes
862e71b73d Merge "Fix bug where empty section is sometimes shown" into main 2024-04-18 22:08:29 +00:00
Becca Hughes
1c3fb49913 Fix bug where empty section is sometimes shown
There is a bug where the empty section is
sometimes shown for additional providers. This
is because the logic for calculating the
visibility gets the providers and then the
logic for displaying the list gets the providers
and can result in getting out of sync. This aligns
both sets of logic to use the same data.

Test: ondevice & unit
Bug: 330163369
Change-Id: Icf71c78d67d55c929476f8e699d5893e60a49776
2024-04-18 19:52:15 +00:00
Samuel Huang
316e7bf3e6 Disable SIM On/Off operation when device is in Satellite Enabled Mode
Cherry-picking ag/26965536 into the 24D1-dev branch caused conflicts. Therefore, manually create this CL to migrate the MobileNetworkSwitchController to Kotlin and utilize Compose.

Bug: 315928920
Test: atest, manual
Change-Id: I215b5a4615a3b3da6fc160f76c85c814210cc3ef
Merged-In: I7aaaf43b4c449129197e7cc92565d274ffdd2d8c
2024-04-16 09:52:00 +00:00
shaoweishen
90e70b15d7 [Physical Keyboard] Clean up old ui and flag
Change-Id: I9423d0e9debcef37338e5733aab56b98920621e3

Test: n/a
Bug: 330517633
Change-Id: I485848f67e0eb3ab207413a6ed8f7de809f80c5c
2024-04-16 05:21:30 +00:00
josephpv
83f73732de Set SKIP_FIRST_USE_HINTS setting for private space
With this change the value of Secure settings SKIP_FIRST_USE_HINTS is
set for private profile after creation of profile in PS setup flow.

The value is set for the profile user so that first launch of an app in
private space will not display introductory hints.

Bug: 325596557
Test: PrivateSpaceMaintainerTest
Change-Id: I63a967bba052a3dcb4742c95b89c6da19aba74d5
2024-04-15 10:47:42 +00:00
Joseph Vincent
e926e87c4b Merge "Add mocks for LockPatternUtils.isSecure() method in setup" into main 2024-04-12 15:21:05 +00:00
josephpv
5e62407466 Add mocks for LockPatternUtils.isSecure() method in setup
This change adds mocking for LockPatternUtils.isSecure method in the
tests where SecurityFeatureProvider is referred in setup as per the
comment in b/323649600#comment7
The tests are passing locally even without this.

Bug: 333504640
Test: atest com.android.settings.privatespace
Change-Id: I7d9c3a8356dbf25cf09530ffb53712b3ab887160
2024-04-12 11:48:48 +00:00
Joshua Mccloskey
d152502aae Merge "Updated FakeFingerprintManagerInteractor" into main 2024-04-11 20:15:23 +00:00
Joseph Vincent
1ddef782c8 Merge "canAddPrivateProfile checks for private space creation test" into main 2024-04-09 10:48:41 +00:00
Tom Hsu
de9a888469 Merge "Listen wifi entry change to make sure UI correct." into main 2024-04-09 09:16:42 +00:00
Treehugger Robot
0f33518068 Merge "Add flag to control Internet preference" into main 2024-04-09 08:22:57 +00:00
tomhsu
91bcc2b594 Listen wifi entry change to make sure UI correct.
Bug: 319905522
Test: make pass.
Test: atest pass.
Change-Id: I0900caf6521bd9a250e85863f48e39668734f1be
2024-04-09 08:05:32 +00:00
Rafael Higuera Silva
363535192d Add new warning dialogue when user is Resetting mobile network settings.
If the user is reseting mobile network settings and have all these
conditions:
- No Wi-fi
- Has check to delete all eSIMs
- Has a least one RAC sim carrier
Then show the warning dialogue.

Test: make, manually test, atest SubSettingLauncherTest, atest ResetNetworkTest,  atest SubscriptionUtilTest
Bug: 328649510
Merged-In: I47d9b868b649b259d5e4008ec742317d2cb7cf51
Change-Id: I47d9b868b649b259d5e4008ec742317d2cb7cf51
(cherry picked from commit 147cc19b53)
2024-04-05 21:39:13 +00:00
Manish Singh
f2869fd64e Merge "Remove all Settings tasks from Recents when PS is locked" into main 2024-04-05 15:06:41 +00:00
josephpv
2c631fcd56 canAddPrivateProfile checks for private space creation test
Bug: 332854426
Test: atest PrivateSpaceMaintainerTest, atest PrivateSpaceDeletionProgressFragmentTest
Change-Id: I50ddd15f53e14b54a2d8df201b94f8423eec3d72
2024-04-04 17:33:54 +00:00