Commit Graph

3482 Commits

Author SHA1 Message Date
jeffreyhuang
1bb0091d94 Introduce AppsNotRespondingPreferenceController
- Create new AppsNotRespondingPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I9cf9a19b59bf21d6aa0205377025f82ed21b7e51
2017-09-29 16:25:39 -07:00
jeffreyhuang
7e81c84a8c Introduce UsbAudioRoutingPreferenceController
- Create new UsbAudioRoutingPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ie806d509e3df4515cccbaf56c259ae55c3e2ab61
2017-09-29 15:47:47 -07:00
jeffreyhuang
86e6304154 Introduce HardwareOverlaysPreferenceController
- Create new HardwareOverlaysPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller
 - Added ShadowParcel to help with testing
 HardwareOverlaysPreferenceController and
 ShowSurfaceUpdatesPreferenceController

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ib6b9679f2a2d2ec84f91da5ac0b68cb2b21eea72
2017-09-29 15:47:00 -07:00
jeffreyhuang
a02a9886c0 Introduce GpuViewUpdatesPreferenceController
- Create new GpuViewUpdatesPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller
 - Fix a typo in preference naming

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ieff20634238900137acc1524edb6fd0d4bfce894
2017-09-29 15:45:54 -07:00
jeffreyhuang
7cf6ba2aab Introduce ShowLayoutBoundsPreferenceController
- Create new ShowLayoutBoundsPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ie7bb26675f4dcedbff9607a2c4e4f5bee0343463
2017-09-29 15:43:42 -07:00
Fan Zhang
2985a0775d Create suggestion state provider.
- The provider now handles isSuggestionComplete check
- Remove SuggestionChecks class.

Bug: 65065268
Test: robotests
Change-Id: Id45d67d4a5146cc023f7fad7bb292b4c1c14a782
2017-09-29 15:42:20 -07:00
Jeffrey Huang
5ae503b383 Merge "Introduce StrictModePreferenceController" 2017-09-29 22:35:55 +00:00
TreeHugger Robot
a3fd9a16e5 Merge "Move code from SuggestionChecks to FeatureProvider" 2017-09-29 20:54:59 +00:00
Jeffrey Huang
d1e65e73ce Merge "Introduce ForceMsaaPreferenceController" 2017-09-29 20:50:36 +00:00
Jeffrey Huang
1f381ffc99 Merge "Introduce HardwareLayersUpdatesPreferenceCtrl" 2017-09-29 20:50:05 +00:00
Jeffrey Huang
76a2128fc0 Merge "Introduce ForceGpuRenderingPreferenceController" 2017-09-29 20:49:46 +00:00
Jeffrey Huang
1b1e66d61a Merge "Introduce RtlLayoutPreferenceController" 2017-09-29 20:49:19 +00:00
jeffreyhuang
99312bc947 Introduce StrictModePreferenceController
- Create new StrictModePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I28d70fd5c82de2427747625b5f06f79d3808a145
2017-09-29 13:46:57 -07:00
jeffreyhuang
28620a136f Introduce KeepActivitiesPreferenceController
- Create new KeepActivitiesPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I9e15d285eee51164dd5c3a07c4f2069bf4d73383
2017-09-29 13:43:52 -07:00
Fan Zhang
31f699c281 Move code from SuggestionChecks to FeatureProvider
This is step one to deprecate SuggestionChecks. Moving logic into
SuggestionFeatureProvider allows potential logic override and improves
testability.

Also moved isSuggestionComplete tests to corresponding activity/pref
controller test.

Bug: 65065268
Test: robotests
Change-Id: I2071d30fc58bb84acad2083ca03cfcf7d41f10cb
2017-09-29 11:36:16 -07:00
jeffreyhuang
6da6ea878f Fix a bug in show surface updates
- fix a bug that caused the master switch to unintentionally turn on
 the show surface updates preference

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I307a801aa1a7c1606b3f5d55a0d1f2dbf1d60416
2017-09-29 10:09:18 -07:00
jeffreyhuang
083ffe8c23 Introduce ForceMsaaPreferenceController
- Create new ForceMsaaPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I5d336037a6ae5904d0459fe56b311fac8372be86
2017-09-29 10:06:30 -07:00
jeffreyhuang
30c143b1e4 Introduce RtlLayoutPreferenceController
- Create new RtlLayoutPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ieefd8dc97b0e1f781d97aca781bba0243c3875b9
2017-09-29 09:53:07 -07:00
jeffreyhuang
a9f7c95f27 Introduce HardwareLayersUpdatesPreferenceCtrl
- Create new HardwareLayersUpdatesPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller
 - Fix a typo in preference naming

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I12744051c836b17ca2bfca5a84b9e22eb7b7d677
2017-09-29 09:51:08 -07:00
jeffreyhuang
e289ec4041 Introduce ForceGpuRenderingPreferenceController
- Create new ForceGpuRenderingPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ib3afb9278257f0c2b181e15f28650d9620538c17
2017-09-29 09:50:21 -07:00
Jeffrey Huang
ae6c29d10f Merge "Introduce ShowSurfaceUpdatesPreferenceController" 2017-09-28 22:46:35 +00:00
Eric Schwarzenbach
c03bd8f86f Fix "Add Network" button on SavedAccessPoints page.
Fix merge conflict.

The old onSubmit was a no-op. It now correctly pipes onSubmit to
WifiManager#save() with the new WifiConfiguration. On successful save,
it displays the new network in the list, and on failure, it displays a
toast indicating that the save action failed. Adds a test for the
WifiDialog behaviors on this page.

Bug: 66177765
Test: make RunSettingsRoboTests, manual - tested with Wifi enabled and
disabled, and with networks that were visible and not.
Change-Id: I27446aa49bc9efaf1ea1d6c6158928b62ce01ba2
2017-09-28 14:38:03 -07:00
Jeffrey Huang
13d469dabf Merge "Introduce BluetoothInbandRingingPreferenceCtrl" 2017-09-28 21:35:35 +00:00
jeffreyhuang
0c292c08dc Introduce ShowSurfaceUpdatesPreferenceController
- Create new ShowSurfaceUpdatesPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I649549af1c5dd9d541bc9e6a62b4553fa7877233
2017-09-28 13:47:42 -07:00
jeffreyhuang
755062ae7f Fix a failing test in AdbPreferenceControllerTest
- Mock out a problematic method

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ib12f1e852d27df705f5a13e73f29b0b6f4ab5ff6
2017-09-28 13:24:16 -07:00
jeffreyhuang
25ce51f4af Introduce BluetoothInbandRingingPreferenceCtrl
- Create new BluetoothInbandRingingPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I2551803b50323c93ce8f1595d5bbab92b7a18ed4
2017-09-28 11:19:21 -07:00
Jeffrey Huang
f77a3fbdc3 Merge "Introduce PointerLocationPreferenceController" 2017-09-28 18:07:05 +00:00
Jeffrey Huang
e6d8e9d374 Merge "Introduce BluetoothAbsoluteVolumePreferenceCtrl" 2017-09-28 18:06:37 +00:00
Jeffrey Huang
cfc2ede22f Merge "Introduce AdbPreferenceController" 2017-09-28 18:05:11 +00:00
TreeHugger Robot
bcc3b924f9 Merge "Refactor IndexData conversion flow" 2017-09-28 17:43:04 +00:00
jackqdyulei
b963125159 Merge "Hide summary for type system" into oc-mr1-dev am: aadee0997c
am: da9247d645

Change-Id: I440fcbfea0cf934e68737eb5314739e397d80d88
2017-09-28 02:18:59 +00:00
jackqdyulei
da9247d645 Merge "Hide summary for type system" into oc-mr1-dev
am: aadee0997c

Change-Id: I99a8cfefe4253ee223b91d2a3e0b9e7721e73ee4
2017-09-28 02:17:08 +00:00
TreeHugger Robot
aadee0997c Merge "Hide summary for type system" into oc-mr1-dev 2017-09-28 02:11:54 +00:00
Doris Ling
9a3fd4f7f1 Merge "Move listening to brightness changes to onStart/onStop." into oc-mr1-dev am: d52c4482e4
am: eccb0fcff9

Change-Id: Ic62d580bad8d520e9a1ec942ab30c361df9e24aa
2017-09-28 02:07:04 +00:00
Doris Ling
eccb0fcff9 Merge "Move listening to brightness changes to onStart/onStop." into oc-mr1-dev
am: d52c4482e4

Change-Id: I2206805a6b9dada11576a6e6667980585acc8472
2017-09-28 02:05:10 +00:00
TreeHugger Robot
d52c4482e4 Merge "Move listening to brightness changes to onStart/onStop." into oc-mr1-dev 2017-09-28 01:58:47 +00:00
TreeHugger Robot
f400a0cf13 Merge "Update Robolectric to 3.4.2" 2017-09-27 23:49:19 +00:00
Chien-Yu Chen
3ea5b0973f Settings: Show HAL HDR+ option in user build am: 4d26fa03a8
am: f0c328ed78

Change-Id: Ia14d7a5ada922d29816f8c9d2895f6141d86ff27
2017-09-27 23:35:18 +00:00
Chien-Yu Chen
f0c328ed78 Settings: Show HAL HDR+ option in user build
am: 4d26fa03a8

Change-Id: I9b94c91b0a212ca727b9ba2ee7fc75902f2590e4
2017-09-27 23:33:01 +00:00
TreeHugger Robot
af83bfa58f Merge "Settings: Correctly align cursor in Settings" 2017-09-27 22:47:40 +00:00
TreeHugger Robot
cc01bdc158 Merge "Settings: Show HAL HDR+ option in user build" 2017-09-27 22:45:27 +00:00
jeffreyhuang
5acf47e402 Introduce PointerLocationPreferenceController
- Create new PointerLocationPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ia2d190ec39d35e10d7ae6663584b993d16958d5e
2017-09-27 15:36:06 -07:00
TreeHugger Robot
0e680b3cfd Merge "Introduce ConnectivityMonitorPreferenceCtrlV2" 2017-09-27 21:36:55 +00:00
PMS22
63a0560a6c Settings: Correctly align cursor in Settings
Steps to Reproduce:
- Click on Density Settings (DPI Settings) / Renaming BT Device / Renaming SIM Settings
- EditText Dialog pops up
- The cursor is at the leftmost side of the text
- Logically Cursor should be at rightmost side which can be aligned grabbing text length

Screenshots:
Before:
http://imgur.com/a/o4vkr
http://imgur.com/a/6Qext

After:
http://imgur.com/a/fuxqT
http://imgur.com/a/vm2WX

Bug: 65185652
Test: RunSettingsRoboTests: OK (47 tests)

Change-Id: Id00308e7e019434edad4afab56cf4719be0d0d54
Signed-off-by: PMS22 <prathams99@rediff.com>
2017-09-27 14:12:32 -07:00
Chien-Yu Chen
bb41a76256 Settings: Show HAL HDR+ option in user build
Test: CameraHalHdrPlusPreferenceControllerV2Test
Bug: 66919557
Change-Id: Ibaadf1b24ba82a8440aae9058397c96db6f24188
2017-09-27 14:09:47 -07:00
Chien-Yu Chen
4d26fa03a8 Settings: Show HAL HDR+ option in user build
Test: CameraHalHdrplusPreferenceControllerTest
Bug: 66919557
Change-Id: I02e89d34db56398e64e12616f34b8584df25c48b
2017-09-27 14:03:12 -07:00
Jeffrey Huang
3e6488448c Merge "Introduce ShowTapsPreferenceController" 2017-09-27 20:02:51 +00:00
Jeffrey Huang
a56dc5a329 Merge "Introduce TetheringHardwareAccelPreferenceCtrl" 2017-09-27 20:02:25 +00:00
jeffreyhuang
8d8f1663b4 Introduce AdbPreferenceController
- Create new AdbPreferenceController
 - Create AdbOnChangeListener interface for adb change callbacks
 - Create EnableAdbSettingWarningDialog
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller
 - Add deprecated annotation to EnableAdbPreferenceController

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Id57146149943d770bf5ccc9ed5ecc6ea9d8ae66c
2017-09-27 12:57:52 -07:00
Matthew Fritze
ab741bb627 Refactor IndexData conversion flow
This is entirely implementation detail, the public
interface and tests get to stay the same.

- The Raw, Resource and Provider methods now return single
or lists of IndexData rather than adding to a member var.
- Some code duplication was removed for Raw IndexData.
- Extra methods were squashed or removed

The only remaining refactoring in IndexDataConverter is
moving work done on IndexProviders to get the raw and
resources into PreIndexDataCollector.

Bug: 33577327
Test: make RunSettingsRoboTests, Database dump before & after
Change-Id: If6011046955f242ba2614400cfeca3bea5b683cb
2017-09-27 12:06:26 -07:00