Commit Graph

3 Commits

Author SHA1 Message Date
Kanyinsola Fapohunda
c9569b1cbd Change namespace for time_help_and_feedback_feature_supported server flag
This change moves the time_help_and_feedback_feature_supported flag from the settings_ui namespace to the system_time namespace.

Flag: EXEMPT refactor
Bug: 283239837
Change-Id: Ic1fcafd3cdbd263d7b800ac7676701628361de63
2025-02-19 07:09:49 -08:00
Kanyinsola Fapohunda
8c427e654e Hide "Send feedback" button if no target exists.
This change hides the "Send feedback" button  when a target for
the intent is not found. This will ensure the button is not
visible in cases when clicking it would have done nothing.

Bug: 283239837
Flag: com.android.settings.flags.datetime_feedback
Test: Test: atest TimeFeedbackPreferenceControllerTest.java
Change-Id: I8bb18c313925a7dc7ac07a1fb4c2f9e2d98352db
2025-02-12 03:42:29 -08:00
Neil Fuller
43ded696dd UI changes to support time feedback
The feature is behind a release flag. It is also behind an experiment
flag so it can be trialed with Googlers before general release even
after being enabled in a release.

The feedback button only shows up if there is an intent URI configured,
which should be handled via an overlay. The design means that the intent
is potentially dependent on the manufacturer (good!), though I expect we
will suggest a standard one for GMS devices so we get feedback from a
variety of devices with different form factors / capabilities.
In this default, GMS core (Google Play Services) will handle the intent
and take the user through a feedback UI flow.

Testing:

To enable the button you need to build with one of release variants that
supports dynamic flags, e.g. trunk_food.

Then release flag:
$ adb shell device_config put location com.android.settings.flags.datetime_feedback true

It still won't work without the experiment flag:
$ adb shell device_config put settings_ui time_help_and_feedback_feature_supported true

Finally, the settings entry will launch an intent when pressed which has
to have a receiver. The receiver will be in GMS core but will be subject
to its own review / launch process. Until then, this feature will remain
quiet, biding its time.

Bug: 283239837
Test: Manual (see above)
Test: atest SettingsRoboTests:com.android.settings.datetime
Change-Id: I68798798fc0a47ae4c6755174ce509fbaee24142
2024-03-25 19:00:47 +00:00