Commit Graph

6 Commits

Author SHA1 Message Date
Chun-Ku Lin
ed3d2f9171 Implemented nested scrolling parent in TextReadingPreviewPager
Flag: N/A
Bug: 317947238
Test: manual

Change-Id: I173881b84d5c5ff81c15a80a4de65fda59f5bf65
2024-01-08 22:07:56 +00:00
Roy Chou
004238d7f8 fix(text preference): fix preview block ui broken in SUW
As previous cl ag/25185014 we increased the preview block horizontal padding when landscape mode. However, in setup wizard it uses GlifPreferenceLayout so the settings page only has half screen width when landscape mode, so the preview block ui is squished due to limited width. Also, setup wizard package has overlay the paddings to larger than our prevoius adjust. Therefore, we rollback the changes in accessibility_text_reading_preview.xml to get the default padding, then add checker to increase the paddings if needed at runtime.

Bug: 309590083
Test: manually
Test: atest TextReadingPreviewPreferenceTest
Test: atest TextReadingPreferenceFragmentForSetupWizardTest
Change-Id: Ib907f4182eed272b84a4ab6208ea2d8a89ba96c4
2023-11-20 03:10:33 +00:00
Roy Chou
b3fb8e0154 chore(text reading settings): increase preview block left/right padding when landscape mode for easier scrolling
When the device is in landscape mode, In the text reading preference page, users have difficulty scrolling the RecyclerView because the preview block is almost full-screen. To scroll the preference list, users typically try to pan the preview block, but the block consumes the scroll gesture, preventing the list from scrolling. Users can successfully scroll the list content by panning outside the preview block. As a quick workaround, we increase the left/right padding of the preview block for landscape mode to make it easier for users to pan outside the block and scroll the preference list.

Bug: 301683714
Flag: NA
Test: manually - attach screenshot in bug
Change-Id: I1dba6e4d83ee1cd2f30163de05dfd7b42f829e42
2023-10-26 13:28:50 +00:00
Peter Liang
edfed449c3 Fix the preview couldn't be scrolled up and down when showing the scroll bar.
Actions:
1) Add the specific attribute to disallow parent view intercept the touch event of child view to avoid conflicting with the nested scroll view.
2) Add the scroll view into the page of the mail content preview.

Bug: 220078816
Test: manual test
Change-Id: I7f3b2afdf76e501386d9080e7a0eed8b92e28d3b
2022-12-12 19:32:52 +08:00
Peter Liang
5d4f28d65a Fix that the padding top/bottom of the preview was wrong when display size is smallest.
Add the padding from settingslib into.

Bug: 241247826
Test: manual test
Change-Id: Ia5f72bc6d6591a6245e623a10bdd3656935a38c4
2022-08-04 00:21:22 +08:00
Peter_Liang
44a275dd8f New feature “Text and reading options” for SetupWizard, Wallpaper, and Settings (6/n).
- Create new preview preference.
1) It will be integrated with TextReadingPreferenceFragment, and sub
previews layouts like app launchers, conversation messages, and mail
content.

Bug: 211503117
Test: make -j64 RunSettingsRoboTests ROBOTEST_FILTER=TextReadingPreviewPreferenceTest
Change-Id: I2d82d58438ee3f96c5a8dbb1809a0d6bdf3a00a2
2022-01-19 05:42:56 +00:00