Commit Graph

20701 Commits

Author SHA1 Message Date
Daniel Norman
35265e838f Fix missing declared accessibility PreferenceControllers.
This includes 3 fixes:

Adds missing settings:controller attribute for bold & high-contrast
text preferences.

Separates VibrationSettings into two fragments, one per fragment XML resource.
  Instead of using a conditional to choose the XML resource ID,
  we now use the conditional to choose which fragment to launch.
  This allows both fragment's preference controllers to be inspected
  by CodeInspectionTest#runSliceControllerInXmlInspection.
  Also updates the preference keys which must be unique per XML in order
  to appear in Settings Search.

Adds Magnification preference controllers to exempt-not-in-XML list.
  These controllers are for fragments that are not declared in an XML.
  See ToggleScreenMagnificationPreferenceFragment
        #getPreferenceScreenResId.

Bug: 289967175
Test: atest SettingsRoboTests:com.android.settings.accessibility
Test: atest CodeInspectionTest#runSliceControllerInXmlInspection;
      Observe no errors in the accessibility package.
Test: Open Settings > Accessibility > Vibration & haptics;
      observe vibration intensity page is shown (behavior unchanged).
      Hardcode config_vibration_supported_intensity_levels=1;
      observe vibration page with toggles is shown (behavior unchanged).
Change-Id: I257b5ad390371bedb1623af6289016b06d478707
2023-10-02 18:00:30 +00:00
Shivangi Dubey
097a9e736c Merge "Disable Fold lock behavior setting by default" into main 2023-10-02 10:00:10 +00:00
Allen Su
7b31a7a612 Fix notificaiton not working in work profile
Bug: 298592379
Test: atest SettingsRoboTests:com.android.settings.localepicker
Change-Id: I1da93e0dd2a7f98c2e635a1d7a520c88ba8258e0
2023-10-02 09:34:40 +00:00
mxyyiyi
1b9eb170dd Refactor Power Usage Time Page.
- Show use time category

Screenshot:
[Screen time with hint] https://screenshot.googleplex.com/3cRLrwevzw4iytb
[Background time with hint] https://screenshot.googleplex.com/zEf8PcWopCVCRZR
[without hint] https://screenshot.googleplex.com/9bao9sVd8s7VRwM
[enter from app info (without category)] https://screenshot.googleplex.com/8sozxMrq8ojadiF

Bug: 302063050
Test: Manual
Change-Id: Ic967d05a173afa76c2a958e1332dedd9f83cd687
2023-10-02 02:34:35 +08:00
Hao Dong
d11b9d1647 Merge "Use shared lib for settings v2." into main 2023-09-30 17:25:52 +00:00
Eghosa Ewansiha-Vlachavas
2c50be71c5 Fix testGetUserMinAspectRatioEntry for both tablets and foldables am: 136bd906da am: 933b2431fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24879571

Change-Id: I1a08e894582e04583bb2f1e26945cae85f1b4fc4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 21:51:22 +00:00
Eghosa Ewansiha-Vlachavas
933b2431fb Fix testGetUserMinAspectRatioEntry for both tablets and foldables am: 136bd906da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24879571

Change-Id: If37a415cc6f53f1f9df7731129dd9fa42341c4d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 20:45:20 +00:00
Valentin Iftime
68916a9bbf Check for NameNotFoundException when querying for PackageInfo
PackageManager.getPackageInfo will throw NameNotFoundException if package was/is being removed.

Test: atest FullScreenIntentPermissionPreferenceControllerTest
Bug: 296163845
Change-Id: I3242ac7e68fa7ed99fe99c7de7cd97aaf87948ee
2023-09-29 11:17:00 +02:00
Anna Bauza
e43590b092 Merge "Declare GuestTelephonyPreferenceController xml exempt" into main 2023-09-28 22:32:01 +00:00
Sudheer Shanka
8af457e732 Merge "Provide SuspendDialogInfo when quarantining an app." into main 2023-09-28 20:20:46 +00:00
Hao Dong
ae40494ee6 Use shared lib for settings v2.
Test: settingsv2 tests passed
Bug: 302372183

Change-Id: I6d1b20853b26662c538e804b1191bb720f1d7b8f
2023-09-28 19:16:11 +00:00
Anna Bauza
c0c206920b Declare GuestTelephonyPreferenceController xml exempt
The GuestTelephonyPreferenceController is related to conditional toggle appearance. Depends if Telephony is supprted by the device, therefore it is not statically defined in xml.

Also order list alphabetically.

Bug: b/289967472
Test:
1. Remove @Ignore tag from `CodeInspectionTest#runSliceControllerInXmlInspection`
2. atest CodeInspectionTest

Change-Id: I5fb95bdd5ca8cb2a5aa1096f57a425a2efa74cf9
2023-09-28 19:08:49 +00:00
Behnam Heydarshahi
3a130e2baa Merge "Declare RingVolumePreferenceController xml exempt" into main 2023-09-28 17:26:08 +00:00
Zoey Chen
60d3f7b7d2 Merge "[ToA] Terms of Address UI, fragment and the list: - Feminine, Masculine, Neutral, Not Specified" into main 2023-09-28 17:00:49 +00:00
Sudheer Shanka
b5441bf782 Provide SuspendDialogInfo when quarantining an app.
Customize the dialog to include a button to allow
users to take an app out of the quarantine state.

Bug: 297934650
Test: atest tests/robotests/src/com/android/settings/development/quarantine/QuarantinedAppsScreenControllerTest.java
Change-Id: I1b6e9f057fed91ae131602fd6d6ddf5e23958a65
2023-09-28 14:48:15 +00:00
Behnam Heydarshahi
fcd370f094 Declare RingVolumePreferenceController xml exempt
The controller is no longer in use in SoundSettings and should not
affect code inspection.

Bug: b/289967737
Test: 1. Remove @Ignore tag from `CodeInspectionTest#runSliceControllerInXmlInspection`
      2. atest CodeInspectionTest
Change-Id: I07cea3c5e2f5282950a63945181cc4711b937bc5
2023-09-28 13:50:26 +00:00
Eghosa Ewansiha-Vlachavas
136bd906da Fix testGetUserMinAspectRatioEntry for both tablets and foldables
Tabelts and foldables now have different aspect ratio values in their
config, so we need to test the devices separately as we shouldnt test for
values that are not in the config of the device the test is run on.

Fixes: 302155585
Test: atest SettingsUnitTests:UserAspectRatioManagerTest
Change-Id: I78fa3020501a4be992bb90fea16a6fec4f37594b
2023-09-28 13:23:11 +00:00
Eghosa Ewansiha-Vlachavas
5f624b70ba Merge "[1/n] Aspect ratio settings app list refinement" into udc-qpr-dev am: a3108d5b14 am: 2595f32076
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24854937

Change-Id: Iaa9687110887498c26d246dfed086eb1f8d529af
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-28 12:13:01 +00:00
Eghosa Ewansiha-Vlachavas
2595f32076 Merge "[1/n] Aspect ratio settings app list refinement" into udc-qpr-dev am: a3108d5b14
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24854937

Change-Id: I9ed3cf613ae4b20c1465403be0c989a00be425fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-28 11:08:02 +00:00
Eghosa Ewansiha-Vlachavas
a3108d5b14 Merge "[1/n] Aspect ratio settings app list refinement" into udc-qpr-dev 2023-09-28 10:39:35 +00:00
Yiyi Shen
7edfdba9c8 Merge "Fix SettingsRoboTests for connecteddevice." into main 2023-09-28 10:11:12 +00:00
Valentin Iftime
9f82e7381a Settings for Polite Notifications
Adds settings page for polite notifications.

Test: atest PoliteNotificationsPreferenceControllerTest
Test: atest PoliteNotificationFilterControllerTest
Test: atest PoliteNotifVibrateUnlockedToggleControllerTest
Test: atest PoliteNotifWorkProfileToggleControllerTest

Bug: 270456865

Change-Id: I3ec497b068c15205df97bb26ee007beed8da9ee1
2023-09-28 09:42:50 +00:00
Treehugger Robot
747d86fef5 Merge "Fix & ignore some tests" into main 2023-09-28 07:41:13 +00:00
Yiyi Shen
ca8885a549 Fix SettingsRoboTests for connecteddevice.
Bug: 296507968
Test: atest
Change-Id: I5b1e868efeffd0ae185c93623c1daa4a5486e751
2023-09-28 14:49:03 +08:00
Chaohui Wang
58871ff999 Merge "Improve the latency of DataUsageList" into main 2023-09-28 03:18:38 +00:00
Zoey Chen
b501ab183e [ToA] Terms of Address UI, fragment and the list:
- Feminine, Masculine, Neutral, Not Specified

Test: atest TermsOfAddressNotSpecifiedControllerTest, atest
TermsOfAddressNeutralControllerTest, atest
TermsOfAddressMasculineControllerTest, atest TermsOfAddressFeminineControllerTest
Bug: 295826542
Bug: 297798866
Change-Id: I490ace0035c809cac47bae460f558f13875ff18f
2023-09-28 02:23:57 +00:00
Xin Li
f0ba9c8b60 Merge UP1A.231005.007
Bug: 291102124
Merged-In: I74cde8ebf8214b314a89452e73b834eac7ae8b1e
Change-Id: If0cc9b99ea3e0e6d908d8c1ed476232d3056cb5d
2023-09-27 16:05:12 -07:00
Eghosa Ewansiha-Vlachavas
6bd9bff2e2 [1/n] Aspect ratio settings app list refinement
All apps list for work profile currently only shows work apps that are
also installed on the normal user. Update filter for list to show all
launcher apps for both users in their respective lists.

Fixes: 301373413
Test: atest SettingsUnitTests:UserAspectRatioManagerTest
Test: atest SettingsSpaUnitTests:UserAspectRatioAppPreferenceTest
Change-Id: Ia0bf15340d1b37dcd926d81598d3e94f448a46fc
2023-09-27 17:30:23 +00:00
Chaohui Wang
9b4db8d33f Fix & ignore some tests
Fix the followings,
- SimSelectNotificationTest
- WifiCallingSliceHelperTest
- WifiDetailPreferenceController2Test
- WifiDialogActivityTest

Ignore the followings,
- WifiP2pSettingsTest

Fix: 300160894
Test: robo test
Change-Id: I27b6eb61dccbd0688a100154fc77b82a91eede57
2023-09-27 23:45:48 +08:00
Treehugger Robot
df1e559e91 Merge "Remove availability tests from RingVolumePreferenceControllerTest" into main 2023-09-27 14:21:54 +00:00
Valentin Iftime
8eb200c177 Remove availability tests from RingVolumePreferenceControllerTest
Controller is always UNSUPPORTED_ON_DEVICE.

Test: atest com.android.settings.notification.RingVolumePreferenceControllerTest

Bug: 300157932
Bug: 302295368
Change-Id: I9f0a453d2966e68e34e381ed1b1a0a01e1e65e23
2023-09-27 15:30:54 +02:00
Treehugger Robot
7147945912 Merge "Fix SmartAutoRotatePreferenceFragmentTest" into main 2023-09-27 12:13:24 +00:00
Chris Göllner
0e0dd4d631 Fix SmartAutoRotatePreferenceFragmentTest
- Adds missing set up for postures helper
- Adds missing mock for context.getApplicationContext

Fixes: 300380893
Test: atest SettingsRoboTests:SmartAutoRotatePreferenceFragmentTest
Change-Id: Ib3cde08354e368c2ac2ecc9024e8f8358fe7b772
2023-09-27 12:08:11 +01:00
Treehugger Robot
2954c150ef Merge "Add SettingsTextFieldPassword." into main 2023-09-27 09:24:47 +00:00
Charlotte Lu
cfa739350f Add SettingsTextFieldPassword.
Fix: 298906796
Test: Visual
Change-Id: I7dc8c641f93df96a28a57a6f6082abe264680298
2023-09-27 16:19:19 +08:00
Chaohui Wang
2205762482 Improve the latency of DataUsageList
Up to 30x faster.

Currently it load the usage detail for every day at the beginning, so
it's quite slow.

To fix,
- Not load the usage detail for every day at the beginning
- Load only the cycles first
- And only load the daily detail for the selected month

Fix: 290856342
Test: manual - on DataUsageList (cell & wifi)
Test: unit tests
Change-Id: Ie18fa68f801743389bd6b6a28e236dcf1fea00e4
2023-09-27 08:05:02 +00:00
Treehugger Robot
db9fdb0de8 Merge "Clean up the global action panel" into main 2023-09-27 07:18:41 +00:00
Sunny Shao
383edb4afa Fixed the robo test failed in AutoRotatePreferenceControllerTest
and SmartAutoRotatePreferenceControllerTest

- Use the correct Settings.System.putIntForUser API.

Fixes: 300200193
Fixes: 300201185
Test: atest AutoRotatePreferenceControllerTest
Test: atest SmartAutoRotatePreferenceControllerTest
Change-Id: Iadd890f21431ccb5d538e40426b0c7d43d46ba52
2023-09-27 11:19:00 +08:00
Mill Chen
7e31ff431a Clean up the global action panel
The global actions panel has been renamed to power menu and there is a
new preference for power menu. The legacy perference for global actions
panel is unused. This CL is to remove the preference controller from
Settings.

Bug: 289967656
Test: manual test and robotest
Change-Id: If820f3fa8a188223703ebc6bc68120164108f483
2023-09-27 09:30:27 +08:00
Peiyong Lin
21c967bc96 Merge "Add debug property to safe guard ANGLE developer option UI." into udc-qpr-dev am: e456cb72f9 am: 759a3fda7b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24842231

Change-Id: Iec2e7a51a9b0179fceef6182a1bd9cd2668ddab0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 21:34:17 +00:00
Peiyong Lin
759a3fda7b Merge "Add debug property to safe guard ANGLE developer option UI." into udc-qpr-dev am: e456cb72f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24842231

Change-Id: Iaae1e5f2747e8e6d62c5426ded572b792642e9b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 20:35:23 +00:00
Peiyong Lin
e456cb72f9 Merge "Add debug property to safe guard ANGLE developer option UI." into udc-qpr-dev 2023-09-26 19:19:37 +00:00
Treehugger Robot
fcd8fdf29d Merge "Ignoring several biometric/password robotests" into main 2023-09-26 18:58:53 +00:00
Joshua McCloskey
344e96c7c5 Ignoring several biometric/password robotests
Test: atest SettingsRoboTests:com.android.settings.password
Test: m -j50 RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.biometrics
Bug: 296640651
Change-Id: Ibf184e954c89e423b5fe1afe221c06568502bb37
2023-09-26 17:56:11 +00:00
Eghosa Ewansiha-Vlachavas
159b8aed3d Update aspect ratio summary strings
Replace usage of `aspect_ratio_summary` and `aspect_ratio_main_summary`
with `aspect_ratio_summary_text` and `aspect_ratio_main_summary_text`

Fixes: 302142203
Test: Manual
Change-Id: Id7570269806e2dd15f45bdc0aad1ed0534e259b6
2023-09-26 17:04:59 +00:00
Joshua Mccloskey
6d8b293051 Merge "Moved FakeFingerprintManagerInteractor" into main 2023-09-26 15:04:03 +00:00
Edgar Wang
4d71b8016b Merge "Fix robo test case failed" into main 2023-09-26 11:46:28 +00:00
Jason Chang
f68ce5987d Merge "Add OneHandedMainSwitchPreferenceController in the exempt_slice_controller_not_in_xml" into main 2023-09-26 11:20:28 +00:00
Viesturs Zarins
99631a11ec Merge "Add searchable metadata attribute for injected tiles." into udc-qpr-dev am: 5bc1e9b38f am: 68fede37a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24792152

Change-Id: Iffe2d746713a2b7f03261ba02ecbce2713546e7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 10:30:22 +00:00
Treehugger Robot
51e3fc3388 Merge "Start logging rotation lock history + include caller information" into main 2023-09-26 09:43:48 +00:00