Commit Graph

87677 Commits

Author SHA1 Message Date
Menghan Li
e8582f9c31 Merge "Fix null pointer issue of accesibility learn more button click event" into sc-v2-dev 2021-09-01 06:19:03 +00:00
Zoey Chen
facfcc0041 Merge "[Provider Model] Add a cutout for signal icon if the mobilde data is disabled" into sc-qpr1-dev am: f25a00217c am: 4e1fba40ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15724801

Change-Id: Ifaaca2ba26687e6ff5e5292d5e420f06e387d36b
2021-09-01 04:23:28 +00:00
Zoey Chen
ae633368e2 Merge "[Provider Model] Add a cutout for signal icon if the mobilde data is disabled" into sc-qpr1-dev am: f25a00217c am: 2d827ddf50
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15724801

Change-Id: I7bb2dbb8b1bcba2d6d568397158e3512c0b2df61
2021-09-01 04:22:59 +00:00
Zoey Chen
2d827ddf50 Merge "[Provider Model] Add a cutout for signal icon if the mobilde data is disabled" into sc-qpr1-dev am: f25a00217c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15724801

Change-Id: Ie210682def804b99f21e3803d95c4d14828af77c
2021-09-01 04:12:08 +00:00
Zoey Chen
4e1fba40ee Merge "[Provider Model] Add a cutout for signal icon if the mobilde data is disabled" into sc-qpr1-dev am: f25a00217c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15724801

Change-Id: If81f3187cbda733d168a8fbe6a692a89fbb41129
2021-09-01 04:12:08 +00:00
Zoey Chen
f25a00217c Merge "[Provider Model] Add a cutout for signal icon if the mobilde data is disabled" into sc-qpr1-dev 2021-09-01 03:58:13 +00:00
Joe Bolinger
2abb74cdd3 Merge "Remove sliceable attribute from biometric preference controllers." into sc-dev am: c7a0b63dd9 am: bc188f609c am: 478de12b83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15546133

Change-Id: I471343acd465b3556beb807cfb142f1746de70eb
2021-09-01 01:59:25 +00:00
Joe Bolinger
2b4b5d3b73 Merge "Remove sliceable attribute from biometric preference controllers." into sc-dev am: c7a0b63dd9 am: bc188f609c am: 9133578aaa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15546133

Change-Id: I19e1251d9b830be8bb25f00d4850053e774b0ca7
2021-09-01 01:58:47 +00:00
Joe Bolinger
374cbccbf0 Merge "Remove sliceable attribute from biometric preference controllers." into sc-dev am: c7a0b63dd9 am: 46470d911e am: 95626d62f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15546133

Change-Id: I25649534415e9c8685195c419f9450def18fc0d0
2021-09-01 01:58:29 +00:00
Joe Bolinger
478de12b83 Merge "Remove sliceable attribute from biometric preference controllers." into sc-dev am: c7a0b63dd9 am: bc188f609c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15546133

Change-Id: Iede9108bcf77cf917a66d59523a05e81e47d6a4c
2021-09-01 01:43:38 +00:00
Joe Bolinger
9133578aaa Merge "Remove sliceable attribute from biometric preference controllers." into sc-dev am: c7a0b63dd9 am: bc188f609c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15546133

Change-Id: Ia27a78476731d285774ca6640414c3670a031d36
2021-09-01 01:43:36 +00:00
Joe Bolinger
95626d62f3 Merge "Remove sliceable attribute from biometric preference controllers." into sc-dev am: c7a0b63dd9 am: 46470d911e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15546133

Change-Id: Idaec22cc49b17bc088380ec4da7ce51e2f037856
2021-09-01 01:43:26 +00:00
Joe Bolinger
bc188f609c Merge "Remove sliceable attribute from biometric preference controllers." into sc-dev am: c7a0b63dd9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15546133

Change-Id: Ifd9ebd5877ce8020c0c977db8f6744c03ca24c70
2021-09-01 01:26:40 +00:00
Joe Bolinger
46470d911e Merge "Remove sliceable attribute from biometric preference controllers." into sc-dev am: c7a0b63dd9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15546133

Change-Id: I8423ebeee18eb6e9213a2e45bc5f2eed3a19aabd
2021-09-01 01:25:27 +00:00
Joe Bolinger
c7a0b63dd9 Merge "Remove sliceable attribute from biometric preference controllers." into sc-dev 2021-09-01 01:15:40 +00:00
TreeHugger Robot
b52a6be60a Merge "Log when DEBUG is on" into sc-qpr1-dev am: 736bce563e am: 0164a3a724
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15598813

Change-Id: I724799581534fdc6da80216a72985aef171f4dd3
2021-08-31 22:58:00 +00:00
TreeHugger Robot
b05bffeb71 Merge "Log when DEBUG is on" into sc-qpr1-dev am: 736bce563e am: 2cb6e12f11
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15598813

Change-Id: Ia3d1839519b3135a4ef29405226bc9eebc961719
2021-08-31 22:41:11 +00:00
TreeHugger Robot
0164a3a724 Merge "Log when DEBUG is on" into sc-qpr1-dev am: 736bce563e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15598813

Change-Id: I527bfca7a4397af216b2abd2b04ab157d1ad1adf
2021-08-31 22:40:47 +00:00
TreeHugger Robot
2cb6e12f11 Merge "Log when DEBUG is on" into sc-qpr1-dev am: 736bce563e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15598813

Change-Id: I871fee03a402a25e917656e4b27015388697df5f
2021-08-31 22:40:39 +00:00
Julia Reynolds
0d16b9cb68 Add new task to intents that leave Settings am: 76aedd72f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15730311

Change-Id: Ibcb97ab31fba46e4c61f68bb03240a43e496a45c
2021-08-31 22:40:24 +00:00
TreeHugger Robot
736bce563e Merge "Log when DEBUG is on" into sc-qpr1-dev 2021-08-31 22:19:19 +00:00
Julia Reynolds
76aedd72f0 Add new task to intents that leave Settings
Test: manual
Fixes: 197702721
Fixes: 197704633
Fixes: 197704125
Fixes: 197704456
Change-Id: Iffeca2d152bd083edafe69a7121d011e284eeb69
2021-08-31 21:13:03 +00:00
Zoey Chen
35803a3b03 [Provider Model] Add a cutout for signal icon if the mobilde data is disabled
Screenshot: https://screenshot.googleplex.com/57wPkj9pq9hP5WA.png

Bug: 198233143
Test: manual, atest SubscriptionsPreferenceControllerTest
Change-Id: I3caefc7e1ca10dadcad114273edf35d9309502e1
2021-08-31 16:03:23 +00:00
ykhung
4e3f692164 Hide Camera background running time in the battery usage screen
hide camera background running time in the battery usage screen to avoid
users confuse about it, since it will standby in the backgound to sspeed
up launching time, not always running in the background

Bug: 196744910
Test: make SettingsRoboTests
Change-Id: Ia391d661bca44435fc5a68b1c86e5ca32dd0fcfe
Merged-In: Ia391d661bca44435fc5a68b1c86e5ca32dd0fcfe
2021-08-31 13:58:13 +00:00
Ting Yu
f56682808e Fix Text of VoLTE setting cannot be updated when SIM state is changed
Text of setting menu for VoLTE should be changed from "VoLTE" to
"4G Calling" if "show_4g_for_lte_data_icon_bool" is true. However, it
is not changed in the following steps.
1. Turn Use SIM off on Mobile Network Setting and close Mobile Network
   Setting screen.
2. Open Mobile Network Setting screen again and turn Use SIM on.

Root cause is that the carrier config value is loaded only when SIM's
subid is changed. So, remove checking subId so that the carrier config
value is updated.

Additional fix:
Removed checking #isModeMatched in # onStart because "4G calling"
Setting was grayed out. It needs to listen to call state change
regardless of display status of the preference because Preference may
be switched even after the screen is displayed.

Test: manual
Test: make RunSettingsRoboTests \
      ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Bug: 196030198
Change-Id: Ibf4d17aa493f69a3f00e35ae0e9d1419bd9e0d77
2021-08-31 20:14:20 +08:00
Hugh Chen
ffeefd4d11 Fix USB tethering is not turned on with a single tap
Before this CL, the USB default settings will set default usb functions
to RNDIS when tethering is started. Because in some devices, the NCM
is used instead of RNDIS to start tethering. If RNDIS is set in the
device that uses NCM to start tethering, it will cause start
tethering failed.

This CL will use the current functions to set default usb functions
to fix this issue.

Bug: 195068679
Bug: 197026638
Test: make -j42 RunSettingsRoboTests
Change-Id: Ic9353c5ac76c0cd517318a4304fa214d6b2201d2
(cherry picked from commit ba30b04cc3)
2021-08-31 09:03:07 +00:00
menghanli
d665ecb86d Fix null pointer issue of accesibility learn more button click event
Root cause: Some OEMs can not provide valid intent for help & feedback
Solution: Check the intent is vaild before show up the help strings

Bug: 197786797
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityFooterPreferenceControllerTest
Change-Id: I8103730ed48a343f7b72c16647f7e8047aee34b2
2021-08-31 16:35:44 +08:00
ykhung
ba35874594 Hide Camera background running time in the battery usage screen
hide camera background running time in the battery usage screen to avoid
users confuse about it, since it will standby in the backgound to sspeed
up launching time, not always running in the background

Bug: 196744910
Test: make SettingsRoboTests
Change-Id: Ia391d661bca44435fc5a68b1c86e5ca32dd0fcfe
Merged-In: Ia391d661bca44435fc5a68b1c86e5ca32dd0fcfe
2021-08-31 07:49:07 +00:00
ykhung
24e8c1f902 Hide Camera background running time in the battery usage screen am: 2401ec4235
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15715976

Change-Id: I19048e33376a9e9b0816f20a6e8fea60c4f46bcc
2021-08-31 07:13:58 +00:00
ykhung
2401ec4235 Hide Camera background running time in the battery usage screen
hide camera background running time in the battery usage screen to avoid
users confuse about it, since it will standby in the backgound to sspeed
up launching time, not always running in the background

Bug: 196744910
Test: make SettingsRoboTests
Change-Id: Ia391d661bca44435fc5a68b1c86e5ca32dd0fcfe
2021-08-31 07:01:01 +00:00
Weng Su
e1c42823ec [automerger skipped] Don't show Wi-Fi icon if the level is -1 am: 1f6f807834 am: ef51aec905 -s ours
am skip reason: Merged-In Ifddc9aace42d1f024b7c861b1207f651061d790b with SHA-1 1f6f807834 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15720350

Change-Id: I2ca1fd3df44f374031c546990ce57b7983a61b35
2021-08-31 03:31:19 +00:00
Weng Su
1ddd133e16 Don't show Wi-Fi icon if the level is -1 am: 1f6f807834 am: dc50ca86fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15720350

Change-Id: I6a2a26f74432e8e31f95ebc00e40000fd8d7f486
2021-08-31 03:30:44 +00:00
Weng Su
ef51aec905 Don't show Wi-Fi icon if the level is -1 am: 1f6f807834
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15720350

Change-Id: I9f8f1ed4d2ec8072dc3b7087d41186f021197e75
2021-08-31 03:21:50 +00:00
Weng Su
dc50ca86fb Don't show Wi-Fi icon if the level is -1 am: 1f6f807834
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15720350

Change-Id: Ib8e3164f046f2deeca88e6d31e29058789751edc
2021-08-31 03:21:47 +00:00
menghanli
a1674787fe Fix a11y service icons are tiny after changing display size to "Largest"
Root cause: Scaled down non vector drawable to to avoid crashing Settings
Solution: Enlarge the maxWidth & maxHeight from 500 to 600

Bug: 195975294
Test: manual test
Change-Id: I9d771cfaa7cf3eed37265219c082b6337fa5c063
2021-08-31 09:38:31 +08:00
Weng Su
1f6f807834 Don't show Wi-Fi icon if the level is -1
Bug: 195893448
Test: manual test
make RunSettingsRoboTests
ROBOTEST_FILTER=NetworkRequestDialogFragmentTest

Change-Id: Ifddc9aace42d1f024b7c861b1207f651061d790b
(cherry picked from commit 7e14668094)
Merged-In: Ifddc9aace42d1f024b7c861b1207f651061d790b
2021-08-30 22:55:26 +00:00
TreeHugger Robot
f5fe795a34 Merge "[Performance] avoid setting the same optimization mode again" into sc-v2-dev am: f3155c03f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15712669

Change-Id: Ic89e75098b40489f66005e1c6309e02c1b427552
2021-08-30 10:49:36 +00:00
TreeHugger Robot
f3155c03f0 Merge "[Performance] avoid setting the same optimization mode again" into sc-v2-dev 2021-08-30 10:28:11 +00:00
PETER LIANG
c3b01abe59 Merge "Correct the position of the marker for audio adjustment." into sc-v2-dev am: 810ab566e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15611717

Change-Id: I75845cabf350a69a15bd1e9b99b1726b0a815bc8
2021-08-30 09:57:30 +00:00
PETER LIANG
810ab566e7 Merge "Correct the position of the marker for audio adjustment." into sc-v2-dev 2021-08-30 09:55:35 +00:00
ykhung
ea57d6863e [B&R] restore the backup data for app optimization mode back am: adec23a106
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15681503

Change-Id: I4977c0f78803d943426a7b2d64b0304bbc2c0b8a
2021-08-30 09:50:51 +00:00
ykhung
9ac072dafe [Performance] avoid setting the same optimization mode again
Add a checking condition to avoid setting the same optimization mode again to improve the performance, since setting the optimization mode is a heavy operation when binding with system service.

Bug: 192523697
Test: make SettingsRoboTests
Change-Id: I4065e3c56201c1c9285d9cebedf670bc0c42c614
2021-08-30 09:25:51 +00:00
Peter_Liang
ba297dc396 Correct the position of the marker for audio adjustment.
Root cause: Miss one the layout padding condition for computing the position of the marker.
Solution: add the layout padding condition into.

Bug: 196980036
Test: make RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBarTest ROBOTEST_FILTER=BalanceSeekBarPreferenceTest
Change-Id: Id0c6ebbc981d9ef41e7956ffff1fc5b9d4c0e787
2021-08-30 07:16:35 +00:00
Bonian Chen
a4a806e4ea [Settings] Avoid from immediate update when UI inactive and SIM absent
When SIM absent during UI inactive, update can be postponed under the
condition of Activity onPause() or onStop(). And update when onResume()
or onStart().

This is not simply an improvement on performance but also a better user
experience.

User might unplug a SIM and plug-in again, and there're cases where a
SIM status might change into absent and back to active again due to some
mode switch in RIL/modem. From user perspective, the SIM status remain
the same and update of content is expected instead of closing the UI and
re-enter.

Bug: 195631787
Test: local
Change-Id: I8248e59895631dc90cf3831398e387b93483280c
(cherry picked from commit b2a6266fa9)
2021-08-30 06:56:12 +00:00
Bonian Chen
94253d725e [Settings] Avoid from floating overlay when displaying SIM selection UI
Avoid from floating overlay when displaying SIM selection UI, which
could avoid from security issue.

Bug: 195667589
Test: local
Change-Id: I8db76005f2c3ad6cc94d68703b2b1647d81371f5
(cherry picked from commit 1cc61672ef)
2021-08-30 06:53:50 +00:00
ykhung
adec23a106 [B&R] restore the backup data for app optimization mode back
BYPASS_INCLUSIVE_LANGUAGE_REASON=legacy method name

Test command for backup manager:
adb shell bmgr backupnow com.android.settings
adb shell dumpsys backup | grep Current
adb shell bmgr restore 3e9867a7660315b8 com.android.settings

Bug: 192523697
Test: make SettingsRoboTests
Change-Id: Ia35f8caa8fe2408be28c3494785a174a1aeb11da
2021-08-30 06:45:26 +00:00
Bill Yi
b089d5fdb8 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev am: 31208c4948 -s ours am: 7514b30f06 -s ours am: 6ee3b9fe8a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15691667

Change-Id: Ied0547f45bb052ec2950e48e73cf08b3721a16c7
2021-08-29 20:53:56 +00:00
Bill Yi
b4971c8081 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev am: a5d0f92e0c -s ours am: 3fb65a4774 -s ours am: 05320e232c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15697678

Change-Id: Iaeae63a70ee7d69fde348692975df5dfbe2062a3
2021-08-29 20:52:56 +00:00
Automerger Merge Worker
3076270ac6 Merge "[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev am: 31208c4948 -s ours am: 4a7694c598 -s ours" into sc-qpr1-dev-plus-aosp am: f0125f178a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15691667

Change-Id: I7a995a143a62de8c38271a4fb75a3c0ae941cb20
2021-08-29 20:52:07 +00:00
Bill Yi
40920a9988 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev am: 31208c4948 -s ours am: 7514b30f06 -s ours am: 92c5bac1ee -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15691667

Change-Id: If3688649cb0d134641fb4c802a8dee6fcfebf6dd
2021-08-29 20:50:06 +00:00