Commit Graph

168 Commits

Author SHA1 Message Date
Johnson Lu
cb36eb394c Adjust landscape layout of QR code scanner/generator
Bug: 118794858
Test: RunSettingsRoboTests
Change-Id: Ifaef7c5fe02abbb377efeb0ab345976ab439aeb0
2019-01-03 11:41:26 +08:00
Amin Shaikh
a5e8bddc46 Update Settings text styles to use DeviceDefault.
- Replace all TextAppearance.Material styles with the equivalent
TextAppearance.DeviceDefault style
- Reparent Theme.Settings.HomeBase to inherit from Theme.Settings. This
ensures that the correct textAppearance theme attributes are applied
throughout the Settings application.

Bug: 121211932
Test: manually opening Settings and enabling/disabling HotDogOverlay
Change-Id: Ibe4873ed0294de79dbb6aeca464d14c291239c4b
2019-01-02 16:08:19 -05:00
Raff Tsai
f6d42a99d1 Clean up styles and aliases
- Remove unused style
- Remove identical style declaration

Test: Manual, Robolectric
Change-Id: Ia98ed82e6ccd4a25af6abbc66709eda1867581ee
2018-12-26 12:56:48 +08:00
Cn Chen
8428d04677 Merge "Change layout prefix of setupdesign from suw to sud" 2018-12-24 03:52:00 +00:00
pastychang
8d2dc16d7f Change layout prefix of setupdesign from suw to sud
Bug: 120805516
Test: RunSettingsRoboTests
Change-Id: Icd24f0336191c4575838cb1b9d131c885304b527
2018-12-24 10:13:54 +08:00
pastychang
1b1666855e Migrating to new footer button for fingerprint and face enrolling pages.
Bug: 120805516
Test: RunSettingsRoboTests
Change-Id: I89a5e3674b8ba9ec66945c03c9b783664eee214f
2018-12-19 23:24:48 +08:00
Arc Wang
9dbc040510 Merge "Fine tune UI layout files of WifiDppQrCodeScannerFragment & WifiDppQrCodeGeneratorFragment" 2018-12-18 07:26:47 +00:00
Arc Wang
fb0a081848 Fine tune UI layout files of WifiDppQrCodeScannerFragment &
WifiDppQrCodeGeneratorFragment

    1. Remove footer in landscape QR code scanner fragment
    2. Move header icon from activity layout file to header layout file
    3. Fine tune header layout file
    4. set icons for the 2 fragments

Bug: 118797380
Bug: 118794858
Test: atest WifiDppConfiguratorActivityTest
      atest WifiDppQrCodeScannerFragmentTest
      atest WifiDppQrCodeGeneratorFragmentTest
      atest RunSettingsRoboTests

Change-Id: I7e547d7c29dd947a890e902e61b8244fec399354
2018-12-18 02:23:22 +00:00
Johnson Lu
ebbb0bc563 Adjust camera preview area to square
1.Choose the smaller size of both dimensions as its size.
2.Set transform matrix to crop and center the preview picture.

Bug: 118797380
Test: make RunSettingsRoboTests
Change-Id: Ic65fb1fe0c5082995d6903f50dda48eec16c3fb1
2018-12-15 16:07:02 +08:00
Pasty Chang
c1f8600d9f Change to use setupcompat and setupdesign for suw pages
1. remove the dependence of setupwizardlib.
2. add to use setupcompat and setupdesign.
3. modify new footer button in following up cl.

Bug: 120805516
Bug: 120872944
Test: RunSettingsRoboTests
Change-Id: I463dd35b799d4250b2aabce0cb0b8102cf9dd7d6
2018-12-12 03:16:29 +00:00
TreeHugger Robot
830e6d4f13 Merge "Update SettingsPanel UI" 2018-12-01 06:51:53 +00:00
Johnson Lu
a558c01696 Integrate QrCode Camera with WifiDppQrCodeScannerFragment
Bug: 118797380
Test: RunSettingsRoboTests
Change-Id: I328bebbbcf44136df2c18ca1929a5da377a0cf6b
2018-12-01 09:03:39 +08:00
Matthew Fritze
c14316c4a9 Update SettingsPanel UI
UI changes include:
- RecyclerView to host slices
- Font family to headline font
- Title is now centered
- Added SeeMore & Done buttons
- Horizontal Dividers between slices
- Indented Slices
- Landscape layout is fullscreen

Change-Id: I3549c847fc88edd81f670ddfa2907dd3741441e0
Screenshot: https://screenshot.googleplex.com/RzWktzOZJkc
Test: Robolectric
Test: Manual app
Bug: 118622007
2018-11-30 13:26:50 -08:00
Stanley Wang
1ed36d8b23 Layout updated for file size text wrapping with largest display
This solution will change the portrait layout for
large, larger, and largest of Display size.

Change-Id: Ib00b23553c34c1e69cb84e446f409c38ea7544ef
Fixes: 69074097
Test: manual
2018-11-14 16:31:53 +08:00
Kevin Chyn
e5a016e076 1/n: Prepare ConfirmDeviceCredentials to use BiometricPrompt
CDC is going to use BiometricPrompt instead. This change
removes FingerprintManager from CDC. BiometricPrompt
will show before pin/pattern/pass is shown.

Bug: 111461540

Test: modified BiometricPromptDemo to use
      KeyguardManager#createConfirmDeviceCredentialIntent,
Test: Fingerprint is gone from CDC, rotation works
Test: atest SettingsRoboTests

Change-Id: I9ce2aad71961af8a0d5ee636600e2fbdb6154e47
2018-11-01 14:11:57 -07:00
TreeHugger Robot
20bb2edda7 Merge "Update fingerprint illustration" into pi-dev 2018-04-14 01:36:27 +00:00
Maurice Lam
a0248df148 Update fingerprint illustration
Test: Manual
Bug: 74410378
Bug: 74410267
Change-Id: I8ef052ea7f1cd6406001d383cab5825ed8f6d5f5
2018-04-11 11:03:36 -07:00
Maurice Lam
8ca084e62b Fix landscape pattern enroll crash
Test: atest SetupChooseLockPatternTest.java
Bug: 77878150
Change-Id: Ie54286765ea0d766bcc9e2c8e56cfbda919d5fd7
2018-04-10 19:53:41 -07:00
Maurice Lam
3e3b8a9618 Make GLIF theme default for confirm lock screen
Use GLIF theme as the default for confirm lock screen, even for
"external" launches of the screen. Renamed the theme from "internal"
to "normal" to reflect this change.
Dark theme code will be cleaned up later.

Test: Existing tests pass
Bug: 62573742
Change-Id: I86958eb3a440d7274807f1cf453c3e53c16c23e7
2018-03-21 18:21:04 -07:00
Ajay Nadathur
6f6a7c6412 Fix NPE in SetupChooseLockpattern screen
bug: 71807569
Test: Manually tested and verified no longer crash
Change-Id: I9b6a20377f2cf7ffb9be12de7bfa59f8b1063625
2018-01-10 14:01:21 -08:00
Maurice Lam
733b7c3c16 Make sure FP error text is visible in landscape
Use layout_weight in the enrolling progress bar to make sure it
there is space left for the error text.

Test: Manual
Bug: 69686380
Change-Id: Idd3d4c4ac376e721f15b8c9871c56e0619def305
2017-11-22 16:17:37 -08:00
TreeHugger Robot
aad3b1cef2 Merge "Use ButtonBarLayout to stack buttons" 2017-10-13 20:12:49 +00:00
TreeHugger Robot
909df8b966 Merge "There is no NEXT button in find sensor screen of fingerprint." 2017-10-13 20:11:09 +00:00
Maurice Lam
bb31c01f87 Use ButtonBarLayout to stack buttons
In fingerprint-enroll-finish landscape, if there is not enough space
to display the buttons, stack them by using ButtonBarLayout.

Bug: 67370165
Test: Manual
Change-Id: I482b811d6a2af545c4783a1cdd50b566c34b60c3
2017-10-13 01:21:31 +00:00
Kevin Chyn
caa78af159 Fingerprint enrolling icon should not overlap text
Fixes: 67369609

Test: manual test of enrolling with combinations of multi-window
      and text/display sizes

Change-Id: I163af87c69a51b0c91778611afa9e80960231c6a
2017-10-09 12:03:31 -07:00
Maurice Lam
d2e50c3c2b There is no NEXT button in find sensor screen of fingerprint.
Precondition: set the Font size and Display size to largest
Enter into the find sensor screen and the NEXT button is missing.
Test: manual - Enter into the find sensor screen -
and can find the NEXT button after sliding the screen.

Change-Id: I8f6219ab22abad98111f016d633bf100dc3222ce
2017-10-06 18:21:58 -07:00
Maurice Lam
7f5e1960f6 Update strings for pattern screens
Test: Manual
Bug: 64339681
Change-Id: I8c68b80a000988734c13cb40e2c049a83a787f2e
2017-09-11 15:35:18 -07:00
Maurice Lam
7efcc35d85 Fix sizing of pattern view
Align the size of pattern view in ChooseLockPattern,
ConfirmLockPattern, and keyguard as much as possible.
In rare cases they may still be inconsistent because
the screens have different content outside of the
pattern view (e.g. header text, navigation buttons etc)

Test: Manual
Bug: 64339681
Change-Id: Ie07ae211340967a3cdf9c6c28f9818f207dbd2c9
2017-09-11 20:07:17 +00:00
Ajay Nadathur
c13273687a Fingerprint added graphic is bigger than enrolling progressbar
bug: 63714762
Test: Manually tested
Change-Id: I415ab41bb985eb52146693091d61152b51ecfd6c
2017-08-02 20:32:03 +00:00
Ajay Nadathur
5eca3a64ea Add another fingerprint button not visible in landscape mode
bug:63067568
Test: Manually tested and verified
Change-Id: I172bbf4c4db6cebb2cc96874f3d8d29e859b07d1
2017-07-11 16:58:12 -07:00
Ajay Kumar Nadathur Sreenivasan
56787e3e54 Merge "Overlapping text over fingerprint animation" into oc-dr1-dev 2017-07-07 21:29:07 +00:00
Ajay Nadathur
715713d524 Overlapping text over fingerprint animation
bug: 63122688
Test: Manually tested and verified using smallest & largest display
settings

Change-Id: I03a6ab380c8d611b69f0b817788ff1f34b47e19d
2017-07-07 12:10:45 -07:00
Andrew Sapperstein
ccbb4cfc2c Use config_headlineFontFamily for password screens.
These screens are used whenever setting or confirming the
lockscreen PIN or password. Set them to a consistent textSize (24sp)
and a consistent fontFamily.

Would have set the fontFamily in the style, but unfortunately
setInputType is called on the TextViews after inflation which blows
away the fontFamily. Instead, we set it in code right after that
call.

Change-Id: I77c3f94e2b1ce6d1f19697394c5caa09aac423b0
Fixes: 62873478
Test: manual
2017-07-06 14:30:28 -07:00
Maurice Lam
b97f91c971 Merge "Update skip button label to "Do it later"" into oc-dr1-dev 2017-06-27 01:10:37 +00:00
Maurice Lam
624212f43c Merge "Add skip button to fingerprint enrolling screen" into oc-dr1-dev 2017-06-27 01:10:23 +00:00
Maurice Lam
d342ad4878 Update skip button label to "Do it later"
Test: Manual
Bug: 62839648
Change-Id: I3616fb8095eb1ca77798d45730a1ffcda8f542a4
2017-06-23 18:55:50 -07:00
Maurice Lam
870b69b067 Add skip button to fingerprint enrolling screen
Test: Manual
Bug: 62839648
Change-Id: I3f05c64eb5b88cd91c8c98b02845a99df2d27203
2017-06-23 18:48:13 -07:00
Maurice Lam
70a031fe06 Update buttons in FP find sensor
Remove the next button (so the user has to touch the sensor to
proceed), and add a skip button.

Test: cd tests/robotests && mma
Bug: 62839648
Change-Id: I555948ac2f3235e08b91f0957aa8e0ce24535c08
2017-06-23 18:05:20 -07:00
Maurice Lam
1a07ab4790 String update for setup wizard
Test: Manual
Bug: 38503505
Change-Id: Idc881e5288ab205dee0a85a02d1365f6c4901c88
2017-05-31 14:59:37 -07:00
Maurice Lam
5ed96dc264 Resize fingerprint added illustration to specs
Use FillContentLayout to make sure the illustration is according to
specs, between 124dp and 264dp, filling up the remaining size.

The landscape layout is also updated so that the illustration is
vertically centered instead of shifted downwards.

Test: Manual
Bug: 37668789
Change-Id: If17e509d4643d620c76ca4a5bc0120272c7c58bb
2017-05-17 19:55:23 -07:00
Maurice Lam
c41e408aea Refactor choose lock password scrolling
Replace the negative margin + inset background hack with a overriding
call to requestRectangleOnScreen, which will also make a best effort
to show all the password requirements if there are multiple of them.

Bug: 38236574
Test: Added ScrollToParentEditTextTest
Change-Id: Id570652b64434b2d0b25c231540375d93884aaa9
2017-05-11 19:26:12 +00:00
Fan Zhang
1c78242a5d No autofill password when in PIN settings
Change-Id: I1a629e296c4759496307510307fd907be39bb8c8
Fix: 37244398
Test: manual
2017-04-25 11:23:29 -07:00
Yohei Yukawa
e2a7bddbe1 Set flagForceAscii for device password entries
Since the beginning [1], ChooseLockPassword#validatePassword() has never
accepted non-ASCII characters [2].  Hence we can safely specify
EditorInfo#IME_FLAG_FORCE_ASCII so that IMEs can optimize their UX based
on this flag.  Note that EditorInfo#IME_FLAG_FORCE_ASCII is just a hint
for the IME so there should be no behavior change in the system side.

Note also that EditorInfo#IME_FLAG_FORCE_ASCII has been used in KeyGuard
(keyguard_password_view.xml) since JB MR-1 [3] so this flag is considered
to be well tested.

 [1]: 00d2476d8f
 [2]: Only character c where 32 <= c <= 126 is accepted
 [3]: Id75286113771ca1407e9db182172b580f870b612

Test: Run `adb shell dumpsys input_method` when the password entry
      field is focused to make sure that 'imeOptions' parameter
      has 0x80000000 bit. Tested the following scenarios:
       - PIN on a direct-boot disabled device
       - PIN on a direct-boot enabled device
       - Password on a direct-boot disabled device
       - Password on a direct-boot enabled device
Fixes: 27858858
Change-Id: I3075e24c6dac4d49f4d0e56a0d4d8434a323754d
2017-03-28 16:42:17 +00:00
Maurice Lam
8d5a4f1689 Support center alignment
Update styles to reference the theme attribute suwGlifHeaderGravity
to, directly or indirectly via SuwDescription.Glif.

Test: Existing tests pass
Bug: 36368632
Change-Id: I6c7c234c32fdd614d4a9cdfabbef05626dad0a93
2017-03-24 15:48:14 -07:00
Maurice Lam
daaf8f8bc9 Use GLIF theme for screen lock confirmation
Theme the confirm password screen similar to setup wizard and screen
lock enrollment flow, so that we can start showing it during setup
wizard.
The new layouts are called "internal" because it's supposed to be
used only when another settings screen starts it. For external
intents from CONFIRM_DEVICE_CREDENTIAL, the existing theme and layout
are unchanged.

Bug: 32373672
Test: Run ConfirmLockPasswordTest with `am instrument`
Change-Id: Ib887a763a073e6e4b96264d08846827b2e5cbf52
2017-03-15 13:26:54 -07:00
Maurice Lam
019593072b Update fingerprint enrolling flow
1. Make FingerprintEnrollFinish stay on the back stack during "add
   another"
2. Remove skip button from the enrolling screen, since the user can
   now back out of the enrollment flow, or back to
   FingerprintEnrollFinish and press "done" there.

Test: Run FingerprintEnrollFinishTest with `am instrument`
Bug: 32054268
Change-Id: Icaf017952d6582a14b4d0904b7ee67ad22e5280d
2017-03-13 10:22:06 -07:00
Maurice Lam
bdfc27f9ac Update GLIF button styles
- The negative/secondary button styles now have the correct alpha
  for the touch highlight. (24%)
- The negative/secondary buttons now align correctly based on their
  labels text, instead of based on the bounds of the touch highlight.
- Fixed issues with button shadows being cropped.

Test: Manual inspection. Existing tests pass.
Change-Id: I261e504d661d7a53eda3561a26942ea11ba0d429
2017-02-21 18:24:39 -08:00
Lei Yu
a6189e0be3 Merge "Add scroll view for choose_lock_pattern in land mode" 2016-10-28 17:02:32 +00:00
jackqdyulei
011f0dbcdb Add scroll view for choose_lock_pattern in land mode
Wrap the title and header with scroll view in case they are too
large to display

Bug: 32261616
Test: Visual
Change-Id: I61ce67c23e27177e2915df012c450f77b40a8fb2
2016-10-21 15:05:16 -07:00
Maurice Lam
67df126291 [Fingerprint] Make enroll progress bar scalable
Make the fingerprint enroll progress bar scalable by moving it to a
single FingerprintProgressBar view and make it fill the remaining
space.

- The background fingerprint icon was changed to include the padding
internally so it can be added as the background directly onto the
progress bar view.
- The icon in landscape mode is also fixed to use the fingerprint
icon rather than the lock icon.

Test: cd tests/robotests && mm
Bug: 32123370
Change-Id: Ia5cf37d92f0af7c1cf39287f5070c44f51d44878
2016-10-20 17:20:56 -07:00