Commit Graph

56807 Commits

Author SHA1 Message Date
Raff Tsai
6db277ebb7 Remove summary provider
- use SummaryProvider to provide the summary of UserSettings
- use WifiDisplayPreferenceController to replace the summary loader
in WifiDisplaySettings
- use ConfigureNotificationPreferernceController to replace the
sumary load in ConfigureNotificationSettings

Fixes: 141653158
Test: robolectric
Change-Id: Id5f5ed645707caa0b25ecae5252174cbf017651c
2019-10-03 15:04:36 +08:00
Stanley Wang
fb2d059c6d Fix a11y issue for the Preferences in the "Model & hardware"
Talkback should not speak "double-tap to activate".

Set the preference selectable attribute to false.

Test: manual
Fixes: 139709361
Change-Id: Ifc3dfcb25fa7aa74f71c79d182668bcfbae31bee
2019-10-03 13:13:58 +08:00
Bill Yi
ccd0c91498 Import translations. DO NOT MERGE
Change-Id: I33d1ef5a92b84fc166b35f7b5b341e7a92b35820
Auto-generated-cl: translation import
2019-10-02 16:55:04 -07:00
Mill Chen
cd869051ef Fix overlapping in TrustedCredentialsSettings
It's a side effect caused by making scrollView extend below navbar.
Set both of clipToPadding and clipChildren true to fix overlapping.

Fixes: 138962899
Test: visual
Change-Id: Icf696a151055d4be76cafe44d5cb95b67bc2ea9f
2019-10-03 00:00:45 +08:00
TreeHugger Robot
616707f486 Merge "Fix talkback issue of Caption preference" 2019-10-02 08:03:41 +00:00
Raff Tsai
9e3a9fd255 Add fragment in xml instead of using injected way
- It can improve performance because we use less injected item
- Also remove summary provider from those fragments

Bug: 141653158
Test: robolectric
Change-Id: I6255f71b3b8300aea064a4fefd6711c1ff59e08a
2019-10-02 11:49:51 +08:00
Mill Chen
0a8fca1ee1 Fix talkback issue of Caption preference
Talkback speaks "double-tap to activate" on the LayoutPreference in the
Caption preference page, but it doesn't have any action after double
tap. So it should be set to unclickable. Set android:selectable to
false to fix it.

Fixes: 141900530
Fixes: 141901515
Test: launch TB and test it by manually
Change-Id: I82720dc46085b84d188730545061269d110f9a7c
2019-10-02 11:29:07 +08:00
Bonian Chen
1673f11d19 Merge "[Settings Telephony] Carrier name API replacement" into qt-qpr1-dev am: 556b34d03d
am: f726a31457

Change-Id: I4690776bb8c8ed174883014063d224dda6c72971
2019-10-01 20:00:17 -07:00
Bonian Chen
f726a31457 Merge "[Settings Telephony] Carrier name API replacement" into qt-qpr1-dev
am: 556b34d03d

Change-Id: Ibffb60c57aa4152b4681f3fe95dae7175f2e878e
2019-10-01 19:53:31 -07:00
Bonian Chen
556b34d03d Merge "[Settings Telephony] Carrier name API replacement" into qt-qpr1-dev 2019-10-02 02:44:34 +00:00
Bill Yi
60b65211ea [automerger skipped] Import translations. DO NOT MERGE am: d57831b7d2 -s ours
am: b489e62ba7 -s ours
am skip reason: subject contains skip directive

Change-Id: I89ed84bee8e0d7db3cb367629d9212bfdacf2216
2019-10-01 17:14:05 -07:00
Bill Yi
b489e62ba7 [automerger skipped] Import translations. DO NOT MERGE
am: d57831b7d2 -s ours
am skip reason: subject contains skip directive

Change-Id: Idf60f77bdffa5efdd33d01c20f4e12076f9b9b87
2019-10-01 17:07:00 -07:00
TreeHugger Robot
240572f0c2 Merge "Add onErrorListner for SliceLiveData" 2019-10-01 23:46:51 +00:00
Bill Yi
d57831b7d2 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 141777841
Change-Id: I5ef0e8ee2f723c81d4cc1c0be5daf311c7c38e84
2019-10-01 16:05:46 -07:00
Bill Yi
a623335ec0 [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev am: 833512a1d2 -s ours
am: cc1306957a -s ours
am skip reason: subject contains skip directive

Change-Id: Id67d986469cd096b9d5a96b006eb618de3b5c048
2019-10-01 15:25:45 -07:00
Joshua Mccloskey
fb09aba2f7 Merge "Added new string." into qt-qpr1-dev am: 262f5fe91f
am: b288f07bb2

Change-Id: Ia15b1cfceaf405d15ad6dc9e10acdd18b11e870e
2019-10-01 15:24:42 -07:00
Bill Yi
cc1306957a [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev
am: 833512a1d2 -s ours
am skip reason: subject contains skip directive

Change-Id: I20fe79ea6a6f6b3fd54da7ab03eaa233913287c1
2019-10-01 15:18:03 -07:00
Joshua Mccloskey
b288f07bb2 Merge "Added new string." into qt-qpr1-dev
am: 262f5fe91f

Change-Id: If8467461e0963648886c02159353c177e9b88d41
2019-10-01 15:17:26 -07:00
TreeHugger Robot
833512a1d2 Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev 2019-10-01 22:08:03 +00:00
Joshua Mccloskey
262f5fe91f Merge "Added new string." into qt-qpr1-dev 2019-10-01 22:05:41 +00:00
Bill Yi
881736b7ef Import translations. DO NOT MERGE
Change-Id: I594742575ea6729d9c71e0ef04658f6513875aaf
Auto-generated-cl: translation import
2019-10-01 12:53:15 -07:00
Bonian Chen
c7c84d2c87 [Settings Telephony] Carrier name API replacement
Replacing TelephonyManager.getNetworkOperatorName() by
Obtaining carrier name from SubscriptionInfo.getCarrierName().

TelephonyManager.getNetworkOperatorName() only be used when there's no
SubscriptionInfo can be found.

Bug: b/140443508
Test: Manual testing
  atest MobileNetworkUtilsTest
  atest OpenNetworkSelectPagePreferenceControllerTest

Change-Id: I7a86395c86d31fe2ba54c04ac16b1a0ebfc843f3
2019-10-01 17:59:43 +00:00
Bonian Chen
527a43530e Merge "[AutoTest] Settings Telephony part" 2019-10-01 11:13:25 +00:00
Mill Chen
649ec4ba16 Merge "Fix BatteryInfo test case failures" 2019-10-01 11:01:29 +00:00
Paul Hu
77226593e0 Merge "[Settings] Replace CONNECTIVITY_INTERNAL to TETHER_PRIVILEGED" am: a67ca4cfd7 am: 3a728ae13b am: a6dadc465b
am: 67fe04814d

Change-Id: I27e85d6780025122b5b56c0f8f827a0a8060e955
2019-10-01 03:21:27 -07:00
Paul Hu
67fe04814d Merge "[Settings] Replace CONNECTIVITY_INTERNAL to TETHER_PRIVILEGED" am: a67ca4cfd7 am: 3a728ae13b
am: a6dadc465b

Change-Id: I08a04f4e627ce876a3cabd194a9838a0b5ce8459
2019-10-01 03:15:14 -07:00
Paul Hu
a6dadc465b Merge "[Settings] Replace CONNECTIVITY_INTERNAL to TETHER_PRIVILEGED" am: a67ca4cfd7
am: 3a728ae13b

Change-Id: Id211709644b505fa866b0661f9657991c36dbaf6
2019-10-01 03:09:15 -07:00
Paul Hu
3a728ae13b Merge "[Settings] Replace CONNECTIVITY_INTERNAL to TETHER_PRIVILEGED"
am: a67ca4cfd7

Change-Id: I7a2a4d76d1e0092188121d390c75c12eac20cdab
2019-10-01 03:03:36 -07:00
Paul Hu
a67ca4cfd7 Merge "[Settings] Replace CONNECTIVITY_INTERNAL to TETHER_PRIVILEGED" 2019-10-01 09:50:28 +00:00
Mill Chen
0ac194de10 Fix BatteryInfo test case failures
Fixes: 141901539
Test: robotests
Change-Id: I63140c36996e463862bb2dc77d26acdaa96530b2
2019-10-01 08:53:38 +00:00
Arc Wang
1fa97eca18 Merge "[Wi-Fi] Improve UX when there is no user certificate to choose for WPA-Enterprise 192-bit" 2019-10-01 08:34:05 +00:00
Bonian Chen
199cae427b [AutoTest] Settings Telephony part
Change design to avoid using Robolectric.setupActivity()

Bug: 140707056
Test: make RunSettingsRoboTests ROBOTEST_FILTER=EuiccPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=DataServiceSetupPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=ApnPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkActivityTest
make RunSettingsRoboTests ROBOTEST_FILTER=DataUsagePreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=ApnEditorTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkSummaryControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=SubscriptionsPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkListControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkPreferenceControllerTest

Change-Id: Ifacd2e6c8733d8e814a277cf34d6f7eb1a9ddba4
2019-10-01 16:15:59 +08:00
TreeHugger Robot
14772ca9f2 Merge "Fix FaceSetupSlice test cases failure." 2019-10-01 08:13:21 +00:00
Yi-Ling Chuang
19c2a20d9a Add onErrorListner for SliceLiveData
SliceLiveData is changed in the framework, where the way it handles null
slices is different. Thus, we handle the case of null slices by adding
onSliceError() to make slice refreshing back to normal and to prevent
from non responding action on slices.

Fixes: 141293788
Test: visual
Change-Id: I4751d57ae478eec66a1a951841d36521556cacd7
2019-10-01 15:21:21 +08:00
Yi-Ling Chuang
8a4cf7c903 Fix FaceSetupSlice test cases failure.
Fixes: 141900531
Test: robotests
Change-Id: I0c68928e99b9fe12ae8d41b37a173ec1b1ecf44c
2019-10-01 14:58:42 +08:00
TreeHugger Robot
2cc52071d0 Merge "Remove summary loader in some fragments" 2019-10-01 04:00:18 +00:00
Raff Tsai
129c98bba1 Remove summary loader in some fragments
- Summary Loader only works in injected items, but those fragments
are not injected to Settings UI. The SummaryLoader class them are
useless.

Bug: 141653158
Test: robolectric
Change-Id: I1ca0bf5a1f417b7fe86b28e96aff7d4aee2cf2d3
2019-10-01 10:02:26 +08:00
Bill Yi
774e25e72f [automerger skipped] Import translations. DO NOT MERGE am: 0631ad6efb -s ours
am: beb37b072f -s ours
am skip reason: subject contains skip directive

Change-Id: I13bb676b52e10295a805a8a2f381f5493fdb80be
2019-09-30 12:47:28 -07:00
Bill Yi
beb37b072f [automerger skipped] Import translations. DO NOT MERGE
am: 0631ad6efb -s ours
am skip reason: subject contains skip directive

Change-Id: I1338a125768855043cf83c6c5c759b470e12e7d4
2019-09-30 12:42:10 -07:00
TreeHugger Robot
6b75cfa6ff Merge "Update enabled state of ZenRulePreference" 2019-09-30 13:29:33 +00:00
Bill Yi
0631ad6efb Import translations. DO NOT MERGE
Change-Id: I10e5b04a3a580ba34f945305d011ac192a3c4dd3
Auto-generated-cl: translation import
2019-09-30 03:35:57 -07:00
TreeHugger Robot
c6d0515600 Merge "Fix UI display abnormal of DatePickerDialog in landscape mode" 2019-09-30 09:36:56 +00:00
Sunny Shao
b1c4b0215b Fix UI display abnormal of DatePickerDialog in landscape mode
Update the themes.xml and styles.xml.

Fixes: 141577901
Test: manual view
Change-Id: I24cadcc972bdc0ee1f6601e3b496d0f69bb5089c
2019-09-30 16:29:17 +08:00
Raff Tsai
360d2f2c6f Fine tune language UI to match preference style
Fixes: 141830486
Test: visual
Screenshot: https://screenshot.googleplex.com/LVv2W9D963s
Screenshot: https://screenshot.googleplex.com/VbJQ0cSPBKK
Change-Id: I44b0ac8ac2bd32b3beeabee195aab928ec4bacc2
2019-09-30 11:17:04 +08:00
Bill Yi
b151b8a758 [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev am: b01e0ab05c -s ours
am: 37703c090a -s ours
am skip reason: subject contains skip directive

Change-Id: I08cf95cb7336d3a3208aa3e3f618d47093402ea8
2019-09-28 14:23:40 -07:00
Bill Yi
37703c090a [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev
am: b01e0ab05c -s ours
am skip reason: subject contains skip directive

Change-Id: Ie644497f111a2029d99a700b6333d3dec43fa948
2019-09-28 14:16:37 -07:00
TreeHugger Robot
b01e0ab05c Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev 2019-09-28 21:05:31 +00:00
Bill Yi
f7de50f5be Import translations. DO NOT MERGE
Change-Id: Idfb9ca3c6ddf6aa0a9bc04a262b8e0fd76032867
Auto-generated-cl: translation import
2019-09-28 04:11:34 -07:00
joshmccloskey
d560588aa0 Changed string for translations. am: 186dbc65af
am: 515772802f

Change-Id: I7554b0e974393e7df7cde9ff4355b3713d0997d5
2019-09-28 01:22:30 -07:00
Kevin Chyn
7ce886bdd7 Fix FaceSetupSliceTest am: acde97cf90
am: a9c14ab4b1

Change-Id: Ic96ff261766e750e0fff6b3ff73e21d0588b0222
2019-09-28 01:20:03 -07:00