Steps to Reproduce:
- Click on Density Settings (DPI Settings) / Renaming BT Device / Renaming SIM Settings
- EditText Dialog pops up
- The cursor is at the leftmost side of the text
- Logically Cursor should be at rightmost side which can be aligned grabbing text length
Screenshots:
Before:
http://imgur.com/a/o4vkrhttp://imgur.com/a/6Qext
After:
http://imgur.com/a/fuxqThttp://imgur.com/a/vm2WX
Bug: 65185652
Test: RunSettingsRoboTests: OK (47 tests)
Change-Id: Id00308e7e019434edad4afab56cf4719be0d0d54
Signed-off-by: PMS22 <prathams99@rediff.com>
- Create new AdbPreferenceController
- Create AdbOnChangeListener interface for adb change callbacks
- Create EnableAdbSettingWarningDialog
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
- Add deprecated annotation to EnableAdbPreferenceController
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Id57146149943d770bf5ccc9ed5ecc6ea9d8ae66c
This is entirely implementation detail, the public
interface and tests get to stay the same.
- The Raw, Resource and Provider methods now return single
or lists of IndexData rather than adding to a member var.
- Some code duplication was removed for Raw IndexData.
- Extra methods were squashed or removed
The only remaining refactoring in IndexDataConverter is
moving work done on IndexProviders to get the raw and
resources into PreIndexDataCollector.
Bug: 33577327
Test: make RunSettingsRoboTests, Database dump before & after
Change-Id: If6011046955f242ba2614400cfeca3bea5b683cb
- Create new ShowTapsPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ifb4aa9e3c95c04bc7f8fd7e0220c9fe46b502ea6
- Fix a bug where an incorrect config value was being passed
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ic42d94867097f7944e66ecc3abc42bb8b72608a2
- Create new ConnectivityMonitorPreferenceControllerV2
- Deprecate ConnectivityMonitorPreferenceController
- Create controller inside the DashboardFragment
- Copy logic from ConnectivityMonitorPreferenceController with slight
modifications for dashboard fragment compatibility
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ibba32208abb2535e1d13b299705e4f4e63aef8c8
- Create new WaitForDebuggerPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I95e25ad244328dd49da1b1e8fcd1c264f0ccc587
- Create new SelectDebugAppPreferenceController
- Update onActivityResult to loop through all controllers
- Add new activity request code
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I90b1da2d536389e45d717adffb3b190ec13b9a2a
- Create new BluetoothAbsoluteVolumePreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: If5b979e8bb641eb8ad2db58246362ec327e17f36
- Create new TetheringHardwareAccelPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ida551460d8227b20cc6bca3f1d46c39ee7176f8f
- Create new WifiVerboseLoggingPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Iccfc9840ed8f5cf4417e326b1bdc62800cb4e93e
- The SuggestionControllerMixin is needed to dismiss a suggestion.
- When swipe a suggestion, SuggestionControllerMixin is called, which
then calls API in SuggestionService to dismiss a suggestion.
Bug: 65065268
Test: robotests
Change-Id: I6a0c5823d60b995ab4a36b1c91777f5cd31a500d
- Create new MobileDataAlwaysOnPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DeveloperSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: If4b1a0d14c4b24cb1562a37627436bfb011e9310
- Create new BluetoothDeviceNoNamePreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ia73952bd396fb50d96393befd011f7cdc08689f7
- Create new WifiAggressiveHandoverPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ic32119a83ca21a6475cfd27b04cde76ba87bd372
- Create new CameraHalHdrPlusPreferenceControllerV2
- Copy logic from CameraHalHdrPlusPreferenceController with slight
modifications for dashboard fragment compatibility
- Deprecate CameraHalHdrPlusPreferenceController
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I9b88286d16930df208c7c413728c816637409c81
TelephonyMonitor can be extended to catch WIFI and GPS
issues.
Bug: 38422753
Test: Unit tests and manual testing
Change-Id: I71f9cf75fdc792452dd35a3581ef0f5fcc0c1ab0
For the sake of incremental updates, we moved all of the
conversion from PreIndexData to IndexData, and the
insertion of the rows into the SQLite DB into a new class,
IndexDataConverter. However, it's real role is just to
convert PreIndexData into IndexData.
So this CL moves the insertion of the rows back into
DatabaseIndexingManager.
Again, for the sake of simplicity, I did not change the
conversion flow. Rather, instead of inserting a row at the
end of the conversion, I just put it into a list which is
then returned. This lets me move the tests to appropriate
locations, without having to change them too much.
In the tests, the references to real xml layouts are
changed to fake references. Hooray for being less brittle.
IndexDataConverter now just tests that the IndexData
has the appropriate data from PreIndexdData.
Independently, we test that IndexData gets inserted in
DatabaseIndexingManager.
In the next CL, I'll refactor the conversion
flow for readability.
Bug: 33577327
Test: make RunSettingsRoboTests
Test: Took a database dump before and after change,
and they were the same. Cool.
Change-Id: I39cc812d1f736e13a0a51af50984c239961ecf7a
- Create new WifiRoamScansPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I967944e8d22d985035c94874d13e02c3f5e70781
- Create new WifiDisplayCertificationPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I34688131054e1a9d660482b04ad4b792235c445a
- Create new CameraLaserSensorPreferenceControllerV2
- Copy logic from CameraLaserSensorPreferenceController with slight
modifications for dashboard fragment compatibility
- Deprecate CameraLaserSensorPreferenceController
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I8854d3e891afab607025a427a376e33e9b61dcc3
- Create new DisableAutomaticUpdatesPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Iae7ff3f7d2e296968c67e14c33089b3b42c4912a
