Commit Graph

5 Commits

Author SHA1 Message Date
Fan Zhang
f559395603 Use preference theme from SettingsLib
Bug: 36663882
Test: rerun robotests
Change-Id: I9f0f51a9d070191f5bf8f3315fef4d997d6213c3
2017-07-10 14:56:49 -07:00
Fan Zhang
04b96110e1 Revert "Use framework support to reserve icon space"
This causes DropdownPreference to crash

Bug: 37850881
This reverts commit 19f5783b75.

Change-Id: Iaa2ceb1a031e8e0b62bc886d908534f3b53d3835
2017-05-01 18:11:59 +00:00
Fan Zhang
19f5783b75 Use framework support to reserve icon space
Framework now has iconSpaceReserved attr to support reserving icon
space. We no longer need to use a custom layout for each preference.

What's removed:
- custom style for normal preference
- custom layout/style for dropdown preference
- custom style for EditTextPreference

Fix: 37572422
Test: visual
Change-Id: I48d2997e6269143f58c2edd2d9902cdc0519ed04
2017-04-25 22:07:24 +00:00
Fan Zhang
87e67b3366 Align dropdown preference's dropdown with preference text
Change-Id: I9446758464fd9220a2670df4203406ba49e24901
Fix: 35807231
Test: RunSettingsRoboTests
2017-03-01 17:47:19 -08:00
Fan Zhang
1c118b5f2a Always reserve space for preference icons.
This aligns text on preferences on the same screen when some of them
don't have icons.

- Use a custom layout for
  preference
  EditPreference
  switch preference
  VolumeSeekPreference
  DialogPreferencei
  Restricted*Preference
  DropdownPreference

- Moved related style defs into a new file styles_preference.xml,
  because current styles file is too large to read.
- Switch <PreferenceScreen ...> to <Preference ...> for a bunch of
  regular preferences.
- Also removed some dead style.

Bug: 33430928
Test: runtest --path packages/apps/Settings/tests/app/src/com/android/settings/dashboard/PreferenceThemeTest.java

Change-Id: Ic9b75d3f133f2a83cd999297b8596253d4b10161
2016-12-12 16:02:45 -08:00