Commit Graph

16058 Commits

Author SHA1 Message Date
jackqdyulei
e8a56c183a Refactor PreferredNetworkModePreference
Create preference controller for it.

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I456b0b954f47a6fb4c03926049b0579fd6488969
2018-10-17 21:26:30 -07:00
Lei Yu
5b0c051dcd Merge "Refactor roaming preference" 2018-10-18 00:44:47 +00:00
TreeHugger Robot
cc607b5634 Merge "Fix visible problem on status bar" 2018-10-17 20:38:14 +00:00
TreeHugger Robot
5477ffe081 Merge "Update toolbar for mobile network settings" 2018-10-17 20:20:08 +00:00
jackqdyulei
d622e14d85 Refactor roaming preference
Use preferenceController instead

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: Idb0276ea0ed1738d93223e072338ba3c32498a9d
2018-10-17 13:03:26 -07:00
TreeHugger Robot
deaded12c7 Merge "Sync style of filter component in data usage" 2018-10-17 18:38:45 +00:00
jackqdyulei
52b08e42ba Update toolbar for mobile network settings
Bug: 114749736
Test: Manual
Change-Id: I9b01df83215ca6974b096060fa8d6669307c96e1
2018-10-17 10:02:46 -07:00
tmfang
60d0b3ce3b Fix visible problem on status bar
Battery Icon is not displayed on "Vision settings" screen

Test: visual
Change-Id: I272302af5b6e7309318c04b891d20526f68c5b0d
Fixes: 117751096
2018-10-18 00:52:08 +08:00
Emily Chuang
8d9b265620 Give SliceView a height to support four rows and show more button.
The default height of sliceView with MODE_LARGE is 240dp which supports
three rows(including the header) above "show more" button. Since WIFI
and Connected devices use cases require four rows + show more button, we
need to expand the height to fulfill it.

Bug: 117868297
Test: visual
Change-Id: I13b29c3f859d1c117c680432f9a6ad8e71c6acf5
2018-10-17 20:50:20 +08:00
Raff Tsai
cb6b34e893 Merge "Use the same layout style for contextual cards" 2018-10-17 10:02:40 +00:00
Bill Yi
f896493c70 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 117801752
Change-Id: I43766c0d85af44370fa136fb4b54869ccfb9bdb4
2018-10-17 04:32:19 +00:00
Lei Yu
5181493586 Merge changes I7a0845c0,I45ecbc86,I3d0203b7,I7cfc27ff
* changes:
  Refactor DataUsagePreference
  Refactor carrier settings
  Refactor CdmaApnPreference
  Refactor CdmaSubscriptionListPreference
2018-10-17 02:56:39 +00:00
jackqdyulei
5680477b8b Refactor DataUsagePreference
Move the logic to PreferenceController

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I7a0845c0cbc3f33e23257831d0d4ed97e7a5cc04
2018-10-16 15:40:17 -07:00
jackqdyulei
1d133e3f04 Refactor carrier settings
Only show it when:
1. It is in CDMA or GSM mode
2. CarrierConfig tell settings to show it

Bug: 114749736
Test: RunSettingsRoboTests

Change-Id: I45ecbc86c793ebec602142be208058e2043a2ba7
2018-10-16 15:33:20 -07:00
jackqdyulei
2de3d28138 Refactor CdmaApnPreference
Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I3d0203b7b5fb732e2814fb741761af4371924e9a
2018-10-16 15:33:20 -07:00
jackqdyulei
37f2e60b8c Refactor CdmaSubscriptionListPreference
Extract CdmaBasePreferenceController that can be shared by all CDMA
PreferenceController. Also create new subscription controller to use
it.

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I7cfc27ffd0704d09dc02e49fbf5641ff8b90642d
2018-10-16 15:33:20 -07:00
Fan Zhang
9c072cd621 Merge "Remove second_button from condition tile. It's never used." 2018-10-16 21:42:05 +00:00
tmfang
6e16b69887 Sync style of filter component in data usage
Settings have new filter component with settings style.
This CL replaced Spinner to SettingsSpinner in data usage page.

Change-Id: I212b6b6ed203f8bffd094c0180873060b93c39cb
Fixes: 117568930
Test: robotests, visual
2018-10-17 05:14:46 +08:00
Fan Zhang
e3e7387105 Remove second_button from condition tile. It's never used.
Change-Id: I69e50d3b777d36731eee024a437facdab67e7ffa
Fixes: 117823082
Test: visual
2018-10-16 12:12:21 -07:00
Raff Tsai
f7bb72c60c Use the same layout style for contextual cards
Test: manual
Change-Id: I41d86df5147290a17ef698f4f6a192081d1e0742
2018-10-16 21:47:58 +08:00
Raff Tsai
2493587202 Use DayNight theme in factory reset page
Change-Id: I3cc75a34aaec71c97d1dd83eaf40232de1fd4168
Fixes: 73738836
Test: Manual
2018-10-16 04:21:15 +00:00
TreeHugger Robot
0d0eec6d4e Merge "Refactor CdmaSystemSelectListPreference" 2018-10-15 20:08:31 +00:00
Bill Yi
2a1a5cba81 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I44be933d470fa7dad8e60b4ecb3dc038ff74c702
2018-10-15 12:34:57 -07:00
Youming Ye
792e6afc84 Merge "Fix error message shown when SIM PIN enable/disable fails" am: f29392303a am: 8bac59265e
am: 6293483fce

Change-Id: I5b533e911f1185bb9fe1847701e333093b49926e
2018-10-15 11:41:46 -07:00
Youming Ye
6293483fce Merge "Fix error message shown when SIM PIN enable/disable fails" am: f29392303a
am: 8bac59265e

Change-Id: If28ef5f32183918404896ed395a49c9c2d87067a
2018-10-15 10:59:04 -07:00
Youming Ye
8bac59265e Merge "Fix error message shown when SIM PIN enable/disable fails"
am: f29392303a

Change-Id: I060d7e0e02b56d9fea5260ba1f2cf8a1ea746414
2018-10-15 10:42:52 -07:00
Philip P. Moltmann
1d95218e49 Merge "Use renamed restricted icon size config-value" 2018-10-15 17:16:55 +00:00
Youming Ye
f29392303a Merge "Fix error message shown when SIM PIN enable/disable fails" 2018-10-15 17:08:22 +00:00
Bill Yi
ebb0bbe3f7 Import translations. DO NOT MERGE
Change-Id: Id3ba67104115b2148f36fb26a94957ee6ac4a89d
Auto-generated-cl: translation import
2018-10-15 01:55:17 -07:00
jackqdyulei
b820483fad Refactor CdmaSystemSelectListPreference
Most logic is copied from previous ListPreference however
1. Create PreferenceController for it
2. Extract API to check whether to display CMDA options
3. In controller, provide API to force display dialog

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: Ic40d2ac1dc1854df9c90d912ea9fc822531b413d
2018-10-12 10:11:58 -07:00
Philip P. Moltmann
92f3a8afe3 Use renamed restricted icon size config-value
Bug: 116797641
Test: Built
Change-Id: I913d7fece475e19969f9d932c0992242308bb02f
2018-10-11 12:42:26 -07:00
jackqdyulei
8eec6ff917 Change packagename to telephony
Also move it under package network, so all of them belong to
com.android.settings.network.telephony.

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I35dbdcd5cc9dab939b0a3efccc8897b9a92338d1
2018-10-11 11:46:38 -07:00
TreeHugger Robot
45d8fbe54f Merge "Change search fab to search bar." 2018-10-11 02:42:24 +00:00
Lei Yu
9b373eb7a0 Merge "Refactor MobileDataPreference" 2018-10-11 00:24:56 +00:00
Fan Zhang
3181e1aceb Change search fab to search bar.
- Remove search fab from layout xml
- Change RelativeLayout to CoordinatorLayout so we can use prebuilt
  scrolling behavior
- Minor update to theme so search bar background works in dark mode for
  the homepage activity.

Change-Id: If7408c12684be65137e04ae3bb4137204c2d77e0
Fixes: 117508596
Test: robotests, visual
2018-10-10 16:29:22 -07:00
jackqdyulei
36063b9222 Refactor MobileDataPreference
1. Remove it and change it to SwitchPrference
2. Build MobileDataDialogFragment to show dialog when needed
3. Create controller for it to decide when to launch the dialog

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I02b9662c5829e765f2c71d10ed951d792cf7aaa1
2018-10-10 16:05:08 -07:00
Fan Zhang
2f18df0c69 Update strings
Change-Id: I3a70d787e6db6743638460195f36386111647e4e
Fixes: 117508849
Test: visual
2018-10-10 11:16:02 -07:00
TreeHugger Robot
0cd4db4762 Merge "Use custom drop-down filter widget" 2018-10-09 05:29:15 +00:00
TreeHugger Robot
12964a7ec0 Merge "Remove obsolete chart view widgets." 2018-10-08 23:00:06 +00:00
Lei Yu
dd2908d5ce Merge changes I3008bf85,I43aebf2e,I4fda0708,I744d5376
* changes:
  Remove AdvancedOptionsPreference
  Add activity for mobile network page
  Fix the complie error of network migration
  Copy MobileNetworkSettings to settings app
2018-10-08 22:12:26 +00:00
Doris Ling
8e208c6516 Remove obsolete chart view widgets.
ChartDataUsageView and ChartNetworkSeriesView are no longer being used.
Remove them to avoid the need to maintain obsolete codes.

Bug: 117433810
Test: rebuild and make RunSettingsRoboTests
Change-Id: I0c99725500926083bee693c102a323d563647c3a
2018-10-08 14:18:50 -07:00
Fan Zhang
e50a56c44f Add search keyword to lock screen notification setting.
Bug: 115894261
Test: reindex
Change-Id: I0532c5dba8175beb2712cd907d132a360d312c04
2018-10-08 12:39:23 -07:00
jackqdyulei
2c0861e61b Remove AdvancedOptionsPreference
This is used to show "Advanced" preference in telephony package.
Remove it since we have better way to do it in settings.

Bug: 114749736
Test: Manual
Change-Id: I3008bf856b8f42ba10ab26cb81d35a9370601c58
2018-10-08 11:12:03 -07:00
jackqdyulei
106ae1d742 Add activity for mobile network page
1. Extract the Tabhost to activity level, not fragment level. So
each mobile fragment has a constant subscriptionId
2. Use BottomNavigationView instead of TabHost

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I43aebf2ec01a945697c6b2302ab750e715e4bfef
2018-10-08 11:00:35 -07:00
jackqdyulei
38f872fa1f Fix the complie error of network migration
1. Fix the error in import part
2. Remove broken code and add TODO

Future CL will fix TODO and add tests

Bug: 114749736
Test: Build
Change-Id: I4fda0708959e299015ecb10ac17c9c2dadc6f852
2018-10-08 10:44:38 -07:00
tmfang
0d07dd19d0 Use custom drop-down filter widget
This CL is just a example how to use this SettingsSpinner.

Change-Id: Ie0d104ce5f3e4c6b852fe7c051253b1567c6c4cd
Fixes: 112706966
Test: robotests
2018-10-08 16:23:52 +08:00
Bill Yi
93c86ab1b6 Import translations. DO NOT MERGE
Change-Id: I97ae0a1863b5a8208b4784e10ee1422e010928c8
Auto-generated-cl: translation import
2018-10-06 21:32:01 -07:00
jackqdyulei
bff33e170c Copy MobileNetworkSettings to settings app
This is a CL to copy most components from telephony to settings app with
following changes to pass the preupload check:
1. Add [CHAR LIMIT]/comments for strings that miss them

This CL cannot build and future CL will fix the broken part.

Bug: 114749736
Test: Build
Change-Id: I744d537610eeeb7f2fb801defdd0ce47ef6088b6
2018-10-03 18:05:15 -07:00
TreeHugger Robot
633650969a Merge "Add PreferenceController for support tile in homepage." 2018-10-03 22:46:56 +00:00
Fan Zhang
dd5828c054 Add PreferenceController for support tile in homepage.
Change-Id: I8fe93456a761382513c07ff85c858ded30f599fc
Fixes: 116875332
Test: robotests
2018-10-03 13:35:12 -07:00