Commit Graph

3987 Commits

Author SHA1 Message Date
TreeHugger Robot
48fab1db3a Merge "Fix the color of dot wrongly in device admin page" into sc-dev 2021-05-21 17:05:30 +00:00
TreeHugger Robot
417af889e1 Merge "Fix overlapping problem for device admin page" into sc-dev 2021-05-21 09:42:05 +00:00
TreeHugger Robot
d573f1d19e Merge "Make preference title align after icon" into sc-dev 2021-05-21 08:30:46 +00:00
Edgar Wang
600d023892 Make preference title align after icon
- Running service should use app preference layout.
- RestrictedDropdownPreference should use preference layout.
- Tweek Storage item icon padding
- Wifi calling should use Prefernce
- In Open by default page, if there is no vierfied link, we should
  hide the checkbox.

Bug: 186069482
Test: manual
Change-Id: Icc186ad79fc2bcf7ecd9c1ebba747bdad2d9b9ad
Merged-In: Icc186ad79fc2bcf7ecd9c1ebba747bdad2d9b9ad
2021-05-21 07:21:59 +00:00
TreeHugger Robot
f8bcde8886 Merge "Apply ripple on entire button" into sc-dev 2021-05-21 01:47:56 +00:00
Tsung-Mao Fang
2bdeaae97a Apply ripple on entire button
Expand the width of button, so we can see ripple on entire button.

Test: Click button and see ripple.
Fix: 188735750
Change-Id: Ic65e3579263108c9d0de0eb405fe30f2556b5193
2021-05-20 16:00:28 +00:00
Tsung-Mao Fang
3720ae21b0 Fix the color of dot wrongly in device admin page
In this cl, we migrate origin files/method from framework into settings app.
So, we can control layout and drawble without impacting other app.

And we only remove to set a tint color in app_permission_item.xml.
Currently, it won't tint color for dot now.

Test: See the screen and dot's color is correct.
Fix: 188188444
Change-Id: I18054b47ba07e7864e7c238f2bec5fbe1d3feeea
2021-05-20 20:21:56 +08:00
menghanli
5eb4edad0e Fix contrast ratio of some text in Audio adjustment page are too low
Apply same the sub text style from seekbar preference

Bug: 188603038
Test: Manual testing
Change-Id: I6e3db2657a02ac885b16309546e7f2224775a194
2021-05-20 06:13:57 +00:00
Mill Chen
ef8f5c5ca4 Fix overlapping problem for device admin page
The content of Activate device admin app is overlapping with the title
while scrolling up. That is because the collapsing toolbar needs to
work with the view that supports nested scrolling feature, and this page
hasn't updated the layout to use NestedScrollView. So that caused the
overlapping problem.

Fix: 188184864
Test: visual verified
1) Navigate to Settings > Security > Device admin apps > pick up one to
activate
2) Scrolling the content and see if the content is overlapping with the
title

Change-Id: Ide5ff9ed40202c3b217934db93c82a4861983416
2021-05-20 13:56:52 +08:00
TreeHugger Robot
2a7e608ef2 Merge "Visual update for FaceSettings" into sc-dev 2021-05-19 03:19:07 +00:00
TreeHugger Robot
6d550713dd Merge "Update the layout of Pattern/PIN/Password confirmation" into sc-dev 2021-05-19 03:16:47 +00:00
TreeHugger Robot
4a67b1c099 Merge "Tweak the layout for Pattern/PIN/Password enrollment" into sc-dev 2021-05-19 03:15:28 +00:00
TreeHugger Robot
db6c7211e4 Merge "Update style name" into sc-dev 2021-05-18 11:28:56 +00:00
Mill Chen
4e168dd691 Visual update for FaceSettings
This includes the following changes:
- Remove the face animation from FaceSettings page
- Correct the color filling of collapsing toolbar
- Make the button align with other settings
- Remove the seperator

Fix: 186804060
Fix: 187882118
Test: visual verified
Change-Id: I4b7679ced0c420b4d23a3c326ac2a93734c0b8bb
2021-05-18 17:29:56 +08:00
Betty Chang
78031d82b7 Merge "[GAR] Change the text color for Private DNS Summary to follow the GAR" into sc-dev 2021-05-18 06:47:00 +00:00
changbetty
cea28334a2 [GAR] Change the text color for Private DNS Summary to follow the GAR
This cl is fixed one of the suggestion. Refer to b/181186668 for another
suggestion on Accessibility Scanner result.

Bug: 181184589
Test: Manual test by Accessibility Scanner
Change-Id: Ief0908891c98f641c99d578cf5acb210cc972e91
2021-05-18 10:14:15 +08:00
Mill Chen
148eb471bf Update the layout of Pattern/PIN/Password confirmation
- Using the SUW library API to enable the new style
- Removing some obsolete layouts which are using in landscape mode
- Verifying that these pages are using the new style

Fix: 188438375
Test: visual verified
1) Register a screen lock
2) Navigate to Settings > Security > Screen lock
2) See and check if the Pattern/PIN/Password confirmation page is using
the new style

Change-Id: I076dbf36388fa3badf4da409bcda83a5b368f13c
2021-05-18 09:57:43 +08:00
Mill Chen
9edcc5b5e3 Tweak the layout for Pattern/PIN/Password enrollment
- Fix the problem with invisible title
- Fix the wrong layout for landscape mode
- Apply color extraction

Fix: 185076320
Fix: 182339941
Fix: 182440016
Fix: 184715547
Fix: 183710293
Test: robotests and visual verified
Change-Id: Ib8e2a015bc52fcac2d285777972177e53bde7489
2021-05-18 03:23:37 +08:00
Wesley.CW Wang
2b6a081a0b Update style name
Bug: 187923403
Test: make SettingsRoboTests
Change-Id: I01455cef919cb8692df9d275c8dff0c68d75861f
2021-05-17 14:02:05 +08:00
Kevin Chyn
15d75cf59a Merge "Fingerprint image is not important for a11y announcements" into sc-dev 2021-05-14 21:06:11 +00:00
Kevin Chyn
dbdaa8518a Fingerprint image is not important for a11y announcements
Fixes: 187338706
Test: manual
Change-Id: Ic0eac21d0265b5fceb0ab71e013932d3629645b3
2021-05-13 16:38:01 -07:00
Julia Reynolds
14f204af54 Merge "Fix vertical alignment in history" into sc-dev 2021-05-13 21:51:03 +00:00
Julia Reynolds
77955974da Fix vertical alignment in history
Test: visual with a ruler
Fixes: 187758949
Change-Id: I337210e9052354aaec5ad93c7147d439ca0f9852
2021-05-13 13:05:48 -04:00
TreeHugger Robot
f6b42231e0 Merge "Notif Settings polish" into sc-dev 2021-05-13 12:51:51 +00:00
Ryan Lin
a2f47b3299 Merge "Fix incorrect layout in RTL" into sc-dev 2021-05-13 04:27:18 +00:00
Curtis Belmonte
5ed928f626 Merge "Consolidate face enroll intro/consent screens" into sc-dev 2021-05-13 04:01:56 +00:00
Jason Chiu
cb88a7e24d Merge "Redesign homepage IA icon" into sc-dev 2021-05-13 02:59:29 +00:00
Curtis Belmonte
cef573f2d0 Consolidate face enroll intro/consent screens
Updates the UI of the face enroll intro screen based on the latest
mocks, while still allowing strings to be overlaid depending on the
device and/or face auth implementation.

Test: Manually tested face enrollment

Bug: 187207438
Change-Id: I5d912261b1eecfc7a241d6b48d549c4ff253ecdf
2021-05-12 17:26:17 -07:00
Kevin Chyn
cbf7e63d11 Merge "Update fingerprint introduction "Keep in mind" section" into sc-dev 2021-05-12 17:44:11 +00:00
Julia Reynolds
8745e5aab9 Notif Settings polish
Adjusting strings and margins

Test: visual
Fixes: 187868912
Fixes: 187853607
Change-Id: I976d0b8b2067556ed95e4610dd6ea3b85e6fc82f
2021-05-12 12:46:12 -04:00
ykhung
2102059e2d Fix GAR issue for battery chart description and the contrast ratio
Bug: 187813918
Bug: 187811403
Test: make SettingsRoboTests
Change-Id: I4fae623a305fd1ee022336bcae35d9dd9995146d
2021-05-12 15:38:33 +00:00
Betty Chang
8081c1fbdc Merge "[GAR] Change the text color for "Airplane mode is on" message to follow the GAR" into sc-dev 2021-05-12 09:56:09 +00:00
Jason Chiu
7d9dceadb7 Redesign homepage IA icon
- remove the outer circle of the icons
- tint the icons including injected ones

Test: robotest, visual
Bug: 182870640
Change-Id: If72c37152f4f0d68e25149b11d497eef1c7ece91
2021-05-12 08:37:37 +00:00
ryanlwlin
7960b88481 Fix incorrect layout in RTL
Fix illustration and the textview alginment.
The imageview doesn't change the direction of the drawable,
so we change scale type based on layout direction.

Bug: 187526643
Test: manually test with with locale ur and en
Change-Id: Ie4544f0eb00309a6132e4b6d794ad2a76966133c
2021-05-12 15:32:49 +08:00
TreeHugger Robot
bc4f3817da Merge "Fix color contrast problem for VPN page" into sc-dev 2021-05-12 03:50:14 +00:00
TreeHugger Robot
0fa1e491f8 Merge "Disable the info icon" into sc-dev 2021-05-12 03:10:36 +00:00
changbetty
86d957ae0b [GAR] Change the text color for "Airplane mode is on" message to follow
the GAR

Bug: 179001230
Test: manual test by Accessibility Scanner
Change-Id: Ib1a09a28c2b4ff3d5dbee13b7d85a973e760bc36
2021-05-12 02:36:12 +00:00
Kevin Chyn
219b919ba5 Update fingerprint introduction "Keep in mind" section
Bug: 187068239
Test: manual
Change-Id: I203f1c52c50dea9cfb1045726f3f2bb4b04435ff
2021-05-11 14:27:51 -07:00
ykhung
525659c291 Refine graph top margin and expand/collapse icon theme color
Bug: 187767343
Test: make SettingsRoboTests
Change-Id: I5084affd49169de1f43a308acbe192f55454d0f7
2021-05-11 08:22:38 +00:00
Sunny Shao
a82183a5f9 Disable the info icon
- Show disabled info icon.
- Remove the duplicated resouce files.

Fix: 186608804
Fix: 182870810
Test: manual test
Change-Id: I8c0ddc8f76921965073699d5bd029dc1b9d59fb0
2021-05-11 11:12:03 +08:00
Tsung-Mao Fang
55ab3f91e5 Fix color contrast problem for VPN page
Test: A11y scanner doesn't show text contrast problem
Fix: 187399519
Fix: 181185518
Change-Id: I830a8b16d817bbdf2c68332e38fad0a15b87ce45
2021-05-10 09:54:12 +00:00
Weng Su
72c3debb0b Merge "[Provider Model] Add progress bar to internet panel" into sc-dev 2021-05-10 05:28:15 +00:00
Weng Su
c407a2d9f8 [Provider Model] Add progress bar to internet panel
- Show progress bar when Wi-Fi scanning

- Show "Searching for networks..." sub-title when Wi-Fi scanning

- Remove "Wi-Fi" from searching networks string

Bug: 178774497
Test: manual test
atest -c InternetConnectivityPanelTest
make RunSettingsRoboTests ROBOTEST_FILTER=PanelFragmentTest

Change-Id: Ic05b939bef3b106845fe90db41eb09f0e15756f4
2021-05-10 05:27:59 +00:00
ykhung
5b27fd923a Fix UI flashes issue when entering to the app in the cold start
1. fix the chart % info will flash issue by deferring the showing time
until the chart content is ready to show (set default as invisible)
2. fix the category title will flash issue by set the default value as
empty to avoid refresh the title twice in the start time

Bug: 177406865
Test: make SettingsRoboTests
Change-Id: If8f247cf5b01c529bc5e4d18fcf409ba296cc2f4
2021-05-09 01:56:09 +00:00
Yanting Yang
c37abc9edb Merge "Add summary back to the homepage" into sc-dev 2021-05-07 09:00:32 +00:00
TreeHugger Robot
8642ee35ad Merge "Fix the battery usage screen left alignment issue" into sc-dev 2021-05-07 03:59:13 +00:00
ykhung
3b6e225a5c Fix the battery usage screen left alignment issue
Bug: 187383692
Test: make SettingsRoboTests
Change-Id: I9abb17562bea3727f31ce781cf452412a4ee7818
2021-05-07 10:48:28 +08:00
TreeHugger Robot
dff47cf00a Merge "Fix loading ring overlapping problem" into sc-dev 2021-05-06 06:51:24 +00:00
Yanting Yang
d1312e8e6e Add summary back to the homepage
Also update some summaries with new strings.

Bug: 183586663
Test: robotests & atest & visual

Change-Id: I692be9b34e8867501aaa8c8e40428870b99644f8
2021-05-06 00:27:37 +08:00
Tsung-Mao Fang
2042dac123 Fix loading ring overlapping problem
By design, the loading ring is in the middle of the recycler view.
In the Android S, recyclerview isn't matched the screen's height.
So, if the recyclerview doesn't contains any item, the height could be
very low and then it causes to overlaps with drop down view.

The simple solution is to fix height of view of progress
bar, so it won't rely on the height of recycler view anymore.

Fix: 184643347
Test: Go to app notification page, and no overlapping problem.
Change-Id: I9f4fddba0254ac0cb0ba0b128a7dcc2de05d1fce
2021-05-05 23:43:46 +08:00