Commit Graph

8 Commits

Author SHA1 Message Date
Wesley Wang
c01d92982d Add manual enabled battery saver reason (2/4)
Bug: 218405966
Test: make SettingsRoboTests
Change-Id: Ifd51cde5abbbd731c24bf677ca1c525ffd6993a3
2023-04-06 17:11:23 +08:00
Fan Zhang
31b210017b Migrate all MetricsProto enums to SettingsEnums
Bug: 122855168
Test: rebuild
Change-Id: I962d9a71179f86b7cae9dc5e9a00e0aa1557dc76
2019-01-17 14:55:42 -08:00
Mill Chen
1c3ed19a09 Remove mIsHalfWidth field from ContextualCard
mIsHalfWidth in ContextualCard is too generic to identify its
responsibility, it is used to hold the value of is_support_half from
database and used to decide the card width. Also, it limits the
relationship of CardType-to-Renderer not to be extended to one-to-many.

To deal with this, we replaced mIsHalfWidth with mViewType to implement
one-to-many relationship of CardType-to-Renderer, and removed all
related logic of mIsHalfWidth.

Bug: 121303357
Test: robotests, visual

Change-Id: I03e14392272194424f317d11bf9d0d794a6133f4
2019-01-16 04:01:45 +00:00
Fan Zhang
0896fa3bee Revert "Remove battery saver condition."
This reverts commit 44b28f4a2b.
Bug: 121115306
Test: robotests

Reason for revert: Change of design

Change-Id: Ia2b9131595d582fd8300367f729fde2b3de81b6e
2019-01-09 15:23:02 -08:00
Fan Zhang
44b28f4a2b Remove battery saver condition.
Battery saver is also implemented as a contextual card. no need to use
condition any more.

Change-Id: I2607c610593c6e250569fbd3b4f1a5516f6ea62f
Fixes: 121115306
Test: robotests
2018-12-17 12:31:50 -08:00
Mill Chen
0ca7130403 Update new UI of conditional cards
- Add half-width and full-width layouts for conditional cards
- Keep origin strings of conditional cards, that could make conditional
cards truncate its title and summary in half-width card.
- Add default value of isHalfWidth to each condition controller.

Bug: 113451905
Test: robotests, visual
Change-Id: Ib0055f32c4ab9e73c0e0a57c6b0ef586d52942e0
2018-11-07 16:06:31 +08:00
Fan Zhang
b739e7cd7f Clean up ConditionalCards
Use ConditionalContextualCard directly.

Change-Id: If2e51cdd2cbed27b0094bbb9be06ee9a67f328ec
Fixes: 114307767
Test: robotests
2018-11-01 14:25:53 -07:00
Fan Zhang
5e6e6a14f2 Move all contextual card related classes.
... from homepage to contextualcards.

Test: rebuild
Change-Id: Id7889566ce1e7257eb699d963ae996906fdb58ff
2018-10-26 10:02:04 -07:00