Commit Graph

3281 Commits

Author SHA1 Message Date
Treehugger Robot
7e8222833b Merge "Remove all pending messages when fragment destroyed" into main am: f85bc08954 am: 07323c29b6
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3329595

Change-Id: I46c5134df5fbe920acc628f4e9456681ca21d2e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-11-11 12:39:49 +00:00
Treehugger Robot
f85bc08954 Merge "Remove all pending messages when fragment destroyed" into main 2024-11-11 11:50:09 +00:00
dingfeisong
64aaa1440a Remove all pending messages when fragment destroyed
Remove all pending messages when the fragment has destroyed.
Otherwise, after fragment disattachs its context, an exception
will be reported when process the messages.

Bug:377166756

Change-Id: I333cedb45c0fe43b81abbfbe19e37f42f98def91
Signed-off-by: dingfeisong <dingfeisong@xiaomi.corp-partner.google.com>
2024-11-04 13:40:27 +08:00
Treehugger Robot
75e2dc4b21 Merge "Avoid disabling the Wi-Fi hotspot switch causing Talkback confusion" into main 2024-10-28 05:38:51 +00:00
Weng Su
259d3a47c8 Avoid disabling the Wi-Fi hotspot switch causing Talkback confusion
- Use local variables to filter inappropriate callbacks when the switch is busy

Bug: 374234537
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiTetherSwitchBarControllerTest

Change-Id: If5237230c73cae5a6230a6d3fdaa65a8511bdcd8
2024-10-28 03:31:32 +08:00
Fan Wu
60521ee2f9 Add WifiCallingScreen and corresponding TS flag
Bug: 372732219
Test: atest
Flag: com.android.settings.flags.catalyst_wifi_calling_settings

Change-Id: I3d78b6745e1127a0a7e73ec20ae95e9c9db2c139
2024-10-24 10:44:24 +08:00
Fan Wu
059593f1b1 Update WifiCallingSettingsForSub to inherit DashboardFragment. Controller logic will be refactored later
Bug: 372732219
Test: atest
Flag: EXEMPT refactor
Change-Id: I8fc419acd0311cc5b11d78662fb6a13b2c61b169
2024-10-23 09:07:59 +00:00
Weng Su
efe8d52f77 Connect to OWE Wi-Fi network when QR code has no password
- Since there is no password for Wi-Fi security in OPEN and OWE, try to connect to one of them

Bug: 360377330
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiDppQrCodeScannerFragmentTest

Change-Id: Ia0a59e099b724170ad993df8b4246b94e0da392c
2024-10-14 07:02:18 +08:00
Weng Su
5644fe1aa7 Add log for new error string in WiFi QR code scanning
Bug: 371506692
Flag: EXEMPT log only update
Test: manual test
Change-Id: I2bc15b0aa0a98a5f8193383decb60308544c810c
2024-10-04 18:27:34 +08:00
Treehugger Robot
78153998c7 Merge "Distinguish different errors of wifi QR code" into main 2024-10-02 21:26:00 +00:00
Yufan Cao
73f66eb8f1 Distinguish different errors of wifi QR code
When failure occurs after scanning wifi QR code, only "Check connection
and try again" will show, which is confusing for user to understand the
errors and take next action.

Add more string resources to cover different errors.

Co-authored-by: Yufan Cao <Yufan.Cao@sony.com>

Flag: EXEMPT bugfix
Test: manual test
Bug: 362305039
Change-Id: I85145eb67eecdc3aa06bb7b8a7b3e7f0ffea1f62
2024-10-02 20:23:42 +00:00
Quang Anh Luong
5aa95553cd Do not auto-downgrade WPA3->Transition mode if password too short
Hotspot security is auto-downgraded from WPA3->Transition mode if the
band is changed from 6Ghz -> 2.4/5GHz. However, Transition mode requires
a password of 8 chars or more, but WPA3 SAE does not. Avoid changing the
security type if the current password is less than 8 chars.

Flag: EXEMPT minor bugfix

Bug: 366452667
Test: atest WifiHotspotRepositoryTest
Change-Id: I1abadd59966e170b51899782746b9f14e33e6186
2024-09-26 07:09:47 +00:00
Weng Su
0256fe816d Avoid launching captive portal pages when uri is empty
- If uri is empty it will cause ActivityNotFoundException when calling startActivity

Bug: 363782926
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiDetailPreferenceController2Test

Change-Id: I48b9a53afe08a7c5e8e512c1961d6aea22a12a21
2024-09-16 17:05:10 +08:00
Weng Su
c749ba028a Fix Wi-Fi details crash in secondary users
- When Wi-Fi details are restricted for secondary users, UI components will be removed to prevent user interaction
  - The UI update function may not obtain the expected resources, causing NPE issues

Bug: 362151753
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiNetworkDetailsFragmentTest

Change-Id: Ia97b4e202faff85ced0b6eaf2e4b4f0dc04b5cef
2024-09-05 03:58:40 +08:00
Weng Su
e8c9816d15 Merge "Fix WifiPrivacy for special SSID AP" into main 2024-08-30 09:25:46 +00:00
Weng Su
407f69fec5 Fix WifiPrivacy for special SSID AP
- root cause: specail SSID AP(contain '%', end with '\' or '/' and end with '???'), andriodx Navigation cannot find destination

- changes: use Base64 UrlEncode replace String

Bug: 360304229
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiPrivacyPageProviderTest

Change-Id: Ifb89451477f2ba143f504b94c8d4d9167aee2c2e
2024-08-30 16:24:49 +08:00
Chaohui Wang
c72c540ab6 Merge "Clean up InternetPreferenceController" into main 2024-08-30 03:29:56 +00:00
Weng Su
1d92232b84 Add WIFI_LEVEL_UNREACHABLE logs
- Add WIFI_LEVEL_UNREACHABLE logs in Wi-Fi details settings

Bug: 362269742
Flag: EXEMPT add logs only
Test: Manual testing
Change-Id: I9a2b01df06417bafa85d300f1abe41797ec08143
2024-08-29 17:08:25 +08:00
Chaohui Wang
fc8e8991c9 Clean up InternetPreferenceController
And also the flag.

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - Network & internet
Change-Id: Icb3427f6624db0442c05f5e149dbe522d1497e83
2024-08-29 15:55:44 +08:00
Weng Su
739fa3f4c3 Refine Wi-Fi privacy settings
- When changing two configurations, the configuration must be refreshed before modifying the second configuration to prevent the first configuration from being rolled back by the old configuration.

Fix: 360313149
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiPrivacyPageProviderTest

Change-Id: If0e2c2b6a708fa59929b23409aff1254c6566fef
2024-08-21 15:32:14 +08:00
Weng Su
1a975d6f72 Refine WifiHotspotRepository variable names
- Since the speed of hotspot design was changed to refer to allowed channels rather than usable channels, remove the "Usable" naming to avoid confusion

Fix: 360312024
Flag: EXEMPT refactor
Test: Manual testing
atest -c WifiHotspotRepositoryTest

Change-Id: Ie54a351e0f788e1b6aeec079ccf6671f7f78fb1c
2024-08-16 18:55:36 +08:00
Xin Li
0b886fe303 Merge 24Q3 (ab/AP3A.240905.015) to aosp-main-future
Bug: 347831320
Merged-In: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
Change-Id: I473577d5983daafb368afa5523bad948499cb9a2
2024-08-14 23:26:30 -07:00
Weng Su
6c2158edef Get available channels allowed by Hotspot
- Use getAllowedChannels API instead of getUsableChannels API to avoid corner cases

Bug: 352267181
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiHotspotRepositoryTest

Change-Id: I5ae4a4d429924ac2b8676bbbb27016a93ccd9a1b
2024-08-14 17:10:05 +08:00
Treehugger Robot
0373a46e81 Merge "Hide new Hotspot preferences if feature is disabled" into main 2024-08-12 04:55:54 +00:00
Weng Su
675b817c49 Hide new Hotspot preferences if feature is disabled
- Hide new "Security" preference

- Hide new "Speed and compatibility" preference

Bug: 356898105
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiTetherSettingsTest

Change-Id: I734959ed511929bfcc9a314770a4acdf9a7e0b99
2024-08-12 05:49:02 +08:00
Weng Su
7b0e5560d1 Fix WifiQrCode scheme inconsistency issue
- New WifiQrCode design has been moved to WiFi Framework module
 - URI scheme changed from string "DPP" to integer 2

Bug: 356971926
Flag: EXEMPT bugfix
Test: manual test by 15-dpp-fail.apk
Change-Id: I00834ccb32f3ced8345213eef55b5aaa77006f7a
2024-08-09 04:36:16 +00:00
Chaohui Wang
c311354d10 Show uncheck toggle when wep not supported
When wep not supported, wep is always not allowed, so we should show
unchecked toggle for "Allow WEP networks"

Bug: 356326814
Flag: EXEMPT bug fix
Test: manual - on Network preferences
Test: atest WepNetworksPreferenceControllerTest
Change-Id: I408434fbbf48e1010710ecf3bf9f7988e521b076
2024-08-02 11:43:20 +08:00
Tom Hsu
d26c804af1 Merge "[Settings]Check the Satellite modem state instead of enabled state only." into main 2024-08-01 05:27:06 +00:00
tomhsu
90553d91f1 [Settings]Check the Satellite modem state instead of enabled state only.
Flag: EXEMPT bugfix
Fix: 354806125
Test: Manual test pass
Change-Id: Iaa8d1c9d3df36e40fafda0117234036d9451a4fa
2024-08-01 03:38:48 +00:00
Priyanka Advani (xWF)
9bf8ce78b2 Merge "Revert "Change API requestIsEnabled to requestIsSessionStarted"" into main 2024-07-30 18:12:18 +00:00
Chaitanya Cheemala (xWF)
413e85fa7a Revert "Change API requestIsEnabled to requestIsSessionStarted"
Revert submission 28533501-NTN_check_modem_state

Reason for revert: Likely culprit for b/356320274  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:28533501-NTN_check_modem_state

Change-Id: I4cdb936eb6a27eeee0aba6a5adfcf9cbdfacd5eb
2024-07-30 09:31:35 +00:00
Chaohui Wang
3a8ce3f970 Merge "Call wifiStatusTracker.fetchInitialState first" into main 2024-07-30 07:09:34 +00:00
Tom Hsu
d5225c236d Merge "Change API requestIsEnabled to requestIsSessionStarted" into main 2024-07-30 06:51:17 +00:00
Chaohui Wang
0be6705da6 Call wifiStatusTracker.fetchInitialState first
Before set listening to true, otherwise could cause race condition.

Fix: 354500692
Flag: EXEMPT bug fix
Test: manual - check wifi summary
Change-Id: I4160f89fae666ac02b816b7d9a69bac581bbd29e
2024-07-30 13:51:52 +08:00
tomhsu
b091995671 Change API requestIsEnabled to requestIsSessionStarted
- Avoid using APM/WIFI/BT in settings app from any transitioning from TN to NTN.

Flag: EXEMPT bugfix
fix: 354806125
Test: Manual test
Change-Id: Id65567971b3d1ea3e177a0cc1e1304446d8fa0e8
2024-07-30 01:27:58 +00:00
Les Lee
ae2195c549 wifi: fix ADB URI doesn't work
Using old WifiQrCode parsing for ADB Uri.

Flag: EXEMPT bugfix
Bug: 355088188
Test: Manual test & TH
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:da21128568e29a6c2992b1b38cbb2db9ec36892f)
Merged-In: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
Change-Id: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
2024-07-29 23:56:20 +00:00
Treehugger Robot
dc8b74e343 Merge "Make adb team OWNERS of all Adb settings" into main am: 998787ffa8 am: ee6f5cf1ed
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3195878

Change-Id: Ifa37256b70cc3c1d7c6b22637cba040bce62ca3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-26 18:39:33 +00:00
Treehugger Robot
ee6f5cf1ed Merge "Make adb team OWNERS of all Adb settings" into main am: 998787ffa8
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3195878

Change-Id: Idcd085b62b69bace7ddfda325b1645b6b89440ca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-26 18:25:24 +00:00
Fabien Sanglard
c7adef9634 Make adb team OWNERS of all Adb settings
Test: NA
Bug: 355088188
Flags: NA
Change-Id: I59c037765940a26509f1d312b4c8c2e0105a3580
2024-07-26 10:57:43 -07:00
Yi Shiou (Les) Lee
ff6a1750bc Merge "wifi: fix ADB URI doesn't work" into main 2024-07-26 00:26:26 +00:00
Les Lee
da21128568 wifi: fix ADB URI doesn't work
Using old WifiQrCode parsing for ADB Uri.

Flag: EXEMPT bugfix
Bug: 355088188
Test: Manual test & TH
Change-Id: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
2024-07-25 21:38:15 +00:00
Quang Luong
2f257a1982 Merge "Fix mac randomization value mismatch" into main 2024-07-25 10:45:54 +00:00
Yuchen Sun
01ecf76247 Add content description to QR code image for talkback.
- Rename string name for reuse purpose.

Test: Visual
Flag: EXEMPT bug fix
Bug: 350603175
Change-Id: Id5b1383c9cf1c2509a621bb9b225e0efeb58ca7f
2024-07-25 08:47:32 +00:00
SongFerng Wang
410f699c6f Merge "Settings: Adapt edge-to-edge enforcement" into main am: 9befb6cd8f am: e910d895f1
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3142636

Change-Id: I4a7f739df1b12c2151a6b4a484881360541c113d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-18 10:08:48 +00:00
SongFerng Wang
e910d895f1 Merge "Settings: Adapt edge-to-edge enforcement" into main am: 9befb6cd8f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3142636

Change-Id: Ibfc5f8fb007d93d618c4a0c67e396677329b5728
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-18 09:48:49 +00:00
Quang Anh Luong
47a83c7ed7 Fix mac randomization value mismatch
WifiConfigController2 passes in
WifiConfiguration.MacRandomizationSetting to methods that expect
WifiEntry.Privacy enums, resulting in the wrong values being saved and
displayed for the edit dialog. Fix this by making sure the correct
WifiEntry values are used.

Note that the Network Details Page uses
WifiPrivacyPreferenceController2, which uses the correct values.

Flag: EXEMPT bugfix
Bug: 284230986
Test: atest WifiPrivacyPreferenceController2Test, atest
WifiConfigController2Test, manually verify adding a new network saves
the config with RANDOMIZATION_AUTO by default and changing the value
works correctly.

Change-Id: I84dc7cc50d04360aca611ca80ee400a97b693722
2024-07-18 05:31:11 +00:00
Chaohui Wang
371e7b09e1 Clean up WifiPrimarySwitchPreferenceController
This one is not used any more.

Bug: 167474581
Flag: EXEMPT clean up
Test: m Settings
Change-Id: Ia2439af2b3a6b643f41f6e3fce9e4bf1126c282e
2024-07-17 16:02:40 +08:00
Treehugger Robot
2db5d1618f Merge "Show less secure warning in Network details settings" into main 2024-07-15 08:00:42 +00:00
Weng Su
05b28d24c3 Show less secure warning in Network details settings
- Show warning when device connected to WEP protocol

Bug: 331973632
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WepLessSecureWarningControllerTest

Change-Id: I54a9bafb2c672db44d47259d6acc49c02046cb81
2024-07-15 14:51:25 +08:00
Kai Zhou
9775bd31f9 Wifi Sharing page uses a new enum for telemetry.
* Previous ID was shared by several pages.
* New ID is only used by this page.

Bug: b/349226088
Settings Intake: b/329012096

Test: atest WifiDppQrCodeGeneratorFragmentTest
Flag: com.android.settings.flags.enable_wifi_sharing_runtime_fragment

Change-Id: I22c8f3a216cf348460a645561be48b23a4bf0e7e
2024-07-11 02:30:12 +00:00